- 03 Jan, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5efb17b5..eb333167 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I81c2fcdae6f32df8fc38956c280cb8700894b024 Reviewed-on: https://chromium-review.googlesource.com/c/1394388Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619687}
-
Nico Weber authored
Remove a redundant entry, and add a dedicated bug line for nacl_helper_bootstrap now that I understand what's going on there. Bug: 918882 Change-Id: Id5c12c9096783dda98b9c80c4de0a9db860d1aa7 Reviewed-on: https://chromium-review.googlesource.com/c/1394707Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#619686}
-
Michael Lippautz authored
Setting a property to undefined that has not been set before can lead to V8 transitioning that wrapper object. This can lead to allocation which in turn can trigger garbage collection. Bug: 916022 Change-Id: I01bfb4af4514138c81a507acbb462b024dc89025 Reviewed-on: https://chromium-review.googlesource.com/c/1394587 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#619685}
-
Tibor Goldschwendt authored
This toast is shown if the VR module is not installed yet when launching Chrome on standalone VR headsets. Bug: 914498 Change-Id: Iaac05f06e20a40d62dca52916bb158914edb4320 Reviewed-on: https://chromium-review.googlesource.com/c/1393556Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#619684}
-
Joshua Pawlicki authored
Split from https://chromium-review.googlesource.com/c/chromium/src/+/1344880 Bug: 907219 Change-Id: Ia855b6ad41bf1a4465233cfd857fae3c1a759c54 Reviewed-on: https://chromium-review.googlesource.com/c/1393403 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#619683}
-
Avi Drissman authored
This is purely a mechanical change; there is no intended behavior change. BUG=837308 Change-Id: I85c15d42228d0e1c88f366af263d86dca15ba44e Reviewed-on: https://chromium-review.googlesource.com/c/1390424Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#619682}
-
Evan Stade authored
Test is SwitchAccessPredicateTest.IsActionableFocusableElements TBR=jamescook@chromium.org Bug: 918876 Change-Id: I8f3de7f4f089d1d9fc9e67a7012baa6c1dfca9f1 Reviewed-on: https://chromium-review.googlesource.com/c/1394396Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#619681}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d9f036200e10..35caab8b839f git log d9f036200e10..35caab8b839f --date=short --no-merges --format='%ad %ae %s' 2019-01-03 perezju@chromium.org [cli services] Fix encoding issue on non-json error responses Created with: gclient setdep -r src/third_party/catapult@35caab8b839f The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:917376 TBR=sullivan@chromium.org Change-Id: I1ff55149492fb34eda4d3607ad2e1ede731b07d1 Reviewed-on: https://chromium-review.googlesource.com/c/1394202Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619680}
-
Pavel Golikov authored
Introduced ozone_extra_path build argument. It points to additional platforms file to include while building ozone platforms. It points to //ui/ozone/ozone_extra.gni by default for backward compatibility. Bug: 918118 Change-Id: If6db25b3693f319955fdec54d9f91d47422a6e38 Reviewed-on: https://chromium-review.googlesource.com/c/1391687Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#619679}
-
Jonathan Metzman authored
Document how to do Linux-x86-ASAN and Linux-x86-ASAN-debug builds. Mention that x86 can be used with UBSan, but probably not with other configurations. Also document "libs" variable for "fuzzer_test" gn template. Change-Id: I70ff71a5ea192b10c7bc495cc657fde34c0653b1 Bug: 917000, 852428 Reviewed-on: https://chromium-review.googlesource.com/c/1394386Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619678}
-
Evan Stade authored
There are still some failing, so instead of filtering many individual tests, filter them all. TBR=jamescook@chromium.org BUG=831826 Change-Id: I42236102982a270917c96c6a9c030b6bd029543f Reviewed-on: https://chromium-review.googlesource.com/c/1394392Reviewed-by:
-
Peter Kasting authored
Bug: 918742 Change-Id: Ib1f99893a80ec033e2c986f93d6f7cf00722569b TBR: rsesek Reviewed-on: https://chromium-review.googlesource.com/c/1394024Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#619676}
-
Steven Bennetts authored
This is just: ./tools/git/move_source_file.py chromeos/chromeos_switches.* chromeos/constants/ ./tools/git/move_source_file.py chromeos/chromeos_pref_names.* chromeos/constants/ ./tools/git/move_source_file.py chromeos/chromeos_paths.* chromeos/constants/ ./tools/git/move_source_file.py chromeos/chromeos_features.* chromeos/constants/ And some minor associated DEPS changes. This will allow more strict DEPS checking for components depending on //chromoes:chromeos_constants (but not //chromeos). It also moves most of the remaining src files from src/chromeos/. For mechanical file moves: TBR=sky@chromium.org Bug: 918682 Change-Id: Ie1cd23b0b69d719cc48d9e60a27eb3c60dbd771d Reviewed-on: https://chromium-review.googlesource.com/c/1393559Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#619675}
-
Jonathan Metzman authored
1. Remove disclaimer about LPM not having a track record. 2. More consistent line length. 3. Change `targeted_code` to `targeted_function` 4. Improve example for multiple inputs. 5. Fix link. 6. Improve wording. Change-Id: I8486c544773bbbd17dd12591ed1c602213275d98 Bug: 769578 Reviewed-on: https://chromium-review.googlesource.com/c/1394310Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/031b028c78a9..943e9fdb7885 Created with: gclient setdep -r src-internal@943e9fdb7885 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib071133c08c1ef664fd37604ee7f9a775b3f8477 Reviewed-on: https://chromium-review.googlesource.com/c/1394684Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619673}
-
Tommy Steimel authored
This reverts commit bae1ec12. Reason for revert: Causing failures on Linux Tests bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests/74581 Original change's description: > Fix RTCPeerConnection-track-stats.https.html expectations. > > The tests started failing in an earlier WPT import, see > https://crbug.com/832501. > > TBR=hta@chromium.org > > Bug: 832501 > Change-Id: If53c927e03dabb60158c61befc5a29d1c45bba1f > Reviewed-on: https://chromium-review.googlesource.com/c/1394307 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619631} TBR=hbos@chromium.org Change-Id: I6b02e4b99e003b1ee1e686eea1bf3b36aadb4b39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 832501 Reviewed-on: https://chromium-review.googlesource.com/c/1394705Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#619672}
-
Nico Weber authored
Bug: none Change-Id: Ib2ceb021eee6edee3fe7fabd1e022063d6e1432b Reviewed-on: https://chromium-review.googlesource.com/c/1394703Reviewed-by:
-
Dan Harrington authored
We need to track the state of the auto-fetch notification that's associated with a SavePageRequest. This change adds a new field to SavePageRequest for this purpose, updates the database schema for storing the field, and adds access methods for setting the value through RequestCoordinator. Bug: 883486 Change-Id: I6baa6d240efdedc210d6917870047812cba02381 Reviewed-on: https://chromium-review.googlesource.com/c/1374114 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#619670}
-
Vladimir Levin authored
This patch adds a test that does an acquire and update, then before the update finishes it removes the element from the DOM and does a commit. This fails the update promise. This test is meant to be paired with another one already checked in where we don't call a commit and also expect the update to fail. R=chrishtr@chromium.org Bug: 882663 Change-Id: Idbe58b5162d4189da05379ed2044a0e620ce5dd9 Reviewed-on: https://chromium-review.googlesource.com/c/1393451Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619669}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8966b55644c2..31c4bcb210bd git log 8966b55644c2..31c4bcb210bd --date=short --no-merges --format='%ad %ae %s' 2019-01-03 reed@google.com rm unneeded encoding param Created with: gclient setdep -r src/third_party/skia@31c4bcb210bd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Iee40d8351cc572579bf4daa1d818ba6a79a58df4 Reviewed-on: https://chromium-review.googlesource.com/c/1394683Reviewed-by:
-
Christian Fremerey authored
As per new report on crbug.com/849636, this device seems to be another instance of drivers reporting the device as available in MediaFoundation but not actually working with it. Bug: 849636 Change-Id: I21764713826e4f86cf600e6e30b75a3d9c3fb087 Reviewed-on: https://chromium-review.googlesource.com/c/1393804Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#619667}
-
Tommy Steimel authored
This reverts commit 70ffd447. Reason for revert: Causing failures on Mac 10.13 bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/8478 Original change's description: > [ChromeDriver] Handle pauses in Perform Actions > > W3C spec allows the app to specify pauses within Perform Actions command > (https://w3c.github.io/webdriver/#dfn-dispatch-actions). Updating > ChromeDriver to handle these pauses. > > Bug: chromedriver:1897 > Change-Id: I533179f4a9f2216bfacf0f4fdb539c8f898bed07 > Reviewed-on: https://chromium-review.googlesource.com/c/1392281 > Commit-Queue: John Chen <johnchen@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619506} TBR=lanwei@chromium.org,crouleau@chromium.org,johnchen@chromium.org Change-Id: Ia03b2b463e5baa93ec1e96c773f38eb9c82f2808 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromedriver:1897 Reviewed-on: https://chromium-review.googlesource.com/c/1394664Reviewed-by:
-
Rohit Rao authored
Fixes a call to an NS_UNAVAILABLE inititalizer. BUG=917351 Change-Id: I3c1471f3fe0764c8e03d026b28bf7b90e44fe9f5 Reviewed-on: https://chromium-review.googlesource.com/c/1394390 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619665}
-
Tommy Steimel authored
Test is flaky on ci bots: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64/30508 Change-Id: I3b2658193ac62f53eed1db9d470c67b28987fc38 Reviewed-on: https://chromium-review.googlesource.com/c/1393664Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#619664}
-
Jeremy Roman authored
ListHashSet is deprecated. Bug: 614112 Change-Id: I7b726aed29a92e8e61499b7a2455de0855735267 Reviewed-on: https://chromium-review.googlesource.com/c/1392273Reviewed-by:
-
Dan Harrington authored
It is possible to reach this function in incognito mode, in which case offline_page_model will be null. Added code to handle this condition instead of crash. Bug: 918119 Change-Id: Iddad53677e168c565a20dfc888d1ccb213a54fe7 Reviewed-on: https://chromium-review.googlesource.com/c/1393465Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#619662}
-
Kevin Ellis authored
Update interpolation of transform lists to reflect recent changes to the spec (https://drafts.csswg.org/css-transforms/#interpolation-of-transforms). * If the transform lists are of different lengths, but the transformations are pairwise compatible to the end of the shorter list, extend the shorter list with corresponding identity transforms. * If the transform lists are incompatible, perform pairwise transforms for compatible entities at the start of the list and fallback to matrix interpolation for the remaining transformations. * Fix discrete fallback. Bug: 860391, 267348, 918643 Change-Id: I8b2d770e354f3d77dad00e088a2eafe6c1ad655a Reviewed-on: https://chromium-review.googlesource.com/c/1372025 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#619661}
-
Mike Reed authored
Change-Id: Ia01ee627f15389ca8fc79d87b93227d434719ecf Reviewed-on: https://chromium-review.googlesource.com/c/1394011Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#619660}
-
Brandon Mayer authored
Enabled edge embedding computation in subgraphs via feature flag. Additionally, the named_template_arguments allows graph template arguments to be modified at runtime via legacy javascript API until IPC refactor work is complete. This cl looks to support m72 and should be deprecated either at the end of beta m72 or early m73. Bug: 914959, b/120986539 Change-Id: I2b42c0989800afa9339ae8176a1a833c85ddcbdd Reviewed-on: https://chromium-review.googlesource.com/c/1376812Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
cathiechen authored
If the zero-height marker container is triggered in the previous layout pass, and in this layout pass, marker become inside or marker container has other child, we need recover from zero-height, the height of marker container should be restored to auto not the height of li. This test passes in Firefox, WebKit as well as LayoutNG. Bug: 918488 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I3c65a2d27f1b8dfef13c41bfe804cd1f9aab89c5 Reviewed-on: https://chromium-review.googlesource.com/c/1393129 Commit-Queue: cathie chen <cathiechen@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#619658}
-
Mason Freed authored
This should have been cleared, but wasn't. Likely the cause of https://crbug.com/917589. Bug: 917589 Change-Id: I68c54ea84dba60c67fea5566a057055c6349f36e Reviewed-on: https://chromium-review.googlesource.com/c/1394085Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#619657}
-
Elly Fong-Jones authored
This change: 1) Splits up NativeWidgetMacTest.MiniaturizeExternally, which was a bit too big; 2) Adds an override on NativeWidgetMacNSWindow of _canMiniaturize, which always allows Views windows to be miniaturized; this is the behavior that the rest of Views (and the tests) expect, and is what happened on older SDKs. Bug: 780980 Change-Id: Ic3356787433d9325aa13f1e01a8165c4ddd07b0a Reviewed-on: https://chromium-review.googlesource.com/c/1394010Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#619656}
-
edchin authored
Pre-bijou, infobars were on displayed on top of the web content below the omnibox. Today, infobars are on the bottom, having no difference with the phone form-factor. This CL removes special casing code for snapshotting in iPad. This should have been removed when bijou was launched. Bug: 918759 Change-Id: Ic18524ac47606b2d1b6ee1c254220465d64a8d71 Reviewed-on: https://chromium-review.googlesource.com/c/1394423Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619655}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/f620af75bd69..2cf86e5ab6dc $ git log f620af75b..2cf86e5ab --date=short --no-merges --format='%ad %ae %s' 2018-12-24 junyer Compute num_captures_ eagerly. 2018-12-21 junyer Make AddState actually POD. Mea culpa. 2018-12-21 ckennelly Use PODArray<> for stacks and also for nodebyid in Prog::IsOnePass(). 2018-12-21 ckennelly Use PODArray<> for temporary Regexp* arrays. 2018-12-18 ckennelly Make Compiler and Prog use PODArray<> for Insts. 2018-12-18 junyer Revert the commits for the shard_cache_mutex option. 2018-12-14 junyer Add a benchmark for the shard_cache_mutex option. 2018-12-13 junyer Make NumCPUs() in util/benchmark.cc work better. 2018-12-13 junyer Fix a bug in the DFA destructor. 2018-12-13 junyer Use NUMA topology to shard the DFA state cache mutex. 2018-12-13 junyer Prepare to shard the DFA state cache mutex. 2018-12-13 junyer Introduce the shard_cache_mutex option. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Bug: 0 Change-Id: Ic96608d666c6af5639a098d0d772d6e4de516a50 Reviewed-on: https://chromium-review.googlesource.com/c/1394372Reviewed-by:
-
Alexei Svitkine authored
- Moves IsMetricsReportingForceEnabled to the base class, so that leaf clients don't have to override it. - Removes CreateEntropyProvider() wrapper in favor of GetMetricsStateManager() which was already implemented by both clients. - Reorders functions. - Removes unnecessary .get() calls. No functional changes. TBR=olivierrobin@chromium.org Bug: None Change-Id: Ia6666d8c82c394a01bf4fb3980603ddf86335c17 Reviewed-on: https://chromium-review.googlesource.com/c/1391783 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619653}
-
Tomasz Wiszkowski authored
Bug: 918685, 918578 Change-Id: I96799594c1fae2f10c00b8d2d2f54bd09ed0d012 Reviewed-on: https://chromium-review.googlesource.com/c/1393888 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#619652}
-
Joshua Peraza authored
When SystemWebview.apk is pre-installed in an Android image, native libraries are loaded from the apk, so libcrashpad_handler.so isn't available to exec directly. Bug: 912739 Change-Id: Ica26df15481ade6951dd5e330425d0ff50b45e05 Reviewed-on: https://chromium-review.googlesource.com/c/1366494Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#619651}
-
Rohit Rao authored
AllWebStateObservationForwarder forwards observer methods for all the WebStates in a WebStateList, keeping track of WebStates as they are added, removed, and replaced. ActiveWebStateObservationForwarder forwards observer methods for just the currently-active WebState, even as the active WebState in the WebStateList changes. These classes are intended to remove some of the boilerplate bookkeeping that is necessary when trying to perform either of these common tasks. Change-Id: I8320f1d1c6aef180a79adf9cbe614cd2066b84fb Reviewed-on: https://chromium-review.googlesource.com/c/1393531Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d0a1f2d4e2ab..031b028c78a9 Created with: gclient setdep -r src-internal@031b028c78a9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I62948de8aefe11a960ebf3c4ecefc87a4cb8c72d Reviewed-on: https://chromium-review.googlesource.com/c/1394448Reviewed-by:
-
Sidney San Martín authored
App shims from a component build previously wouldn't launch without the DYLD_LIBRARY_PATH environment variable set to the path to the out directory. This change embeds the path so that they can be launched normally. Change-Id: I5c88b0e70172d385d93e8de8d096b03ea408d942 Reviewed-on: https://chromium-review.googlesource.com/c/1393533Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#619648}
-
