- 30 Sep, 2019 40 commits
-
-
Yue Zhang authored
Bug: 1008232 Change-Id: I0032cabd435015a8a54e19628c5444de3c0e2755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827491Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#701177}
-
Eric Karl authored
Missed these in https://chromium-review.googlesource.com/c/chromium/src/+/1810317 Bug: 995965 Change-Id: Ib6e58b7f91a2d1dca5b62a91efeb936e5bdf70d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827254 Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#701176}
-
liberato@chromium.org authored
Test is flaky. Bug: 1009347 Change-Id: Idd99519acf6cf0d0a8a10f7c04fb19fb4a9dd910 TBR: dimich@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831945Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#701175}
-
Nektarios Paisios authored
This is a speculative fix for the busy problem on Mac whereby some pages hit a DCHECK in AXPosition. On Mac there are some extra AXNodes that are only created for table columns. These have negative node IDs, and so using -1 as the invalid node ID might create a conflict with those nodes. Table columns are not created on any other platform. R=dmazzoni@chromium.org Bug: 1006842 Change-Id: I38da62f41c570cebfde197895fb6bebb16649cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827999Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#701174}
-
Roger Tawa authored
When uploading files for deep scanning, chrome should use the trigger type FILE_UPLOAD so that the correct rules can apply. Bug: None Change-Id: Icef41bd726aac5d664aef699f10c06edc1f5c6f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827740 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#701173}
-
liberato@chromium.org authored
Test is flaky. Bug: 1009359 Change-Id: I63fbc1be9e65ce0ee4eb8b8c53f40270a2ffa8d7 TBR: michaelbai@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829581Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/31464956f9ed..5c101eb826b8 Created with: gclient setdep -r src-internal@5c101eb826b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1009419,chromium:None Change-Id: I601460b2309f5c7f3b54f7646e44f70b19bda617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829495Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701171}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d9d7419a45d6..ec36c06fb12c git log d9d7419a45d6..ec36c06fb12c --date=short --no-merges --format='%ad %ae %s' 2019-09-30 saklein@chromium.org chroot_lib: Fix goma env setup. Created with: gclient setdep -r src/third_party/chromite@ec36c06fb12c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4fcd824c7cb3226f28d97eee4954160876527e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831782Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701170}
-
Sergey Poromov authored
Failures: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/15481 TBR=newcomer@chromium.org Test: Run interactive_ui_tests with MSan. Bug: 1008744 Change-Id: I3e8a9775833f2f5810ef4687479c48eb8f7dd343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832261Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#701169}
-
Xiaocheng Hu authored
Two classes became redundant wrappers after crrev.com/c/1769554, so this patch removes them. Bug: 991672 Change-Id: I69a0131036563d1e90820381c711de91bd63a455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829783Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#701168}
-
Mikhail Khokhlov authored
Bug: 981349 Change-Id: I8faa2aa790327a838978d3f002ad706db70e9d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829337 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#701167}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/45b176fc2289..32eae4c231b4 git log 45b176fc2289..32eae4c231b4 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 saza@webrtc.org AEC3: use different seed for different channels in CNG 2019-09-30 mbonadei@webrtc.org Always pass arguments to INSTANTIATE_TEST_SUITE_P. Created with: gclient setdep -r src/third_party/webrtc@32eae4c231b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ic10064ed715a2f9981da36f3692c7e6df1f36c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830316Reviewed-by:
-
liberato@chromium.org authored
Bug: 1009464 Change-Id: Idd6aa2b18ee7dcc6cead9050944ccfe1cb6f15c6 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831449Reviewed-by:
-
liberato@chromium.org authored
Bug: 1009465 TBR: mdjones@chromium.org Change-Id: I40d0a3919d92e02d885648707569735f3cf80d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831448Reviewed-by:
-
Jeroen Dhollander authored
This is a reland of de88f517 Note: No changes were made in this reland, the only difference is that now the Assistant internal code has been uprev'ed to the correct edition. Original change's description: > Introduce AssistantServiceManager::State::STARTING state. > > Until now the |AssistantServiceManager::State| enum did not distinguish > between the state in which libassistant was started (but not ready yet) > and in which it is ready. > That distinction is needed to be able to add tests using libassistant, > as they have to wait until it is ready. > > So now there are 4 states: > - STOPPED: It has not started/it has been stopped (this is the same > as the old STOPPED state). > - STARTING: |AssistantServiceManager::Start| has been called and the > libassistant |AssistantManager::Start| call has not finished yet (this > is the same as the old STARTED state). > - STARTED: the libassistant |AssistantManager::Start| call has > finished, but libassistant has not signalled it is ready yet (this > is the same as the old RUNNING state). > - RUNNING: libassistant signalled it is ready (this state is new). > > As this CL also introduces the first unittests for > |AssistantServiceManagerImpl|, it also contains a bunch of fake/dummy > classes used for the unittests. > > This CL increases test coverage in //chromeos/services/assistant from 28% > to 41%. > > Change-Id: If38a6b70e22e6392537b6658e5f39eebf6dd9099 > BUG: b/141264108 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810019 > Commit-Queue: Jeroen Dhollander <jeroendh@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700410} Change-Id: Ifb9c7ebc235d2813fdb331408873a37791bc8d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828225 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#701163}
-
Nate Fischer authored
This permits createInvocationHandlerFor(null) to return null, and follows through with the related methods (supporting or not supporting nullable values as appropriate). The main advantage is this causes nullability mistakes to have clearer error messages. Instead of triggering an NPE inside BoundaryInterfaceReflectionUtil internals, we treat null InvocationHandlers as representing null instances, and calling methods on those instances will trigger NPE much more clearly. This should not change behavior, it should only make it clearer under conditions where we would have already hit NPE. This should be backwards and forwards compatible: * Old WebViews do not pass null InvocationHandlers, so new versions of the AndroidX library will treat these InvocationHandlers the same (nonnull). * If old WebViews receive a null InvocationHandler, they will NPE (but would have NPE'd anyway). * Same vice-versa for new WebViews and old versions of the AndroidX library. Bug: 1009056, 998001 Test: Manually cherry-pick this into AndroidX, verify it compiles with http://aosp/1129297 Test: Manually cherry-pick this into AndroidX, ./gradlew :webkit:connectedAndroidTest (against M76 and tip-of-tree) Change-Id: I3246d0b4a30ef752977d2e8dd4f51889006b7536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829770Reviewed-by:
Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#701162}
-
Maksim Moskvitin authored
We factor out subset of field in NigoriSyncBridgeImpl to a separate struct NigoriState. This struct directly maps to sync_pb::NigoriModel proto and the key reason to do that is to move proto serialization/ deserialization away from the bridge. This CL is pure refactoring. Bug: 922900 Change-Id: I19b0425aeccce475f34dab6375f9929994f17ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813311 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#701161}
-
Alex Chau authored
- Added DeviceInfoSyncClient::GetLocalSharingInfo and returns nullopt until SharingSyncPreference is change is ready. Bug: 991971 Change-Id: Ie1c29c6140afe83d6f08fc5d4d8d6bc469e2770b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825219 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Christy Chen authored
Port the localization documentation from wiki page https://github.com/ChromeDevTools/devtools-frontend/wiki/Localization to devtools/docs/langpacks/ for visibility. The documentation includes the following topics: -How to add a localizable string -What are the localization APIs -How to add descriptive information to GRDP messages -How to prevent specific terms being localized Bug: 941561 Change-Id: Ide16269d417d23142a042b92d2f25a2468839fa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740079Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Jeff Fisher <jeffish@microsoft.com> Commit-Queue: Christy Chen <chrche@microsoft.com> Cr-Commit-Position: refs/heads/master@{#701159}
-
Vadym Doroshenko authored
This logging was accidentally removed with removing (Old)PasswordFormManager on https://chromium-review.googlesource.com/c/chromium/src/+/1768457 Bug: 1009435 Change-Id: I5cb39022b787846f59f4a9470537d1aa37b5efa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831911Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#701158}
-
Peter Wen authored
Please try to fix breakages rather than reverting this CL, since fixes will typically simply be removing an exception on method signatures, and reverts will likely cause merge conflicts. Remove InterruptedException and many other unthrown exceptions from test method signatures. Tbr: Tree-wide mechanical refactor for test code. Bug: 673892 Change-Id: I638187c866057aca2fa954bc2c865a8d6dcb06b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826875 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#701157}
-
chrome://dom-distillerMarc Treib authored
This existed to support/test a feature that was abandoned. Bug: 1007942 Change-Id: I9a485ea6a2d3ee72b1715308a72b8c5518439d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829346 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#701156}
-
Daniel Libby authored
Perspective transforms only need a layer if descendants have 3d transforms. Modify CompositingReasonFinder::DirectReasonsForPaintProperties to not require a layer for a transform property which only has perspective() and also ensure that. Move the logic for deciding composited layers are required for perspective and preserve-3d with 3d descendants entirely to SubtreeReasonsForCompositing instead of calculating this possibility up front. We are using a compositing trigger due to the fact that perspective transforms with 3d descendants need a render surface for flattening purposes. Bug: 919294 Change-Id: I219790977fe43a40c4258945565d012c0a0bdb56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788301Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#701155}
-
Amr Aboelkher authored
A device policy which controls the sticky keys accessibility feature on the login screen.The policy can be applied as a recommended or mandatory policy. Test: 1. Set the login_screen_sticky_keys_enabled policy to True, open System Tray => "Accessibility", check that "Sticky keys" is displayed with a green check in the login screen. 2. Set the policy to False, open System Tray, check that "Sticky keys" is not displayed in the login screen. Bug: 552439 Change-Id: If5120e4bfb46c336842ec797456035dbb5504de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828818 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#701154}
-
Etienne Bergeron authored
This CL is exposing the FontFallbacks cache and is adding some checks in the current unittests. The main goal of these refactoring is to add a cache to GetFallbackFont(..). We are planing to test it the same way. R=robliao@chromium.org Bug: 1008531 Change-Id: I1970985ea92c46bc67fd9230803f04a521b0f3e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829862 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#701153}
-
Nikita Podguzov authored
Bug: 992889 Change-Id: Ia9380e82947ddd4e71d6c905e52f58b90b6f32c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825602Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#701152}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ceac3320975b..2e80cf9d91ab git log ceac3320975b..2e80cf9d91ab --date=short --no-merges --format='%ad %ae %s' 2019-09-30 cnorthrop@google.com Vulkan: Refactor render target initialization for texture arrays Created with: gclient setdep -r src/third_party/angle@2e80cf9d91ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: None Change-Id: Ia648f539402edaccb601657f74ba49a2cdb4ddc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831781Reviewed-by:
-
Philip Rogers authored
TileManager.ExceededMemoryBudget is an important metric and we should not let it expire. Change-Id: I599ea7906660d507e43a39e8d5b098f7a494c2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829945 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#701150}
-
Andrew Grieve authored
This is a finish up of intern change: https://chromium-review.googlesource.com/c/chromium/src/+/1738632 Changing one file in chrome_java before/after: 17.9s vs 3.6s for just the dex step. Bug: 937874 Change-Id: I1aefc01446d99eedd79094e9429d7d69c6d05631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825471 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#701149}
-
Xiaocheng Hu authored
Current progress: - Implementation finished - Test suite finished except for a minor serialization spec issue [1], which seems minor enough not to block the launch - The spec issue with table layout [2] is already resolved. In case of similar spec issues in other layout algorithms, I believe a similar approach (UA must treat the value as auto) can be adopted. Therefore, I believe there is no longer any issue blocking the shipping of the feature. [1] https://github.com/w3c/csswg-drafts/issues/4372 [2] https://github.com/w3c/csswg-drafts/issues/94 Bug: 825895 Change-Id: I0fe8e934d4429fa6ed1c3dd8847f70b1ba350e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829471Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#701148}
-
Raul Tambre authored
[290/24365] ACTION //chrome/common/extensions/api:manifest_features_json_features(//build/toolchain/win:win_clang_x64) ../../tools/json_schema_compiler/feature_compiler.py:681: SyntaxWarning: "is" with a literal. Did you mean "=="? if sep is -1 or no_parent: Bug: 958874 Change-Id: I7114523a95c3300a0a077732868f523d666fd826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829207 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Yasmin authored
Bug: 1005813 Change-Id: I355e11ecd6945ca0b49bfeac79a9761b54d4d1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831800 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#701146}
-
Yann Dago authored
ImportAutofillFormData, ImportBookmarks, ImportHistory, ImportHomepage, ImportSavedPasswords, ImportSearchEngine did not work on first run if the default browser was IE on Windows 10. Bug: 1003284 Change-Id: If4962497f36c401194ce1acf5e27b30cfa80a0e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825327 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#701145}
-
Jasper Chapman-Black authored
* Uncovered sections * Partially covered sections (when the last parsed symbol in a section doesn't reach to the end of the section, according to readelf) Bug: 872796 Change-Id: If88897a2d692ac4a13cfad7ada0e493ecd10005a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825898 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#701144}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01cd0891cf7a..31464956f9ed Created with: gclient setdep -r src-internal@31464956f9ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I110d5c3839c9d7af646957f5b36e06118aa4104d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831783Reviewed-by:
-
Maks Orlovich authored
In particular, at top-level too, the computation should be about origins, not URLs, to resolve about:blank and to stop fighting with sandbox. Bug: 911299 Change-Id: I2d1b05b597ec7c5062f7beb320ccc3384e22cf82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816656 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#701142}
-
Dominik Röttsches authored
Confirm the API call does not report a 0 number of font families at the start of font metadata scanning. Used in investigating https://crbug.com/1009402. Bug: 1009402 Change-Id: I7ea13510e8ababf94bd8f0d4c9ddf291ca8272cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831770 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#701141}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1370481f..353af798 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7725d442f66aad17aeddb566d307a7c1ff51e5e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832108Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701140}
-
Evan Stade authored
This reverts 8f7ddcd6 It breaks Windows, where |set_accept_events| does not work. Original description: > Uses BubbleDialogDelegateView::set_accept_events and removes > BubbleFrameView::set_hit_test_transparent > See related https://crbug.com/978985 Bug: 1004721 Change-Id: Ia272423be8706c4793c2c3f089ca30e16c653094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824031Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#701139}
-
Sergey Poromov authored
Still flaky: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/14609 TBR=manucornet@chromium.org Bug: 1000463 Change-Id: Iae03820fc6b3e653e70028ba9e65d96fa005b568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831914Reviewed-by:
-
