GitLab

BUG=640312
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2338433002
Cr-Commit-Position: refs/heads/master@{#419624}

When the PreferHtmlOverPlugins feature is active, and the plugins content
setting isn't one of ALLOW or BLOCK, each site's engagement score is
now consulted to determine whether or not Flash is added to the list of
available plugins. The score must be above a certain threshold for Flash
to be advertised.

The amount of engagement required to activate Flash defaults to 1, which
is currently the equivalent of navigating directly to a site via the
omnibox, or spending ~1 minute interacting with the site after visiting
via a link. This value is controllable via a variations parameter under
the PreferHtmlOverPlugins feature.

This CL adds a thread-agnostic interface to the site engagement service,
which is necessary as ChromePluginServiceFilter::IsPluginAvailable
runs exclusively on the IO thread, from which is it not possible to
create a SiteEngagementService object. This new interface relies on the
fact that the underlying HostContentSettingsMap class methods can be
called from any thread.

This CL additionally removes the fallback logic from the site
engagement service for incognito support, as this is already baked into
the underlying HostContentSettingsMap. A minor cleanup of
ChromePluginServiceFilter is also undertaken.

BUG=626728,641627,641630

Review-Url: https://codereview.chromium.org/2285553002
Cr-Commit-Position: refs/heads/master@{#419623}

This saves only 5kb off of webview's .apk.

BUG=641032

Review-Url: https://codereview.chromium.org/2343083003
Cr-Commit-Position: refs/heads/master@{#419622}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c36cf56a4fcc..ac4a5f45193a

$ git log c36cf56a4..ac4a5f451 --date=short --no-merges --format='%ad %ae %s'
2016-09-19 ynovikov Add a note on android_optional_gpu_tests_rel trybot to manual rolls doc.
2016-09-19 lpy Make radio picker fire an event when selected key changed.
2016-09-19 sullivan Do not cache LastAddedRevision entities in memcache by default
2016-09-19 sullivan Do not cache Row entities in memcache by default.
2016-09-19 sullivan Do not cache TestMetadata entities in memcache by default.

BUG=646924

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2350193004
Cr-Commit-Position: refs/heads/master@{#419621}

This CL uses load_timing_info_test_util.cc in quic_http_stream_test.cc
so not to duplicate test logic and fixes an incorrect use of function name
camel case.

BUG=637051

Review-Url: https://codereview.chromium.org/2348313004
Cr-Commit-Position: refs/heads/master@{#419620}

The lack of sel_ldr_x86_32 is causing the webports
tree to be red for all mac builders.  Re-enabling
seems more trivial and updating expectations in
webports.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk

Review-Url: https://codereview.chromium.org/2353683003
Cr-Commit-Position: refs/heads/master@{#419619}

BUG=646533
TEST=manually run Ash with --ash-md=experimental and check the icon

Review-Url: https://codereview.chromium.org/2345573003
Cr-Commit-Position: refs/heads/master@{#419618}

This is a display scheduler only concept now that unified begin frame is
turned on.  Renderers can just use the deadline passed to them from the
top level begin frame source.

This fixes a regression from https://codereview.chromium.org/2299003002
where Android was using the incorrect parent estimated draw time of
none and so thought it had less time for frames than it did.

R=brianderson@chromium.org
BUG=646377
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2352823002
Cr-Commit-Position: refs/heads/master@{#419617}

BUG=429053
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2353443002
Cr-Commit-Position: refs/heads/master@{#419616}

As a bonus, we get warnings if you add a new enum value without
updating gfx::ColorTransform.

Committed: https://crrev.com/a54ef7e4e7e234b2bb95f2000b72da718cbbc610
Review-Url: https://codereview.chromium.org/2338213009
Cr-Original-Commit-Position: refs/heads/master@{#419552}
Cr-Commit-Position: refs/heads/master@{#419615}

This patch adds main thread scrolling reasons to blink's scroll nodes
and plumbs them to the compositor.

The approach taken in this patch is to match the semantics of cc's
scroll_tree so that main thread scrolling reasons are propagated up
the scroll tree.

Incremental updates are not yet possible but TODOs and tests have been
updated to ensure the main thread scroll reasons are recomputed.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=644514

Review-Url: https://codereview.chromium.org/2345403003
Cr-Commit-Position: refs/heads/master@{#419614}

Change the offline page icon first
For download completion notification, still pending clarification

BUG=648221

Review-Url: https://codereview.chromium.org/2356643002
Cr-Commit-Position: refs/heads/master@{#419613}

BUG=648406
TBR=miu@chromium.org

Review-Url: https://codereview.chromium.org/2350953004
Cr-Commit-Position: refs/heads/master@{#419612}

Official builds don't use the Field Trial config JSON files, so this
CL manually adds the feature flags in the setup portion of the test.

BUG=648254

Review-Url: https://codereview.chromium.org/2350773003
Cr-Commit-Position: refs/heads/master@{#419611}

On Mac, Ctrl-A and Ctrl-E go to the start and end of a line respectively.

BUG=648331

Review-Url: https://codereview.chromium.org/2352793002
Cr-Commit-Position: refs/heads/master@{#419610}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/09899f1cc00cc6132790ee7ade5e6169f3928b9b Corrected test results presentation for android gtests; Made method showTestsOfOneSuiteOnly faster. (hzl@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=605572

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2350933004
Cr-Commit-Position: refs/heads/master@{#419609}

Printer objects are just data.  There are instances where copying them
is convenient and it should always be safe.

BUG=

Review-Url: https://codereview.chromium.org/2343063004
Cr-Commit-Position: refs/heads/master@{#419608}

For reasons not fully understood, some of clang's tests started failing
when building clang with gcc 4.8.2 but they pass with 4.8.4 or 4.8.5.
Since we do bootstrap builds when building clang binaries, the stage1
host compiler doesn't matter much to us, so just flip the bots to
gcc 4.8.5 and move on with life.

I built 4.8.5 (in a precise vm) with:

  contrib/download_prerequisites
  mkdir build && cd build
  ../configure --prefix=$HOME/gcc485precise --enable-languages=c,c++ --enable-checking=release
  time make -j10
  make install-strip
  tar czf gcc485precise.tgz gcc485precise
  cd ~
  ~/gsutil/gsutil cp -n -a public-read gcc485precise.tgz gs://chromium-browser-clang/tools/gcc485precise.tgz

i.e. I switched from `make install` to `make install-strip`, which also reduces
download size from 125MB to 30 MB.

BUG=648300
TBR=hans

Review URL: https://codereview.chromium.org/2354583004 .

Cr-Commit-Position: refs/heads/master@{#419607}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/d3f0b20208f462f7d31b5798d0a4eb2de13e5b4d Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/ed1c9af068d1c043587013181e6a4b32fae0eb44 [recipes/catapult] Use the head version of bootstrap/get_appengine.py for downloading app engine (nednguyen@google.com)
depot_tools:
  https://crrev.com/186449d3e74a84a1fbd5394fab24da997629c2f4 docs: Removing references to SVN (benhenry@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=643697,chromium:648429

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2349343003
Cr-Commit-Position: refs/heads/master@{#419606}

Objects with a role of IA2_EMBEDDED_OBJECT should get a role of IA_SYSTEM_GROUPPING because otherwise Jaws and NVDA ignore any children.

This makes the PDF viewer accessible on Windows with NVDA but not with Jaws.
R=dmazzoni@chromium.org
TESTED=manually with NVDA

Review-Url: https://codereview.chromium.org/2351043002
Cr-Commit-Position: refs/heads/master@{#419605}

- removes debug switch that I deprecated in previous CL
https://crrev.com/2336943002
- makes the build applications GN rules more DRY

BUG=none

Review-Url: https://codereview.chromium.org/2354683002
Cr-Commit-Position: refs/heads/master@{#419604}

To allow access to Physical Web data, the URL info and Physical Web
Service data needs to be paired together. The pairing gives all relevant
information for a scanned URL.

BUG=636490

Committed: https://crrev.com/576c1dde62f1bc26e4366d50b32f76a636a1dbbd
Review-Url: https://codereview.chromium.org/2330253002
Cr-Original-Commit-Position: refs/heads/master@{#419531}
Cr-Commit-Position: refs/heads/master@{#419603}

BUG=634443

Review-Url: https://codereview.chromium.org/2349103002
Cr-Commit-Position: refs/heads/master@{#419602}

BUG=529395

Review-Url: https://codereview.chromium.org/2350553002
Cr-Commit-Position: refs/heads/master@{#419601}

This CL makes the empty view to be a simple TextView with compound
drawable, instead of a linear layout that nests a textview and an image
view.

BUG=NONE

Review-Url: https://codereview.chromium.org/2343383002
Cr-Commit-Position: refs/heads/master@{#419600}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/b496036ace04eed39f864147805cba03d9f40c71 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/e465667e78b3f898f25b64a3ec4f5c003f7554e7 bot_update: add --auth-refresh-token-json passthrough for apply_issue (hinoka@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=642150

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2346413002
Cr-Commit-Position: refs/heads/master@{#419599}

Revert of Always use valid enum values in gfx::ColorSpace (patchset #3 id:40001 of https://codereview.chromium.org/2338213009/ )

Reason for revert:
broke build:

https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.10%20Retina%20Release%20%28AMD%29/builds/17323

DCHECK failure:

[29864:20227:0919/143752:FATAL:gfx_param_traits_macros.h(19)] Check failed: (static_cast<int>(value) >= static_cast<int>(0) && static_cast<int>(value) <= static_cast<int>(gfx::ColorSpace::PrimaryID::LAST)).
0   Chromium Framework                  0x0000000107a6caf3 _ZN4base5debug10StackTraceC1Ev + 19
1   Chromium Framework                  0x0000000107a8eb17 _ZN7logging10LogMessageD2Ev + 71
2   Chromium Framework                  0x00000001090ac690 _ZN3IPC11ParamTraitsIN3gfx10ColorSpaceEE5WriteEPN4base6PickleERKS2_ + 96
3   Chromium Framework                  0x000000010909096e _ZN3IPC11ParamTraitsIN2cc20TransferableResourceEE5WriteEPN4base6PickleERKS2_ + 270

Original issue's description:
> Always use valid enum values in gfx::ColorSpace
>
> As a bonus, we get warnings if you add a new enum value without
> updating gfx::ColorTransform.
>
> Committed: https://crrev.com/a54ef7e4e7e234b2bb95f2000b72da718cbbc610
> Cr-Commit-Position: refs/heads/master@{#419552}

TBR=sandersd@chromium.org,ccameron@chromium.org,hubbe@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2352903002
Cr-Commit-Position: refs/heads/master@{#419598}

BBC recommends simply using gamma 2.4 when displaying HLG content on non-HDR.

Review-Url: https://codereview.chromium.org/2355633002
Cr-Commit-Position: refs/heads/master@{#419597}

We are not guranteed a mouse motion event before receiving a button
event, which can lead to clicks at the wrong location.
This CL makes sure that button events will report any location and
pointer changes before generating the button event.

BUG=645576

Review-Url: https://codereview.chromium.org/2342413002
Cr-Commit-Position: refs/heads/master@{#419596}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/9cc146d974a9814686e25baf7d6dbe4afeab708a Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/e4abcee60eea8f5a1bc81ddee64d44f847066224 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/f7ada90c926c78704f048767e29e8ae836d8a65b Prefer overridden dependencies. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=None

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2351073002
Cr-Commit-Position: refs/heads/master@{#419595}

Changes the datastore push logic to use the new gcloud
datastore client library.

BUG=646877
R=rdevlin.cronin@chromium.org
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2352813003
Cr-Commit-Position: refs/heads/master@{#419594}

PostmortemReportCollector handles the collection of stability reports,
their packaging to minidump format and registration to the Crashpad
database for reporting.

BUG=620813

Review-Url: https://codereview.chromium.org/2339193003
Cr-Commit-Position: refs/heads/master@{#419593}

This still fails on Windows official builds.
This is in lieu of reverting all of https://codereview.chromium.org/2354633002

TBR=dimich@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2356603002
Cr-Commit-Position: refs/heads/master@{#419592}

https://pdfium.googlesource.com/pdfium.git/+log/b12fbddece43..c6c2e36f59f5

$ git log b12fbddec..c6c2e36f5 --date=short --no-merges --format='%ad %ae %s'
2016-09-19 tsepez Remove CPDF_Object::Destroy { delete this; }
2016-09-19 art-snake Fix "heap use after free" bug.
2016-09-19 kcwu Add fuzzer for fax codec

BUG=647612

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2350993002
Cr-Commit-Position: refs/heads/master@{#419591}

https://chromium.googlesource.com/skia.git/+log/613664b1bc64..304e6745dc5e

$ git log 613664b1b..304e6745d --date=short --no-merges --format='%ad %ae %s'
2016-09-19 rmistry Reland of Run SVGs through nanobench on all Perf bots (patchset #1 id:1 of https://codereview.chromium.org/2348563003/ )
2016-09-19 egdaniel Create GrVkCopyPipeline class
2016-09-19 reed remove dead code around SK_ENABLE_CLIP_QUICKREJECT
2016-09-19 mtklein Add FrameworkDefs bot to the CQ.
2016-09-19 hinoka Skia recipe: Use [depot_tools]/gsutil.py instead of [depot_tools]/third_party/gsutil/gsutil
2016-09-19 bungeman Split SkFontConfigInterface globals and factory.
2016-09-19 csmartdalton Add adb support to skpbench

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=borenet@google.com

Review-Url: https://codereview.chromium.org/2356523003
Cr-Commit-Position: refs/heads/master@{#419590}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/bb8206eeece0eb7ec7dfa832535a0f1a5a56c500 Remove package build step from dart recipes (whesse@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2352713003
Cr-Commit-Position: refs/heads/master@{#419589}

Inspired by https://codereview.chromium.org/2347973002/ .

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2349213004
Cr-Commit-Position: refs/heads/master@{#419588}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/4654e248929bffb7eee1df0ba851f608dbe6eee1 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/8cde6a2835f03e5bf18e1bd8e84e8421dc206495 Revert of Changed sequence of package_build step (patchset #2 id:20001 of https://codereview.chromium.org/2335383002/ ) (dtu@chromium.org)
depot_tools:
  https://crrev.com/8ea74908a6b6f9ec1ab1a8333d40b54cef0f6f19 depot_tools: Remove third_party/gsutil (hinoka@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=645662

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2351013002
Cr-Commit-Position: refs/heads/master@{#419587}

Speculative fix for crasher in RenderWidgetHostViewGuest::
OnSwapCompositorFrame(), in case it is caused by guest_ being null.

BUG=646736
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2346863004
Cr-Commit-Position: refs/heads/master@{#419586}

Since the GYP files have been removed, the "GYP version" annotations above
targets can be removed.

TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2356543002
Cr-Commit-Position: refs/heads/master@{#419585}