- 15 Oct, 2020 40 commits
-
-
Scott Violet authored
The fix for this landed in 88, not 87. BUG=1075744 TEST=test only change Change-Id: If1fd318cf5c6f151549dff042dd6c288a146870e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476914 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817560}
-
Jesse McKenna authored
This change removes histogram suffixes PageLoad.PaintTiming.NavigationToFirstContentfulPaint.OnBattery and PageLoad.PaintTiming.NavigationToFirstContentfulPaint.NotOnBattery, which allowed the filtering of FirstContentfulPaint measurements by whether the system was on battery or wall power during page load. This was used to filter FirstContentfulPaint regressions for battery-specific Finch experiment SlowDCTimerInterruptsWin, which is now on Stable. Because the experiment is finished and I'm not aware of any other users, this histogram can be removed. Change-Id: I78a6a2026596cb9aaa0783129ee3f4d8034fc039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468337Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#817559}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/ff267ca60e14..53380f9ed76f 2020-10-15 sarahmashay@google.com [validation] remove tests that have landed in cts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: enga@google.com Change-Id: I412da03b8f2af4c360d5a063fc53936c997a5e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476093Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817558}
-
Amin Hassani authored
Also mark other histograms in installer as obsolete as they have been replaced by UpdateEngine onces long time ago. BUG=None TEST=None Change-Id: Id5698e75d9f152f142f131b53ccaadc45ee899a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472595 Auto-Submit: Amin Hassani <ahassani@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Amin Hassani <ahassani@chromium.org> Cr-Commit-Position: refs/heads/master@{#817557}
-
Zach Trudo authored
Bug: chromium:1078512 Change-Id: I160ad5d61ad05f5e95f63188c40f9084b6e816e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369659 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#817556}
-
Viktor Semeniuk authored
This change adds Password Edit feature to testing config. Bug: 377410 Change-Id: I9a950611f1462d43b8c6770f90b2f62da53b297b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474875Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#817555}
-
Xiqi Ruan authored
Records the Chrome browser usage time of Chrome OS users to UMA at the beginning of the first session on the next day. It helps us understand users' usage on Chrome OS and improve family users' experience. Metrics from abnormally terminated sessions will be skipped. Bug: 1114849 Change-Id: Ia2d51161937492cea034c75aa98b077b56445af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410619 Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#817554}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c6b4ce00..029d567d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2cd171a1ac824d2b5e1864de8b5a1d5832a38fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475307Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817553}
-
Xiqi Ruan authored
The feature launched more than half a year ago, so it's a high time to cleanup. Also removed code in other files that is related to this feature flag. Bug: 1120085 Change-Id: Ia64376339f6aebbf20b7d494cda4e6d26a7785a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469234 Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Gayane Petrosyan authored
Bug: 1129652 Change-Id: Ice49fcc2ec98f3a975f2ae5dfd113af98ba2ef5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472262Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#817551}
-
Sophey Dong authored
Bug: 1138750 Change-Id: I0cf69bfad56ed24704d0e2e02050537c2fbea73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473804Reviewed-by:
-
Dominik Röttsches authored
Change-Id: I541eca7671cc2904e71b3ab959058cc5881c52dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476153 Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#817549}
-
Maggie Chen authored
GPU.WatchdogThread.ExtraThreadTime GPU.WatchdogThread.ExtraThreadTime.Init GPU.WatchdogThread.ExtraThreadTime.PowerResume GPU.WatchdogThread.ExtraThreadTime.Normal GPU.WatchdogThread.ExtraThreadTime.Foregrounded GPU.WatchdogThread.ExtraThreadTime.NumOfUsers GPU.WatchdogThread.WaitTime GPU.WatchdogThread.WaitTime.Foregrounded GPU.WatchdogThread.WaitTime.Normal GPU.WatchdogThread.WaitTime.PowerResume GPU.WatchdogThread.WaitTime.Init GPU.WatchdogThread.WaitTime.NumOfUsers GPU.WatchdogThread.WaitTime.ProgressAfterWait Bug: 1138404, 1138386 Change-Id: Ic84509ea6ec13acf0d54dc874d7738eb3d015ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473431 Auto-Submit: Maggie Chen <magchen@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: -
Toni Barzic authored
BUG=1137452 Change-Id: Ifb3caf122cb8a0600b2ee5b7a61ed4596a9b91ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472609Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#817547}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dd09d6e2ef11..41fc174d7967 2020-10-15 robertphillips@google.com Restore cpu execution of async* GMs 2020-10-15 fmalita@chromium.org [svg] Relocate out of experimental If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I382f4bae0b490605b93dabea700c1299e8759ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476066Reviewed-by:
-
Muhammad Hasan Khan authored
In this change we're adding a test that simulates the same condition that was addressed in https://crrev.com/c/2389060 i.e. we ensure that ArcInstanceStopped is not called on new instances of arc_vm_client_adapter if they're created during handling of ArcInstanceStopped event. BUG=b:164816080 TEST=components_unittests --gtest_filter='ArcVmClientAdapterTest*' TEST=revert the fix and ensure that the test fails Change-Id: Icd90da53f832d13893f20bb017fdc793e14af628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469813Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#817545}
-
Peter Boström authored
Replaces BubbleDialogDelegate::SetFixedWidth with DialogDelegate::set_fixed_width(). Removes ClientView::set_fixed_width in favor of fetching the values directly from DialogClientView::CalculatePreferredSize which is where the DialogDelegate margins are also fetched. This is done so that set_fixed_width() can be used for non-bubbles to remove additional CalculatePreferredSize calls where the end result is expected to be a fixed width. Bug: 1128500 Change-Id: I8164b2348d5945ffc5b3985120e2102e62b0f066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472910Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#817544}
-
Jeremy Roman authored
This reverts commit 9b1cb285. Reason for revert: Appears to break linux-chromeos-rel: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/41980 In particular, the test says this: #if defined(OS_LINUX) && defined(OS_CHROMEOS) // QueryOutputProtectionStatus() is known to fail on Linux Chrome OS builds. std::string expected_title = kEmeUnitTestFailure; #else std::string expected_title = kUnitTestSuccess; #endif The condition becomes impossible after this CL. It's not obvious to me whether defined(OS_CHROMEOS) is the right fix here, because the comment specifically refers to Linux Chrome OS. Hence reverting so that this can be sorted out with media folks before relanding. Original change's description: > Undefine OS_LINUX for Chrome OS. > > Bug: 1110266 > Test: Built and took diff of the executable via objdump. > Change-Id: I80832fb472e6cc78d1e967f6216b1c33cc79ba73 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475013 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817475} TBR=thakis@chromium.org,hidehiko@chromium.org Change-Id: I42d0ff74a7f640edd2b9d986628329dcff6c5d4e No-Presubmit: true Bug: 1110266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477033Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#817543}
-
Min Qin authored
And also fixes some of the exiting arms BUG=1096224 Change-Id: Ibbc50ea023d9f6dc426e1ec6c001e613b5fedf3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469458Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817542}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a7b30cd95fed..acbaac2aa7cd 2020-10-15 bmgordon@chromium.org cros_sdk: Add explicit --use-image option 2020-10-14 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I33708b5cdea802e6d7cb9084d58ffe4222b8e6aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475012Reviewed-by:
-
Alex Gough authored
This is only read from: https://source.chromium.org/chromium/chromium/src/+/master:components/web_package/web_bundle_parser_factory.cc;drc=0e22286ee95d2bd711f81d73f1178343fbacc890;l=29 Bug: 1130762 Change-Id: I1859ab3cf91f8131190883479735fd1ca9acb608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464205Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#817540}
-
Morten Stenshorne authored
No code changes required. Bug: 294205 Change-Id: I39a0bc14e444a9bbff70f57a9866acda8a9c0c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472040Reviewed-by:
-
Ben Pastene authored
The filter file exists on both branches: https://chromium.googlesource.com/chromium/src/+/refs/branch-heads/4240/testing/buildbot/filters/chromeos.ozone_unittests.filter https://chromium.googlesource.com/chromium/src/+/refs/branch-heads/4280/testing/buildbot/filters/chromeos.ozone_unittests.filter So just needs the cmd-line arg specified. Bug: 968349 Change-Id: Idf88d88e11f1bf03ab6d93e354c14844b1b43482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472208Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#817538}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ad2ec763873b..a39689cc986e 2020-10-15 hta@webrtc.org Separate PC resources required at runtime from PCfactory If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I62bbfc9b8099b491fe8bb4572e76e85a124a20cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475009Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0963e7ee54a8..08ffb75d06d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbroman@google.com,msramek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1061119 Tbr: jbroman@google.com,msramek@google.com Change-Id: Ib5cbfecd65e8f28c3454a968e10d4fe8f4f7e2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475011Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817536}
-
Fredrik Söderqvist authored
This might have caught the regression found by said bug (hot-spot clamped by unscaled image dimensions). Bug: 1138488 Change-Id: Ib31b78b00d25f84476d65886090d8c3a44aef32e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475881Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#817535}
-
Mustafa Emre Acer authored
NavigationSuggestion.Event histogram records each lookalike domain in a redirect chain as a separate entry. This slightly overcounts lookalike matches. This CL changes the histogram name to NavigationSuggestion.Event2 and records only one entry per navigation. Bug: 1136296 Change-Id: Icc0beae3d497718a7700f1875db7e5646e729fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459430 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#816816} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473064 Cr-Commit-Position: refs/heads/master@{#817534}
-
Peter Kasting authored
This reverts commit 6460aa02. Reason for revert: Looks to have broken Android compile: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/15768 Original change's description: > Merge Webapk/TWA disclosure controller 1 > > This CL moves WebappDisclosureSnackbarController to browserservices > folder, makes it use TrustedWebActivityModel and the > DisclosureInfobar as TrustedWebActivityDisclosureController. > > This will change the text in unbound webapk's disclosure snackbar text > to be the same as TWA one. > > Bug: 1128675 > Change-Id: I900c41c04a6f36489bed1e08cf81c74f89e2801e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453896 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Commit-Queue: Ella Ge <eirage@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817516} TBR=agrieve@chromium.org,peconn@chromium.org,eirage@chromium.org Change-Id: I97a14528dbe701a19753b87b3a9a13963716099f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1128675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476775Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#817533}
-
Andrew Grieve authored
Just a random cleanup I noticed. Should have no effect. Bug: None Change-Id: Iedcadbbb222b565bd094eb614ad002627330c47f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475754 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#817532}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6298d2b70cb6..a7278454b28b 2020-10-15 cwallez@chromium.org Make dawn_use_x11 = use_x11 when building inside Chromium 2020-10-15 cwallez@chromium.org ShaderModule: Don't use Format::Type for reflection. 2020-10-15 cwallez@chromium.org TextureView: only store the Aspect as a bitfield. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:976495 Tbr: enga@google.com Change-Id: I27c267e5cbb2504cac33252275070e1538238ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475010Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817531}
-
Paula Vidas authored
This CL adds support for highlighting fields that are in a "bad" state in the About tab of chrome://sync-internals. When a field is in a bad state (e.g. Notifications Enabled - false), the text will be colored red, to make it easier to spot. This is done for the following fields: - Auth Error - Last Token Request Result - Server Connection - Notifications Enabled - GetKey Step Result - Download Step Result - Commit Step Result Bug: 1126083 Change-Id: I804132974724ff0d6256a324d1333d39e476e6dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474874 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#817530}
-
Rohit Agarwal authored
This CL explicitly make use of getPrimaryOTRProfile for cases dealing with primary OTR profile. Bug: 1060940 Change-Id: Ibb003f0f42eef2e824112075465d27b0f9920f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475797Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#817529}
-
Manas Verma authored
Includes a third line in the autofill popup suggestion UI, which will include credit card offer data. Bug: 1093057 Change-Id: I26b2c647a6dbe81ec367ff75dbdcc2074375b7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436849Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#817528}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/52c1a859d9eb..04bd4d8e4ece 2020-10-15 amaiorano@google.com Add unit tests for arithmetic ops with constant args 2020-10-15 eholk@chromium.org Handle mul instructions with two immediates on x86-32 and x86-64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I09a0185aa4df92d780baf4b9cf664323273bcf8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475006Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010150700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/tzLm8HyLE4vYMwHlQ9sxWnDlV3EFRrx_A_t8MIGN9YcC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/162187144 Tbr: media-app@grotations.appspotmail.com Change-Id: Iee94c9a767832da48718ada01703aa3f162fcafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476013Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds a link to the origin to the dialog shown when removing a compromised credential. Since injecting links to insecure domains is not allowed due to the risk of XSS, this is limited to HTTPS origins. Fixed: 1066790 Change-Id: I297c3e49b4388bed5c229959345741565b1d2092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133966Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#817525}
-
Clemens Arbesser authored
This was erroneously reported on every start of autofill_assistant, not just lite-script starts. Bug: b/170952445 Change-Id: I952c7f7aafce879ad7fd8ef7c268b42c5b4fd101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475916Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#817524}
-
Ben Pastene authored
We skip expectations for any builder with 'error' in its GN args. And many android builders set the 'use_errorprone_java_compiler' arg, so they all have their expectations skipped. The correct condition would be to test that all the GN args is wholly equal to 'error'. This fixes that. Now only 'chromium_presubmit' and 'ios-simulator' are skipped. Bug: 1117577 Change-Id: Ibcbfd966fe5918e234a99b010928345192daf057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472207Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#817523}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 87-4277.0-1602498224-benchmark-87.0.4280.19-r1 to 87-4277.0-1602498224-benchmark-87.0.4280.20-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I71ad830c3ab81006798bef2a87f13f6c41e989f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476513Reviewed-by:
-
Thomas Lukaszewicz authored
This CL adds a reusable bubble and corresponding WebUIController class to be used when implementing Secondary UI using WebUI. See the below doc for more details. https://docs.google.com/document/d/1UtAVhVpo8Si_XlZEdt-BH_AN4egBo1XppZEhF3_bthM/edit?usp=sharing Bug: 1099917 Change-Id: I6b16997b05dc2bf2f208ca71dd5b3cfa11db00f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462223 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#817521}
-
