- 25 Jun, 2019 40 commits
-
-
Wez authored
This reverts commit e2a060b2. Reason for revert: CL changed #includes from mojom-shared.h to mojom-blink.h without migrating the corresponding |deps| in BUILD files to refer to the Blink "mojom_platform" target that generates the mojom-blink headers, leading to flaky builds. Original change's description: > Use mojom-blink.h headers in blink/renderer/ > > ... instead of the respective mojom-shared.h variant. > > Today there is a mix of *mojom-shared and *mojom-blink.h usage > within third_party/blink/renderer. > > This CL replaces all instances of the former by the later, > except for one in renderer/modules/indexeddb, which seems to > require some more work. > > Next an amend on third_party/blink/PRESUBMIT.py will be done > to avoid further occurrences. > > TBR=dcheng@chromium.org > > BUG=973028 > R=haraken@chromium.org > > Change-Id: Ifab9a832c5435e37399e8d210b5c716daeba66ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658911 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669501} TBR=haraken@chromium.org,tonikitoo@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 973028 Change-Id: I2427c43ec95b27f942f1be77674069fe4fe7cc2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675469Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#672000}
-
Yutaka Hirano authored
Bug: 978265 Change-Id: Ib7347822f49f5ea8ab4b11e19d0d4db6ae218734 Tbr: caseq@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675507Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#671999}
-
Shuo-Peng Liao authored
In V4L2Device::V4L2FormatToVideoFrameLayout(), when converting V4L2_PIX_FMT_NV12 format, it should expect to see two planes. However, the code expects 3. It passes CQ because CQ does not cover v4l2 specific unittests. BUG=chromium:971943 TEST=pass media_unittests on an ChromeOS DUT. Change-Id: Ib5504ef36e0935235cd36a390b3905d45ba8b6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675506Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Shuo-Peng Liao <deanliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#671998}
-
Takashi Sakamoto authored
This reverts commit 87d6424d. Reason for revert: suspect causing ash_unittests failure on Linux Chromium OS ASan LSan Tests (1). https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/34147 deterministic failures: TabletModeWindowManagerWithClamshellSplitViewTest.ClamshellTabletTransitionTest ==23210==ERROR: AddressSanitizer: container-overflow on address 0x6020000e12b8 at pc 0x55b059128cb9 bp 0x7ffdb6f1b8d0 sp 0x7ffdb6f1b8c8 READ of size 8 at 0x6020000e12b8 thread T0 #0 0x55b059128cb8 in ash::SplitViewDivider::~SplitViewDivider() ./../../ash/wm/splitview/split_view_divider.cc:253:19 #1 0x55b059128f4d in ash::SplitViewDivider::~SplitViewDivider() ./../../ash/wm/splitview/split_view_divider.cc:249:39 #2 0x55b0591499fc in ash::TabletModeController::SetTabletModeEnabledInternal(bool) ./../../ash/wm/tablet_mode/tablet_mode_controller.cc:622:16 #3 0x55b052f19119 in ash::TabletModeWindowManagerTest::DestroyTabletModeWindowManager() ./../../ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc:138:45 #4 0x55b052f8060b in ash::TabletModeWindowManagerWithClamshellSplitViewTest_ClamshellTabletTransitionTest_Test::TestBody() ./../../ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc:1974:3 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8909703871929620480/+/steps/ash_unittests/0/logs/Deterministic_failure:_TabletModeWindowManagerWithClamshellSplitViewTest.ClamshellTabletTransitionTest__status_CRASH_/0 Original change's description: > Clamshell <-> tablet mode transition > > There are 3 cases in clamshell to tablet mode transition: > 1) overview is active but splitview is not: keep overview active during > transition. > 2) overview and splitview are both active: keep them both active during > transition. > 3) overview and splitview are both inactive: keep the current behavior. > a) if the top window is a snapped window, put it in splitview > b) if the second top window is also a snapped window that snaps to the > opposite side of the screen, put it in splitview as well > c) if the top window is not a snapped window, maximize or fullscreen > all windows when entering tablet mode. > > There are 4 cases in tablet to clamshell mode transition: > 1) overview is active but splitview is not: keep overview active during > transition. > 2) overview and splitview are both active: keep them both active during > transition. > 3) overview is inactive but splitview is active (i.e., two snapped windows), > splitview will be no longer active after transition. But the two snapped > window will still keep snapped in clamshell mode. > 4) overview and splitview are both inactive: keep the current behavior, > i.e., restore all windows to its old window state before entering tablet > mode. > > > Bug: 890029 > Change-Id: I7769021f74c3e9d591b19258be2821992d780451 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658955 > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#670678} TBR=oshima@chromium.org,xdai@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 890029 Change-Id: I518170a62a0cf82aff14748679e3a5f12f054f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675924Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#671997}
-
Yi Su authored
This CL moves the hanler method for window.error Js message from CRWWebController into WindowErrorManager. All unused and unnecessary methods in CRWWebController for Js message handling are also removed. Bug: 956516 Change-Id: If0823bc3cdab1042538ce314626681bcd28ad56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674014 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#671996}
-
Yoichi Osato authored
This patch changes the test to listen |searchParams| option so that we can test it in various size from lightweight-for-check to heavyweight-for-accuracy. Example: $ content_shell receive-arraybuffer-1MBx100.html?iteration=3&server=ws://127.0.0.1:8002/ > Connect to ws://127.0.0.1:8002/ Running 3 times Ignoring warm-up run (346.07608397871 MB/s) 349.01482119459 MB/s 332.869505903946 MB/s 286.404642021716 MB/s Description: Measure performance of receiving 1MB array 100 times. Bug: 954000 Change-Id: Idc0365c97e6a659f0d91e8e57f6c789407b06739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669149 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
-
Kent Tamura authored
Bug: 972476 Change-Id: I1cca5af7809c0575f9c34a5d11068dc41aea157b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672847Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#671994}
-
Leo Zhang authored
Interfaces was used in IME service, but somehow it's not added into IME service deps. Bug: 837156 Change-Id: I8d18ad33d45f58b306e1d54f0dfe16df15cb1fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675279Reviewed-by:
Marti Wong <martiw@chromium.org> Commit-Queue: Marti Wong <martiw@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#671993}
-
Rune Lillesveen authored
TBR=drott@chromium.org Bug: 977283 Change-Id: I4870a222ed6fcddfc716b6f3e43c5fcd126709e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675804Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#671992}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9ca73fdc2fa..b7104ada38e4 Created with: gclient setdep -r src-internal@b7104ada38e4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tzik@google.com,dbeam@google.com,huanzhong@google.com Change-Id: Id6df49dd31c020fa1ae2d28b9ac56d80009edf6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675386Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671991}
-
Satoshi Niwa authored
Bug: 971499 Change-Id: Ifef681fbeccc902a80df145b61830c74ae6be7b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670136Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#671990}
-
Matthew Cary authored
Replace a use of the deprecated SharedMemoryHandle with the current shared memory region API. This changes PolicyTargetTest. SharedHandleTest to use anonymous shared memory rather than named shared memory. Bug: 795291 Change-Id: I5177db8e47c08259b26a3bb660da500fa0eb10b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658015Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#671989}
-
Jay Harris authored
The explainer is being updated to indicate that websites should use the presence of 'files' and 'request' to determine the cause of launches. Note: This API is hidden behind the NativeFileSystemAPI and FileHandling blink flags. Bug: 829689 Change-Id: Ia8a39ce36fee06281ab51e03c3ad2db401c105c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672611 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#671988}
-
Colin Blundell authored
This CL tightens the DEPS restrictions on inclusions of IdentityManager internal headers to be allowed only for the various IdentityManager factories. Even this allowance will shortly be removed when we internalize the building of IdentityManager from embedder-level dependencies. TBR=jochen@chromium.org Bug: 970268 Change-Id: Iaf0637aff5cfc3f710edcc3919645dba358bf52e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674091 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#671987}
-
Colin Blundell authored
This CL updates //components/signin/core/browser/BUILD.gn to account for the evolution of the IdentityManager project and prepare for upcoming restructuring of //components/signin. Bug: 952788 Change-Id: Ie01eb5b072758d507e6ca5420030e52b433e1b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674005Reviewed-by:
-
Yutaka Hirano authored
...due to flakiness. Bug: 978278 Change-Id: I227c9182e4433160a8ca8788f44f2d138ea363f3 Tbr: shik@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675904Reviewed-by:
-
Meredith Lane authored
Clusterfuzz identified a null dereference on AXLayoutObject. Bug: 970217 Change-Id: I269ba9bfce1d07e6af48a11bd9080279400ca965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666576 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#671984}
-
Lutz Justen authored
If ${PASSWORD} is present in KerberosAccounts, store the login password in the kernel keyring. The Kerberos system daemon will then grab the password to authenticate to a Kerberos account. Also moves the call to InitializePrimaryProfileServices to an earlier place. The KerberosCredentialsManager, which is created there, has to be created when the login password is still stored in the user context, so that UserSessionManager has a chance to send it to the session manager (see SaveLoginPassword). However, the call happened when the password was already cleared, see user_context_.ClearSecrets() in FinalizePrepareProfile. BUG=chromium:952240 TEST=Manually tested on device (enabled KerberosEnabled policy, set ${PASSWORD} as password for an account in KerberosAccounts, changed Gaia password to patch Kerberos password, logged in, verified in chrome:settings/kerberosAccounts that the ticket was valid. Change-Id: I3d82b293c3d236b03928cd5cd75edbea6c8999a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656570Reviewed-by:Colin Blundell <blundell@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#671983}
-
Yutaka Hirano authored
...due to flakiness. Bug: 976841 Change-Id: Ia98c267bc9d1234095196046e684372d5720a8d3 Tbr: grunell@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675665Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ce76d1e960eb..3df9c76a4999 git log ce76d1e960eb..3df9c76a4999 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 mmortensen@google.com Build API: Refactor service/lib and commands.py to use artifacts.BundleFirmware Created with: gclient setdep -r src/third_party/chromite@3df9c76a4999 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I57657ae23cdaca4f0e5786b5f728180591682b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675385Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671981}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/afa3e0ca167b..96f6f7f65b3c git log afa3e0ca167b..96f6f7f65b3c --date=short --no-merges --format='%ad %ae %s' 2019-06-25 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 dfd760055152..3b2255975f37 (3 commits) 2019-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 91f69e5c..aab9fad6 (366 commits) Created with: gclient setdep -r src/third_party/skia@96f6f7f65b3c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@google.com Change-Id: I51ef093a250ab0699e67a771f6f1f3b3f5179beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675387Reviewed-by:
-
Colin Blundell authored
This CL eliminates the last inclusion of gaia_cookie_manager_service.h from files other than the IdentityManager internals by moving the standalone MultiloginParameters struct to its own file. Bug: 970268 Change-Id: I40d6b58065b0d3f268a775f9a0ee8ef2936a9372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674090 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change implements replacing the PasswordFormFieldPredictionType autofill enum with its Mojo equivalent and gets rid of now unneeded type conversions and performs minor clean-ups. Bug: 962853 Change-Id: I304443d90dc77f82283b89f283e4b1738e108472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662550 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#671978}
-
tby authored
Unfortunately we can't use maps in a RecurrenceRankerConfigProto because they cannot be relied upon for a consistent hash, as their field ordering is not guaranteed. This CL changes the hour binned model to use a repeated field of pairs instead of a map for bin weights in the config. This CL also reshuffles the hour binned tests, so that the test fixture is close to the tests themselves. Bug: 921444 Change-Id: I06148466ca380001f7bb86e1bcdf10f662b7f728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669072Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#671977}
-
Eliot Courtney authored
This is to prevent it from triggering auto-picture-in-picture. which causes the WebView in the assistant to cover the Youtube app while it's playing a video does not trigger auto-PIP. Bug: b/134793884 Test: Pressing the assistant button on eve and then selecting an option Change-Id: Ia94c876d1fc67c6010b3625342e21f73568534b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671894Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#671976}
-
Domenic Denicola authored
Along with https://chromium-review.googlesource.com/c/chromium/src/+/1670572, this aligns the KV Storage implementation with https://github.com/WICG/kv-storage/pull/68, which uses Web IDL to define the API. The observable changes are to: * Enumerability of methods * Adding @@toStringTag (affecting Object.prototype.toString.call) This includes web platform tests that abuse the current idlharness.js infrastructure, plus some ad-hoc hand-written tests that we expect to be generated by future versions of idlharness.js once the relevant Web IDL pull requests are merged. It removes the existing API surface tests and helpers in favor of idlharness.js. Bug: 931263 Change-Id: I9205d1a8b3040617cbb6200f825ba9ad250e61c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672137 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#671975}
-
Oleh Prypin authored
Otherwise they're running on a random machine with arbitrary OS version, including the bots that are explicitly called like "Win8 Tester". Right now the main problem with this is that Chromium fails to build on Windows 7, and due to random selection of machine the build appears "flaky". Bug: 976184 Change-Id: I5de22cf1072d003856b89ef152f35d22436de991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672849Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#671974}
-
Jeevan Shikaram authored
Open App Management in a new tab from the settings page. Bug: 906508, 972988, 965903, 965897 Change-Id: I6bda7059b1d75edf30b9f1796f42b6a589b54da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659657 Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#671973}
-
Findit authored
This reverts commit 971acfcb. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 671864 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTcxYWNmY2JmNjhiMmQ4MWQ1ZTUzMWZkNjI5MDdiYmRjMTE5N2M2NQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/81349 Sample Failed Step: webkit_layout_tests Sample Flaky Test: virtual/not-omt-sw-fetch/external/wpt/service-workers/service-worker/fetch-canvas-tainting-video.https.html Original change's description: > service worker: Add virtual tests for on-the-main-thread script fetch > > On-the-main-thread script fetch is disabled by default. Add virtual > tests for on-the-main-thread script fetch to have better test > coverage until we ship off-the-main-thread script fetch. > > Bug: 967272 > Change-Id: If0b50ad557699d57bae70b2972418df5dc91ed72 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673487 > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671864} Change-Id: I95b54ba1e51139180ba860f5d9c73aff33995276 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 967272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675467 Cr-Commit-Position: refs/heads/master@{#671972}
-
Takashi Toyoshima authored
- Deprecate Media.Midi.InputPorts - Deprecate Media.Midi.OutputPorts - Merge Media.Midi.ResultOnShutdown error case into Media.Midi.Usage - Update expiry milestone for Media.Midi.SysExMessageSizeUpTo1MB to be M85 - Add expiry milestone to metrics that did not have Also now we can remove MAX and LAST from the mojo enum. Bug: 975668, 582327 Change-Id: I8358ea0130def2b0661d0f460741957360cd6550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670577Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1ae6ac81e68a..afa3e0ca167b git log 1ae6ac81e68a..afa3e0ca167b --date=short --no-merges --format='%ad %ae %s' 2019-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 900e1dac1b2d..e899321b0bf7 (7 commits) 2019-06-25 mtklein@google.com assemble directly into mmap'd memory 2019-06-25 brianosman@google.com ByteCode: Improved ExternalValue interface 2019-06-25 bsalomon@google.com Trace events in Gr[Vk]Gpu, GrVkCommandBuffer, GrVkCommandPool, and GrVkResoureProvider. Created with: gclient setdep -r src/third_party/skia@afa3e0ca167b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:919885 TBR=djsollen@google.com Change-Id: I4790c2da23786011de5544bce79359c53d45cf17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675225Reviewed-by:
-
Joel Hockey authored
Always share files when RUNNING signal is received rather than only when we explicitly start. Bug: b:135772268 Change-Id: I772284a51e1df32654ea2cb2ff4c9ddfe5df7152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674968 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#671969}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/eb66fe4e15e8..3b2255975f37 git log eb66fe4e15e8..3b2255975f37 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 jiajia.qin@intel.com Fix the DispatchCompute error Created with: gclient setdep -r src/third_party/angle@3b2255975f37 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: Ib32ac270d63ca82ccf4a97db2623c9c1d26140ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674419Reviewed-by:
-
Alexandre Courbot authored
VideoDecoder methods are only supposed to be called from the client's task runner. Add a few missing DCHECKs to ensure this is really the case. BUG=920058 TEST=Build succeeds on Eve. Change-Id: Ia1783011cb75edecf834f38dd619ba82abcd2cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670144Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#671967}
-
Xianzhu Wang authored
Also fix a lot of wrong baselines for LayoutNG. We should have been more careful when rebaselining tests, and should have noticed this bug when we first saw LayoutNG painted selections differently. Bug: 967432 Change-Id: Ibd36dbfdfc8a98b7b86e3c74d8db725a98652da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674262 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#671966}
-
tby authored
This adds methods that allow the user of a RecurrenceRanker to mutably access the storage maps of the ranker's FrecencyStore. This is useful for custom target/condition deletion logic that cannot be efficiently implemented via RemoveTarget/Condition. Bug: 921444 Change-Id: If6add2dee46e6cbd2b0a33820a5e613d5fde3d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669010Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#671965}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0cc2343f646..f9ca73fdc2fa Created with: gclient setdep -r src-internal@f9ca73fdc2fa The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tzik@google.com,dbeam@google.com,huanzhong@google.com Change-Id: Ib784ec419bdfcf2e59a12276374b8c707a24ba36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674333Reviewed-by:
-
Makoto Shimazu authored
Bug: 972458 Change-Id: Ibc0e0da1a69905ca8318e762ea92e1eb3616bbf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669253Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/99b76d1b8fdd..41c24ee4eb69 git log 99b76d1b8fdd..41c24ee4eb69 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 yizhou.jiang@intel.com Fix computation of mipmap sizes used in validation 2019-06-25 hao.x.li@intel.com Supress failing end2end tests with Metal validation layer Created with: gclient setdep -r src/third_party/dawn@41c24ee4eb69 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: Id4fcc7a6af7dc6dc3b199f67e0d2297aa6a8c065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675204Reviewed-by:
-
Jeremy Klein authored
This also fixes the flash of previous dialog content by covering it with a loading indication until the new content has been loaded. Bug: 956491 Change-Id: I06f03c1194925c45d3f40a054e26a017ac48c074 Tested: Heavily manually tested swapping between links. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668494 Auto-Submit: Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#671961}
-
