Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 06 Jun, 2018 9 commits
    • Tetsui Ohkubo's avatar
      Disable remaining tests unrelated to UnifiedSystemTray. · 68be1657
      Tetsui Ohkubo authored 
      This CL disables unit tests that are testing the features that are just
removed in UnifiedSystemTray. These tests crashed/failed when
UnifiedSystemTray was enabled.

TEST=ash_unittests --enable-features=SystemTrayUnified
BUG=847104

Change-Id: I7a8b9b0723737fc03a048d41be2f23b1e73dd8a7
Reviewed-on: https://chromium-review.googlesource.com/1086813Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564716}
      68be1657
    • skia-chromium-autoroll's avatar
      Roll src/third_party/skia 5e6853d..3857fbf (5 commits) · 7efc227d
      skia-chromium-autoroll authored 
      https://skia.googlesource.com/skia.git/+log/5e6853d..3857fbf


git log 5e6853d..3857fbf --date=short --no-merges --format='%ad %ae %s'
2018-06-05 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 57776df..f398044 (1 commits)
2018-06-05 kjlubick@google.com Add Gr enums and version parsing for SwiftShader
2018-06-05 herb@google.com Have draw(Text|PosText|PosTextH) use a single entry on the device
2018-06-05 mtklein@chromium.org restore headers lost from skia.h
2018-06-05 jvanverth@google.com Consolidate ambient and spot code setup.


Created with:
  gclient setdep -r src/third_party/skia@3857fbf

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=halcanary@chromium.org

Change-Id: I0b7c4269ed5b0b130d22ebc8c50e136a183cab82
Reviewed-on: https://chromium-review.googlesource.com/1087632Reviewed-by: default avatarskia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564715}
      7efc227d
    • Tetsui Ohkubo's avatar
      Fix TrayEventFilterTest for UnifiedSystemTray. · 3c6c00c5
      Tetsui Ohkubo authored 
      This CL fixes TrayEventFilterTest crash when SystemTrayUnified is
enabled.

This CL makes following changes:
* Fix TrayEventFilterTest to use UnifiedSystemTray instance when the
  flag is true.
* Fix vpn/network feature pod buttons not to observe NetworkHandler
  when it doesn't exist. It's cumbersome to mock NetworkHandler for all
  unit tests, and old SystemTray did the same. Also NetworkHandler will
  be refactored soon.

TEST=TrayEventFilterTest (--enable-features=SystemTrayUnified)
BUG=847104

Change-Id: I2b9b281d182d9fbbbf159e9374c53adb29a1c756
Reviewed-on: https://chromium-review.googlesource.com/1082140
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564714}
      3c6c00c5
    • Allen Vicencio's avatar
      Add metrics for Native SMB Mount operation · d55b4703
      Allen Vicencio authored 
      This adds the enum and histogram for the result of mounting an SMB share. The metric is recorded when SmbService returns from calling Mount

Bug: 757625
Change-Id: I670ce6343131719850a1368154eec6e123354fca
Reviewed-on: https://chromium-review.googlesource.com/1077605
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: default avatarBrian White <bcwhite@chromium.org>
Reviewed-by: default avatarZentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: default avatarRyan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564713}
      d55b4703
    • Esmael El-Moslimany's avatar
      WebUI: cr-dialog, padding adjustments · fc9eab35
      Esmael El-Moslimany authored 
      Bug: 849851
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I84564b4c1dce0729ccdcb00b346196c6b3111401
Reviewed-on: https://chromium-review.googlesource.com/1087810
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564712}
      fc9eab35
    • Tetsui Ohkubo's avatar
      Close UnifiedSystemTray bubble immediately on dtor · b11ce870
      Tetsui Ohkubo authored 
      When Chrome OS is shutdown while UnifiedSystemTray is opened, it
crashes, because UnifiedSystemTray bubble did not close immediately and
kept reference to UnifiedSystemTrayModel during close animation. It can
be problematic in some unit tests including TrayEventFilterTest.

TEST=TrayEventFilterTest
BUG=847104

Change-Id: Ia6175b8663acd19d8e5e0b2f31e38e1d3ba565c6
Reviewed-on: https://chromium-review.googlesource.com/1084367Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564711}
      b11ce870
    • Eric Robinson's avatar
      Safe browsing notification reports all results. · d88ee855
      Eric Robinson authored 
      Changed the safe browsing notifications to report all of the results,
not just the final one obtained.  This is done by passing the
check_results_ vector directly to the consumers.  The only non-test
consumer currently is the pop-up blocker, which now scans for any
matching condition and reports it rather than just looking at the
final result and determining if it was a match.

Bug: 823414
Change-Id: I9c820e6d1ca2b640339cc31a17c42d3fb8486f2b
Reviewed-on: https://chromium-review.googlesource.com/1081048
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Reviewed-by: default avatarCharlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564710}
      d88ee855
    • Yafei Duan's avatar
      [Offline Pages] Refactor DownloadUIAdapter and OfflinePageDownloadBridge · c53e06b3
      Yafei Duan authored 
      This CL removed OfflinePageDownloadBridge and related code, integrated
them into DownloadUIAdapter/OfflinePageDownloadBridge, in order to unify
the notification/UI pipeline.

This CL removed the cache and its loading state in DownloadUIAdapter,
replacing the APIs with asynchronous calls down to lower level instead
of querying preloaded cache.

With the CL, DownloadUIAdapter will be registered as observer to both
OfflinePageModel and RequestCoordinator when OCANBUi is created. And
sending notification of page/request added/deleted whenever it receives
the event. Since successful request completion turns into successful
page save, OfflinePageAdded and OnAdded (with successful status) will
be merged if necessary, then notify OfflineContentProvider.

Minor details:
- Removed OfflinePageNotificationBridge.
- Removed OfflinePageDownloadNotifier and DownloadNotifyingObserver.
- Integrated some of the functions into DownloadUIAdapter and
  OfflinePageDownloadBridge.
- Changed some UI treatment based on newly used OfflineItem attributes.
- Changed related tests.

Bug: 839175
Change-Id: Icbe763bf70b3f49d1db6717a3b7c4ba57c25fb71
Reviewed-on: https://chromium-review.googlesource.com/1068063Reviewed-by: default avatarShakti Sahu <shaktisahu@chromium.org>
Reviewed-by: default avatarDmitry Titov <dimich@chromium.org>
Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564709}
      c53e06b3
    • Lambros Lambrou's avatar
      Revert "Add browser tests for Chrome autofill on captured sites. (Bug 847905)" · 22387fe1
      Lambros Lambrou authored 
      This reverts commit c2ec5265.

Reason for revert: Broke compile on https://ci.chromium.org/buildbot/chromium/Win%20x64/23318

../../chrome/browser/autofill/autofill_captured_sites_interactive_uitest.cc(404,45): error: no viable conversion from 'const wchar_t [12]' to 'base::StringPiece' (aka 'BasicStringPiece<basic_string<char, char_traits<char>, allocator<char> > >') .AppendASCII(FILE_PATH_LITERAL("wpr_key.pem"))


Original change's description:
> Add browser tests for Chrome autofill on captured sites. (Bug 847905)
> 
> These tests are the first step in building a test framework for testing
> chrome autofill on complex, real-world sites pages. Since interacting
> with live sites are flaky and vulnerable to updates to the sites'
> features, this framework interacts with captured sites.
> 
> Sites are captured with the Web Page Replay (WPR) tool. Prior to
> running the test, the browser test will start WPR locally on the
> machine using a capture file. The test then navigates to the test
> site, interact with the site's checkout workflow, and verifies that
> autofill correctly completes the address and payment information.
> 
> Tests for 5 sites are included in this code change: Amazon, Zappos,
> Apple, Ebay and Walmart.
> 
> This change fixes the build breaks caused by the earlier change,
> 963800, and it also changes the tests from being driven by test code
> to being driven by test recipe files. The test recipe files will be
> generated by a chrome automation extension recording user actions.
> 
> Bug: 847905
> Change-Id: I0ef7b2b04be2a6caf3742c520f25ab1de80f9711
> Reviewed-on: https://chromium-review.googlesource.com/1086088
> Commit-Queue: Yiming Zhou <uwyiming@google.com>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564693}

TBR=anthonyvd@chromium.org,sebsg@chromium.org,mahmadi@chromium.org,uwyiming@google.com

Change-Id: I2e6625dd64bfa91e15c4c048d0cd3174be960fee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847905
Reviewed-on: https://chromium-review.googlesource.com/1088129Reviewed-by: default avatarLambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564708}
      22387fe1
  3. 05 Jun, 2018 31 commits