GitLab

If the top controls manager calculates an animation scroll delta of
zero, we schedule another animation attempt for the following frame.
This causes the compositor to run constantly -- for instance -- on pages
where scrolling JavaScript-driven instead of impl-driven.

The fix is to bail out if there is no active top controls animation.

TEST=LayerTreeHostImplWithTopControlsTest.NoIdleAnimation
BUG=309648

Review URL: https://codereview.chromium.org/167013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251770 0039d316-1c4b-4281-b951-d872f2087c98

BUG= 343024

Review URL: https://codereview.chromium.org/169673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251768 0039d316-1c4b-4281-b951-d872f2087c98

* Added shadows for bubbles.
* Make app window to set its size automatically.
* Prevented buttons blinking on hover/click/focus.

BUG=342397
TEST=manually

Review URL: https://codereview.chromium.org/169173007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251767 0039d316-1c4b-4281-b951-d872f2087c98

ProcessManager creates RenderViewHostDestructionObserver for all WebContents.
It's not necessary as ProcessManager keeps information about WebContents
only related to extensions (extension's background page, extension's popup).

BUG=344297

Review URL: https://codereview.chromium.org/169413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251765 0039d316-1c4b-4281-b951-d872f2087c98

It was meant to be named Settings.TrackedSplitPreferenceChangedCount, but a typo was introduced in the code to Settings.TrackedSplitPreferenceChanged; it's now easier to keep the typo'ed name, making histograms.xml use it as well.

NOTRY=True

Review URL: https://codereview.chromium.org/169403007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251764 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251762 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251760 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
This patch seems to be breaking Win7 tests.

http://goo.gl/c6Fv8F
http://goo.gl/vsb4MM
http://goo.gl/gGKujF
http://goo.gl/0YMBYg
http://goo.gl/JFCYgH

Original issue's description:
> Blink roll 167304:167323
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=167305:167323&mode=html
> TBR=
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251752

TBR=eseidel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/170343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251759 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251758 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mflodman@chromium.org


TEST=bots
NOTRY=true

Review URL: https://codereview.chromium.org/167313004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251757 0039d316-1c4b-4281-b951-d872f2087c98

BUG=156975

Review URL: https://codereview.chromium.org/156883006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251756 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341698
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/167313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251755 0039d316-1c4b-4281-b951-d872f2087c98

Only running ephemeral apps will appear in the notification settings
pane. This avoids spamming the list with inactive cached ephemeral apps.

The setting will also be persisted across cache evictions, so that
notifications will still be disabled when the ephemeral app is
re-cached at a later date.

BUG=343453
TEST=browser_tests (EphemeralAppBrowserTest.StickyNotificationSettings)

Review URL: https://codereview.chromium.org/163953012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251754 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251753 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=167305:167323&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/164373014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251752 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251751 0039d316-1c4b-4281-b951-d872f2087c98

Includes a GYP tweak for MemorySanitizer builds. No other changes are included, and non-MSan builds should not be affected.

BUG=313751
R=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/168903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251750 0039d316-1c4b-4281-b951-d872f2087c98

Hosted app windows currently use the current URL to determine the taskbar icon.
This CL makes hosted app windows always use the app icon which provides a
higher resolution icon than is currently provided and provides the window
with a better sense of identity since the icon doesn't change.

BUG=318607

Review URL: https://codereview.chromium.org/169443007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251749 0039d316-1c4b-4281-b951-d872f2087c98

The patch identifies network configurations and certificates with duplicate GUIDs and repairs the ONC such that the first occurrence is retained as a unique network configuration or certificate.

BUG=211421

Review URL: https://codereview.chromium.org/166903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251748 0039d316-1c4b-4281-b951-d872f2087c98

Factor out a shared Stop() method into superclass. The method is
public because AutocompleteController calls Stop() on
zero_suggest_provider. There is no change to functionality.

BUG=338955
TBR=mpearson

Review URL: https://codereview.chromium.org/158223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251746 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331468,344428,344429
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/170163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251745 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313751
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/170213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251744 0039d316-1c4b-4281-b951-d872f2087c98

This CL sets the minimize button state to unhovered on layout to fix an issue
where the hover would be sticky between window minimize and restore.

BUG=338319
TEST=Open the settings app from the app launcher. Minimize it and then restore it from the taskbar. The minimize button should not be hovered.

Review URL: https://codereview.chromium.org/169463008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251743 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343838
R=scottmg@chromium.org,brettw@chromium.org

Review URL: https://codereview.chromium.org/169463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251742 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251741 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TBR=atwilson@chromium.org, dewittj@chromium.org

Review URL: https://codereview.chromium.org/169523009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251740 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251739 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=167246:167304&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/170133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251738 0039d316-1c4b-4281-b951-d872f2087c98

DM_YRESOLUTION check was invalid.

TBR=noamsml

Review URL: https://codereview.chromium.org/170013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251737 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Re-enable prerender RemovingLink browser tests. (https://codereview.chromium.org/142013004/)

Reason for revert:
Failing on XP Tests 1, build 30187 and onwards.
Also failing on XP Tests 2 and 3.

[ RUN      ] PrerenderBrowserTest.PrerenderPageRemovingLinkWithTwoLinks
HTTP server started on 127.0.0.1:4080...
sending server_data: {"host": "127.0.0.1", "port": 4080} (35 bytes)
File not found prerender/prerender_page.html%E2%80%93)%C3%A4%C2%B3%C3%BBh%C3%BE)%C3%ACz%C2%BB full path:E:\b\build\slave\XP_Tests__1_\build\src\chrome/test/data\prerender\prerender_page.html%E2%80%93)%C3%A4%C2%B3%C3%BBh%C3%BE)%C3%ACz%C2%BB
127.0.0.1 - - [14/Feb/2014 22:17:53] code 404, message Not Found
[2656:2572:0214/221753:3777828:INFO:CONSOLE(1)] "Uncaught ReferenceError: DidPrerenderPass is not defined", source:  (1)

Original issue's description:
> Re-enable prerender RemovingLink browser tests.
> 
> The tests have changed significantly since they were first disabled. Add a
> WaitForStop or two for good measure, but leave them as-is for the most part.
> They can be disabled again if they still flake. Merge their custom prerender
> loader into the main one; it's mostly the same.
> 
> In addition, for better test coverage, add a new test which asserts on events
> received when a <link rel=prerender> is added for an existing prerender after
> that prerender has loaded. Significantly rework the prerender events logic
> to allow the test framework to wait on an event being received in the loader.
> 
> BUG=167340, 128841
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251495

TBR=mmenke@chromium.org,davidben@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=167340, 128841

Review URL: https://codereview.chromium.org/170173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251732 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Significantly cleans up the ImageWriter Operation class and subclasses. (https://codereview.chromium.org/149313003/)

Reason for revert:
Broke ASAN bots.

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%282%29/builds/23085/steps/unit_tests/logs/DownloadFile

Original issue's description:
> Significantly cleans up the ImageWriter Operation class and subclasses.
> 
> * Moved Operations to be in CPS for stage isolation.
> * Updates unit tests to use isolated stages.
> * Adds unit tests for uncovered stages.
> * Cleans up temporary file handling.
> * Removes unnecessary and redundant code (CompareFiles, ImageReader).
> * Fixes bug with verification progress updates.
> * All .zip files now unzipped before burning.
> * All non-.zip files not unzipped before burning.
> * Removes unnecessary complexity, e.g. unnecessary scoped_ptrs.
> 
> BUG=292956
> BUG=337883
> BUG=335404
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251704

TBR=tbarzic@chromium.org,haven@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=292956

Review URL: https://codereview.chromium.org/170123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251729 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251726 0039d316-1c4b-4281-b951-d872f2087c98

Upon patch upload 'git cl format' is run on the diff and outputs a
warning if the diff has style violations, saving manual review
time for coding style.

BUG=None
TEST=None
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/169003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251724 0039d316-1c4b-4281-b951-d872f2087c98

We now hold the surface inside MediaSourcePlayer.
So when a new MediaCodec is recreated, we reuse the same surface object.
As a result, we no longer need to recreate the stream texture for each MediaCodec.

BUG=339191

Review URL: https://codereview.chromium.org/149273005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251723 0039d316-1c4b-4281-b951-d872f2087c98

command line. Only the former is authoritative.

BUG=141168

Review URL: https://codereview.chromium.org/169833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251720 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251719 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ronghuawu@chromium.org

Review URL: https://codereview.chromium.org/169923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251718 0039d316-1c4b-4281-b951-d872f2087c98

enableV8SingleThreadMode() and flushConsoleMessages() do nothing in
their Blink implementation, so we don't need to call them as they won't
do anything at all.

BUG=None
TEST=content_shell, content_unittests
R=abarth@chromium.org, jochen@chromium.org

Review URL: https://codereview.chromium.org/169173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251716 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343115
R=dewittj@chromium.org, atwilson@chromium.org

Review URL: https://codereview.chromium.org/160923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251715 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Move TextInputController from CppBoundClass to gin::Wrappable. (https://codereview.chromium.org/144013010/)

Reason for revert:
Broke LayoutTests/editing/selection/move-left-right.html, which uses TextInputController.


Original issue's description:
> Move TextInputController from CppBoundClass to gin::Wrappable.
> 
> Also, change the class to use chromium coding style.
> 
> BUG=297480, 331301
> R=jochen@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251692

TBR=jochen@chromium.org,tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=297480, 331301

Review URL: https://codereview.chromium.org/169813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251714 0039d316-1c4b-4281-b951-d872f2087c98