GitLab

[InstantExtended] Changing the histogram name since the definition of the histogram changed when the values used for recording were updated in CL/19772015.


BUG=261681

Review URL: https://chromiumcodereview.appspot.com/19862004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213316 0039d316-1c4b-4281-b951-d872f2087c98

Seems to be related to buildbot failure:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/22366

> Moves calling OnAutoHideState to when exactly the state has changed (2nd)
> 
> This method is called when a window is maximized or fullscreen.
> 
> The first attempt was reverted due to a test failure in LauncherTooltipManagerTest,
> and it turns out that's because the observer method is not emitted
> correctly.
> 
> BUG=249509
> TBR=harrym@chromium.org, jamescook@chromium.org
> TEST=manually
> 
> Review URL: https://chromiumcodereview.appspot.com/20056003

TBR=mukai@chromium.org

Review URL: https://codereview.chromium.org/19974006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213315 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/19981004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213314 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds the D-Bus hook for calling Device.ProposeScan to
NetworkDeviceHandler as well as bindings for and a function to parse
the results of a cellular network scan which are exposed form shill
as a Device property.

BUG=260964

Review URL: https://chromiumcodereview.appspot.com/19509002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213313 0039d316-1c4b-4281-b951-d872f2087c98

The message center still has the arrow because it sets arrow-paint-type
to NONE but further TrayBubbleWrapper's constructor calls
UpdateBubbleViewArrow().

Instead of adding the check before calling UpdateBubbleViewArrow(),
I think it's better to ignore inside.

BUG=260372
R=harrym@chromium.org
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/19843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213312 0039d316-1c4b-4281-b951-d872f2087c98

This makes host_dispatcher.js and host_native_messaging.js consistent
with the rest of the webapp. Also fix function declaration style.

Review URL: https://chromiumcodereview.appspot.com/19597006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213311 0039d316-1c4b-4281-b951-d872f2087c98

Most suppressed tests have been rebaselined in https://src.chromium.org/viewvc/blink?revision=154755&view=revision.

TBR=robertphillips@chromium.org
BUG=258850

Review URL: https://chromiumcodereview.appspot.com/20063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213310 0039d316-1c4b-4281-b951-d872f2087c98

Fixes some of the memory leaks in those tests.

BUG=222687
R=thestig@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19945010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213309 0039d316-1c4b-4281-b951-d872f2087c98

EnterNotify and LeaveNotify events will be dispatched to event handlers.

BUG=263220

Review URL: https://chromiumcodereview.appspot.com/19664007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213308 0039d316-1c4b-4281-b951-d872f2087c98

Compile failed on buildbot:
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20Builder%20%28dbg%29&number=18573

> Add the tracing manager
> 
> BUG=248357
> 
> Review URL: https://chromiumcodereview.appspot.com/19762005

TBR=zork@chromium.org

Review URL: https://codereview.chromium.org/19471017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213307 0039d316-1c4b-4281-b951-d872f2087c98

The Google Test templates provide a default value printer function that naively dumps all bytes in the range [&object, &object + sizeof(object)).  However, due to the memory layout of the TestScenario class (on some platforms), there was a hole of uninitialized memory being read from; and this triggered Valgrind errors.

The solution here is to implement an ostream& operator<<(ostream&, const TestScenario&) function that will not read from uninitialized memory regions.

BUG=263315

Review URL: https://chromiumcodereview.appspot.com/19647013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213304 0039d316-1c4b-4281-b951-d872f2087c98

BUG=179830, 262796, 263548

Review URL: https://chromiumcodereview.appspot.com/19477008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213303 0039d316-1c4b-4281-b951-d872f2087c98

Inside OnDraw, RequestDrawGL can fail and return false, which means
there will not be a follow up DrawGL call to actually trigger the draw,
but the FallbackTick is cancelled anyway. Fix by moving the cancel
inside DrawSWInteral to reflect we only want to cancel when we actually
draw.

BUG=internal b/9978808
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/19509007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213302 0039d316-1c4b-4281-b951-d872f2087c98

BUG=248357

Review URL: https://chromiumcodereview.appspot.com/19762005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213299 0039d316-1c4b-4281-b951-d872f2087c98

This method is called when a window is maximized or fullscreen.

The first attempt was reverted due to a test failure in LauncherTooltipManagerTest,
and it turns out that's because the observer method is not emitted
correctly.

BUG=249509
TBR=harrym@chromium.org, jamescook@chromium.org
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/20056003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213298 0039d316-1c4b-4281-b951-d872f2087c98

When a CopyResult provides a TextureMailbox, the ReleaseCallback must
be called on the TextureMailbox when then client is done with the
CopyResult.

This change ensures that this happens. If the TextureMailbox is never
removed from the CopyResult, then the CopyResult destructor takes care
of it. Since the texture was never used, it uses a sync point of 0.

When the TextureMailbox is removed from the CopyResult, then RWHVAura
makes sure it calls the ReleaseCallback once it has the pixels it needs
in memory. Since the pixels are already available on the CPU, it can
use a sync point of 0 as well.

R=piman
BUG=263483

Review URL: https://chromiumcodereview.appspot.com/19990007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213297 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242290
R=mark@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19960008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213294 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/19925002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213293 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175796
TBR=jamescook

Review URL: https://chromiumcodereview.appspot.com/19744003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213292 0039d316-1c4b-4281-b951-d872f2087c98

Quick fix for now, but I may need to reconsider how run_measurement resolved name conflicts.


BUG=263511
TEST=None.
R=tonyg@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19915008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213290 0039d316-1c4b-4281-b951-d872f2087c98

Exposes POTENTIALLY_UNWANTED ClientDownloadResponse verdict from the
SafeBrowsing service to ChromeDownloadManagerDelegate. Downloads for
which this verdict is seen will be marked with the danger type
DOWNLOAD_DANGER_TYPE_POTENTIALLY_UNWANTED.

A dangerous download prompt will be displayed on the download shelf
indicating that the download may make changes to the browser or
system.

Changes are for Windows only since the POTENTIALLY_UNWANTED signal is
only implemented for Windows.

BUG=262983

Review URL: https://chromiumcodereview.appspot.com/19863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213289 0039d316-1c4b-4281-b951-d872f2087c98

Firstly, this uses more correct fields for displaying synced notifications.
The Annotation field is better than the description or text fields in most
cases.

Secondly, this fixes some image fetch problems.  I was using images from the
expanded_notification section instead of the collapsed_notification section,
and the schemaless URLs were being interpreted by the chrome code as UNC paths!
I added a function to add a default schema of https: if none was provided to
prevent the GURL code from thinking "//" meant a UNC path on windows.

Thirdly, I noticed some changes to the server side protobuf that we were not in
sync with, so I copied the new fields into the protobuf that we use.  (This
includes the annotation field).

BUG=262303,247668

Review URL: https://chromiumcodereview.appspot.com/19771013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213288 0039d316-1c4b-4281-b951-d872f2087c98

This is the 1st patch to add progress bar notification support. It contains:
1) A new progress type is added and a new optional progress value is added.
2) NotificationView creates and adds a NotificationProgressbar child view.

BUG=170924
TEST=manual test by creating a progress bar notification

Review URL: https://chromiumcodereview.appspot.com/18662006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213287 0039d316-1c4b-4281-b951-d872f2087c98

Fixes memory leak in PrintPreviewDialogControllerUnitTest.* (unit_tests).

R=thestig@chromium.org
BUG=176888

Review URL: https://chromiumcodereview.appspot.com/19714003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213286 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for switching from mongoose to net::HttpServer.
BUG=none

Review URL: https://chromiumcodereview.appspot.com/19616008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213285 0039d316-1c4b-4281-b951-d872f2087c98

BUG=247435

Review URL: https://chromiumcodereview.appspot.com/19482020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213284 0039d316-1c4b-4281-b951-d872f2087c98

The SkColorFilter* we get in GLRenderer is a refcounted
object with a reference on it. Since we just store it in
a raw pointer, we leak that reference. Instead, store
it in a RefPtr.

R=senorblanco
BUG=259815

Review URL: https://chromiumcodereview.appspot.com/19267024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213283 0039d316-1c4b-4281-b951-d872f2087c98

during unit tests.

Submitting separately first so that try/cq servers can be used for the
main CL ()

BUG=chromium:236093
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/19551005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213280 0039d316-1c4b-4281-b951-d872f2087c98

This measurement reports the hottest functions during page load. I plan to run
it over the top million sites.

It works by loading each page twice, the profile is captured for the second load
only. This is because cross-origin navigations cause the renderer to be swapped
out during profiling and to get more stable results.

This required a couple of core modifications:
1. csv_page_measurement_results should work when the page runner creates a
   dummy results object because discard_first_results is enabled.
2. discard_first_results should discard the first result of each page in
   the page set. Not just the first page.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/19857003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213279 0039d316-1c4b-4281-b951-d872f2087c98

In certain cases, generates a suggestion object from the iframe params.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/19803006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213278 0039d316-1c4b-4281-b951-d872f2087c98

This implements the confirm request side of privet registration that sends an
authenticated request to the cloud print server to claim the device.

BUG=245375

Review URL: https://chromiumcodereview.appspot.com/19788004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213277 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/19626003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213276 0039d316-1c4b-4281-b951-d872f2087c98

BUG=249435

Review URL: https://chromiumcodereview.appspot.com/19482009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213275 0039d316-1c4b-4281-b951-d872f2087c98

This makes the method consistent with the other methods of
HostNativeMessaging, and allows future flexibility to define
error codes, instead of just passing a boolean to onDone().

BUG=249970
TEST=Verify host setup flow, with and without native messaging.

Review URL: https://chromiumcodereview.appspot.com/17465007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213274 0039d316-1c4b-4281-b951-d872f2087c98

Restores state that matches ContextState::RestoreGlobalState
with some exceptions.

Also remove some unneeded states from MODE_DRAW.

BUG=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/19787007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213273 0039d316-1c4b-4281-b951-d872f2087c98

Until this CL, TestingProfile had 3 distinct URLRequestContexts it would return to the user: one via profile->GetDefaultStoragePartition()->GetRequestContext(), one via profile->GetRequestContext(), and one via profile->GetResourceContext->GetRequestContext().  All of these had different cookie stores.  This CL unified them so they all return the one from profile->GetDefaultStoragePartition()->GetRequestContext(). This correctly mimics how production code works.

Doing this had a bunch of implications:
 (1) Removes TestingProfile::CreateRequestContext()/ResetRequestContext()
 (2) Changes MockRequestContext to share the URLRequestContext with TestingProfile.
 (3) TestingProfile now requires all BrowserThreads.

Point (3) effectively adds TestBrowserThreadBundle into a bunch more spots. Because of that, we also have the following changes:
  (a) AshTestBase now has a TestBrowserThreadBundle
  (b) Removed a bunch of real threads from tests.
  (c) TemplateUrlService has reworked synchronization semantics.
  (d) Removed MultiThreadTestHelper.
  (e) Added TestingIOThread class + testing API in IOThread to mock out various IO thread tasks which enervated with the new TestBrowserThreadBundle.

TBR=bauerb,brettw,isherman,joth,jyasskin,mattm,mmenke,mnissler,pkasting,rkc,rlp,satorux,tim,xians,joth
BUG=159193

Review URL: https://chromiumcodereview.appspot.com/17127002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213272 0039d316-1c4b-4281-b951-d872f2087c98

Demonstrate a canonical way to detect if the browser
has support for NaCl/PNaCl in the SDK examples.

Do the check before creating the embed tag, when the page
loads. If the browser does not have support, do not create
the embed and just update the status message.

If NaCl is disabled in about:plugins, then this will show
an error.  If NaCl is not enabled in about:flags, then
this will not show an error and continue loading.  The
embed tag will then either (a) be created for CWS apps
or (b) show a puzzle piece for the open web.

For PNaCl, the page will show an error and not attempt
to create an embed tag if either NaCl is disabled
in about:plugins, or PNaCl is disabled in about:flags.

BUG=243040
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/19751003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213271 0039d316-1c4b-4281-b951-d872f2087c98

These DCHECKs fire if we ever commit to the impl side twice without
performing a draw in between. There are various ways that this
could happen, and it doesn't really matter to the CopyOutputRequest
code anyways, so remove the DCHECKs and deal with the case gracefully
instead.

Test: LayerTreeHostTestAsyncTwoReadbacksWithoutDraw

BUG=263486
R=enne,piman

Review URL: https://chromiumcodereview.appspot.com/19668008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213270 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/19647011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213269 0039d316-1c4b-4281-b951-d872f2087c98

This enables a seccomp-bpf sandbox for NaCl on x86_64 and i386.

This policy is a little bit less tight than Chromium's renderers policy and
should be tightened in the future.

BUG=168812
R=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/19980003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213268 0039d316-1c4b-4281-b951-d872f2087c98