- 03 Feb, 2017 40 commits
-
-
vadimsh authored
The old name is going away. R=tandrii@chromium.org NOTRY=True BUG= Review-Url: https://codereview.chromium.org/2671593004 Cr-Commit-Position: refs/heads/master@{#447993}
-
jkrcal authored
This CL removes one obsolete variation param and associate another one by the feature name. BUG=686778 Review-Url: https://codereview.chromium.org/2665743002 Cr-Commit-Position: refs/heads/master@{#447992}
-
estevenson authored
This CL adds detailed metrics for the main native library section sizes, grouped into "text", "data", "relocations", "unwind", "symbols", and "other" sections. These categories are added under a new subtest: "_MainLibInfo". BUG=681153 Review-Url: https://codereview.chromium.org/2675703003 Cr-Commit-Position: refs/heads/master@{#447991}
-
kylechar authored
Add mojoms and StructTraits so that a complete DisplayLayout can be serialized. This includes DisplayPlacement and some enums. DisplayLayout is serialized via unique_ptr since it is normally stored as a unique_ptr. This is required to pass the DisplayLayout from mus-ws to chrome for the display options page. BUG=686848 Review-Url: https://codereview.chromium.org/2661663002 Cr-Commit-Position: refs/heads/master@{#447990}
-
mahmadi authored
Revert of Check HRESULT using macros in DXVAVideoDecodeAccelerator (patchset #1 id:1 of https://codereview.chromium.org/2669083002/ ) Reason for revert: Causing failures in http/tests/media/media-source/mediasource-duration.html https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/8902 22:44:47.228 2772 worker/0 http/tests/media/media-source/mediasource-duration.html output stderr lines: 22:44:47.228 2772 [4800:5628:0202/224446.112:3700733:ERROR:audio_manager_win.cc(414)] GetPreferredAudioParameters failed: 88890004 22:44:47.228 2772 [5600:2452:0202/224446.116:3700749:INFO:gpu_video_decode_accelerator_factory.cc(181)] Initializing DXVA HW decoder for windows. 22:44:47.228 2772 [5600:2452:0202/224446.116:3700749:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 593 22:44:47.228 2772 [5600:2452:0202/224446.117:3700749:ERROR:gpu_video_decode_accelerator.cc(375)] HW video decode not available for profile vp8 22:44:47.228 2772 [4800:5628:0202/224446.123:3700749:ERROR:audio_manager_win.cc(414)] GetPreferredAudioParameters failed: 88890004 22:44:47.228 2772 [4800:5628:0202/224446.123:3700749:ERROR:audio_manager_base.cc(257)] Invalid audio output parameters received; using fake audio path. Channels: 0, Sample Rate: 0, Bits Per Sample: 0, Frames Per Buffer: 0 22:44:47.228 2772 [2916:5884:0202/224446.171:3700796:ERROR:gpu_video_decode_accelerator_host.cc(99)] Send(GpuCommandBufferMsg_CreateVideoDecoder()) failed 22:44:47.228 2772 [5600:4620:0202/224446.172:3700796:ERROR:gpu_channel.cc(564)] Could not find message queue 22:44:47.228 2772 [4800:5628:0202/224446.207:3700827:WARNING:audio_sync_reader.cc(188)] AudioSyncReader::Read timed out, audio glitch count=1 22:44:47.228 2772 [5600:2452:0202/224446.222:3700842:INFO:gpu_video_decode_accelerator_factory.cc(181)] Initializing DXVA HW decoder for windows. 22:44:47.228 2772 [5600:2452:0202/224446.223:3700842:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 593 22:44:47.228 2772 [5600:2452:0202/224446.223:3700842:ERROR:gpu_video_decode_accelerator.cc(375)] HW video decode not available for profile vp8 22:44:47.228 2772 [2916:5884:0202/224446.224:3700842:ERROR:gpu_video_decode_accelerator_host.cc(99)] Send(GpuCommandBufferMsg_CreateVideoDecoder()) failed 22:44:47.228 2772 [5600:4620:0202/224446.225:3700842:ERROR:gpu_channel.cc(564)] Could not find message queue 22:44:47.228 2772 [4800:5628:0202/224446.263:3700889:WARNING:audio_sync_reader.cc(188)] AudioSyncReader::Read timed out, audio glitch count=2 22:44:47.228 2772 [2916:5884:0202/224446.383:3701014:ERROR:render_media_log.cc(30)] MediaEvent: MEDIA_ERROR_LOG_ENTRY {"error":"Failed to reconcile encoded audio times with decoded output."} 22:44:47.228 2772 [5600:2452:0202/224446.405:3701030:INFO:gpu_video_decode_accelerator_factory.cc(181)] Initializing DXVA HW decoder for windows. 22:44:47.228 2772 [5600:2452:0202/224446.406:3701030:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 593 22:44:47.228 2772 [5600:2452:0202/224446.407:3701030:ERROR:gpu_video_decode_accelerator.cc(375)] HW video decode not available for profile vp8 22:44:47.228 2772 [2916:5884:0202/224446.410:3701030:ERROR:gpu_video_decode_accelerator_host.cc(99)] Send(GpuCommandBufferMsg_CreateVideoDecoder()) failed 22:44:47.228 2772 [5600:4620:0202/224446.411:3701030:ERROR:gpu_channel.cc(564)] Could not find message queue 22:44:47.229 2772 [5600:2452:0202/224446.412:3701030:INFO:gpu_video_decode_accelerator_factory.cc(181)] Initializing DXVA HW decoder for windows. 22:44:47.229 2772 [5600:2452:0202/224446.412:3701030:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 593 22:44:47.229 2772 [5600:2452:0202/224446.413:3701045:ERROR:gpu_video_decode_accelerator.cc(375)] HW video decode not available for profile vp8 22:44:47.229 2772 [2916:5884:0202/224446.414:3701045:ERROR:gpu_video_decode_accelerator_host.cc(99)] Send(GpuCommandBufferMsg_CreateVideoDecoder()) failed 22:44:47.229 2772 [5600:4620:0202/224446.415:3701045:ERROR:gpu_channel.cc(564)] Could not find message queue 22:44:47.229 2772 [5600:2452:0202/224446.416:3701045:INFO:gpu_video_decode_accelerator_factory.cc(181)] Initializing DXVA HW decoder for windows. 22:44:47.229 2772 [5600:2452:0202/224446.417:3701045:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 593 22:44:47.229 2772 [5600:2452:0202/224446.417:3701045:ERROR:gpu_video_decode_accelerator.cc(375)] HW video decode not available for profile vp8 22:44:47.229 2772 [2916:5884:0202/224446.419:3701045:ERROR:gpu_video_decode_accelerator_host.cc(99)] Send(GpuCommandBufferMsg_CreateVideoDecoder()) failed 22:44:47.229 2772 [5600:4620:0202/224446.419:3701045:ERROR:gpu_channel.cc(564)] Could not find message queue 22:44:47.229 2772 [2916:5884:0202/224446.431:3701061:ERROR:render_media_log.cc(30)] MediaEvent: MEDIA_ERROR_LOG_ENTRY {"error":"Failed to reconcile encoded audio times with decoded output."} 22:44:47.229 2772 [2916:5884:0202/224446.574:3701201:ERROR:render_media_log.cc(30)] MediaEvent: MEDIA_ERROR_LOG_ENTRY {"error":"Failed to reconcile encoded audio times with decoded output."} 22:44:47.229 2772 [2916:5884:0202/224446.575:3701201:ERROR:render_media_log.cc(30)] MediaEvent: MEDIA_ERROR_LOG_ENTRY {"error":"Failed to reconcile encoded audio times with decoded output."} 22:44:47.229 2772 [2916:5884:0202/224446.598:3701217:ERROR:render_media_log.cc(30)] MediaEvent: MEDIA_ERROR_LOG_ENTRY {"error":"Failed to reconcile encoded audio times with decoded output."} Original issue's description: > Check HRESULT using macros in DXVAVideoDecodeAccelerator > > /analyze on Windows complains about using HRESULT in a Boolean context, > so check returned values using the appropriate macro. > > BUG=687394 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2669083002 > Cr-Commit-Position: refs/heads/master@{#447925} > Committed: https://chromium.googlesource.com/chromium/src/+/5429b39dda87c47ace86635ab4cf998255ced5fb TBR=dalecurtis@chromium.org,jrummell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=687394 Review-Url: https://codereview.chromium.org/2673023002 Cr-Commit-Position: refs/heads/master@{#447989}
-
mikhail.pozdnyakov authored
As described in Generic Sensor specification (https://w3c.github.io/sensors/#dom-sensorstate-unconnected). BUG=606766 Review-Url: https://codereview.chromium.org/2675483003 Cr-Commit-Position: refs/heads/master@{#447988}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6ea247d1..7c13382c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2670993002 Cr-Commit-Position: refs/heads/master@{#447987}
-
olivierrobin authored
DomDistillerService is a service destined to display a distilled version to the user. It's settings are optimized to distill pages that are already fully loaded and to display the page to the user as fast as possible (through a cache feature).. ReadingList has a different objective. Download the page in background and store the result for a later use. ReadingList does not want cache, sync or storage of distilled articles. This led to have special cases in the usage of DomDistillerService in ReadingList code. But the fundamental issue is that ReadingListDownloadService should not use DomDistillerService and directly use the distiller. This will avoid side effects if some settings changes for ReaderMode. Remove dependency to the DomDistillerService and use directly the distiller. BUG=686640 Review-Url: https://codereview.chromium.org/2666643002 Cr-Commit-Position: refs/heads/master@{#447986}
-
stkhapugin authored
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2664233004 Cr-Commit-Position: refs/heads/master@{#447985}
-
aazzam authored
A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch modifies make_css_property_apis.py and CSSPropertyDescriptor.cpp.tmpl so that when the descriptors for a property are initialised, properties that are not implemented are set to nullptr. This removes the need for temporaryCanReadValue in the descriptor struct. The template is also changed so that it does not need to be modified when new methods are added to the API. BUG=668012 Review-Url: https://codereview.chromium.org/2670433002 Cr-Commit-Position: refs/heads/master@{#447984}
-
msramek authored
BrowsingDataFilterBuilder[Impl] is to be used by both content/ and chrome/ parts of the browsing_data/ codebase. Therefore, we move it to content/browsing_data with a public interface in content/public/. Note that this CL is the *first* part of browsing_data/ codebase that is moving to content/; BrowsingDataFilterBuilder has no users in content/ yet. BrowsingDataRemover[Impl] will move soon after. The intention of this CL is to make the upcoming change smaller. BUG=668114 Review-Url: https://codereview.chromium.org/2657453006 Cr-Commit-Position: refs/heads/master@{#447983}
-
eranm authored
On network change, discard all the CT log entries that are pending auditing in the SingleTreeTracker. Doing so will ensure inclusion proofs for these log entries are not looked up on a different network than the one in which the original certificates were obtained, thus preventing state leak between networks. BUG=506227 Review-Url: https://codereview.chromium.org/2668803004 Cr-Commit-Position: refs/heads/master@{#447982}
-
blundell authored
As a precursor to a refactoring of the identity extension API implementation to use the Identity Service, I am moving the implementations of the six identity extension API functions to their own files, rather than all being lumped together in identity_api.*. This will make it easier to analyze each of these function implementations independently and incrementally convert them to use the Identity Service. BUG=685654 Review-Url: https://codereview.chromium.org/2668203004 Cr-Commit-Position: refs/heads/master@{#447981}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5dd3abff..6ea247d1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2670973002 Cr-Commit-Position: refs/heads/master@{#447980}
-
rego authored
This patch fixes a crash in HTMLElement::attributeChanged(), we were missing a nullptr check as document().frame() can be null in some situations. BUG=687984 TEST=editing/spelling/crash-modifying-contenteditable.html Review-Url: https://codereview.chromium.org/2667393005 Cr-Commit-Position: refs/heads/master@{#447979}
-
guidou authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/baf0285..a4c36d8 $ git log baf0285..a4c36d8 --date=short --no-merges --format=%ad %ae %s 2017-02-03 ilnik@webrtc.org Added VP8 simulcast tests. Fixed analyzer to correctly infer timestamps. 2017-02-02 skvlad@webrtc.org Fix Chromium FYI bot 2017-02-02 skvlad@webrtc.org Pick the DTLS handshake timeout based on the ICE RTT estimate 2017-02-02 deadbeef@webrtc.org Get rid of unqualified std:: types. 2017-02-02 hnsl@webrtc.org Implement new PeerConnection certificate policy API in ObjC API 2017-02-02 skvlad@webrtc.org Objective-C API to set the ICE check rate through RTCConfiguration. 2017-02-02 ehmaldonado@webrtc.org Don't capture variables explicitly in lambda expression. 2017-02-02 skvlad@webrtc.org Allow applications to limit the ICE check rate through RTCConfiguration 2017-02-02 philipel@webrtc.org Reland of Make the new jitter buffer the default jitter buffer. (patchset #2 id:260001 of https://codereview.chromium.org/2656983002/ ) 2017-02-02 philipel@webrtc.org video_coding::PacketBuffer now group all H264 packets with the same timestamp into the same frame. 2017-02-02 ehmaldonado@webrtc.org Remove all occurrences of "using std::string". 2017-02-02 stefan@webrtc.org Add event log visualization of rtp timestamps over time. 2017-02-02 michaelt@webrtc.org Add 120ms frame ability to ANA 2017-02-02 solenberg@webrtc.org Remove bad DCHECK added as part of https://codereview.webrtc.org/2452163004/ 2017-02-02 stefan@webrtc.org Fix perf issue when timinig out receiver infos in RTCP. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2676553004 Cr-Commit-Position: refs/heads/master@{#447978}
-
jif authored
This CLs implements UIActivityItemSource's |activityViewController:thumbnailImageForActivityType:suggestedSize:|. Also: -factor out of the BVC the creation of ShareToData. -remove unused UIActivityURLSource. -fix ui/base/test/ios/OWNERS (broken by https://codereview.chromium.org/1885043012 ) TEST=Share a page from Chrome iOS to the Chrome iOS extension. A thumbnail of the page should be shown. BUG=686049 Review-Url: https://codereview.chromium.org/2645653003 Cr-Commit-Position: refs/heads/master@{#447977}
-
kraynov authored
BUG=670826 Review-Url: https://codereview.chromium.org/2667353004 Cr-Commit-Position: refs/heads/master@{#447976}
-
ccameron authored
Merge all of resource_multiplier, resource_offset, yuv_matrix, and yuv_adj into a single variable, yuv_and_resource_matrix. Use this regardless of using a LUT for color conversion. Move LUT based color conversion out of YUV to RGB code. In this instance, use yuv_and_resource_matrix only for resource scaling and offset. Don't actually delete the old YUV code yet (that's coming next). BUG=682416 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2674763003 Cr-Commit-Position: refs/heads/master@{#447975}
-
je_julie.kim authored
This patch doesn't assign header and footer roles for descendants of main or other sectioning content or sectioning root element. BUG=591328 Review-Url: https://codereview.chromium.org/2649953004 Cr-Commit-Position: refs/heads/master@{#447974}
-
maxmorin authored
Clean up confusing usage of "low latency". Remove a factory function since there were two similar ones. Before this CL, "low latency" could either refer to requesting a low latency stream type from the AudioManager or that the stream was requested over IPC, which was confusing. Now, it always refers to the kind of stream requested. This also means that the streams for which Media.AudioInputControllerSessionSilenceReport is reported changes. The Media.AudioInputControllerCaptureStartupSuccess stat is split into three separate stats: Media.{{High,Low}Latency,Virtual}AudioCaptureStartupSuccess, where Virtual refers to stream types obtained by redirecting output streams rather than going through the platform audio system (such as tab capture). BUG=600536 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2665163002 Cr-Commit-Position: refs/heads/master@{#447973} -
gsennton authored
By using the JobScheduler to upload minidumps we are restricting ourselves to not start a job uploading minidumps on costly connections (we allow only unmetered connections). In this CL we explicitly ensure that we are using an unmetered connection just before performing uploads as well to ensure we aren't hitting a race where we just switched connection and the JobScheduler hasn't yet shut our job down. NOTE: This commit adds the permission android.permission.ACCESS_NETWORK_STATE to WebView. BUG=678924 BUG=673280 Review-Url: https://codereview.chromium.org/2666603002 Cr-Commit-Position: refs/heads/master@{#447972}
-
vitaliii authored
Rephrase the comment from "backup OWNERS" to "ordinary OWNERS for inside-team CLs". BUG=None Review-Url: https://codereview.chromium.org/2670833003 Cr-Commit-Position: refs/heads/master@{#447971}
-
blundell authored
In preparation for IdentityGetAuthTokenFunction being moved to its own file, we must break the cyclic interface dependency between IdentityAPI and IdentityGetAuthTokenFunction (identity_api.h will need to include identity_get_auth_token_function.h for the extension registration mechanism to see the latter). This CL removes IdentityAPI::ShutdownObserver and replaces it with IdentityAPI directly calling IdentityGetAuthTokenFunction::Shutdown(). BUG=685654 Review-Url: https://codereview.chromium.org/2673443002 Cr-Commit-Position: refs/heads/master@{#447970}
-
ccameron authored
gfx::ColorSpace is used as input (speciying monitor color space) and output (compositor texture mailbox) format for color spaces. Avoid conversions by using this directly instead of SkColorSpace. The SkColorSpace to pass to Skia APIs is accessible via the method gfx::ColorSpace::ToSkColorSpace. Delete gfx::ColorSpace::FromSkColorSpace and gfx::ICCProfile::FromSkColorSpace, since they could not be implemented reliably. For CanvasRenderingContext and Canvas2DLayerBridge, create a distinction between the gfx::ColorSpace that the canvas is to be interpreted in by the compositor, and the SkColorSpace that is to be used by SkSurfaces during rendering (for canvases that are not using Skia's color conversion, but still need to specify their color space to the compositor). BUG=634102 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2660393002 Cr-Commit-Position: refs/heads/master@{#447969}
-
vitaliii authored
Add a new metric to track category index after it has been moved up due to a click. This is done in order to check how stable to order is and whether it is becoming more stable. BUG=687505 Review-Url: https://codereview.chromium.org/2668063004 Cr-Commit-Position: refs/heads/master@{#447968}
-
tkent authored
All test in this directory are disabled, and the implementation and the specification were removed some years ago. This CL has no behavior changes. BUG=685886 TBR=kochi@chromium.org Review-Url: https://codereview.chromium.org/2676783002 Cr-Commit-Position: refs/heads/master@{#447967}
-
csharrison authored
See the loading-dev@ thread for more context: https://groups.google.com/a/chromium.org/forum/#!topic/loading-dev/_cXkjQ0-L_E BUG=623165 Review-Url: https://codereview.chromium.org/2666993006 Cr-Commit-Position: refs/heads/master@{#447966}
-
tkent authored
This CL has no behaivor changes. BUG=685886 TBR=kochi@chromium.org Review-Url: https://codereview.chromium.org/2674833002 Cr-Commit-Position: refs/heads/master@{#447965}
-
grt authored
From comments in https://codereview.chromium.org/2663003003/. BUG=none R=huangs@chromium.org Review-Url: https://codereview.chromium.org/2670133002 Cr-Commit-Position: refs/heads/master@{#447964}
-
hlundin authored
Changing the preferred experiment group from "30" to "70" based on recent experiment results. This is now the most likely candidate for launch. BUG=672476 Review-Url: https://codereview.chromium.org/2676563002 Cr-Commit-Position: refs/heads/master@{#447963}
-
szager authored
When a frame is throttled, its compositing state cannot be queried, so don't try to set main thread scrolling reasons. This fixes DCHECK failures when root layer scrolling is enabled. BUG=490942 TEST=FrameThrottlingTest with RLS enabled R=skobes@chromium.org Review-Url: https://codereview.chromium.org/2662153004 Cr-Commit-Position: refs/heads/master@{#447962}
-
ke.he authored
BUG=554289 Review-Url: https://codereview.chromium.org/2658013002 Cr-Commit-Position: refs/heads/master@{#447961}
-
estark authored
This records a histogram, at most once per main-frame navigation, when "Login not secure" is shown in a password form. This will allow us to measure the frequency of the warning (e.g. the number of times the warning is shown per million navigations.) BUG=687823 Review-Url: https://codereview.chromium.org/2670733002 Cr-Commit-Position: refs/heads/master@{#447960}
-
tkent authored
This CL moves test for the following elements: BODY, ARTICLE, SECTION, NAV, ASIDE, H1, H2, H3, H4, H5, H6, HGROUP, HEADER, and FOOTER. This CL has no behaivor changes. BUG=685886 TBR=kochi@chromium.org Review-Url: https://codereview.chromium.org/2669403002 Cr-Commit-Position: refs/heads/master@{#447959}
-
yukishiino authored
Makes the test result of xss-DENIED-window-name-navigator.html deterministic and fixes the flakiness. BUG=686470 Review-Url: https://codereview.chromium.org/2673583003 Cr-Commit-Position: refs/heads/master@{#447958}
-
ichikawa authored
With this change, I merged protocol CRIWVWebView and class CRIWVWebViewImpl into a class CRIWVWebView. But the class still has two headers (public/criwv_web_view.h and internal/criwv_web_view_internal.h) to define public and internal methods. BUG=687827 Review-Url: https://codereview.chromium.org/2675633002 Cr-Commit-Position: refs/heads/master@{#447957}
-
jam authored
BUG=682002 Review-Url: https://codereview.chromium.org/2667753005 Cr-Commit-Position: refs/heads/master@{#447956}
-
patricialor authored
Avoid clashes with YES/NO keywords in Objective-C. BUG=687822 Review-Url: https://codereview.chromium.org/2671643002 Cr-Commit-Position: refs/heads/master@{#447955}
-
yoshiki authored
Previously, BS and return key events were consumed by the message center and the custom contents couldn't receive them. This patch adds a check if the current input mode is none or not. If the type is not none (it means the focus is on edit box), we don't handle BS/Return key events and pass them to the custom notification content. BUG=679664 TEST=manually (BS and Return keys work on custom notification) Review-Url: https://codereview.chromium.org/2670213002 Cr-Commit-Position: refs/heads/master@{#447954}
-