- 20 Feb, 2018 40 commits
-
-
Changwan Ryu authored
Support library update regressed start up time by 10 ms (crbug.com/782956). Webview uses support library through an indirect dependency chain, such as DropdownAdapter, AutofillKeyboardAccessory, and GMS core library. This can be explained by what we do in ResourceRewriter. ResourceRewriter checks for dependency graphs and call onResourcesLoaded() for all the reachable R's. This is a necessary step to avoid conflicts between library apks and main apk, and webview is doing this on its own. However, resource rewriting takes quite some time, as it creates dependency graphs all the way into support library and GMS core library. Local experiment shows that setting up resources on a separate thread can reduce start up time by 15-50 ms. AwBrowserProcess requires AwResource#getConfigKeySystemUuidMapping() so there is a chance that it can crash if startUpResources() is not finished. When tested, calling startUpResources immediately before AwBrowserProcess seems to work. Bug: b/69005401, 782956 Change-Id: Ie05ffd68063013a251bb5af3618bb78b2576dcbe Reviewed-on: https://chromium-review.googlesource.com/923174Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#537878}
-
Malay Keshav authored
The tab recording alert indicator icon no longer has a default color assigned to it in the icon file. Even when touch optimized mode is disabled, the correct color needs to be retrieved from the theme provider. Bug: 813763 Change-Id: I6cf37194aa1498520d973ee4300499ed402b10dc Component: Tab alert icon, recording icon, color Reviewed-on: https://chromium-review.googlesource.com/927110Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#537877}
-
Malay Keshav authored
The paint recording scale factor is set to 1 when pixel canvas is disabled. We cannot use the value of PaintContext::device_scale_factor for the recording scale factor in such cases. Bug: 813463 Change-Id: If51bfde2e271ce863cf3971016ee6347cbce592a Component: Tabs, Clipping, Scaling Reviewed-on: https://chromium-review.googlesource.com/927182Reviewed-by:
-
Parastoo Geranmayeh authored
Problem: Sometimes, one section of a form appears in multiple groups over time. This causes field by field situation from second group onward, because we group them all as one section, and would consider the fields which appear later as already filled. This is also an inconsistency, because the browser side fills them, but the renderer side doesn't. Examples: oup.com tradepub.com Solution: Don't fill hidden fields on the browser side. This way, they can get filled in later steps for real. This is also more consistent with a real user's action. As a result of this change, we can no more say if a section is autofilled as a unit. Some fields may be autofilled and some may not. We should consider the fields separately. So, we should take care of: 1.filling/previewing the form. 2.deciding if a credit card number will be filled. Tests added and modified. Note: Previously we would fill the hidden fields (on browser side), because we were not looking at the most updated version of the form, and couldn't trust the given visibility status of a field. This is not the case anymore. This change is based on the new version. Bug: 807780 Change-Id: I297ef33ce5952bab8ff5fce90bf4fc4d6a09731e Reviewed-on: https://chromium-review.googlesource.com/919525 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537875}
-
danakj authored
This format isn't part of the TransferableResource::MakeFoo() helpers but is important nonetheless for memory accounting, and would be important for software resources. For GL the format is known in the service so it ends up not being used for correctness. R=ericrk@chromium.org Bug: 811432, 730660 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ibaacf987cbbdb1cc17ad624325c843aca7ba7230 Reviewed-on: https://chromium-review.googlesource.com/927021 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#537874}
-
Jiawei Li authored
Bug: internal b/71879643 Test: Build cast_shell Change-Id: I47b8ab347a9f307e8c504dc609ab1eebd4a6cc52 Reviewed-on: https://chromium-review.googlesource.com/924279Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Jiawei Li <lijiawei@chromium.org> Cr-Commit-Position: refs/heads/master@{#537873}
-
https://webrtc.googlesource.com/src.git/+log/6bd3cddcef0c..1896cece014c $ git log 6bd3cddce..1896cece0 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2075853bc35ea0ec34f7fdaf15df98ae0f64d94d Reviewed-on: https://chromium-review.googlesource.com/927042Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537872}
-
Justin DeWitt authored
Bug: NONE Change-Id: Ie55f6bdde715bba84dfaba5eb51acbd559e28ed9 Reviewed-on: https://chromium-review.googlesource.com/926712Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#537871}
-
Daniel Blakemore authored
Bug: 808113 Original change's description: >Enables Mailto Handling with Google UI by default. > >Bug: 808113 >Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs >Change-Id: I2b475e6fd474c900ed1984010d15a3e1e31c2af0 >Reviewed-on: https://chromium-review.googlesource.com/922930 >Commit-Queue: Daniel Blakemore <danblakemore@google.com> >Reviewed-by: Peter Lee <pkl@chromium.org> >Cr-Commit-Position: refs/heads/master@{#537373} Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3c9821bd95d1ac74fcc4dc4b7c4474ce0b40c5da Reviewed-on: https://chromium-review.googlesource.com/924635Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Daniel Blakemore <danblakemore@google.com> Cr-Commit-Position: refs/heads/master@{#537870}
-
Tom Anderson authored
BUG=789768 R=dpranke Change-Id: I4c31c8c2c2fefad5337dff51727cbfd9c58a89b4 Reviewed-on: https://chromium-review.googlesource.com/924391Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#537869}
-
Bill Budge authored
- Removes ReserveMemory method. - Removes ReleaseReservedMemory, this is now just base::FreePages. - Removes SetProtection, this is now base::SetPermissions. - Removes dependency on sandbox/linux. base::AllocPages / FreePages now updates address space limits. Bug: chromium:799573 Change-Id: Iabc57c61511dfdc7b7ca2aa93c56ed21a22692f4 Reviewed-on: https://chromium-review.googlesource.com/923173Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#537868}
-
Ashley Enstad authored
Bug: 758632 Change-Id: I2aa7e817265a5d7bd25823aa47544f53ccc976c1 Reviewed-on: https://chromium-review.googlesource.com/926567Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#537867}
-
https://skia.googlesource.com/skia.git/+log/c68ba1d7d981..300cc5b5c1e1 $ git log c68ba1d7d..300cc5b5c --date=short --no-merges --format='%ad %ae %s' 2018-02-20 caryclark fix IRect doc 2018-02-20 halcanary SkQP: update README.md 2018-02-20 fmalita Add SkRect::contains(SkScalar x, SkScalar y) 2018-02-20 csmartdalton Drop unused support for MSAA sample locations 2018-02-20 halcanary android_build_app: optionally disable gradle daemon 2018-02-20 fmalita [sksg] Add 'plane' geometry node 2018-02-20 stephana Add SKQP bot to build universal APK to master 2018-02-15 csmartdalton ccpr: Fix a couple issues with tessellation and winding 2018-02-20 jvanverth Some more cleanup of GrDrawOpAtlas compaction 2018-01-25 mtklein Reland "remove third_party/etc1" 2018-02-20 halcanary Docs: clean up links 2018-02-14 csmartdalton Drop unused shader support for multisample interpolation Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: Ifd60a31ef8b4620f988fb7a85dd5f6d009b458cd Reviewed-on: https://chromium-review.googlesource.com/926902Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537866}
-
Tibor Goldschwendt authored
Use the procedural controller instead of the GLTF controller. Also remove the GLTF resource and the related parser since they are now unused. The GLTF parser can be re-submitted later when we have a use for it. Also reduce the number of polys of the procedural controller to avoid a perf regression. Bug: 799606, 779108, 770891 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I93209628fbcf20cf708b47c78689a951851f9b4b Reviewed-on: https://chromium-review.googlesource.com/922161Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537865}
-
Victor Costan authored
Without the --system-clang flag, ycmd fails to find the system headers, which severely limits its usefulness. The flag is documented as unsupported, but it's recommended by the maintainers on OSX: https://github.com/Valloric/YouCompleteMe/issues/2536#issuecomment-333909807 Change-Id: I93aeb12656d32e0fa2099aa0c703fcb6f7154bfb Reviewed-on: https://chromium-review.googlesource.com/925102Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Jianpeng Chao <chaopeng@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#537864}
-
Takumi Fujimoto authored
The error appears when we try to update the dialog height before the container element is initialized. We will update later when the element is initialized. Bug: 799912 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia24832275a46e753da48be9223f0a3ec83463d04 Reviewed-on: https://chromium-review.googlesource.com/919310Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#537863}
-
Francois Doray authored
This flag delays execution of base::TaskPriority::BACKGROUND tasks until shutdown. Bug: 726937 Change-Id: I2ce529a410382e7199558a0ed95476767b14786b Reviewed-on: https://chromium-review.googlesource.com/919866 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#537862}
-
Fredrik Söderquist authored
The code in its current form gives the impression that there's a dependency on the initial value of the 'fill' property, while all we really want to say here is 'black'. Use a more direct approach. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib75ba965c585771e9a009f91f0055a592a37c1b0 Reviewed-on: https://chromium-review.googlesource.com/926845Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#537861}
-
Peter K. Lee authored
Use base::FeatureList and about:flags to enable V2 feature. Default for this flag is DISABLED. Bug: 657076 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4b5ee8c95a79f533fded6b717efa0dd6c0bae895 Reviewed-on: https://chromium-review.googlesource.com/900543Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#537860}
-
Dave Tapuska authored
Shadowed variables can make code harder to read. Don't support them in the content layer. BUG=794619 Change-Id: I117ee483681a2788f93f544dee037dee856f7680 Reviewed-on: https://chromium-review.googlesource.com/926566Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#537859}
-
Erik Luo authored
When paused on an error, the debugger paused message is not showing the correct red styles. Screenshot: https://imgur.com/a/R9tv6 Bug: 812713 Change-Id: I23a95848b7727a2357614172c93b055fa5c185b8 Reviewed-on: https://chromium-review.googlesource.com/922396 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#537858}
-
stkhapugin@chromium.org authored
Since the clear button is in omnibox, it makes sense for it to be directly configured in the omnibox layer, without going to the location bar. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I51be645345550517e120939416a7e0664b74cf87 Reviewed-on: https://chromium-review.googlesource.com/924424 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#537857}
-
Raymond Toy authored
- AudioParam IDL test: Actually add the IDL to the test. Also removed unused helpers.js. - MediaElementAudioSourceNode Fix error because the expected result is mono, so only has one channel. However, this still fails on bots because there's no audio hardware to drive the online context. Bug: 626703 Test: the-audioparam-interface/idl-test.html Change-Id: I987ad1219da1b6b6ef677f2923416634fa281d5f Reviewed-on: https://chromium-review.googlesource.com/920261 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#537856}
-
Miguel Casas-Sanchez authored
This CL tentatively fixes GLImageIOSurface/GLImageBindTest/4 on Nvidia + 10.13.4 Mac OS X systems; the error log points to the current workaround swizzling the R and B channels specifically on such system and OS version combination doing the wrong thing, so let's removes it and see if it does the trick. Bug: 813846 Change-Id: I013da016158860da05b1b2bf0c363d29afdbef2f Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/926763Reviewed-by:
-
Dave Tapuska authored
Shadowed variables can make code harder to read. Don't support them in the content layer. BUG=794619 This CL was uploaded by git cl split. Change-Id: I89b52d89edbaff91c681700fa58bd591757abc28 Reviewed-on: https://chromium-review.googlesource.com/923346Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#537854}
-
Dmitry Skiba authored
Currently demuxer stream limits are 12MiB for audio and 150MiB for video, regardless of the platform. This means that when playing long videos Chrome will slowly allocate up to 162MiB. Most low-end Android devices can't afford allocating that much, which translates to bad user experience: first device becomes sluggish, as OS tries hard to kill other processes / move memory to zram. Eventually (since renderer keeps allocating) Android gives up and kills Chrome. Turns out that Chromecast had similar issues and ended up lowering demuxer limits to 2MiB for audio / 30MiB for video. This CL turns demuxer limit constants into functions and selects lower values on low-end Android devices. Bug: 810906 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I33fcd7d4916379abcb1f56cf9289928dfe3788a7 Reviewed-on: https://chromium-review.googlesource.com/922884Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Cr-Commit-Position: refs/heads/master@{#537853}
-
spqchan authored
Move the credit card autofill touch bar logic from AutofillPopupViewCocoa to AutofillPopupControllerImplMac so that is can be used on both Toolkit and Cocoa autofill popups. Bug: 812658 Change-Id: Ic8d788dddabb909edee46da46899d759447a7c7d Reviewed-on: https://chromium-review.googlesource.com/915438Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#537852}
-
Ahmed Fakhry authored
This CL implements the touch-optimized design of the New Tab Button in both incognito and normal modes. Button is flat with no highlight, and has an ink drop ripple effect. Demo is posted on the bug. BUG=805245 TEST=manually Change-Id: I33a2e5e213193318b70e1c01ee330a67d6af21f0 Reviewed-on: https://chromium-review.googlesource.com/903375 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Guido Urdaneta authored
Tracked requests are normally removed when the corresponding renderer process dies. However, it has been reported that this mechanism could be used to launch a DoS attack against the browser process, resulting in "leaks". This CL sets a limit of 1000 tracked gUM requests, which is a number probably beyond what is practical for the webrtc-internals UI anyway. Bug: 804440 Change-Id: I578fbb4ab6feee17f035beca2dbec86381376b6c Reviewed-on: https://chromium-review.googlesource.com/926366 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#537850}
-
Qiang Xu authored
changes: - WindowState caches a member for saving PersistentWindowInfo, which is saved on OnWillProcessDisplayChanges() and restored on OnDisplayConfigurationChanged(). - Saving when it hasn't been saved. - Restoring when (1) we have saved persistent info, (2) persistent display id is a valid display currently, (3) persistent display id is not current display id. We could have display position/layout changes, in which case we transform the window accordingly. - Reset saved PersistentWindowInfo each time window bounds have restored or when bounds changed by user. Bug: 805046 Test: ash_unittests --gtest_filter=PersistentWindowControllerTest* Change-Id: I67426ca17f0d25f92284eb690f849bf77bb748be Reviewed-on: https://chromium-review.googlesource.com/893644Reviewed-by:
Mitsuru Oshima (In Tokyo) <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#537849}
-
Dianna Hu authored
This pseudo-header is defined in https://tools.ietf.org/html/draft-ietf-httpbis-h2-websockets-00. This CL lands server change 184848446 by bnc. BUG=488484 Change-Id: I32000864d0f5cfef66767b8b23ddf4749c61cfc3 Reviewed-on: https://chromium-review.googlesource.com/925624 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#537848}
-
Erik Luo authored
The Elements search bar shows the number of matches when active. Upon a refresh/navigation, it cancels the search, but leaves '0 out of 0' in the search box, even if there are matches. This CL stops showing incorrect information and hides the match count completely in those cases. Screenshot: https://imgur.com/a/xdyD4 Bug: 554654 Change-Id: I49791d302ade2719ae0b609cab8d325a562bb87a Reviewed-on: https://chromium-review.googlesource.com/920041Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#537847}
-
Eric Lawrence authored
When an OBJECT or EMBED element requests an image, it does so using an ImageLoader. To ensure that Content-Security-Policy restrictions are applied correctly in this scenario, we must adjust the request's context to indicate the originating element. Bug: 811691 Change-Id: I0fd8010970a12e68e845a54310695acc0b3f7625 Reviewed-on: https://chromium-review.googlesource.com/924589 Commit-Queue: Eric Lawrence <elawrence@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#537846}
-
Mike Dougherty authored
Metrics logged from the CaptivePortalMetricsTabHelper are useful to determine the users affected by a broken connection due to a Captive Portal. However, it is not necessary to log these metrics continuously. Keeping the tab helper behind a flag allows re-enabling the metrics in the future in order to examine the issues caused by Captive Portals. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8c4fca02d85701ca1ef1b7bf0aec87cf08015bd0 Reviewed-on: https://chromium-review.googlesource.com/924571 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#537845}
-
Donn Denman authored
There are two tests that are currently flaking a lot, one when running in multiprocess_mode. Disabling these tests until they can be fixed. TBR=wnwen@chromium.org BUG=813837 Change-Id: I6f969a9f8bdfe3d74ff92d3d60b6f3d7d94c986b Reviewed-on: https://chromium-review.googlesource.com/926969Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#537844}
-
David Benjamin authored
This is no longer necessary as of https://boringssl-review.googlesource.com/24124. Change-Id: I704668dd9bf9c1a08c7574c5b95b090485a7ade5 Reviewed-on: https://chromium-review.googlesource.com/924547Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#537843}
-
Christopher Grant authored
This reverts commit 467ac499. Reason for revert: This broke presubmit due to an owners change. Original change's description: > VR: Rename native vr_shell directory to vr > > This change follows up on the namespace change, to relocate files, > and address some of the presubmit warnings stirred up by that move > (mainly BindRepeating/Once updates). > > BUG= > NOPRESUBMIT=true > > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Ieb4d0ad3fd039e5e85b0a8cf2204d1141d3438d9 > Reviewed-on: https://chromium-review.googlesource.com/921924 > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537822} TBR=yfriedman@chromium.org,mthiesse@chromium.org,cjgrant@chromium.org Change-Id: I23f72f9cf9a8a64a9f92dec0ca4d78f961fa2e02 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/926884Reviewed-by:
-
Fernando Serboncini authored
Change-Id: I9986d7ca3468f6e5f3ce2c33da627b580c2ac7fe Reviewed-on: https://chromium-review.googlesource.com/883768 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#537841}
-
Stephen McGruer authored
This test has non-flaky failures, so we can track them directly and don't need to disable the test in TestExpectations. Bug: 772076 Change-Id: Idd071879e02acfff7e77a3b4e923d4fe98f34cbc Reviewed-on: https://chromium-review.googlesource.com/926721Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#537840}
-
Rob Buis authored
Make ChromeDriver more extensible on Android by allowing to set the exec name and device socket as capabilities. The already existing androidActivity capability can be used to specify the exact Activity to launch. This should benefit browsers other than Chrome, for instance Opera etc. Bug: chromedriver:2280 Change-Id: Ice811df1c9b1985f47515c597731942a6e33a1cd Reviewed-on: https://chromium-review.googlesource.com/924441Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#537839}
-
