- 05 Mar, 2019 40 commits
-
-
Sergiy Belozorov authored
R=perezju@chromium.org Bug: 895891 Change-Id: Ib4b6b0ea123b64d0333cb0911930358dcb3ff2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496871 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#637677}
-
Vadym Doroshenko authored
This reverts commit e9aa20fd. Reason for revert: this change breaks tests on win dbg bot This is the first failure https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64%20%28dbg%29/6437 Test InsertListCommandTest.CleanupNodeSameAsDestinationNode is definitely fails because of this patch (I've verified it locally on Windows). The problem with this test that it's very deep recursion in function between functions AdjustBlockFlowPositionToInline ComputeInlineAdjustedPositionAlgorithm and as a result stack overflow. Original change's description: > Fix caret rendering when at the end of a block after an ineditable inline > > AdjustBlockFlowPositionToInline() has an early-reject branch that avoids > infinite recursion, introduced in crrev.com/664b6437. > > However, the early reject condition is too aggressive that, it also > rejects some positions that don't enter an infinite recursion, like > the one used in the new unit test added in this CL. > > As now AdjustBlockFlowPositionToInline() has a hard limit on recursion > depth, this CL safely removes the over-aggressive reject condition, so > that caret can be correctly rendered for more positions. > > Note: Unit test InlineBoxPositionTest.ComputeInlineBoxPositionMixedEditable > uses another position that doesn't enter the infinite loop but is falsely > rejected by the condition. This patch allows caret rendering also for that > position, and therefore changes its test expectation. > > Bug: 936988 > Change-Id: Idef91ffaa412e67cddd5fcf0dd61f54055de7189 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497466 > Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637311} TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org Change-Id: I6fcff118f27d633e627d5942671b04554fef283b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 936988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503579Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#637676}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d69cdaba1445..e95eeb19a770 git log d69cdaba1445..e95eeb19a770 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 bclayton@google.com SpirvShader: Add relational ops for integers Created with: gclient setdep -r src/third_party/swiftshader@e95eeb19a770 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/127282157 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ic24afd6b9f2205ff33392b674ef67adbe95c9bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503297Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637675}
-
kylechar authored
Add a function to check if the VizDisplayCompositor feature is enabled instead of checking base::FeatureList for the feature. This will allow keeping the feature always enabled on platforms where it's launched and old code is ready to be deleted. Bug: 730193 Change-Id: Ie40c6bfc7651566202354d8e64af26eac724da48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492476Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#637674}
-
Mohamed Amir Yosef authored
The password manager stores the password in an encrypted form. The decryption key is stored in platform-specific storage, but in case that decryption key is lost (e.g. migrating the user directory from a machine to another), the passwords in the stores will always be undecryptable. For syncing user, during initial merge, we try to clean up the password store by deleting all undecryptable passwords. At merge time, the store is empty and hence will be filled with data from the sync server. This functionality has been implemented in the PasswordSyncableService in the directory implementation. This CL implements the same functionality in the PasswordSyncBridge the USS counter part. It is worth noting though that the merge logic is run on every start in the directory, while in USS, it's invoked only during initial sync. Bug: 935996,902349 Change-Id: I755f887a3849176cb3b9a7e05f3d4c333f8f623c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503315 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#637673}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f87f16a7d161..2ea9c01a11a6 Created with: gclient setdep -r src-internal@2ea9c01a11a6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: Icae1041373474e25376491b041da0aeb7dfd7a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503295Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637672}
-
Maksim Sisov authored
This change does not bring any functionality changes. TBR=rjkroege@chromium.org Bug: 578890 Change-Id: Ibbd06a33c41b63274c99473f79bb21eafdf6fa67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503592 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#637671}
-
Takuto Ikuta authored
I will deprecate deps in proto_library for improved build throughput. Instead, * use proto_deps for proto file generating task dependency * use link_deps for link/compile time dependency Bug: 938011 Change-Id: Ieb1281a9653fdfdd1add3594b2b19a138aff37ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503275 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#637670}
-
Daniel Vogelheim authored
TrustedTypes.isXXX are meant to safely check whether the given parameter is a 'safe' type or not. That implies that the function shouldn't throw for some parameters. Bug: 739170, 936433 Change-Id: I374a88c53c97a5ecd2e9ac71b303eec6bdb6c0f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499555 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637669}
-
Hiroki Nakagawa authored
This CL... - merges LoadScriptFromInstalledScriptsManager() and LoadScriptFromClassicScriptLoader() into FetchClassicImportedScript() to remove complex state handling (i.e., LoadResult). - adds spec comments. - removes unnecessary 'virtual' specifier from importScriptsFromStrings(). - renames importScriptsFromStrings() to ImportScriptsInternal(). Bug: 938219, 937195 Change-Id: Ib9573a14d4542a6dc0fadcca6c4643546be19fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502773Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#637668}
-
Roger Tawa authored
Bug: 936584 Change-Id: I0614a7859d453a99d676462978f809b2440ef2c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492037 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637667}
-
Javier Ernesto Flores Robles authored
Changes the string to the right one. Bug: 913105 Change-Id: Ia327e5c82f89f4e70ce43a756516ed08bf7125db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503372 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637666}
-
Kent Tamura authored
We have an optimization reusing a Text child, but the standard doesn't define such behavior, and Edge, Firefox, and Safari don't have it. This CL might regress benchmarks. We'll accept it. Bug: 573309 Change-Id: I3aacae5d37e5a7685ce2d310944dfef8d6e4b13a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502338 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637665}
-
Mohamed Amir Yosef authored
LoginDatabase::RemoveLoginByPrimaryKey() returns a change list that contains the forms that have been deleted. Therefore, it needs to first load the forms from the database. Before this CL: LoginDatabase::RemoveLoginByPrimaryKey() would actually decrypt and fill in the password value. Therefore, it fails in case of a decryption failure. After this CL: Since it doesn't make sense to block the removal of a form in case of decryption failure, LoginDatabase::RemoveLoginByPrimaryKey() won't actually fill in the password value. Hence, the password in the change list will be missing a password value. This change list is used to communicate the change to other observers of the password store. This should be fine because none of the password store observers is interested in the password value in case of deletion. Change-Id: I697e507584d77406280604a1481e437b80184890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503322 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
jdoerrie authored
This change removes base::ConstRef from the codebase and replaces previous usages with the equivalent std::cref. TBR=tzik@chromium.org Bug: 934808 Change-Id: Idbdd1e8b5ea29aaaa0e85067923d3e61edb0d3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1484291 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#637663}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/156cf83837bc..63d7594c653d git log 156cf83837bc..63d7594c653d --date=short --no-merges --format='%ad %ae %s' 2019-03-05 lalitm@google.com traceconv: bump linux sha 2019-03-05 lalitm@google.com trace_processor: fix writing of clk_set_rate events Created with: gclient setdep -r src/third_party/perfetto@63d7594c653d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:124446759 TBR=perfetto-bugs@google.com Change-Id: I3f379dc88a6aa24d8e888c5ec706294e7273222c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503492Reviewed-by:
-
philipel authored
CodecSpecificInfo has a default constructor, so initializing by memset is not necessary and is in the way of adding non-trivial members. Related webrtc CL: https://webrtc-review.googlesource.com/c/src/+/125093 Bug: webrtc:10342 Change-Id: I72a98dbb87c99219fdc389c31f65fbd3a580bd5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495533 Commit-Queue: Philip Eliasson <philipel@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#637661}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fbc887df72ec..13623c141ead git log fbc887df72ec..13623c141ead --date=short --no-merges --format='%ad %ae %s' 2019-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0e1ce2e55387..b8cff9e9347c (6 commits) 2019-03-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@13623c141ead The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I919b315183b80b6776e22b1129ae0aea57d24dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503493Reviewed-by:
-
Monica Salama authored
Collect native code's resident memory size accross processes. In the browser process use the collected data to report the global resident memory footprint. Works on Android devices running kernel version >= 4.4. Bug: 866396 Change-Id: If85f30108d391cf4fc7ea943716ef61b7951efdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1430083 Commit-Queue: Monica Salama <msalama@google.com> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#637659}
-
Alex Clarke authored
Some TaskQueueImpl methods could lock and unlock immediate_incoming_queue_lock_ twice. Unlikely to be a huge deal but it's simple to avoid doing so... Change-Id: I00627424ddd3bbda81a5d5f481a981d9d8dcad2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503252Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#637658}
-
Clemens Arbesser authored
Bug: 806868 Change-Id: Icc812a087a74b3af21bb6fb58c01558e68b0a125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503132Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#637657}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b678940d3a44..c8eeb18d41d8 git log b678940d3a44..c8eeb18d41d8 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 srte@webrtc.org Fixes parsing of logs where receive time info is missing. 2019-03-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4229a4b6..5fe3fd14 (637436:637538) 2019-03-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5afa5224..4229a4b6 (637301:637436) 2019-03-04 srte@webrtc.org Injecting Clock into video senders. 2019-03-04 srte@webrtc.org Injecting Clock in video receive. 2019-03-04 steveanton@webrtc.org Remove lock in WebRtcVideoEngine 2019-03-04 eladalon@webrtc.org Fix some typos found in ivf_file_writer.cc 2019-03-04 srte@webrtc.org Allow Clock injection in Call. 2019-03-04 nisse@webrtc.org Move ownership of RTPSenderVideo one more level up, to RtpVideoSender 2019-03-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e65d7afd..5afa5224 (637200:637301) 2019-03-04 srte@webrtc.org Injecting Clock into BitrateAllocator. 2019-03-04 ilnik@webrtc.org Wire UpdateRect signalling in test frame generators 2019-03-04 jonasolsson@webrtc.org Reinstate old iceConnectionState "completed" behavior 2019-03-04 phensman@webrtc.org Use JavaAudioDeviceModule as default 2019-03-04 ossu@webrtc.org Switch back to native mutexes on macOS Created with: gclient setdep -r src/third_party/webrtc@c8eeb18d41d8 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0ab4d8b176867d96a4f0cac00a0d7e3ade545a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502676Reviewed-by:
-
Egor Pasko authored
On webview bots either crashpad is not set up for a webview app (likely, I did not confirm) or the package name for the app is not detected properly. As a result the path to the file does not exist on the device: /data/data/<PACKAGE_NAME>/cache/Crashpad/pending/ Make crashpad_stackwalker return with an error in this case instead of throwing. The caller in android_platform_backend.py will ignore the exit code, so this change effectively only removes printing of the stack trace in this situation. A confusing stack trace nevertheless. Bug: 937796 Change-Id: Iea084fa466556d26e6d004313f89a62a8026ad40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499557Reviewed-by:
-
Javier Ernesto Flores Robles authored
This changes the logic of the title for the Manual Fallback addresses cells. Previosly the line 1 was always in black and the line 2 was in gray. Now the logic is to fallback in the following order: 1. Line 1 and Line 2 (as previously) 2. Line 2 3. City 4. Email Bug: 924097 Change-Id: Id8b4c7d0b69729c5b2f0008868341d690697256c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503312Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#637654}
-
Anders Hartvoll Ruud authored
InternalPopupMenu ensures the ComputedStyle of some elements, via InternalPopupMenu::AddElementStyle, HTMLSelectElement::ItemComputedStyle. This hits a DHCECK in Element::EnsureComputedStyle, because the tree is apparently not style-clean at that time. R=fergal@chromium.org Bug: 934035 Change-Id: I7c48690d06484c6bbce4e2dad952e2edd73fa231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482891 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#637653}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d8b0d88d..0f03f503 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I54677c5ca9fe1f032bb9227b67cf1b9d244e0623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503092Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637652}
-
Adam Rice authored
Move ReadableStream to ReadableStreamWrapper. Make ReadableStream be an interface which can have multiple implementations. Make ReadableStreamWrapper implement the ReadableStream interface, and be delegated to by the ReadableStream static methods. Deprecate ReadableStreamOperations as it won't work with the new implementation. BUG=902633 Change-Id: Idcc8ae62e787e5696698f13229d19c91ca7a7e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1494394Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#637651}
-
Mohamed Amir Yosef authored
Before this CL: StatmentToForms() used to return false in case of DB error or Decryption failure. This doesn't allow upper layers from acting differently in each case. After this CL: StatmentToForms() return one of three outcomes: SUCCESS, DB_ERROR, ENCRYPTION_SERVICE_FAILURE This allow later patches to use of the outcome and do cleanup of passwords don't are not decryptable. Bug: 935996 Change-Id: I2e27285feef76030895ab4476bc9f3cde2e53e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499353 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Stephane Zermatten authored
Before this change, the client waited for a hardcoded duration for scripts to become available and then entered a generic error state. After this change, the timeout and action can configured by the backend. When that timeout is reached, the client executes a specific script, controls what the client does. This change also subtly modifies the time after which the client stops waiting for autostart scripts: it now stops either once it's found a script to autostart or when it's found runnable scripts to propose, instead of waiting for a script to be started. This unifies operations and avoid the unlikely but confusing case where there client would autostart a script after having proposed scripts to run. For background, see go/autobot-a2m74ux-client-errors Bug: b/125245527 Change-Id: I0bc757293ca324544f1b3d35275168ee6545c340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497073 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#637649}
-
Juan Antonio Navarro Perez authored
Some external module dependencies, notably numpy and pandas, are required by some command line perf tools to work properly. And these are normally satisfied by the vpython environment. However vpython is not always available, e.g. on ChromeOs, so we provide a mechanism to safely dismiss the respective import errors and skip tests that cannot be run due to the lack of these modules. Doing in this in preparation for the migration of soundwave out of catapult/experimental and into tools/perf; since that includes many other tests that also depend on these external modules. TBR=achuith@chromium.org Bug: 922030 Bug: 921762 Change-Id: I162e8e232484a5f9c8f919426ad86c6d0ad2e428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1494887Reviewed-by:
-
David Jean authored
Bug: 886583 Change-Id: I28e56d75def275ec05b5425be85282d1f11fffe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480458 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Change client code to work as if IdentityManager::GetPrimaryAccount where returning a CoreAccountInfo instead of an AccountInfo. Method will be updated in a followup CL. This CL was uploaded by git cl split. Bug: 926204 Change-Id: I963b34fe4bf1dac600e7859608c8090bbb05396b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499539Reviewed-by:
-
Stephane Zermatten authored
This change adds a blue line around transparent areas and adds a fade animation when the transparent area appears or disappears. Screenshot: https://screenshot.googleplex.com/kAH8AHKk2du.png Animation: https://drive.google.com/open?id=1E_X48t1Kl-z2JAJpWyVtuCP8tmzcrnEz Bug: b/125245127 Change-Id: I95ba459c6420620b64225c9043e00ce2dcfd25d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497138 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#637645}
-
Tsuyoshi Horo authored
Bug: 937583 Change-Id: I07ae09c08dd3277176444a63cefe3d68db004b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496408Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
Previously, a single flag (#enable-layered-api and "LayeredAPI") is used to enable/disable all built-in modules as well as Layered API Infra + Import Maps. To enable/disable individual modules separately, and to rename "Layered APIs" to "built-in modules" in externally visible places, this CL renames the existing flag and introduces new flags: - #enable-built-in-module-all / BuiltInModuleAll that enables all built-in modules (renamed from #enable-layered-api / LayeredAPI). - #enable-built-in-module-kv-storage / BuiltInModuleKvStorage that enables kv-storage only (new flag). - #enable-built-in-module-infra / BuiltInModuleInfra that enables built-in module infra + import maps (new flag), which is implied if any of built-in modules are enabled. This CL replaces RuntimeEnabledFeatures::LayeredAPIEnabled() with RuntimeEnabledFeatures::BuiltInModuleInfraEnabled(). So far all built-in modules are enabled if BuiltInModuleInfra is enabled. Subsequent CL [1] will introduce control over individual built-in modules using BuiltInModuleKvStorage and BuiltInModuleAll flags. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1497468 Bug: 829084, 938069 Change-Id: I2486c9e8b0c5ea96056a60e645a171d642c218fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497616Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL removes a check that an entity that gets deleted exists. It turns out it gets deleted before notifying so this check always fail, producing useless results. As a result we compute is_converted_from_server for DELETE changes differently, based on the storage key. The metric does not get renamed as it only lives on Canary / Dev so far and is not used in production. Bug: 904390 Change-Id: Iac3e5c42377d480671efce57ec225fea1cc8f625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496859 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#637642}
-
Takashi Toyoshima authored
Changes from the original patchset: - variation header support for iOS Chrome - additional variation header support for Chromecast - additional variation header support for StoragePartition Original descriptions: > Now ResourceRequest has multiple special header entries that are aimed > for escaping from CORS checks for internal uses. This patch introduces > cors_exempt_headers to handle this kind of entries in an unified way. > > Also this patch removes {Get|Set}ClientDataHeader interfaces from > WebURLRequest because these should not be used in Blink. > Bug: 870173 > Change-Id: I5ae5a4a58df30e54064da5b7ab74abb69c9e42a7 > Reviewed-on: https://chromium-review.googlesource.com/c/1445178 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630268} Bug: 931190, 870173 Change-Id: I0220918d3aa18787d2ed1ef8029f8c568d8afb4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1485560Reviewed-by:John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#637641}
-
Takuto Ikuta authored
device_management_backend.pb.h is 1.5MB. Removing such header include reduces compile time of some files. e.g. compile time of obj/chrome/browser/browser/chrome_content_browser_client.o is improved from 30.2s to 29.7s. Bug: 242216 Change-Id: If05857d45165756b6e86330f332280ad20ee3458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502318 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#637640}
-
Ivan Sandrk authored
Locked fullscreen is supposed to be a secure mode where the user cannot do anything outside of the current browser window, but ARC apps can currently draw on top of it. To fix this, we disable ARC when entering the mode, and we re-enable it upon exiting the mode. This is a follow-up CL to crrev.com/c/1363202 ([ARC] Decouple ARC data removal from disabling ARC inside of ArcSessionManager) More details can be found on the design doc go/disabling-arc-locked-fullscreen Bug: 888611 Change-Id: I295902b2dfb6889457ef468c15bb7becdec1c746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488927Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#637639}
-
Takashi Toyoshima authored
In OnLifecycleStateChanged(), ShowConsoleMessageIfNeeded() is called and it chosen the top request from |pending_requests_| to show a console message if the request is stacked in the queue for a long time. This code expects the entry in |pending_requests_| is always alive even in the |pending_request_map_|, but it's wrong. If the request is canceled, it remains only in |pending_requests_| and DCHECK fires. This patch changes ShowConsoleMessageIfNeeded() to choose a request only when it is still alive in |oending_request_map_|. Bug: 936937 Change-Id: Ic0ea774f62719a3b36e78c49f24da3d5f6ce8365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498971Reviewed-by:
-
