GitLab

[reland] When GPU process falls back to SwiftShader, about:gpu displays an extra copy of data for real GPU.

This was originally reviewed in https://chromium-review.googlesource.com/c/chromium/src/+/1017300.

BUG=828462,835343
TEST=manual in about:gpu
TBR=piman@chromium.org,dcheng@chromium.org,kbr@chromium.org,sadrul@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I05db9214a8e9478ad69bb81cb10a3b3d4e9380c9
Reviewed-on: https://chromium-review.googlesource.com/1022506Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552536}

This smoke tests exercises the cross-platform serial device enumeration
code on all supported platforms.

Bug: None
Change-Id: If283efc796b2bf0225d5b66489b00adb8d75d425
Reviewed-on: https://chromium-review.googlesource.com/1022718Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552535}

This patch removes some obsolete logic from the ContextualSearchPanel
that caused the Android browser controls to hide while the bottom
sheet is expanded. This fixes the issue of not being able to tap on
the controls.

This patch also introduces the concept of suppression to the sheet's
controller. When the sheet needs to be temporarily hidden, it can
now be suppressed without modifying the contents of the sheet. This
prevents several race conditions involving switching browser layouts
and showing the sheet.

Bug: 835042
Change-Id: Ieac27944edbac2a67049b9db6b4789b12e162a3f
Reviewed-on: https://chromium-review.googlesource.com/1022972Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552534}

Make the focus manager notify the focus manager delegate with
focus changed events, and make the ash focus manager delegate
center the viewport of the currently enabled magnifier (if any)
around the center of the focused view.

BUG=833345

Change-Id: Ifc047e761bc24b58029545113a3a5ab6dbf01ef6
Reviewed-on: https://chromium-review.googlesource.com/1014680
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552533}

The Mac AppController needs to know about the last active profile to
keep the system menus updated and to know which profile to open when a
first window is created. Usually this is tracked at profile creation,
but since the UserManager is not a "browser window", the usual
tracking logic doesn't apply and AppController has to be informed
manually. This was done in UserManagerMac already. This change splits
the logic for doing so out of UserManagerMac into the
app_controller_mac namespace and invokes it from UserManagerView.

This fixes a handful of browser_tests in Views mode on Mac, such as:

ProfileChooserViewExtensionsTest.LockProfile*
AppControllerNewProfileManagementBrowserTest.LockedProfileReopenWithNoWindows

Bug: 834754
Change-Id: Ib80aa5a931c96b5d3b38d974f88402b2d4406255
Reviewed-on: https://chromium-review.googlesource.com/1022290
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552532}

This patch moves the CreateCrostiniAppId from crostini_util.cc to the
CrostiniAppRegistry and makes it look for a matching app registration.
This will be useful when we want to make launching of apps focus
existing windows if they exist.

Bug: 819444
Change-Id: Ibef29d4441ea6f4aaab3ea45cce0982493f69a47
Reviewed-on: https://chromium-review.googlesource.com/1004564
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552531}

Add a new method with filter (by generalizing the ClearCacheUrlFilter)
and time range support to NetworkContext. Use it from
BrowsingDataRemoverImpl.

Also changed some of the Closure parameters in ChannelIDStore to
OnceClosure to more cleanly support calling with the mojo callbacks.

Bug: 824970
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I9a8bb37ef80ccda1d048c4c090ebc61855066960
Reviewed-on: https://chromium-review.googlesource.com/1013303
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552530}

The original CL was reverted because --memlog did not support Android Webview,
but --enable-heap-profiling did. Now that they both support Android Webview,
there is no reason to keep "--enable-heap-profiling" anymore.

> The flag is deprecated and replaced by --memlog and co. See
> https://chromium.googlesource.com/chromium/src/+/lkcr/docs/memory/debugging_memory_issues.md#taking-a-heap-dump
> for more details.
>
> Bug: 758739
> Change-Id: I8f7ac614298334a90103cd5b4c9667468d662845
> Reviewed-on: https://chromium-review.googlesource.com/970852
> Reviewed-by: Tommy Martino <tmartino@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Reviewed-by: Siddhartha S <ssid@chromium.org>
> Reviewed-by: Dmitry Skiba <dskiba@chromium.org>
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545929}

Change-Id: I2f503b6f685aa6030ca27b60fa2e578aa9766b94
TBR: dskiba@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1022533Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552529}

We treat null and undefined frame IDs as -1. Add a test for native
extension bindings.

Follows Rob Wu's CL from revision
https://crrev.com/35b5a75bf1276ea448944fa1295828207d95b2bb.

BUG=834055

Change-Id: I100c2fc90c920f0af0cff69aa387de66c7e790bd
Reviewed-on: https://chromium-review.googlesource.com/1020368Reviewed-by: Rob Wu <rob@robwu.nl>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552528}

This patch adds functionality to force a new surface synchronization via
EnsureSurfaceSynchronizedForCopy(). The general idea is to keep track
of a capture sequence number which would be incremented by this function
and propagated throughout all of the frames, creating new LocalSurfaceIds
along the way.

Once the top level CompositorFrame activates, all the the frames will have
generated a new CompositorFrame giving the viz host (browser) an
opportunity to capture a screenshot of the freshest content.

Bug: 667551
Change-Id: I0727183b0ee7851e815b616fc4a78463f89a517a
Reviewed-on: https://chromium-review.googlesource.com/986752
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552527}

Introduces a new consistency check strategy for persistent pages. Since
persistent pages should be living in an external directory and exposed
to third party file explorers, we should not deleting any files.

Some more details:
- For all persistent pages, try to see if it still has its archive file
 - If not and the page has been missing the file for a while, delete the
   entry from DB and notify the system download manager about deletion;
   If it's newly discovered missing, set the file missing time in DB.
 - If the file is there and the page has been marked as missing file,
   remove the file missing time.
- The new persistent page consistency check will run together with the
  ClearStorageTask, scheduled by actions(GetAllPages or SavePage) and
  limited by a time threshold.

Bug: 830102
Change-Id: Ie90d9fd988c642bdb6f598982f93e33642bd97ca
Reviewed-on: https://chromium-review.googlesource.com/1016015Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552526}

And double shard crypto_unittests to test sharding & merging logic.

Bug: 832374
Change-Id: I165160b5482efb505861f7f4bd0e0f1497923efc
Reviewed-on: https://chromium-review.googlesource.com/1022255Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552525}

This is a reland of 622eec2f

Original change's description:
> Revert "Temporarily disable angle_vulkan_deqp_tests."
>
> This reverts commit 5f77b73e.
>
> Reason for revert: Roll has landed, reinstating tests.
>
> Original change's description:
> > Temporarily disable angle_vulkan_deqp_tests.
> >
> > Unblocks the Vulkan roll.
> >
> > Bug: angleproject:2482
> > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> > Change-Id: I9577f331977e9add28bb7875e70260d428ad0cd5
> > Tbr: kbr@chromium.org
> > No-try: True
> > Reviewed-on: https://chromium-review.googlesource.com/1014322
> > Reviewed-by: Jamie Madill <jmadill@chromium.org>
> > Commit-Queue: Jamie Madill <jmadill@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#551102}
>
> TBR=jmadill@chromium.org,kbr@chromium.org
>
> Change-Id: Iab80706a6e74c442533d4df60c753e7dc270c380
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: angleproject:2482
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Reviewed-on: https://chromium-review.googlesource.com/1014726
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551235}

Bug: angleproject:2482
Tbr: kbr@chromium.org
No-Try: True
Change-Id: I973e3e300eb4a886aff1179d5673758686b78e0e
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1023151Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552524}

This is a preliminary change to remove the posix source exclusion
filter in a future commit.

Bug: 835405
Change-Id: I69e6b3ba30daafc57ab06c664f0166ba537dbc05
Reviewed-on: https://chromium-review.googlesource.com/1022315
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552523}

Changes:
The removed lines aren't necessary as they would be called from
ash::AccessibilityController::UpdateHighContrastFromPref() and
chromeos::MagnificationManager::UpdateMagnifierFromPrefs() when pref
is available to observe pref change.

Bug: None
Change-Id: I2655c202f626fbdd215a3c76071a8fdb6749b1cd
Reviewed-on: https://chromium-review.googlesource.com/1022176Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#552522}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/b915daddaea1..ef1ada9adf6a

$ git log b915dadda..ef1ada9ad --date=short --no-merges --format='%ad %ae %s'
2018-03-27 fqj Add a whitelist to not to rename some artifacts.

Created with:
  roll-dep src/third_party/chromite


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I1c04caa2ed0962eeb2273d89c5f630a41027bee4
Reviewed-on: https://chromium-review.googlesource.com/1022497Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#552521}

https://chromium.googlesource.com/angle/angle.git/+log/3ec304dba28d..5f21df8318e9

$ git log 3ec304dba..5f21df831 --date=short --no-merges --format='%ad %ae %s'
2018-04-18 tobine Roll (1/2) LVL version forward and disable VANGLE
2018-04-19 ynovikov Use EGL_KHR_no_config_context in Android GLES backend, when available
2018-04-20 ynovikov Print more logs
2018-04-10 geofflang Refactor packed enum generation to support EGL enums.
2018-04-20 geofflang Use LIKELY and UNLIKELY macros to wrap error generation.
2018-04-20 jmadill Fix WebGL compat feedback loop null deref.
2018-04-19 tobine Make Mock ICD json file a data_dep of Mock ICD
2018-04-19 lucferron Refactor Texture::syncState to pass down the Context

Created with:
  roll-dep src/third_party/angle
BUG=chromium:609673,chromium:834943


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: Ifbfe7a6eec5c1771a9ecf20a9cd31f5070758588
Reviewed-on: https://chromium-review.googlesource.com/1022720Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#552520}

The Create() signature change will also be useful in an upcoming test.

BUG=834728
TEST=none

Change-Id: I49dd07d3b3f56b9d012af9017af954eb1b62c647
Reviewed-on: https://chromium-review.googlesource.com/1020306
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552519}

Bug: 819256
Change-Id: I8fb3a646ebd390530c611aa4a42db501168db62f
Reviewed-on: https://chromium-review.googlesource.com/1020441
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552518}

Manifest v1 extensions will no longer be loaded in M67. We need to
update this extension to manifest v2.

Update the manifest, and add a trivial browser test to at ensure the
extension is properly loaded on CrOS (since it looks like we don't have
any other coverage for this).

Bug: 835392
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I36734dd22b85a93639cf6603841ada430b3bdf50
Reviewed-on: https://chromium-review.googlesource.com/1022258Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552517}

SharedBitmapManager is now a service-side only concept, so remove all
client-side APIs. This includes the ClientSharedBitmapManager, the
SharedBitmapAllocationNotifier mojo and c++ APIs, and the allocation
method (and impls) in {Server,Test}SharedBitmapManager.

Also removes the instance and bindings for these things from the
renderer process in RenderThreadImpl, and the service-side connections
in RenderProcessHost{Impl}.

R=piman@chromium.org
TBR=groby

Bug: 730660
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia976eb0e2a805c8e00803291214d346423315914
Reviewed-on: https://chromium-review.googlesource.com/1022180
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552516}

There are two syntaxes to declare an Objective-C block taking
no arguments and returning no value (so of type void(^)()):
1. ^{ ... } or 2. ^() { ... }.

The syntax 1. appears to be the most popular in the codebase
with at the time of writing 11643 references while 2. only
had 58.

Conversion was automated with the following command:

    sed -i '' -e 's/\^ *() *{/^{/' $(git grep -l '\^ *() *{')

Bug: none
Change-Id: I4f6ccf1578342d64de8d60f4d29b4b327e6ecd6e
Reviewed-on: https://chromium-review.googlesource.com/1022730Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552515}

The initial CL had a logic bug in browser_window_controller.mm that caused
crashed on macOS.

> This CL is a refactor with no intended behavior change.
>
> Previously, the method returned a raw pointer, and ownership was implicitly
> passed. This CL updates the method to returned a unique_ptr. In this process of
> updating all call sites, this CL also:
>   * Gets rid of UnloadControllerWebContentsDelegate, which added an unnecessary
>     layer of abstraction. FastUnloadController can directly inherit from
>     content::WebContentsDelegate, which removes an extraneous class.
>   * Updates FastUnloadController to hold WebContents waiting for deletion in a
>     vector of unique_ptrs. Previously, the WebContents were simply dropped on
>     the floor, and then UnloadControllerWebContentsDelegate would delete the
>     pointer it received in a callback.
>   * Updates DevToolsWindow to use clear ownership semantics for the
>     main_web_contents_. Ownership passes between DevToolsWindow and its member
>     browser_, based on the |is_docked_| parameter, but ownership was not being
>     explicitly specified.
>
> Change-Id: I4c21f04fe5d60a5149d79bda7b6ba3535bef2b7f
> Bug: 832879
> Reviewed-on: https://chromium-review.googlesource.com/1012938
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552063}

Change-Id: Ic2af1f7a8c02e923eda3cfd980d0b845d619f00d
Bug: 832879
TBR: sky@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1022750
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552514}

There is special logic in ChromeCommandDispatcherDelegate's
prePerformKeyEquivalent: method that handles user key equivalents for builtin
browser commands. This same logic needs to happen in the Views browser, so
the Views-side logic needs to consult the BrowserView's accelerator table
to see if the key is bound.

This involves an ungainly bridge, because it's not possible to include
BrowserView and BrowserWindowController's full definitions at the same time -
they have conflicting C++ and Objective-C class names in their dependencies.

Bug: 834754
Change-Id: I67a62064d58cb7dba9c3bd532917ed1f90959340
Reviewed-on: https://chromium-review.googlesource.com/1022530Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552513}

There are two syntaxes to declare an Objective-C block taking
no arguments and returning no value (so of type void(^)()):
1. ^{ ... } or 2. ^() { ... }.

The syntax 1. appears to be the most popular in the codebase
with at the time of writing 11643 references while 2. only
had 58.

Conversion was automated with the following command:

    sed -i '' -e 's/\^ *() *{/^{/' $(git grep -l '\^ *() *{')

Bug: none
Change-Id: I2c799e1931c8d87352040bc91d56a8368b17cb89
Reviewed-on: https://chromium-review.googlesource.com/1022713Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552512}

This avoids many extra Save/Transform(identity)/../Restore,
Save/../Restore without transform. Also simplifies
Save/ClipRect/Transform(identity)/Save/ClipRect/Transform/../Restore/Restore
to Save/ClipRect(combined)/Transform/../Restore.

This especially fixes the performance regression of perf tests containing
svg images.

https://pinpoint-dot-chromeperf.appspot.com/results2/16c651cec40000
shows 18% improvement of frame_time of
tough_canvas_cases/rendering_throughput/bouncing_svg_images.html.

Bug: 823452
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4576646cbe9c59bc8a7f56b67ef59f2ad57f159d
Reviewed-on: https://chromium-review.googlesource.com/1020152
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552511}

AshAssistantController needs to be cleaned up while there is still a
valid Shell instance.

Will do follow up CL to add unit tests.

Bug: 835410
Change-Id: I44edcb86e224cb6ade956db564228eb66d5bad83
Reviewed-on: https://chromium-review.googlesource.com/1022528Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#552510}

+ Histogram of settings enabled state
+ Histogram of user preference enabled state
+ User action on clicking the preference

Bug: 832914
Change-Id: Icc266929cf66fc1593bfd5f1ed3188dbcd4e7c1b
Reviewed-on: https://chromium-review.googlesource.com/1015761
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552509}

Moved the leveldb::Env from the FileSystemOptions to the FileSystemContext
class. With this change the FileSystemContext owns the Env and is
responsible for deleting it when no longer needed.

This is the first of two changes to eliminate this memory leak. The second
change is to ensure that FileSystemContext is kept alive until it's
backends are deleted which ensures the Env is no longer used and can be
deleted.

Bug: 823854
Change-Id: Ic2cfc71683e85110774fde91ce0973cd93dd970e
Reviewed-on: https://chromium-review.googlesource.com/971941
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552508}

This is a reland of e88248f6

The original CL makes a test flaky. (crbug.com/835242)

The detailed failure reason is, in the refactored code, saving the
wallpaper file does not (and should not) block the response to the
wallpaper picker renderer, so the test fails when the file saving
operation hasn't completed. Since the CL moved the implementation
to //ash, that test should ideally be deleted since //ash already
has the same test coverage.

Original change's description:
> mash: Remove //ash dependency in wallpaper_private_api.cc
>
> We need this because:
> 1) Mustash requires all //ash dependency except //ash/public to be
>    removed from //chrome.
> 2) Currently saving and retrieving online wallpapers are handled
>    separately in //chrome and //ash, and it has duplicate logic in the
>    path calculation.
> 3) Currently wallpaper_private_api.cc is responsible for saving online
>    wallpapers, so it defeats the goal of making wallpaper paths
>    internal to //ash.
>
> Also fixed a bug: on Linux build, online wallpaper is lost at login
> screen.
>
> Bug: 827062
> Change-Id: I0d3ea5daf537db6e189c7a8b2ede469521e9dcbf
> Reviewed-on: https://chromium-review.googlesource.com/1013211
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552244}

TBR=xdai@chromium.org, sammc@chromium.org

Bug: 827062
Change-Id: I6cef49c2f17048e8412e1006088ab1ccb32c2f9b
Reviewed-on: https://chromium-review.googlesource.com/1022431Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552507}

If a page does not have any favicon, do not try to fetch an icon from
large icon bridge and wait for callback to update the notification icon.
We know if the page has favicon or not by tracking if onFaviconUpdated
was ever called.

BUG=827602

Change-Id: I3356470ca7088871540360621ee3140a3304621b
Reviewed-on: https://chromium-review.googlesource.com/1000314Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552506}

Get started tutorial code snippet was causing an error.
This update corrects this issue on tutorial page and completed file.

Bug: 834614
Change-Id: Ia3d61ef1510383b3b278ac957deeab047142fcd9
Reviewed-on: https://chromium-review.googlesource.com/1022950Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552505}

Factor out "https://www.example.org/foo.dat" to a file scope constant in
spdy_network_transaction_unittest.cc.

Change-Id: I1fdb9d848d8213f8b3aa48e546370441e3d2e166
Reviewed-on: https://chromium-review.googlesource.com/1022293
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552504}

Bug: 731555
Change-Id: I89002781928761b392645153658f90fb9f6f4ba9
Reviewed-on: https://chromium-review.googlesource.com/1022117Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552503}

This reverts commit ac6125e4.

Reason for revert: This change completely broke ChromeDriver for users
who run multiple instances of ChromeDriver. The seed for the new
random number generator can easily lead to same seed used by multiple
processes.

Original change's description:
> RandUtil: Add Mersene Twister Enginer to thread's local storage to avoid
> the overhead associated with seeding the generator.
> 
> One can do ~18 M (~26 M) calls per second when using
> unifom_int_distribution on top of Mersene engine versus <1M (~ 8M) calls
> per second when using the current implementation on POSIX and Windows,
> respectively.
> 
> Note that these figures are obtained when the generator is seeded once,
> otherwise the figure obtained for the suggested implementation would
> be <1M (this is for POSIX, we don't have the figure for windows).
> To that end, we use thread's local storage to seed the generator once.
> 
> Change-Id: I628d2e0ab882a9703e52b4007d53fa5cf49d4d47
> Reviewed-on: https://chromium-review.googlesource.com/982115
> Commit-Queue: Farah Charab <farahcharab@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550496}

TBR=gab@chromium.org,altimin@chromium.org,farahcharab@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I999423e955aa163c3863297ea9c81575a2ce8066
Reviewed-on: https://chromium-review.googlesource.com/1022250Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552502}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/263de54c..6b76faea

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: If710e264a4a418e26980fbda2011728cd810adff
Reviewed-on: https://chromium-review.googlesource.com/1021912Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552501}

Bug: 824834
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia1ad9ddf170cd3b20f735d04074b3101023a3d05
Reviewed-on: https://chromium-review.googlesource.com/1021681
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552500}

The old code was reaching into ash to get the shelf alignment. This
won't work with out-of-process ash (see //ash/README.md). Convert to
using ash/public/cpp and profile pref.

This enables the first run browser_tests under mash.

Bug: 770866, 756057
Test: browser_tests --enable-features=Mash
Change-Id: I43b202ef255301f637593e24a588a42bacdc7fff
Reviewed-on: https://chromium-review.googlesource.com/1022523Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552499}

Bug: 835388
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I85a4f50b315dc37769d762a2de2d6e5f15a33261
Reviewed-on: https://chromium-review.googlesource.com/1022390
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552498}

This CL adds four new metrics:
 - Logs an isolated/non-isolated bit per request
 - Logs real-delay per request
 - Logs the expected delay per request
 - Logs the queueing (i.e. unexpected) delay per request

Bug: 829042
Change-Id: Id31f3e062cda0f9b644466eb06be21b471a80d4e
Reviewed-on: https://chromium-review.googlesource.com/1021913Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552497}