GitLab

It was added as a part of this patch
https://chromiumcodereview.appspot.com/24078024

Review URL: https://codereview.chromium.org/598643002

Cr-Commit-Position: refs/heads/master@{#296225}

DCHECK(!channels_[name]) adds NULL channel with |name| into the
map, which was breaking DCHECK in JingleSession destructor. Replaced
with another DCHECK that doesn't have side-effects. Added unittest
to catch this problem.
Also removed no-op line from ~JingleSession().

Review URL: https://codereview.chromium.org/594743002

Cr-Commit-Position: refs/heads/master@{#296224}

Add histogram "Network.Shill.DeviceRemovedEvent" for tracking device
removed events per device (technology) type.

Add histogram "Network.Shill.Cellular.DevicePresenceStatus",
"Network.Shill.Ethernet.DevicePresenceStatus",
"Network.Shill.Wifi.DevicePresenceStatus", and
"Network.Shill.Wimax.DevicePresenceStatus" for tracking the presence
of each network device in the system. The presence status is emitted once
every 3 minutes for each device type.

While here, update the value definitions for NetworkServiceError enum to
match the definitions used in Shill. Also correct the histogram name for
WiMax related histograms.

BUG=chromium:411512, chromium:411510, chromium:402202

Review URL: https://codereview.chromium.org/589233003

Cr-Commit-Position: refs/heads/master@{#296223}

This will hopefully clear up the failure on the Windows GPU bots.

BUG=416719

Review URL: https://codereview.chromium.org/595933002

Cr-Commit-Position: refs/heads/master@{#296222}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d39c191..cd523eb

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/595983002

Cr-Commit-Position: refs/heads/master@{#296221}

BUG=none
TBR=ajwong@chromium.org

Review URL: https://codereview.chromium.org/601483003

Cr-Commit-Position: refs/heads/master@{#296220}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f704a8d..562c87e

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/598613002

Cr-Commit-Position: refs/heads/master@{#296219}

Now that selection bounds are routed through the compositor, enable the feature
in Blink and hook the CompositorFrameMetadata-carried bounds into the existing
selection handle pipeline.  Also suppress the sending of
ViewHostMsg_SelectionBoundsChanged messages when the feature is enabled.

This patch depends directly on
https://codereview.chromium.org/454643002/.

BUG=135959

Review URL: https://codereview.chromium.org/359033002

Cr-Commit-Position: refs/heads/master@{#296218}

Based on keyboard layout for opened and closed streams, keep count of those containing keyboard mic. Activate mic for first such stream, inactivate when last one is closed.

BUG=345296

Review URL: https://codereview.chromium.org/599443003

Cr-Commit-Position: refs/heads/master@{#296217}

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/557833006

Cr-Commit-Position: refs/heads/master@{#296216}

BUG=none
TBR=awong

Review URL: https://codereview.chromium.org/598453005

Cr-Commit-Position: refs/heads/master@{#296215}

For now, this allows only a very limited set.  Also describes the process we're
going to follow to allow more features.  The idea is that we're gradually going
to allow more features over time.

Also included is the source of a tiny appengine app running at
chromium-cpp.appspot.com that will show the contents of the document in this
CL once it's submitted.

BUG=360096
NOTRY=true
R=ben@chromium.org, inferno@chromium.org, jamesr@chromium.org

Review URL: https://codereview.chromium.org/589413003

Cr-Commit-Position: refs/heads/master@{#296214}

BUG=None
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/596493002

Cr-Commit-Position: refs/heads/master@{#296213}

BUG=414363
R=jln@chromium.org

Review URL: https://codereview.chromium.org/588143007

Cr-Commit-Position: refs/heads/master@{#296212}

net: another batch of HSTS updates.
Cr-Commit-Position: refs/heads/master@{#296211}

BUG=410946
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/594283002

Cr-Commit-Position: refs/heads/master@{#296210}

BUG=414233

Review URL: https://codereview.chromium.org/545973003

Cr-Commit-Position: refs/heads/master@{#296209}

Note: thie will also change the name of some of our
raster_worker_pool_* performance tests.

BUG=
R=vmpstr@chromium.org

Review URL: https://codereview.chromium.org/584393003

Cr-Commit-Position: refs/heads/master@{#296208}

Split the Perl script into 2 and shard the actual checking, so we can
run it in parallel. On bots, this reduces the time needed to complete
"check licenses" step from 3-4 mins to 40 seconds!

I'm planning to rewrite the scanner in Python soon, but I see that this
change can already help running trybots faster.

BUG=416496

Review URL: https://codereview.chromium.org/589143002

Cr-Commit-Position: refs/heads/master@{#296207}

Becuase base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250

Review URL: https://codereview.chromium.org/593033002

Cr-Commit-Position: refs/heads/master@{#296206}

A valid scenario, observed in the wild, is a touchstart handler removing
itself and adding a touchmove handler. If those are the only touch
handlers on the document, the renderer will forward two distinct handler
existence notifications to the browser. This causes the TouchEventQueue
to effectively drop the remainder of the touch sequence, even though the
element targetted by the touchstart now has a touchmove.

Fix this scenario by making the TouchEventQueue effectively idempotent
to repeated addition and removal of touch handlers. In practice, this
means simplifying its statefulness and instead relying on the existing
pointer id state map to determine whether to forward touches for the
remainder of the sequence.

BUG=412723

Review URL: https://codereview.chromium.org/586553002

Cr-Commit-Position: refs/heads/master@{#296205}

BUG=415838
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/597593002

Cr-Commit-Position: refs/heads/master@{#296204}

BUG=371012

Review URL: https://codereview.chromium.org/575283005

Cr-Commit-Position: refs/heads/master@{#296203}

This removes the rest of guava from a chromium checkout.

It also removes a workaround in build/android/gyp/javac.py
which sorts input files for javac. The issue was fixed in guava 14
(https://code.google.com/p/guava-libraries/issues/detail?id=950),
but it was never rolled in to chromium.

The last remaining files in third_party/guava are left because
some bots do not delete non-existing DEPS. COPYING is a copy of the
current version of the COPYING file from the guava repository.
See http://crbug.com/380688 for details about the DEPS issue.

BUG=412673

Review URL: https://codereview.chromium.org/574103002

Cr-Commit-Position: refs/heads/master@{#296202}

This CL adds two initial tests that use mock URLRequestJob to
intercept URL requests.

BUG=415781

Review URL: https://codereview.chromium.org/558333007

Cr-Commit-Position: refs/heads/master@{#296201}

This CL links libsanitizer_options into every executable built with ASan on OSX.
The existing implementation of __asan_default_options for Chromium.app is merged
with that in sanitizer_options.cc

Also now use_sanitizer_options is only set when building with sanitizers so that
there isn't an unconditional dependency on an empty object file in every
executable in non-sanitizer builds.

In addition to that, the dependency on sanitizers.gyp:sanitizer_options is removed
from ui/base/ui_base_tests.gyp:ui_base_tests_bundle which is not a real shared lib,
despite marked as such.

BUG=302040
TBR=earthdok@chromium.org,cpu@chromium.org
R=avi@chromium.org

Review URL: https://codereview.chromium.org/594843002

Cr-Commit-Position: refs/heads/master@{#296200}

"Add New User" screen should have enabled all hardware
keyboards, owner and system input methods.

BUG=365299
TEST=manual

Review URL: https://codereview.chromium.org/484353005

Cr-Commit-Position: refs/heads/master@{#296199}

BUG=404089

Review URL: https://codereview.chromium.org/571623003

Cr-Commit-Position: refs/heads/master@{#296198}

BUG=none

Review URL: https://codereview.chromium.org/592413002

Cr-Commit-Position: refs/heads/master@{#296197}

BUG=0
NOTRY=true

Review URL: https://codereview.chromium.org/589353002

Cr-Commit-Position: refs/heads/master@{#296196}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/63c0786..f704a8d

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/598593002

Cr-Commit-Position: refs/heads/master@{#296195}

This CL adds an app_shell_browsertest to verify the existence of the webview API.

BUG=352290

Review URL: https://codereview.chromium.org/581283002

Cr-Commit-Position: refs/heads/master@{#296194}

While setting up the scrollbar layer if the properties of the scrollbar
layer didn't change, then avoid setting update_draw_properties.
Scrollbar needs animation if any of the scrollbar properties changed.
In the same way set update_draw_properties if scrollbar properties
are changed.

Review URL: https://codereview.chromium.org/595913002

Cr-Commit-Position: refs/heads/master@{#296193}

Reusing the "base::StringPairs" insted of  "std::vector<std::pair<std::string, std::string> >"
same is defined in  base/strings/string_split.h.

BUG=412250

Review URL: https://codereview.chromium.org/591313004

Cr-Commit-Position: refs/heads/master@{#296192}

Revert of Fix the way how we create webrtc::AudioProcessing in Chrome (patchset #5 id:100001 of https://codereview.chromium.org/588523002/)

Reason for revert:
It broke some internal webrtc bots, revert it for now and will reland it after fixing the problems.

http://chromegw.corp.google.com/i/internal.chromium.webrtc/builders/Mac%20Tester/builds/22092

Original issue's description:
> Fix the way how we create webrtc::AudioProcessing in Chrome.
>
> BUG=415935
> TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist.
>
> Committed: https://crrev.com/a5e9fc62b7bf25931ffe6153cc738098d8119c28
> Cr-Commit-Position: refs/heads/master@{#295990}

TBR=tommi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=415935

Review URL: https://codereview.chromium.org/594883002

Cr-Commit-Position: refs/heads/master@{#296191}

Controlled with Variations parameter "hide_promo_header" which should be set to "enabled" for the image to be hidden

BUG=413337
TBR=jhawkins

Review URL: https://codereview.chromium.org/587803003

Cr-Commit-Position: refs/heads/master@{#296190}

BUG=414794

Review URL: https://codereview.chromium.org/591263002

Cr-Commit-Position: refs/heads/master@{#296189}

BUG=338303

Review URL: https://codereview.chromium.org/560523004

Cr-Commit-Position: refs/heads/master@{#296188}

This is particularly important on Mac, where unless we do this the Bookmarks/History
menu bar items will reflect the last active profile (which has now been locked).

On Windows this is a nice to have and to be consistent. Overall this adds an extra
layer of security that you won't accidentally open a locked profile's window.

BUG=412952

Review URL: https://codereview.chromium.org/585653002

Cr-Commit-Position: refs/heads/master@{#296187}

BUG=399456

Review URL: https://codereview.chromium.org/575213002

Cr-Commit-Position: refs/heads/master@{#296186}