GitLab

Remove unused empty SpdyFrameBuilder constructor.


Review URL: http://codereview.chromium.org/10053029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132428 0039d316-1c4b-4281-b951-d872f2087c98

That way, the action reruns if pkg-dmg (called from the
build_app_dmg shell script) is touched.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/10073026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132426 0039d316-1c4b-4281-b951-d872f2087c98

1.) Remove `set -x`
2.) Explicitly add '.dmg' extension to output, so pkg-dmg no longer
    warns about adding this implicitly
3.) Pass '--verbosity 0' to pkg-dmg to tell it to print only errors

If build_app_dmg needs to be debugged, it's easy to undo 1 and 3.
There's no need to have all this output on every single build.

BUG=none
TEST=`ninja all` has 38 lines less output.


Review URL: http://codereview.chromium.org/10073020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132424 0039d316-1c4b-4281-b951-d872f2087c98

This increased over 2% gradually over the last 950 revisions, without
clear culprit:
http://build.chromium.org/f/chromium/perf/xp-release-dual-core/intl2/report.html?history=950&rev=132408
Review URL: https://chromiumcodereview.appspot.com/10095019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132423 0039d316-1c4b-4281-b951-d872f2087c98

The save dialog, when viewed in the expanded mode, will show the 'Hide Extension'
checkbox with this change. This will apply to all save dialogs. Note that this
checkbox is only visible if Finder's 'Show all extensions' settings is turned
OFF.

I don't see any downside to having this checkbox available. Other apps that
appear to always enable this checkbox: Safari, Mail, TextEdit.

BUG=123118
TEST=Save a web-page, expand window, 'Hide Extension' checkbox should be visible.
Review URL: https://chromiumcodereview.appspot.com/10082016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132422 0039d316-1c4b-4281-b951-d872f2087c98

R=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10097001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132421 0039d316-1c4b-4281-b951-d872f2087c98

* Ash uses a taller content area shadow, so the toolbar needs to avoid taking mouse clicks along its top 2 pixels, as they overlap the tab strip.
* Added more GetClassName() implementations for views to help with future debugging.
* Removed an attempt to forward-declare an enum.

BUG=123354
TEST=manual, ensure that hovering mouse along the very bottom of a tab results in the hover-glow effect

Review URL: https://chromiumcodereview.appspot.com/10082029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132415 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122532
TEST=Log in with file /root/.forget_usernames, avatar is correctly set and does not change when locking.


Review URL: http://codereview.chromium.org/9972004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132414 0039d316-1c4b-4281-b951-d872f2087c98

Allow optional remote callback, then perform synchronous completion
if receiving data is enough small for SRPC buffer. Otherwise invoke
another callback for asynchronous completion from main thread.

BUG=87310
TEST=browser_tests --gtest_filter=PPAPINaclTest.WebSocket_StressedSendReceive

Review URL: https://chromiumcodereview.appspot.com/9802027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132413 0039d316-1c4b-4281-b951-d872f2087c98

R=dmaclach@chromium.org
BUG=108171


Review URL: http://codereview.chromium.org/10019016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132411 0039d316-1c4b-4281-b951-d872f2087c98

Remove the TabContents typedef.

BUG=105875
TEST=no change


Review URL: http://codereview.chromium.org/10082021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132410 0039d316-1c4b-4281-b951-d872f2087c98

This fixes RTL painting in the launcher.

BUG=112070
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10081037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132409 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114148
TEST=browser_tests --gtest_filter=ExtensionApiTest.FontSettings and ExtensionApiTest.Preference*, and manually

Review URL: http://codereview.chromium.org/10008076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132408 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104346
TEST=Steps to reproduce listed in the bug.


Review URL: http://codereview.chromium.org/10065028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132407 0039d316-1c4b-4281-b951-d872f2087c98

Updated comments.

BUG=105875
TEST=no change


Review URL: http://codereview.chromium.org/10073023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132406 0039d316-1c4b-4281-b951-d872f2087c98

This is necessary so that BrokerDuplicateHandle() can be used from
chrome/browser while passing the check_deps rules.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2719
TEST=build

Review URL: https://chromiumcodereview.appspot.com/10082018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132405 0039d316-1c4b-4281-b951-d872f2087c98

Fixing issues with alignment, undefined behaviour and endianness in the FieldTrial::HashName function. I also added new functions to base that convert from host order to little endian.

BUG=123230FieldTrialTest.HashName
TEST=FieldTrialTest.HashName


Review URL: http://codereview.chromium.org/10088001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132404 0039d316-1c4b-4281-b951-d872f2087c98

BUG=119798
TEST=Screen locker works on desktop builds.

Review URL: https://chromiumcodereview.appspot.com/10095002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132403 0039d316-1c4b-4281-b951-d872f2087c98

Fixed a memory leak in SpeechRecognitionManagerImpl causing ChromeSpeechInputManagerDelegate to be never freed.

BUG=123116,116954
TEST=Run Valgrind tests.

Review URL: https://chromiumcodereview.appspot.com/10071040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132401 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132400 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scheib@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10097008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132399 0039d316-1c4b-4281-b951-d872f2087c98

*) On DSE change, new provider is not pushed to Sync.
*) Simplified code in BrowserInit.


BUG=None
TEST=protector.py


Review URL: http://codereview.chromium.org/10065016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132398 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104998
TBR=oshima
Review URL: https://chromiumcodereview.appspot.com/10097012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132397 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=try bots still pass
TBR=zmo

Review URL: https://chromiumcodereview.appspot.com/10097010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132396 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132395 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scheib@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10096006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132394 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132393 0039d316-1c4b-4281-b951-d872f2087c98

BUG=121700
TEST=The generated ADMX templates don't have syntax problems.

Review URL: https://chromiumcodereview.appspot.com/10092007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132392 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132391 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scheib@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10095005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132390 0039d316-1c4b-4281-b951-d872f2087c98

Partial fix for crbug.com/120597. Send the current cursor location when one of the Japanese IMEs is enabled.

Without the fix, for example, the suggestion window could be shown in a wrong place in step #6 below:

1. switch to mozc, the Japanese IME.
2. press a, press Enter.
3. repeat step #2 several times so that 'あ' is suggested when a is pressed.
4. focus text area.
5. switch to US-Qwerty, type aaaaa
6. switch to mozc, type a. The suggestion window could be shown in a wrong position because cursor location information is not sent to the IME in step #5.

BUG=120597
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10066008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132389 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:29248
TEST=Manual test.

Review URL: https://chromiumcodereview.appspot.com/10001004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132386 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132385 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132383 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scheib@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10092005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132382 0039d316-1c4b-4281-b951-d872f2087c98

Cleans up some early-exit tests that duplicate checks in HostEventDispatcher, and which are verified in debug builds via DCHECKs.


Review URL: http://codereview.chromium.org/10093001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132381 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=BrowsingDataCookieHelperTest.Canned*

Review URL: https://chromiumcodereview.appspot.com/10084009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132380 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:29378
TEST=Cut 2 or more files. Paste them into another folder of the same volume.

Review URL: https://chromiumcodereview.appspot.com/9949069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132379 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132378 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scheib@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9972005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132377 0039d316-1c4b-4281-b951-d872f2087c98