GitLab

TBR=jchinlee@chromium.org

No-Try: True
Bug: 731365, 764174, 764174, 807149
Change-Id: I44dda43c2ead5edbe6801eb6fc11337ad05e399a
Reviewed-on: https://chromium-review.googlesource.com/1006264
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549687}

Prevents popup favicon and Developer Tools window Icon from being
rendered on top of the incognito badge. Drawing the icon next to the
incognito badge was also tested but looked weird (like double icons).

The favicon / Developer Tools icon is still the icon used in the
Windows window switcher and not the incognito badge.

Bug: chromium:829724
Change-Id: Ie850cec31d51e808ad718ba96e32eac6b0942158
Reviewed-on: https://chromium-review.googlesource.com/1003378Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549686}

This reverts commit 9638e4f4.

Reason for revert: Test suites fail to execute, breaking FYI

Original change's description:
> Fuchsia: remove "shell" capability and add dynamic libraries to packages.
> 
> Removing the "shell" capability allows packaged apps to load dynamic libraries
> from the package. In addition, it prevents the app from using any
> system-provided libraries, in favor of the package supplying all of its
> data and dynamic library dependencies.
> 
> This CL includes the system libraries from the SDK's "dist" directory in
> packages built using the package() GN template.
> 
> Bug: 823927
> Change-Id: I7c0eaef08765f8119bec9a67d381014d07ba4606
> Reviewed-on: https://chromium-review.googlesource.com/985474
> Reviewed-by: Wez <wez@chromium.org>
> Reviewed-by: James Robinson <jamesr@chromium.org>
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549641}

TBR=wez@chromium.org,jamesr@chromium.org,kmarshall@chromium.org

Change-Id: Id96067185552ed932590c73e87fc57050341dfa5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 823927
Reviewed-on: https://chromium-review.googlesource.com/1005741Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549685}

Unused but valid looking schemes are a bit confusing.

R=juliatuttle@chromium.org

Change-Id: If82be15a61bf768cc4fb9f5e496dc52f8ab14aea
Reviewed-on: https://chromium-review.googlesource.com/1001597
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549684}

This gets the highlighter type from the network UISourceCode, if it
exists. For overrides files with no extension, they will stay colorful
as long as they are bound.

Change-Id: I5f1ff41f54eabb7a7f1abf1aa27b19629529fbfd
Reviewed-on: https://chromium-review.googlesource.com/1003875
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549683}

With https://chromium-review.googlesource.com/997892, a task posted
via base::PostTaskWithTraitsAndReplyWithResult() can be deleted on the
sequence on which it was supposed to run if it can't run because of its
shutdown behavior.

The constructor of AddressNormalizerImpl uses
base::PostTaskWithTraitsAndReplyWithResult() to post a task to which
a ChromeStorageImpl is bound. If the task runs before shutdown, the
ChromeStorageImpl is returned to the main thread via the reply.
However, if the task doesn't run before shutdown starts, it is
deleted in the TaskScheduler thread pool (which also means that the
ChromeStorageImpl is deleted in the TaskScheduler thread pool).
An access race occurs when ~ChromeStorageImpl tries to remove itself
from the observer list of its WriteablePrefStore.

To fix this race, this CL uses base::OnTaskRunnerDeleter() to
ensure that the deletion of ChromeStorageImpl occurs on the right
sequence.

Bug: 829122
Change-Id: I75ba8eab4a884b0f1ac5e571eaaab18f63599d6b
Reviewed-on: https://chromium-review.googlesource.com/1005915Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549682}

ImplicitWaitTest class tests started to fail on Android Chromium build bot.
Disabling all tests for this class.

Bug: chromedriver:2376
Change-Id: I0691b82fc269b4974d31ffcaabd3251858cd8444
Reviewed-on: https://chromium-review.googlesource.com/1003525Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549681}

s/UseCounter.cpp/use_counter.cc/

Change-Id: I5d079595a3e28de098547d12636dd8f4a8167ffa
Reviewed-on: https://chromium-review.googlesource.com/1006039
Commit-Queue: Luna Lu <loonybear@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549680}

But with a fallback, since it's sometimes necessary.

Bug: 828886
Change-Id: I5ca1a6a6377667f2b950a209310230e8031e6043
Reviewed-on: https://chromium-review.googlesource.com/999155Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549679}

Declaring move constructors and assignment operators noexcept
allows STL containers to use moves instead of copies, which is
generally more efficient.

Previously, there were compiler issues that prevented this from
working [1]. They seem to have mysteriously fixed themselves
and testing on https://godbolt.org/g/TqfqtK seems to indicate that
the previously highlighted problematic test cases now work.

[1] https://groups.google.com/a/chromium.org/forum/#!topic/cxx/ze4WJFg7RvU

Bug: 706963
Change-Id: Ieb73b4c53ab4235838265f1d968d2a57aa34a737
Reviewed-on: https://chromium-review.googlesource.com/1003872Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549678}

Update V4UpdateProtocolManager, V4GetHashProtocolManager and V4LocalDatabaseManager to use SimpleURLLoader.

Also add a SharedURLLoaderFactory getter on SafeBrowsingService for IO thread users.

Bug: 825242
Change-Id: Ib41699d932469b4bb92130103b5257509d6b2a36
Reviewed-on: https://chromium-review.googlesource.com/1002473Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549677}

The immediate issue this CL tries to fix is crbug.com/830629, which is
fixed by using mac_chromium_rel_ng instead of mac10.12_blink_rel for
rebaselining on Mac 10.12. After crbug.com/818301, the remaining
*_blink_rel bots need to be replaced as well.

(NOTE: mac_chromium_rel_ng is planned to be upgraded to 10.13 soon.
When that happens, mac_chromium_10.12_rel_ng should be used for 10.12.
We are using mac_chromium_rel_ng for now only because of capacity
issues of mac_chromium_10.12_rel_ng.)

Meanwhile, we take this chance to add support for LUCI Buildbucket as
Buildbot (and its "master" concept) is being deprecated. Buildbuckets
for each bot can now be specified in builders.json. The special
treatment for android_blink_rel is also moved into builders.json to
reduce the amount of magic in the code.

Bug: 830629
Change-Id: I4c1777f93ff63ccd7bc35abaaea435eafd19e18c
Reviewed-on: https://chromium-review.googlesource.com/1003132
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549676}

Cast dialog was enabled behind a flag in VR. It was a mistake since,
the same flag is used to enable some other popups. We should enable
cast icon once we VR can support this dilog.

Bug: 822090
Change-Id: I6c414f85d7b24a0f5dfaea4d37d541268abb4556
Reviewed-on: https://chromium-review.googlesource.com/1006037Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549675}

Handle errors that occur before downloading, including the name being
repeated/too long, the location being missing/full, etc. Some of the
changes include:

- Creating DownloadsLocationDialogType to indicate which type of error-
handling dialog to display.
- Re-routing DownloadTargetDeterminer to loop back and double check in
the case that it was a user-confirmed "new" filename/location.

Screenshots:
Rename workflow:
https://drive.google.com/file/d/1S4Pw8zXy-uZvotx3L8eNZgl2QMzaETfX/view

Not enough space option:
https://drive.google.com/file/d/1JiCVo5K4kEcGVtZQhdJ4sSrqEQNagdgB/view

Bug: 792775, 825929
Change-Id: Ic981343eede2b10a84d383ad429f5ddcbccfd38c
Reviewed-on: https://chromium-review.googlesource.com/982530
Commit-Queue: Joy Ming <jming@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549674}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/39414498..42f2c717

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I286d3362a8cc93153b3c2400f751159cabafaa42
Reviewed-on: https://chromium-review.googlesource.com/1005575Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549673}

Clarify that groups only have features automagically associated with them if
they don't directly specify *any* associated features. The comment was
previously worded for a single feature, and got only partially updated.

R=asvitkine@chromium.org

Bug: None
Change-Id: I6cd7e79fb78112c990a5f9ed6d4ca0d59531f159
Reviewed-on: https://chromium-review.googlesource.com/1005798
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549672}

Now that CDMs use mojo exclusively, remove the Pepper APIs that are
now unused.

BUG=772160
TEST=compiles

Change-Id: I4161d7430f86f5033dd7997fb5f2cc4a04aefa22
Reviewed-on: https://chromium-review.googlesource.com/988254Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ben Smith <binji@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549671}

ExtensionStorageMonitor.

Bug: 793887
Change-Id: I877a8734b419054da94b307bab5389bada8aab62
Reviewed-on: https://chromium-review.googlesource.com/1000114
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549670}

R=piman
CC=zmo
BUG=794735

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I3919d0e62ed445ae1f254c4b106df721e2139d32
Reviewed-on: https://chromium-review.googlesource.com/1004001Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549669}

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/f34a90b21090..272be0ac4cae

$ git log f34a90b21..272be0ac4 --date=short --no-merges --format='%ad %ae %s'
2018-04-10 jcivelli Make OWNERS file not reference outside of this repo

Created with:
  roll-dep src/third_party/ffmpeg

Bug: 831242
Change-Id: I89e269c3b6db30de1318b70bfdc0ae84fcdf1f70
Reviewed-on: https://chromium-review.googlesource.com/1005630Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549668}

Supersize-archive requires one of '--apk-file', '--elf-file', or
'--map-file' followed by filename. To simplify command-line interface
for testing, this CL adds '-f' switch, which automatically identifies
a given file (relies on external program 'file') to fit one of the
above switches,

Change-Id: I3806e27a8dbd5c260c1bda54339cef8ce9ae2f1d
Reviewed-on: https://chromium-review.googlesource.com/1005729Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549667}

Remove the the elipses in "Uninstall..." which is used in
app context menus.

Bug: 826410
Change-Id: Ia6a925b23314ac7ce72985414216a8a646c7b378
Reviewed-on: https://chromium-review.googlesource.com/1003375Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549666}

Make BindingManagerImpl only be responsible for the LRU queue of
connections and the corresponding moderate binding ref count.
Lift up controls of all other bindings to ChildProcessLauncherHelper.

More concretely, remove ManagedConnection and merged ModerateBindingPool
directly into BindingManagerImpl. Moved the logic of whether moderate
binding management is enabled to ChildProcessLauncherHelper as well.

This is not a totally no-op refactor:
* Visibility signals now work on "always foreground", ie non-sandboxed,
  connections. This makes non-sandboxed connections less special. Note
  this has no practical difference since non-renderer processes
  do not have priorities set currently.
* Connection with strong binding can remain in LRU queue. This is just a
  consequence of making these two systems independent.
* The "use" signal, in the LRU sense, is now when a connection gains
  strong binding only. Previously a connection is marked as most recent
  when strong or initial binding is dropped, which doesn't make much
  sense.

For tests, essentially deleted a lot of tests that explicitly check
binding state, and at the same time breaks layering.

One clean up not yet done to make review easier is that the
BindingManager interface can now be removed.

Bug: 689758
Change-Id: I32489a809bee944fbe26f34ca1de06b4e65c310e
Reviewed-on: https://chromium-review.googlesource.com/642058
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549665}

Bug: 829119

Change-Id: I8808486a29691cf0881864be000485322e5c2034
Reviewed-on: https://chromium-review.googlesource.com/996554
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549664}

- Disable ProcessUtilTest.LaunchWithHandleTransfer under Debug builds,
  since launching the child process is currently too time consuming.
- Modifies that test to distinguish the child process failing to send
  data from the timeout case.
- Disable SecurityTest.NewOverflow, which fails under Fuchsia/Debug
  builds due to the SDK exporting the wrong new[].
- Disable RTCRtpSenderTest.GetStats, which is part of a suite of tests
  which appear to be inherently flaky, but fail most often under Fuchsia.
- Filter DataPipeTest.SendConsumerAndCloseProducer

Bug: 793412, 828229, 827450, 831024
Change-Id: Icb655ca91881c3ff7059f333f0e22d9bf2d92468
Reviewed-on: https://chromium-review.googlesource.com/1003996Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549663}

A small bit of cleanup work following on
https://chromium-review.googlesource.com/c/chromium/src/+/949052

Change-Id: I52da7165e2c8f7edc664cbd025cbbcbdaccd7252
Reviewed-on: https://chromium-review.googlesource.com/1000332
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549662}

See Bug for discussions on the new text.

Note that I am not adding a trailing dot/period to the new text because
even if I do, it'll be stripped and not showing up in the actual
permission prompt.

Bug: 721969
Test: Manually tested and inspected the new prompt.
Change-Id: I609512b11991354bdb8954f3e63c6ac157f17927
Reviewed-on: https://chromium-review.googlesource.com/996769Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549661}

BUG=813926

Change-Id: I896cd3f83c41202b0f97e5acfec0ee875c4bd065
Reviewed-on: https://chromium-review.googlesource.com/1005909Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549660}

This change cleans up the remaining tests in http/tests/w3c/ directory in
preparation to delete it. It moves some tests to external/wpt and removes other
tests, which are duplicates:
* test_user_timing_entry_type.html is duplicated by entry_type.any.js
* test_user_timing_mark_exception.html duplicated by mark_exceptions.html
* test_user_timing_method_exist.html is duplicated by user_timing_exists.any.js

Bug: 498037
Change-Id: I1ba43eba81ed0a5d9e1e1a79aef11b9904556f69
Reviewed-on: https://chromium-review.googlesource.com/1002736Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549659}

Adding a histogram to track how the user got into XR Presentation.

Bug: 808589
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iad597f74fe22afac5709ebee1525c0b342cc24a4
Reviewed-on: https://chromium-review.googlesource.com/999019
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549658}

This extends [Affects=Nothing] to mark attributes/accessors with
getter callbacks that produce no JS-observable side effect. This also
marks Node's isConnectedAttributeGetter as side-effect-free.

Bug: 829571
Change-Id: I21211b477a95e51e10cade1ffbd0249171684d1c
Reviewed-on: https://chromium-review.googlesource.com/999304
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549657}

This allows us to avoid a preload=metadata suspend if we know playback
would start once we reach the HaveEnoughData state. There are still
cases where the play() call might come in after Start(), but this
should capture a significant chunk.

In order to test this change, I've built up significant infrastructure
inside HTMLMediaElementTest and WebMediaPlayerImplTest. The WMPI test
can now fully start the media pipeline and execute up to the metadata
state. This is sufficient for testing this feature and an improvement
to the state of our existing WMPI tests.

Note: Extending the WMPI tests required fixing up instances of const&
base::TimeDelta usage by the MediaPlayerManager interfaces to avoid
presubmit errors.

BUG=827396
TEST=new unittests.

Change-Id: I8b5c3dea1ecc3e3b519e2b26bfc45b9d9204fb81
Reviewed-on: https://chromium-review.googlesource.com/996632
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549656}

Bug: 829119
Change-Id: I6b85f4776e54fdc3f5cc036cfe46b6ef53e250b1
Reviewed-on: https://chromium-review.googlesource.com/1000518Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549655}

The goal of this CL is to break down the TimeToReadyToCommit metric into
cases where we perform cross-process navigation vs same-process one. This
will allow us to analyze whether regressions are due to change of process
or potentially other differences in code.

Bug: 808114
Change-Id: Ic98c2f9f5b7a6a21ee44e34bc8668af61e4a0f9e
Reviewed-on: https://chromium-review.googlesource.com/1003290Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549654}

Bug: 830909, 756447, 829125, 829141
Change-Id: Iaf467fbe9cf2c836bfcd761d558c3f7c0e7379a8
Reviewed-on: https://chromium-review.googlesource.com/1003281Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549653}

This reverts commit a9d4f347.

We verified that high-volume kills reported in https://crbug.com/831082
go away after reverting.  Simple repro that would have resulted in a
renderer kill before the revert:

    $ out/rel/chrome --disable-features=NavigationMojoResponse \
    --user-data-dir=$HOME/.chrome-kill-x1 --site-per-process \
    http://chromium.org

Bug: 831082
Change-Id: Ibbb9b08862e4c611c7d8bd139b96970edbebf460
Tbr: kinuko@chromium.org
Tbr: clamy@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1005792
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549652}

This CL adds some unit tests for search_suggestion_parser which
previously had none. This set of tests can be expanded upon, this is
just a start.

Bug: None
Change-Id: I445865beee434674e2d11c3d3cb9e708d19336ff
Reviewed-on: https://chromium-review.googlesource.com/999297
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549651}

Creating histograms for roam complete for FT and non-FT networks and for
PSK and 802.1X authentication. This is a success metrics to show roaming
reliability improvements from FT. Histograms are implemented in
CL:957442.

Bug: 791202
Change-Id: Ia9174e6239804187bd5c16445de6f6229f3e55a3
Reviewed-on: https://chromium-review.googlesource.com/972591
Commit-Queue: Matthew Wang <matthewmwang@chromium.org>
Reviewed-by: Kevin Cernekee <cernekee@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549650}

This CL fixes a bug introduced during the refactoring of
ArcNavigationThrottle to AppsNavigationThrottle where the intent picker
could be shown multiple times during a redirect chain. If the user has
ARC apps installed which handle all URLs (e.g. Chrome Beta/Chrome Dev),
we could get into a situation where we show the intent picker but
reset our internal state to be not showing.

The fix is to only set the internal |ui_displayed_| state to false if
the apps list sent back to AppsNavigationThrottle is empty.

BUG=824598

Change-Id: I990d00d90665d362ee9e894ad71a71454e78ebea
Reviewed-on: https://chromium-review.googlesource.com/1003812Reviewed-by: David Jacobo <djacobo@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549649}

Handle iTunes bundle URLs regularly, instead of launching storekit for
them. The reason is StoreKit view controller doesn't present bundles
correctly.

Bug: 829302
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idcd6fd1ef42fd48550b589330ec3191484619a2b
Reviewed-on: https://chromium-review.googlesource.com/1005443Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549648}