GitLab

BUG=none

Review URL: https://chromiumcodereview.appspot.com/15650013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202456 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/12381081 added UMA histograms for the web
history but no entries were added to the histograms.xml file.

This CL fixes that.

R=isherman@chromium.org
BUG=177073

Review URL: https://chromiumcodereview.appspot.com/15821006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202455 0039d316-1c4b-4281-b951-d872f2087c98

This CL split global_usage_ into global_limited_usage_
 and global_unlimited_usage_ to prepare for adding GetGlobalLimitedUsage.

BUG=220029
TEST=no functional change, should not break existing tests

Review URL: https://chromiumcodereview.appspot.com/16067003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202454 0039d316-1c4b-4281-b951-d872f2087c98

This flag will protect the refactoring work for the pinch virtual viewport.

TBR=cevans@chromium.org
BUG=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15567005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202453 0039d316-1c4b-4281-b951-d872f2087c98

These objects are created on the UI thread but some of them are passed to the
FILE thread, which may old the last reference. This was caught by the in_dtor_
check.

Since they live across threads then they must be RefCountedThreadSafe.

BUG=None
R=bartfab@chromium.org

Review URL: https://codereview.chromium.org/16058005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202452 0039d316-1c4b-4281-b951-d872f2087c98

We should consider empty input method id is passed.
To handle correctly, we should handle fallback handling before pending input method.

BUG=241492
TEST=ran all unit tests/browser tests/chromeos_unitests

Review URL: https://chromiumcodereview.appspot.com/15959004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202451 0039d316-1c4b-4281-b951-d872f2087c98

This CL extracts the GetResolveFile into an operation class, with simplifying
the implementation by merging consecutive accesses to the metadata and cache
into a function.

BUG=242084
TEST=Ran unit_tests

Review URL: https://chromiumcodereview.appspot.com/15681009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202450 0039d316-1c4b-4281-b951-d872f2087c98

It seems ca(multix) is good rather than ca(multi) based on compatibility with
Windows.
With this patch, ca(multi) user will be fallbacked to "us" but I won't add
migration code for this, ca(multi) is only available on Canary.

BUG=240980
TEST=None

Review URL: https://chromiumcodereview.appspot.com/15938003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202449 0039d316-1c4b-4281-b951-d872f2087c98

Sorry for this regression, DeleteSurroundingText can't be used on actual device due to forgetting connecting signal.

BUG=None
TEST=Manually checked on link

Review URL: https://chromiumcodereview.appspot.com/15971003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244232
R=nkostylev@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16109002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202447 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves the setting and removal of the ThreadIdNameMapping into the ThreadFunc methods. This removes any potential race conditions around thread name removal as the thread will be live during both addition and removal.

BUG=238371

Review URL: https://chromiumcodereview.appspot.com/14634009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202446 0039d316-1c4b-4281-b951-d872f2087c98

This handles the "storage.managed_schema" manifest key, and validates the
schema when this key is present. The schema is then published in the descriptor
of the extensions' policy namespace.

BUG=108992

Review URL: https://chromiumcodereview.appspot.com/14587009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202445 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244257
TBR=bruening
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15780007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202444 0039d316-1c4b-4281-b951-d872f2087c98

> Translate: adopt html lang attribute if valid value is provided
> 
> Language decision is made by heuristics using Content-Language and CLD
> determined language. This change adds html lang attribute, e.g.,
> <html lang="ja">, as a third hint for language decision.
> Content-Language is often invalid due to invalid server configuration.
> On the other hand, lang attribute is provided by pages, or authoring
> tools or authors themselves. As a result, they are more reliable than
> Content-Language. With this change, language decision uses html lang
> attribute instead of Content-Language if valid value is provided.
> Other dicision process is not changed at all.
> 
> BUG=222073
> TEST=unit_tests, browser_tests
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201856
> 
> Review URL: https://chromiumcodereview.appspot.com/15728002

TBR=toyoshim@chromium.org

Review URL: https://codereview.chromium.org/16045007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202443 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202436 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151181:151189&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/15989007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202435 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128314
R=mark@chromium.org

Review URL: https://codereview.chromium.org/15722004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202433 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202432 0039d316-1c4b-4281-b951-d872f2087c98

Remove systemInfo.cpu and systemInfo.storage from extensions
template and add systemInfo.display template.

TBR=kalman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12297011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202430 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16101002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202429 0039d316-1c4b-4281-b951-d872f2087c98

Language decision is made by heuristics using Content-Language and CLD
determined language. This change adds html lang attribute, e.g.,
<html lang="ja">, as a third hint for language decision.
Content-Language is often invalid due to invalid server configuration.
On the other hand, lang attribute is provided by pages, or authoring
tools or authors themselves. As a result, they are more reliable than
Content-Language. With this change, language decision uses html lang
attribute instead of Content-Language if valid value is provided.
Other dicision process is not changed at all.

BUG=222073
TEST=unit_tests, browser_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201856

Review URL: https://chromiumcodereview.appspot.com/15728002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202427 0039d316-1c4b-4281-b951-d872f2087c98

BUG=229829

Review URL: https://chromiumcodereview.appspot.com/15875005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202426 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nkostylev@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16104006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202425 0039d316-1c4b-4281-b951-d872f2087c98

Please note that this supports INFO, WARNING, ERROR. I have yet to add support for DVLOG levels.

BUG=241689
TEST=chrome/browser/sync_file_system/logger_unittest.cc
unit_tests.LoggerTest*

Review URL: https://chromiumcodereview.appspot.com/15657002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202424 0039d316-1c4b-4281-b951-d872f2087c98

As of Clang r182645 -fsanitize=address implies -lrt, but until that revision is rolled some binaries (e.g. symupload) need an explicit dependency.

BUG=234010
TBR=thakis

Review URL: https://chromiumcodereview.appspot.com/16090004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202423 0039d316-1c4b-4281-b951-d872f2087c98

Also, hopefully improve the buffering behaviour, see
BUG=163314

NOTRY=true
R=glider@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16103005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202422 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=uma.googleplex.com gains a user action entry from Accel_Exit_First_Q and Accel_Exit_Second_Q
R=sschmitz@chromium.org
TBR=sschmitz@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15841006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202421 0039d316-1c4b-4281-b951-d872f2087c98

swap the renderer_ reference to local before calling Stop(), otherwise we will invalidate the pointer during the Stop() call.

The problem that this CL is trying to fix:
In WebRtcAudioDeviceImpl::Terminate(), when the renderer_ is valid and we call renderer_->Stop(), this Stop() function will trigger a callback till WebRtcAudioDeviceImpl::RemoveAudioRenderer() where we set the renderer_ to NULL. This will crash chrome since renderer_ is being used at the same time.


BUG=241430

Review URL: https://chromiumcodereview.appspot.com/15732021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202420 0039d316-1c4b-4281-b951-d872f2087c98

After calling Stop(), the timer should just stop.


BUG=244192
TEST= https://webrtc.googlecode.com/svn/trunk/samples/js/demos/html/local-audio-rendering.html
Calling Start/Stop, the timer used to start/stop counting.

Review URL: https://chromiumcodereview.appspot.com/16045004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202419 0039d316-1c4b-4281-b951-d872f2087c98

This gets rid of more places where Persistent handles are copied
(see bug).

BUG=236290
TBR=eroman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15796006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202418 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244102
NOTRY=true
R=timurrrr@chromium.org

ScreenCaptureDeviceTest.Capture causes SEGV_MAPERR under Mac Valgrind. Bug
244102.

Review URL: https://chromiumcodereview.appspot.com/16104003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202417 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244110

Review URL: https://chromiumcodereview.appspot.com/16081002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202416 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
R=nkostylev@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16037002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202415 0039d316-1c4b-4281-b951-d872f2087c98

Modify SocketStream::Finish so that it works correctly if the delegate
calls DetachDelegate() and then deletes itself from within the OnError()
callback.

Test the delegate deleting itself in OnError().

SocketStream::Delegate is permitted to call
SocketStream::DetachDelegate() and then delete itself from within the
OnError method. Ensure this works correctly.

BUG=
TEST=net_unittests layout tests

Review URL: https://chromiumcodereview.appspot.com/15989003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202414 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242145
TBR=jar@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15646003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202413 0039d316-1c4b-4281-b951-d872f2087c98

This CL updated CSS and fixed the padding of name column header.

BUG=239294
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/16089002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202412 0039d316-1c4b-4281-b951-d872f2087c98

BUG=172593
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/16100003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202411 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202410 0039d316-1c4b-4281-b951-d872f2087c98

At the same time, it changes the behavior to highlight only
the first occurrence of the query pattern. I believe it is ok,
because (1) drive.google.com highlights in that way (2) it is
sufficient for users to know why the file is suggested.

BUG=173948

Review URL: https://chromiumcodereview.appspot.com/15945004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202409 0039d316-1c4b-4281-b951-d872f2087c98

This CL updates Chrome to return plugin NPP identifiers for NPAPI, PPAPI and browser plugins, and to make the necessary calls into Blink to support object ownership tracking.

This CL is a re-land of crrev.com/15007012, which was somehow landed by CQ despite breaking ClickToPlayPluginTest.NoCallbackAtLoad.  It requires Blink CL crrev.com/14989014, and is itself required by Blink CL crrev.com/14019005.

BUG=152006
TBR=jamesr,bauerb

Review URL: https://chromiumcodereview.appspot.com/15941006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202408 0039d316-1c4b-4281-b951-d872f2087c98