- 12 Sep, 2020 40 commits
-
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I83ba4498f2001e0adb3229420f084ff3511c2ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407196Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806442}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599847371-2549063c30c7bdee5663dc0b19c5059a31ce77db.profdata to chrome-win64-master-1599868763-30f77ddd393f754f7848eee1f62307631707625b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I069f1977291cde57082ea079354f63a76e85da21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406985Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806441}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599847371-1259e0f875e6a0f41f2ed4be7cfee7084b9f6f04.profdata to chrome-mac-master-1599890263-fec1849195edddbb913b14431d354b7c3cb15383.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I1a924e9b2a0919f1ae99394e9b2b2b2492c2aed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407290Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806440}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/75b04124ad49..06c254c59bf3 2020-09-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iff348ffdef889161f847dec0f6ddcc20b46b1d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407286Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806439}
-
Side Yilmaz authored
|IncognitoTabModelImpl#getProfile| returns null, and that makes |TabModelSelectorProfileSupplier| provides null profile to the callers. Null profile causes crashes on |IdentityDiscController| that uses TMSPS to observe profile changes. This CL sets a non-null profile in TMSPS, even if IncognitoTabModelImpl returns null profile. Bug: 1124597, 1124653 Change-Id: I48c248865294cf5415333e9653d2f7773a9910b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391154Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#806438}
-
Muyao Xu authored
Global Media Controls can now show available cast devices along with availblae audio devices for each active media session. This change is visible when GlobalMediaControlsCastStartStop feature is enabled. MediaNotificationAudioDeviceSelectorView implements CastDialogController::Observer interface and owns a CastDialogController object to listen to sink updates and update the UI. Change-Id: Ie9488fee7183f10b4f6d71e41254223fc6d68c48 Bug: b/161610050, 1107162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353010 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#806437}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1599868763-9c26f0178a8723b1466085a6c61b30b25b4440bf.profdata to chrome-linux-master-1599890263-8ae2d38cb929823d567b028c12de944a4ad8e3af.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I0dcdcb5f3469d7cb2d156e14e094bb83fb85430f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407288Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806436}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a163e26c8305..40d3f47d189c 2020-09-11 thestig@chromium.org Add an embedder test to render jpx_lzw.pdf with flags. 2020-09-11 nigi@chromium.org Enable FPDFFlattenEmbedderTest.BUG_861842 for Skia. 2020-09-11 thestig@chromium.org Initialize CFX_DIBitmap in the header. 2020-09-11 thestig@chromium.org Remove unneeded limits.h includes. 2020-09-11 thestig@chromium.org Fix header guard for xfa_test_environment.h. 2020-09-11 thestig@chromium.org Remove unneeded STL includes. 2020-09-11 tsepez@chromium.org Make CFXA_FMSimpleExpression a subclass of CFXA_FMExpression. 2020-09-11 tsepez@chromium.org Return Optional<CFX_WideTextBuf> from CFXJSE_FormcalcContext::Translate() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I9a1451b8c42c9ece188e8c18f12d92f6dacd820a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407285Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806435}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599781911-129feccf91ed1046080abe39627e119a3ba44fb5.profdata to chrome-win32-master-1599847371-4645c77f1dfaeb8f25cfbd8cea3dc9ba600f7437.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I011fc01660b143b5237b1c1f7f66abd957c54727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406892Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806434}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ifd5f922cae65cc942b87b60e75cec71fd4847b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407297Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806433}
-
Erik Staab authored
The tests are run from mac-arm64-rel-tests now and don't need to be isolated using workarounds on the mac-arm64-rel side. TBR=gbeaty@chromium.org Bug: 1117252 Change-Id: Ia54bba134e304f3c4ffe395358a95ce7dbcbbf66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407293Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#806432}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I26464e9f0548967cdfb226e24cc869f6279f786c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406986Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806431}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c62a79d55ed7..75b04124ad49 2020-09-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3743e58bc956fe8b49c57c74e8922ed1f0f954a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406984Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806430}
-
Kyle Horimoto authored
Will be used to determine when to show the onboarding UI [1]. For now, this functionality is not implemented, but this CL unblocks the UI from being build out. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2406662 Bug: 1106937 Change-Id: I2e8b0438c14a633dacee7b066ea908559ceeed93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407173 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#806429}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bca88739adb7..6830eb6041ea 2020-09-11 m.maiya@samsung.com EGL: Fix a bug in ImageTest 2020-09-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from a48ed7c29144 to b045bf7d3b6a (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Id88500141b71a85a339020e5e1ad896d54626535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406979Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806428}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599760756-ff576999efc14edb97330a2a91d8abce13fe0e29.profdata to chrome-win64-master-1599847371-2549063c30c7bdee5663dc0b19c5059a31ce77db.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic7a467f9c0ed463106027cb2bdd2cd7ad3812f9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406745Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806427}
-
Shrek Shao authored
TBR=kbr@chromium.org Bug: 1127541 Change-Id: I93f966abef09171d3fef2af833521d9ff9f2e4b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407070Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#806426}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I9799e626727e590cfd955010df3ff0656fa5def6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407177Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806425}
-
Jonah Chin authored
This CL plumbs calls to PaintImage::FlushPendingSkiaOps() through to a new version on TextureBacking, which uses the new SkImage::flushAndSubmit() API. This CL also cleans up more GetSkImage() callsites by replacing users of SkImage's unique ID with an ID on PaintImage. All of these callers were just using this ID for tracing. Bug: 1031050 Change-Id: I8ebb1b33836fedad8093adcab677fdc5a8eff29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363260 Commit-Queue: Jonah Chin <jochin@microsoft.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#806424}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1599847371-251c84d55c3e42dd8994b61e3cd668b3bbeb13e1.profdata to chrome-linux-master-1599868763-9c26f0178a8723b1466085a6c61b30b25b4440bf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ic84ece35538b6d297335b707dada75885a6a6db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406980Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806423}
-
Josh Simmons authored
These heartbeat metrics are still useful. Bug: 1125777 Change-Id: Idedb4c86cd667565d85ff55c314a8d5a8489efef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401816Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#806422}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/32eb03a1fbe2..5c8aa5cd05ae 2020-09-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 86121ae2..9d73c26f (806200:806356) 2020-09-11 jleconte@webrtc.org Remove uppercase after number on gtest names. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6b0245a41614c03164b65be7c62c1f044d61ce79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406976Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806421}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/970bf5ad2cd0..a1e15498cd2d 2020-09-11 norberg@google.com Xcode 12b3 (and later) emits arm64e binaries; try that architecture. 2020-09-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-11 gbeaty@chromium.org Handle failures in the bot_update script. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1103236 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: Idf4caf8972aee38b8a1fe619feefdc410058d8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406897Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806420}
-
Shrek Shao authored
TBR=kbr@chromium.org Bug: 1127541 Change-Id: Iecab32b2bb40726246bc6856aab482f850e2e9ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406842Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#806419}
-
Darwin Huang authored
OSExchangeData::SetDownloadFileInfo is no longer used anywhere, so remove it. The function it calls, OSExchangeDataProvider::SetDownloadFileInfo[1], is still used. Refactoring change only, so no functional changes expected. [1]: https://source.chromium.org/chromium/chromium/src/+/master:ui/base/dragdrop/os_exchange_data_provider.h;l=93;drc=c741e070dbfcc33b2369e7a5131be87c7b21bb99 Change-Id: I623c86eca682450a8c02d3d46dda0b80e4852252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404538 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#806418}
-
Jeremy Roman authored
They have been identical since UTF-32 support was removed three years ago: https://chromium-review.googlesource.com/c/chromium/src/+/559995/ Bug: 417850 Change-Id: I9db2a9a8a94d18732e8c45caaaffc443ab387f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401341 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#806417}
-
Ken MacKay authored
Bug: internal b/168149351 Test: cast_audio_backend_unittests Change-Id: I4172e243bc514888d127f56c8dfa83e83f9d60ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407057Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#806416}
-
Gang Wu authored
Share icon looks taller than other icons in action bar, so update a new share icon for action bar. Bug: 1127473 Change-Id: I5b22d852f86896a78e56560d7f151afce6e0a6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406680Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806415}
-
Jazz Xu authored
This CL add MediaNotificationBackground interface and create MediaNotificationBackgroundAshImpl for CrOS implementation. Bug: 1126711 Change-Id: I8c452fe2ccba16f436b9f3844091c62aa8e148e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401313 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#806414}
-
Erik Staab authored
Goes with https://crrev.com/c/2406459 on the build side. Bug: 1117252 Change-Id: I10c876ddfc442a10cc8b1f26392e1ddc17182b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406682 Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#806413}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9eb848ae8218..582c5a9a84ac 2020-09-11 csmartdalton@google.com Fix assert on tessellated stroke join type If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Id195de19885ded5e3463d5aa72e07b2e3bda8c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406895Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806412}
-
Yusuke Sato authored
This CL depends on the following CLs: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2380431 https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/2378806 https://chrome-internal-review.googlesource.com/c/chromeos/overlays/project-cheets-private/+/3238221 Diff from the original: None. This CL is safe to reland as-is because go/lkgm was updated past 13439.0.0. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2380733 BUG=b:166314117 BUG=chromium:1123901 TEST=arc.Boot.vm still passes, arcvm-adbd runs Change-Id: I828323a877128ae32283110d709c85ceb72e96c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404874 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#806411}
-
Josh Simmons authored
This also sets mUserInteracted = true in a couple places where it was not being set previously. I believe the intention of the bool and the INFOBAR_DECLINE metric is to track the number of immediate closes of the infobar, but please let me know if this isn't the case. Bug: 1123180 Change-Id: Ia8bd867575b7d242554cec8336a31aa5ead714e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388777 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#806410}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7870cf3f0a34..bca88739adb7 2020-09-11 jmadill@chromium.org Add a perf test that cycles through many VBOs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Iab471f2724fe26c388580465e17c764c6a3eec28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406747Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806409}
-
James Zern authored
picks up a couple ubsan fixes 24 commits: https://chromium.googlesource.com/webm/libwebp/+log/0fa56f3..55a080 Bug: skia:10693 Test: layout tests, blink unittests Change-Id: I3d7bc625f27b15a4ea09cebb26042b75be30f8cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406679 Commit-Queue: Urvang Joshi <urvang@chromium.org> Reviewed-by:
Urvang Joshi <urvang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806408}
-
Owen Min authored
When manifest type allowlist policy is set, GetExtensionInstallStatus() function always returns blocked-by-policy when there is no manifest type information. However, it should actually skip the manifest type check. Add a test to verify the fix. Also add a test to verify we can handle similar situation for permission set. Bug: 1124669 Change-Id: I9727222688177a7beb386e5dc473ef21e766ce8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392442Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#806407}
-
Raphael Kubo da Costa authored
VS Code 1.49 introduced a new setting called editor.formatOnSaveMode that makes Format On Save only format modified lines rather than the entire file: https://code.visualstudio.com/updates/v1_49#_only-format-modified-text Add a commented out optional setting that enables that. Change-Id: I13f3e0eb345c065737fd4dffc413cdd9df8689e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404345 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#806406}
-
mwakizaka authored
After running chromedriver with Android Chrome, there will be a listening port not being cleaned up. This commit addresses the issue by calling `adb forward --remove` call. Bug: chromedriver:2421 Change-Id: I606aab3154bc7e5a7cf587de5fd82c9894d1bec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385036Reviewed-by:
Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#806405}
-
Mei Liang authored
After crrev.com/c/2314557, |mOverviewModeController| can be null depends on the stage of Chrome initialization. ChromeNextTabPolicySupplier is created before the OverviewModeController is instantiated, thus the OverviewModeController in that class is always null. and it always returns the HIERARCHICAL policy and messes up the next tab logic in TabModelImpl. This CL fixes the issue by using the ObservableSupplier to supply the OverviewModeController, so by the time Chrome finishes its initialization the ChromeNextTabPolicySupplier would have a valid OverviewModeController. Bug: 1124227 Change-Id: I5123487ba13cf6797e281df1ab834322dd2ef39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404458Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806404}
-
Markus Handell authored
Recently a few changes (crrev.com/c/2391767 and crrev.com/c/2399238) entered the AVFoundation capturer, and it's better if these are controlled by a new base::Feature instead of raw changes, because 1) More evolution is expected, 2) We had one regression introduced (crbug.com/1124884#c7). 3) Additionally, this change enables A/B testing in a few months. The change introduces a new feature kMacNextGenerationCapturer controlling which implementation (default: new capturer) is in use by the system. The change also dupes the current _mac-suffixed capturer into a new _legacy-suffixed variant. In future CLs, last weeks evolution to the _mac capturer will be reverted inside the _legacy variant. Bug: chromium:1126690 Change-Id: I972663eef38623c9a76e0b2424e048bc24fc7093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401168 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#806403}
-