GitLab

SyncTaskRunner's task invocation tend to grow call stack deeper.
This CL clears the call stack per task to avoid stack overflow.

BUG=344769

Review URL: https://codereview.chromium.org/334053008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278362 0039d316-1c4b-4281-b951-d872f2087c98

Should not affect behaviour of the normal app list. The experimental app
list now transitions pages in from the correct side of the screen,
instead of simply sliding pages out to the left.

BUG=377381

Review URL: https://codereview.chromium.org/316393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278361 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347425
TEST=./unit_tests --gtest_filter="MetadataDatabaseTest.*:MetadataDatabaseIndexTest.*"

Review URL: https://codereview.chromium.org/340243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278359 0039d316-1c4b-4281-b951-d872f2087c98

Honour the safe browsing opt out and report on incidents that arrive
before profile initialization is complete.

BUG=383039,383365
R=mattm@chromium.org, noms@chromium.org
TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/341563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278358 0039d316-1c4b-4281-b951-d872f2087c98

mojo_common can not depends on embedder, as standalone application must
depends on it. channel_init is in fact a part of the embedder.

R=viettrungluu@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/346633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278357 0039d316-1c4b-4281-b951-d872f2087c98

Currently, we use wrong storage type for nested arrays. For example, the storage
type of the outer array of int8[][] is
StructPointer<Array_Data<int8_t>>. After this CL it will be
ArrayPointer<int8_t>.

The current code works because StructPointer happens to be of the same
size as ArrayPointer.

(The newly-added tests pass with/without this CL. But I think it is good
to have them.)

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/340223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278356 0039d316-1c4b-4281-b951-d872f2087c98

It's a goodness to sequester build configuration in the build/
directory. The gn secondary_source stuff was under tools/gn for
historical reasons, so move it to a more appropriate place.

BUG=None
TEST=do a gn build of base_unittests, run said unittests.

Review URL: https://codereview.chromium.org/340153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278355 0039d316-1c4b-4281-b951-d872f2087c98

All benchmarks that uses the old format have been converted.

https://code.google.com/p/chromium/codesearch#search/&type=cs&sq=package:chromium&q=%22page_test%20=%20'%22%20

https://code.google.com/p/chromium/codesearch#search/&type=cs&sq=package:chromium&q=%22page_test%20=%20%5C%22%22

BUG=362293

Review URL: https://codereview.chromium.org/331213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278353 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/346663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278352 0039d316-1c4b-4281-b951-d872f2087c98

Since the "Create Shortcuts" button is disabled on ChromeOS, add a
pin/unpin button that allows pinning and unpinning the app from the
shelf. This is the functional equivalent of creating shortcuts on
ChromeOS.

Based off https://codereview.chromium.org/335523002/.

BUG=385526

Review URL: https://codereview.chromium.org/340453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278351 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344769

Review URL: https://codereview.chromium.org/337803005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278350 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278349 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/b59161f0000eb4aca3dcef29f27ffd0fb5a568e5..30e6e2af14e84216b1c113fd7500d0822bc81daa

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=reed@google.com
BUG=

win_chromium_rel seems unrelated to this cl
NOTRY=True

Review URL: https://codereview.chromium.org/343593005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278348 0039d316-1c4b-4281-b951-d872f2087c98

A ui::Combobox (|denial_combobox_|) doesn't take an owner of a
ui::ComboboxModel, so we should have clarify who is the owner of
the combobox model.
This CL fixed the leak to make TranslateBubbleView owner of the
ui::ComboboxModel (|denial_combobox_model_|).

BUG=309468
R=sky@chromium.org

Review URL: https://codereview.chromium.org/330443004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278347 0039d316-1c4b-4281-b951-d872f2087c98

Add a regression test, confirming that sessions which race host
resolutions don't fail network transactions.

BUG=334413

Review URL: https://codereview.chromium.org/346713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278346 0039d316-1c4b-4281-b951-d872f2087c98

Modifies AudioInputCallback::OnData and use media::AudioBus instead of plain byte vector (Relanding).

Second attempt to land https://codereview.chromium.org/314713002/ which has been reverted.

TBR=dalecurtis
BUG=375155
TEST=WebRTC and WebSpeech demos

Review URL: https://codereview.chromium.org/344583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278345 0039d316-1c4b-4281-b951-d872f2087c98

Explicitly issue decode error if MP4 stream parser peek fails during
MDAT discarding.

BUG=380806
R=acolwell@chromium.org

Review URL: https://codereview.chromium.org/342083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278344 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344543

Review URL: https://codereview.chromium.org/340273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278343 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354035
TEST=unit_tests,ash_unittests,manual
R=sadrul@chromium.org,derat@chromium.org

Review URL: https://codereview.chromium.org/255033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278342 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386207

Review URL: https://codereview.chromium.org/343673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278341 0039d316-1c4b-4281-b951-d872f2087c98

This test was disabled because it was failing. A few changes have been made:
-The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption.
-testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091.
-The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory).

BUG=303491

Review URL: https://codereview.chromium.org/290803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278340 0039d316-1c4b-4281-b951-d872f2087c98

Add histograms to record the response codes seen by all WebSocket
requests, and also the error codes. This will provide more insight into the
reasons for WebSocket connection failures.

BUG=384273
TEST=manually tested with chrome://histograms

Review URL: https://codereview.chromium.org/336753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278339 0039d316-1c4b-4281-b951-d872f2087c98

"Smart" because it needed some rebasing.

> Win Video Capture: Add support for HDYC pixel format.
>
> This pixel format is a synonym of YUYV and is needed
> for at least the DeckLink video capture card.
> This format is not specified in Windows headers
> probably because this is just a synonym of other
> pixel formats, IOW they are all the same except for
> the first word, which is the name read in hex
> backwards:
> 30323449 --> 0x30 0x32 0x34 0x49 -> 024I
> 43594448 --> 0x43 0x59 0x44 0x48 -> CYDH
>
> and then all the YUV (422 and 420 alike) use the same
> trailing sequence
> ... 0x0000, 0x0010, {0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}}
>
> HDYC: http://www.fourcc.org/yuv.php#HDYC
>
> BUG=380939
>
> Review URL: https://codereview.chromium.org/317073010

NOTRY=true

TBR=mcasas@chromium.org

Review URL: https://codereview.chromium.org/338853009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278338 0039d316-1c4b-4281-b951-d872f2087c98

1. Modify HostInfo.java to parse the tokenPatternUrl from the host list.
2. Modify ThirdPartyTokenFetcher to check against the domain's allowed URL before directing the user to the login page requested by the host.

Review URL: https://codereview.chromium.org/348433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278337 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361790
TBR=nhiroki@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/341033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278336 0039d316-1c4b-4281-b951-d872f2087c98

Code that modifies an already-serialized packet was erroneously writing
out a 16-bit value using little-endian byte order.  This change corrects
that to be written big-endian, per the spec.

BUG=385894

Review URL: https://codereview.chromium.org/342003007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278335 0039d316-1c4b-4281-b951-d872f2087c98

Make sure Widget observes the correct NativeTheme. Wait until everything else is done initializing so GetNativeTheme() returns the right thing.

BUG=384492

Review URL: https://codereview.chromium.org/330873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278334 0039d316-1c4b-4281-b951-d872f2087c98

This adds the possibility of a control group for suggestions, where the user is served local TopSites suggestions, but would have received suggestions from the SuggestionsService. This enables us to avoid a population bias.

Regarding UMA_ prefix for histograms, will rebase once https://codereview.chromium.org/343643002/ gets in.

BUG=385159
TEST=SuggestionsServiceTest*

Review URL: https://codereview.chromium.org/341943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278333 0039d316-1c4b-4281-b951-d872f2087c98

This avoids a name conflict between winnt.h's FileSystemType enumerator
value and Chromium's fileapi::FileSystemType enum type.  MSVC doesn't
care, but Clang diagnoses this with:
  error: must use 'enum' tag to refer to type 'FileSystemType' in this scope

I could use the enum tag to avoid this ambiguity, but it would be very
inconsistent with other Chromium code.  A full nested name specifier
seems better.

R=thakis@chromium.org,hans@chromium.org
TBR=kinuko@chromium.org
BUG=82385

Review URL: https://codereview.chromium.org/345673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278332 0039d316-1c4b-4281-b951-d872f2087c98

Previously Desktop.dispatchKeyEvent() was sending keyboard events to
the host and then pretending that it didn't handle the event. Now it
returns correct result telling the caller when the event was handled.

BUG=385972

Review URL: https://codereview.chromium.org/341693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278331 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes several changes to the EME player to enable test
specific expectations possible.

The EME player can be still used as a stand alone player.

BUG=356892
TESTS=out/Release/browser_tests --gtest_filter=*EncryptedMedia*

Review URL: https://codereview.chromium.org/308553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278330 0039d316-1c4b-4281-b951-d872f2087c98

Gsutil tries to create a dir (for keeping track of resumable downloads)
under home dir. On ChromeOS this is, given that the tests must be run
by root, read-only '/root/'. This causes gsutil commands to fail. To
avoid this, override HOME dir to writable '/home/chromeos-test'.

(this will also require gsuitl to be configured with the same HOME dir)

BUG=359293,386416

Review URL: https://codereview.chromium.org/334603004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278329 0039d316-1c4b-4281-b951-d872f2087c98

1. Make the chrome://devices issue run right to left for RTL languages
2. Make the chrome://devices page show icons correctly when displayed right to left
3. Remove unnecessary comment about needing i18n

BUG=386020

Review URL: https://codereview.chromium.org/339403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278328 0039d316-1c4b-4281-b951-d872f2087c98

Now the browser will register or unregister a Service Worker only if document url,
scope, and script url have the same origin.

This patch removes TODOs for adding SW to ChildProcessSecurityPolicy, since it
turns out the only security check needed here is the URL origin one. SW is
expected to be enabled always, not a permission granted per-process.

BUG=311631

Review URL: https://codereview.chromium.org/334413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278326 0039d316-1c4b-4281-b951-d872f2087c98

Previously, when the device scale factor >= 1.5, selects the 2x
resource, but then scales it by the DSF. So, for example, at 1.5,
it selects 64x64, and draws it as 96x96 pixels, which causes it to
overlap. Setting the size explicitly seems to fix it, but I'm not
sure if this is the right fix.

R=kalman@chromium.org
BUG=366377
TEST=manual with --force-device-scale-factor={1,1.25,1.5,2}

Review URL: https://codereview.chromium.org/343473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278325 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/340523008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278324 0039d316-1c4b-4281-b951-d872f2087c98

The approach here is to literally copy most of the logic in VideoSender
over into AudioSender, since VideoSender already solves a number of
transmission/re-transmission issues using heuristics that should work
well for audio.  (This also brings us much closer to being able to merge
AudioSender and VideoSender into one implementation.)

Testing: Confirmed correct halting and recovery behavior between
cast_sender_app and cast_receiver_app (SIGSTOPP'ed and SIGCONT'ed each
to simulate a temporary outage).  Also tested a Chromium sender with a
Chromecast receiver.

BUG=380023

Review URL: https://codereview.chromium.org/340903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278323 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242982,382679

Review URL: https://codereview.chromium.org/342743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278322 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278321 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176427:176443&mode=html
TBR=schenney@chromium.org,jamesr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/343693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278320 0039d316-1c4b-4281-b951-d872f2087c98