GitLab

In https://chromium-review.googlesource.com/c/chromium/src/+/974445 I
failed to notice that the content scheme was only on the intent filter
with mime types. Assuming this was intentionally only on the filter
with mime types, I've added it back to that filter.

Bug: 827796
Change-Id: I6b1f9dc1b01e6b87838215698290d7ac8d894022
Reviewed-on: https://chromium-review.googlesource.com/995957Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548088}

This compression overhead should be a padding-only symbol since it is
purely overhead that is inactionable.

Bug: 826008
Change-Id: I6d2b21676d3cd41efdb738d1c85b4f783dff9286
Reviewed-on: https://chromium-review.googlesource.com/995964Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548087}

WebView was calling WebContents::IsCrashed() to determine if the
crashed overlay view (sad tab) should be shown on top of the web
contents, but on Windows only, IsCrashed() was returning false for
a tab that was killed due to OOM.

It's not clear whether OOM should count as a crash or not or
whether there should be a platform difference. However, this bug
can be fixed safely either way. The real logic determining whether a
sad tab is shown or not happens in SadTabHelper. It's sufficient for
WebView to just check whether the WebContents has any abnormal
termination status, and show the crashed overlay view if so.

Bug: 817124
Change-Id: I7ba5f5f40e8d4499ec509b38471bbc1a1f8b6225
Reviewed-on: https://chromium-review.googlesource.com/993992
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548086}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8e870f6ea5bea91a48f09273d7a4d78e44d553b2
Reviewed-on: https://chromium-review.googlesource.com/992853Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548085}

Wait to create views for the suggested content until after the sheet is
opened. This will reduce memory cost if the sheet is never opened.

BUG=822955

Change-Id: I657f601cc1862227514eb599df205da2c5dee1ad
Reviewed-on: https://chromium-review.googlesource.com/990773
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548084}

https://chromium.googlesource.com/angle/angle.git/+log/6bc264aee686..59c5b897ec70

$ git log 6bc264aee..59c5b897e --date=short --no-merges --format='%ad %ae %s'
2018-04-03 oetuaho Validate gl_FragData and gl_FragColor access after parsing
2018-03-30 jmadill Vulkan: Make RenderTargetVk use ImageHelper.
2018-03-29 lucferron Vulkan: Support for bools and bvec* uniforms
2018-03-30 jmadill Vulkan: Add an Image helper class.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: I4f17f987277a23d4c13bb56dbeccf3482839b176
Reviewed-on: https://chromium-review.googlesource.com/995954Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548083}

Disable this test as it's flaky on Linux.

Tbr: yiyix@chromium.org, fsamuel@chromium.org
Bug: 828061
Change-Id: Ia890fb9392d2784e4b2c835665cc7a6427b1c0e4
Reviewed-on: https://chromium-review.googlesource.com/995588Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548082}

Currently, _CheckUniquePtr PRESUBMIT check reports each failing line as
a separate error. This repeats the error explanation and thus clutters
the output necessarily.

This CL makes _CheckUniquePtr collect all occurences of the two issues
it checks for (direct use of unique_ptr constructor and replaceability
with nullptr) and group them under a separate single error, one for each
of the both types of check.

It also adds the failing line into the output, to make it easier to
understand the issue already from the presubmit logs.

This follows what is done for other checks, e.g., _CheckNoPragmaOnce).

Bug: 827961
Change-Id: Ic7d60a05b6f96da741f1401422f4a1690bb6e279
Reviewed-on: https://chromium-review.googlesource.com/990132
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548081}

Bug: 804570
Change-Id: If8461c73deb1938a643bf7a3a3e4d753fe4e7c00
Reviewed-on: https://chromium-review.googlesource.com/991060Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548080}

4 kB is a bit large. Microbenchmarks don't indicate a performance
hit when lowering this, and they may even improve on lower-end
devices.

This decreases the default size to 128 bytes. We can monitor perf
dashboards for the effect.

Also fixes a bug in test code which assumed an allocation wouldn't
resize a message, since that actually happens now.

Bug: None
Change-Id: Ibc7d17fe6f7cc98db7b290862cd4aea0f9be4fe0
Reviewed-on: https://chromium-review.googlesource.com/992553Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548079}

Move the touch-action: pan-left/right/up/down tests to
the next version of the spec.
https://github.com/w3c/pointerevents/pull/238

Bug: 826726
Change-Id: Icab0e439e0c2281f0c9fc78eec0a41a044f37f71
Reviewed-on: https://chromium-review.googlesource.com/984736Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548078}

Bug: None
Change-Id: I964926f9177af1b227e381f59c5140e3389e3f07
Reviewed-on: https://chromium-review.googlesource.com/993774
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548077}

When we have an untrusted offline page, the popup should show the claimed
URL and creation date, and allow the user to copy the claimed URL.
* Trusted offline pages are unchanged
* Untrusted offline pages don't show the scheme.

Mocks at go/offline-pages-p2p-mocks#slide=id.g1d74dc3fd1_0_13

Bug: 826362
Change-Id: I4c33c6b151f1e6f82bccb44122081712648c39c7
Reviewed-on: https://chromium-review.googlesource.com/980925Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548076}

Previously, we would do the local update unconditionally. With this
change, we keep track of a dirty bit for the world space transform as
well as a baked version of the local transform so we don't need to
call cc::TransformOperations::Apply repeatedly to realize the same
results.

Some elements have special conditions for the dirtiness of their local
transform, so I have also created a ShouldUpdateWorldSpaceTransform
function so that subclasses can customize this behavior. The reticle,
for example, is always dirty.

Bug: 828684
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5b581a72d7caa39d47dcdc686d212879b3da3093
Reviewed-on: https://chromium-review.googlesource.com/995573Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548075}

The ASAN runtime doesn't detect heap corruption from uninstrumented code,
and so the test fails to die.

Bug: 818747,827548
Change-Id: Ic8bd73c375887b3cf1de79b6fe5838cd31efa426
Reviewed-on: https://chromium-review.googlesource.com/992572
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548074}

Breaking some Ozone==Linux assumptions in ui/gl to enable an Ozone/Windows build.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id0093cd5f8cda8ae582dfe012d4ba33a4af53a03
Reviewed-on: https://chromium-review.googlesource.com/978615Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Mustafa Çamurcu <camurcu@google.com>
Cr-Commit-Position: refs/heads/master@{#548073}

This test fails under Fuchsia's implementation of the pthreads API.

Bug: 825218, 828897
Change-Id: I33df13b18e295a05acb000db7ebbcc7ea02b1728
Reviewed-on: https://chromium-review.googlesource.com/994341
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548072}

Bug: 826515
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7f404b4769499fa1b5efc11b6750f5b059d89822
Reviewed-on: https://chromium-review.googlesource.com/989249Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548071}

Bug: 564071
Change-Id: Ic7a829f3fe6c6388761370585d4f643e00c774a0
Reviewed-on: https://chromium-review.googlesource.com/992872Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Paul Meyer <paulmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548070}

This replaces checks for IsIpadIdiom with RegularXRegular size classes.

Bug: 819461
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I33b4410214dd1ca0672afd46953435150ccfb3c7
Reviewed-on: https://chromium-review.googlesource.com/981939
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548069}

This adds a perftest which moves the reticle around and measures the
UI costs.

Bug: None
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I688ad47adb6e3ba4f6cf5fd19410d348ba154e30
Reviewed-on: https://chromium-review.googlesource.com/993760
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548068}

FakeProfileOAuth2TokenService has two modes of operation:
auto_post_fetch_response mode, which means it'll automatically post
successful responses to all access token requests to the message loop,
or regular (manual) mode, where the user calls IssueToken*/IssueError*
etc. This CL adds DCHECKs to make sure the two modes are not mixed.
It also fixes some ProfileSyncService tests which did just that.

Bug: 825190
Change-Id: Ibed800c7defa09fb8efbf8cb8a56608731aaf70e
Reviewed-on: https://chromium-review.googlesource.com/995434Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548067}

This reverts commit 16e808d7.

Reason for revert: Merge step still failing. 

Original change's description:
> Enable extracting unwind table on official builds without channel
> 
> The original cl was here:
> https://chromium-review.googlesource.com/c/chromium/src/+/990092
> This CL fixes the following problems with the original CL:
> 1. The apk_merger script fails because the unwind tables were only added
>    in 32-bit apk. The merger script expects all the files to be same and
>    the ones different should be checked.
>  1a. The resources.arsc is non-hermetic and ordering is affected by
>      adding file to only one apk. As a workaround for crbug/828528,
>      add an empty (valid) unwind table file to the 64 bit monochrome
>      apk to make the resource.arsc consistent.
>  1b. The merger script simply adds all the files in apk which are not
>      same. To keep the script simple and functional, the unwind resource
>      is renamed to unwind_cfi_32 and unwind_cfi_empty in respective
>      builds and the app_merger is updated to specify this file is
>      expected to be different and included. This causes an extra file
>      (4 byte) in the merged apk.
> 
> 2. The unwind tables were always generated for "libchrome.so" for all
>    chrome apks. The different chrome_apk(s) have different shared
>    libraries like libchromefortest, etc.. So, update the unwind asset to
>    get unwind table for the right library for each apk. Only adds assets
>    to *_public_apk(s).
> 
> 3. The monochrome_apk_checker was failing because the unwind file
>    included was different in chrome_apk and monochrome_apk. This CL adds
>    the asset to all apk at the same time and adds exception for this
>    file.
> 
> BUG=819888
> TBR=dpranke@chromium.org
> 
> Change-Id: Ibceeeacc19fa424d519891b8c17e349ee6c2dfd6
> Reviewed-on: https://chromium-review.googlesource.com/991236
> Commit-Queue: Siddhartha S <ssid@chromium.org>
> Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547993}

TBR=boliu@chromium.org,dpranke@chromium.org,mariakhomenko@chromium.org,changwan@chromium.org,ssid@chromium.org,agrieve@chromium.org

Change-Id: I0a96e213133b6cb21c36db365b7c72f0f4642c8e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 819888
Bug: 828879
Reviewed-on: https://chromium-review.googlesource.com/995697Reviewed-by: Anthony Berent <aberent@chromium.org>
Commit-Queue: Anthony Berent <aberent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548066}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/69d8b7f7..36ee60c3

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ia417512a045d3e8cb6e1102bf4b8898aa6081993
Reviewed-on: https://chromium-review.googlesource.com/995154Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548065}

BUG=268984

Change-Id: I2335a0537df4d0437f061b57d4f0d3c20657afdf
Reviewed-on: https://chromium-review.googlesource.com/990633
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548064}

BUG=714018

Change-Id: I9d846815404f3154639cf6c2a2fcff98ee91cd0c
Reviewed-on: https://chromium-review.googlesource.com/995512Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#548063}

NOTRY=true  # tests are covered by PRESUBMIT only

Bug: 825181
Change-Id: I59ee1dc37b86d5100881c11789bbef2076b113ad
Reviewed-on: https://chromium-review.googlesource.com/995578Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#548062}

KeyboardCommandsTestCase:
- Updates the recent tabs test now that recent tabs is always presented
  and never contained.
- Updates the recent tabs test because the a11y ID of the "Done" button
  is different when the UIRefresh flag is enabled.

RecentTabsTableTestCase:
- Properly nils out the mediator after it is disconnected.  This
  prevents a crash when launching recent tabs a second time.

BUG=825431

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib97c1536083fae82dcc523c8ea2787c74f92469b
Reviewed-on: https://chromium-review.googlesource.com/995617Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548061}

This was discovered in
https://chromium-review.googlesource.com/c/chromium/src/+/980757 by
letting assert_throws also check that the message matches. That change
itself isn't a good idea, but it's still just as well to use plain
TypeErrors here to not make it seems like more is being tested than in
fact is.

Change-Id: I8f964e9b25cc94942cb86f3ee0017530f230e04a
Reviewed-on: https://chromium-review.googlesource.com/995192Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548060}

SIGSYS is grabbed by the system seccomp filter trap, and SIGSEGV is
grabbed by libsigchain. Both of these need to have their default signal
actions so that the sandbox test framework can interpret process death
accurately.

Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg
Change-Id: I3879f83bd16d1a71df389fe25d52bb68baacf596
Reviewed-on: https://chromium-review.googlesource.com/984516Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548059}

https://chromium.googlesource.com/catapult.git/+log/e13394ffef36..23d04ac91acd

$ git log e13394ffe..23d04ac91 --date=short --no-merges --format='%ad %ae %s'
2018-04-04 eyaich Updating artifact paths to cloud storage paths.

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:772208


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I1c69b0313e48b5156a93b78e3e562cf4ecddbeec
Reviewed-on: https://chromium-review.googlesource.com/995579Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548058}

It passes locally and flakiness dashboard shows it's been passing for as
far as the results go.

Bug: 711529
TBR: kinuko
Change-Id: Ia9c75b49639c752d9d92ccbf0ee10c4cf0b3c37a
Reviewed-on: https://chromium-review.googlesource.com/995752Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548057}

The statement copied from the original code would be

size_t size = size();

but that does not compile since size now refers to the variable size_t size.

I mistakenly replaced size() with data_->size() forgetting that data_ could be nullptr.

The correct fix was to use this->size() which includes a check for nullptr.

Add a test that would have caught this.

Bug: 828740
Change-Id: I57a396d968a1a8e947bb9fdb0b7d232494c6d5d5
Reviewed-on: https://chromium-review.googlesource.com/995592Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548056}

Turns out downstream sdk tools is too old and doesn't have the tool.

Change-Id: I4a08d1658854647f473923263137530c7910deba
Reviewed-on: https://chromium-review.googlesource.com/995583Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548055}

A new switch is add to traffic annotation auditor's call to clang tool,
to ignore uknown switches and do not stop on them. This is done as a
quick fix to reactivate traffic annotation auditor's tests and will be
updated to a more presistant approach after discussing with clang team.

Bug: 690323
Change-Id: If350a83b2d70003a2600f9ad84d774a049a9f532
Reviewed-on: https://chromium-review.googlesource.com/995132Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548054}

This reverts commit 523c07e8.

Reason for revert: SettingsAccessibilityTest.MANAGE_ACCESSIBILITY_aria_valid_attr_value is Flaky.

Original change's description:
> Add tests for accessibility pages in Chrome / Chrome OS settings.
> 
> Bug: 823359
> Change-Id: I62707b079f9ee899feb7c624a498c5f16f6fe061
> Reviewed-on: https://chromium-review.googlesource.com/988226
> Reviewed-by: Hector Carmona <hcarmona@chromium.org>
> Commit-Queue: Katie Dektar <katie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547747}

TBR=hcarmona@chromium.org,katie@chromium.org

Change-Id: I4c26092b8c2be2ee2a041a5ac420b57fe5b72a60
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 823359
Reviewed-on: https://chromium-review.googlesource.com/995553Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548053}

This reverts commit 755a9214.

Reason for revert: Mid-flight collision with 162e9dda47d694596620b69c5fb23cc7f0f87126 - will update and reland.

Original change's description:
> Serialize 'oblique' computed values for 'font-style'
> 
> Handling of 'oblique' values were missing in
> ComputedStyleUtils::ValueForFontStyle - serialize as 'oblique <angle>'.
> Because of this the return value needs to be widened to CSSValue.
> 
> Bug: 809935, 809938
> Change-Id: I1de846595ed955455d57ab9f6ea45326e502a65b
> Reviewed-on: https://chromium-review.googlesource.com/995273
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Commit-Queue: Fredrik Söderquist <fs@opera.com>
> Cr-Commit-Position: refs/heads/master@{#548044}

TBR=fs@opera.com,drott@chromium.org,futhark@chromium.org

Change-Id: I379a152245f16fc792c8bfc55a2d8b127ba30820
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 809935, 809938
Reviewed-on: https://chromium-review.googlesource.com/995695Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#548052}

Add an EnabledStateMonitor to monitor changes to contextualsuggestions
enabled state. Currently the only monitored state is whether sync
upload to Google is active.

Also updates the FeatureUtilities check to account for the search engine
promo.

BUG=823987

Change-Id: I9b4ae44ae94e73ef5c7e43cbfe6aebf657f4ada0
Reviewed-on: https://chromium-review.googlesource.com/988343Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548051}

Change-Id: Iaa6b4ef193e738164b71de06125e8befa0e0d13d
Reviewed-on: https://chromium-review.googlesource.com/995456Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548050}

The convention is to use ASSERTs for preconditions to the actual test,
so let's do that.

Bug: none
Change-Id: I8580438b70669adda6507192f226e96231a1ccf7
Reviewed-on: https://chromium-review.googlesource.com/995436Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548049}