- 31 Aug, 2018 40 commits
-
-
Lakshman Annadorai authored
Bug: 755630 Change-Id: Ia5940e7be3821200a38a2405c2676ef37326bcf7 Reviewed-on: https://chromium-review.googlesource.com/1199485Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Lakshman Annadorai <lakshmana@chromium.org> Cr-Commit-Position: refs/heads/master@{#588165}
-
chcunningham authored
onNativeSignOut() triggers a call to signOut() -> nativeSignOut() Parts of signOut() are needed, but the call to nativeSignOut() should be avoided for flows that originated at the native side (native signout is already done). Change-Id: Ib205cfd61e94b49838e738b87c5cdb43b2d9f563 Bug: 873116 Reviewed-on: https://chromium-review.googlesource.com/1169462 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#588164}
-
Theresa authored
Remove padding from modern_toolbar_background and update/simplify the location bar layout logic to better match the UX spec. BUG=815343 Change-Id: I24e0239f3763c6c2fd7bd1f8c5f286ebf4f0b78c Reviewed-on: https://chromium-review.googlesource.com/1197902Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#588163}
-
Emircan Uysaler authored
This CL adds observable settings to MediaStreamTrack objects returned by getDisplayMedia() calls. These constrainable properties are set before the stream is returned based on user choice. Information about these settings are stored in DisplayMediaInformation struct. It is set in the low level device selection and then parsed by UserMediaProcessor before passing it to blink. Bug: 326740 Change-Id: I81d5f2eb24d2c1a37df0fbe2d34bc469fa575bf1 Reviewed-on: https://chromium-review.googlesource.com/1185875Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#588162}
-
Owen Min authored
The API has been proposed by crbug.com/876800 Bug: 877238 Change-Id: Ic3ad7466d4bff95d8626e8339e13799545bf3f50 Reviewed-on: https://chromium-review.googlesource.com/1187514 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#588161}
-
Bailey Forrest authored
Bug: None Test: le_scan_result_fuzzer Change-Id: I38a27cf7edfe1624a71f0a33850185c03312a299 Reviewed-on: https://chromium-review.googlesource.com/1189125Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Bailey Forrest <bcf@chromium.org> Cr-Commit-Position: refs/heads/master@{#588160}
-
Kurt Horimoto authored
This allows for the optional disabling of the default LoadIfNecessary() behavior that previously occurred in TabModelWebUsageEnabledObserver. This can be used when restoring a large number of Tabs to prevent the creation of many WKWebViews at once. Bug: 864478 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie80722aa178e260e6c6841de8e4cad8bb1e7ada4 Reviewed-on: https://chromium-review.googlesource.com/1148596 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#588159}
-
Kyle Horimoto authored
It should be required that users enter their password to enable SmartLock, since it is a security-sensitive feature. As a corollary, it should also be required that users enter their password to enable the Better Together suite if doing so would implicitly cause SmartLock to become enabled. Previously, entering a password was required for enabling the Better Together suite under any circumstances, but this was unnecessary, since no password should be required if SmartLock were turned off. This CL fixes this issue; additionally, it updates the authentication code here, which was previously not as robust. Bug: 876436, 824568 Change-Id: Ia61dd112675485972361a51b406482a0bb0a1f05 Reviewed-on: https://chromium-review.googlesource.com/1200148Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#588158}
-
Oksana Zhuravlova authored
Bug: 879248 Change-Id: Ib2ac501729e0376eb17dc467df5be849ebf416f5 TBR=mastiz@chromium.org Change-Id: Ib2ac501729e0376eb17dc467df5be849ebf416f5 Reviewed-on: https://chromium-review.googlesource.com/1199696 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#588157}
-
Vaclav Brozek authored
The feature has been enabled in stable releases for a number of versions by now, hence the flag can be safely removed. Bug: 838789 Change-Id: I172df59564d881c8c7b6b5cad3b49d0971fc0251 Reviewed-on: https://chromium-review.googlesource.com/1195489 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#588156}
-
chrome://discardsSigurdur Asgeirsson authored
Bug: 874968 Change-Id: I05a6fb88d7a013c7df74234f4ece03d53c275789 Reviewed-on: https://chromium-review.googlesource.com/1178236Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#588155}
-
Ted Meyer authored
Bug: 849379 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iab509858f50280fb8e0ab2f2e71dadc5d5fcc6d5 Reviewed-on: https://chromium-review.googlesource.com/1173429Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#588154}
-
Miguel Casas authored
This CL cleans up a bit the jpeg_decode_accelerator_unittest file; singleton JpegDecodeAcceleratorTestEnvironment created a number of temporary files on SetUp() (via CreateTestJpegImage() method) that were removed on TearDown(). It also created by hand the content of TestImageFile objects. All this logic is moved to the struct TestImagefile (renamed to ParsedJpegImage), so that a) the struct is better defined in terms of what it holds and how is it initialized (CreateFromFile() and CreateBlackImage() are the factory methods), b) there's one place only to fill in its sizes (InitializeSizes()) and c) there's no need for temporary files written to disk and deleted. Also for good measure: - GetOriginalOrTestDataFilePath() is simplified and folded inline. - Couple of consts/constexprs here and there. - Initialize members in ctor initialization lists (ISO ctor body). Test: compile and run j_d_a_unittest on nautilus Bug: 877694 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib2cb4ba218df84955757298e7d0cd85503ee1c98 Reviewed-on: https://chromium-review.googlesource.com/1197372 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#588153}
-
Yuwei Huang authored
Turns out I forgot to include the resize-to-fit feature in Android client's What's New text. This CL adds it back. Bug: 877704 Change-Id: I277c5e5eaefd3247769b7cdf17c84f95a8db0072 Reviewed-on: https://chromium-review.googlesource.com/1198565Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#588152}
-
braveyao authored
webrtc::ScreenCapturerMac requires to be started and destroyed on same thread. The current SequencedTaskRunner can't satisfy this and will cause random crashes. This cl is to use an exclusive capture thread as same as the one in content/browser/media/capture/desktop_capture_device.cc. Bug: 877982,851883 Change-Id: I6508add3660f63e1d2539dd2175a131f869a836a Reviewed-on: https://chromium-review.googlesource.com/1199806 Commit-Queue: Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#588151}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9951cbf4ca79..7bfe8438a94b git log 9951cbf4ca79..7bfe8438a94b --date=short --no-merges --format='%ad %ae %s' 2018-08-31 bsalomon@google.com Test glbetex and glbert configs on BonusConfigs bots 2018-08-31 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 5fb5e817a20d..fe5861bf5bb1 (1 commits) 2018-08-31 stani@google.com Support more hardware buffer formats 2018-08-31 michaelludwig@google.com Fixes for primitive handling for uniforms 2018-08-31 jvanverth@google.com Simplify perspective shadows to match future MD specs. 2018-08-31 fmalita@chromium.org [skottie] Lazily-initialized default font manager 2018-08-31 benjaminwagner@google.com Unomit passing tests for Radeon. 2018-08-31 benjaminwagner@google.com Remove GTX1070 and GTX1050 jobs. 2018-08-31 bsalomon@google.com Fix GrAAConvexTessellator colinear point removal. 2018-08-31 benjaminwagner@google.com [infra] Add rack dimension for QuadroP400 tasks. 2018-08-31 benjaminwagner@google.com Unomit passing tests for Win Intel. 2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-31 brianosman@google.com Revert "Add support for gray + colorspace to SkCodec" Created with: gclient setdep -r src/third_party/skia@7bfe8438a94b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:113555199,chromium:869172,chromium:784662 TBR=stephana@chromium.org Change-Id: I75ea11ce12a9a2eed101571b2adfde0c7c93ced8 Reviewed-on: https://chromium-review.googlesource.com/1199694Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588150}
-
Will Harris authored
This suppresses a number of warnings that will be enabled in the future. Remove unneeded extra warnings, as these are covered by a global config. ../../third_party/ots/src/prep.cc(25,20): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] this->m_length = length; ~ ^~~~~~ ../../third_party/ots/src/fpgm.cc(24,18): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] this->length = length; ~ ^~~~~~ ../../third_party/ots/src/post.cc(104,44): warning: implicit conversion loses integer precision: 'std::vector<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::basic_string<char, std::char_traits<char>, std::allocator<char> > > >::size_type' (aka 'unsigned long long') to 'const unsigned int' [-Wshorten-64-to-32] const unsigned num_strings = this->names.size(); ~~~~~~~~~~~ ~~~~~~~~~~~~^~~~~~ ../../third_party/ots/src/cvt.cc(28,18): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] this->length = length; ~ ^~~~~~ ../../third_party/ots/src/cmap.cc(153,49): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] ranges[i].id_range_offset_offset = subtable.offset(); ~ ~~~~~~~~~^~~~~~~~ ../../third_party/ots/src/cmap.cc(884,42): warning: implicit conversion loses integer precision: 'std::vector<ots::OpenTypeCMAPSubtableVSRecord, std::allocator<ots::OpenTypeCMAPSubtableVSRecord> >::size_type' (aka 'unsigned long long') to 'const unsigned int' [-Wshorten-64-to-32] const unsigned num_records = records.size(); ~~~~~~~~~~~ ~~~~~~~~^~~~~~ ../../third_party/ots/src/cmap.cc(886,30): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] !out->WriteU32(this->subtable_0_5_14_length) || ~~~~~~~~ ~~~~~~^~~~~~~~~~~~~~~~~~~~~~ ../../third_party/ots/src/cmap.cc(901,44): warning: implicit conversion loses integer precision: 'std::vector<ots::OpenTypeCMAPSubtableVSRange, std::allocator<ots::OpenTypeCMAPSubtableVSRange> >::size_type' (aka 'unsigned long long') to 'const unsigned int' [-Wshorten-64-to-32] const unsigned num_ranges = ranges.size(); ~~~~~~~~~~ ~~~~~~~^~~~~~ ../../third_party/ots/src/cmap.cc(916,48): warning: implicit conversion loses integer precision: 'std::vector<ots::OpenTypeCMAPSubtableVSMapping, std::allocator<ots::OpenTypeCMAPSubtableVSMapping> >::size_type' (aka 'unsigned long long') to 'const unsigned int' [-Wshorten-64-to-32] const unsigned num_mappings = mappings.size(); ~~~~~~~~~~~~ ~~~~~~~~~^~~~~~ ../../third_party/ots/src/cmap.cc(963,40): warning: implicit conversion loses integer precision: 'std::vector<ots::OpenTypeCMAPSubtableRange, std::allocator<ots::OpenTypeCMAPSubtableRange> >::size_type' (aka 'unsigned long long') to 'const unsigned int' [-Wshorten-64-to-32] const unsigned num_groups = groups.size(); ~~~~~~~~~~ ~~~~~~~^~~~~~ ../../third_party/ots/src/cmap.cc(985,40): warning: implicit conversion loses integer precision: 'std::vector<ots::OpenTypeCMAPSubtableRange, std::allocator<ots::OpenTypeCMAPSubtableRange> >::size_type' (aka 'unsigned long long') to 'const unsigned int' [-Wshorten-64-to-32] const unsigned num_groups = groups.size(); ~~~~~~~~~~ ~~~~~~~^~~~~~ ../../third_party/ots/src/cff.cc(69,36): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] index->offset_to_next = table->offset(); ~ ~~~~~~~^~~~~~~~ ../../third_party/ots/src/cff.cc(112,28): warning: implicit conversion loses integer precision: 'unsigned long long' to 'unsigned int' [-Wshorten-64-to-32] object_data_offset + (rel_offset - 1)); // less than length(), 1GB. ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ ../../third_party/ots/src/ots.cc(545,23): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'Cr_z_uLongf' (aka 'unsigned long') [-Wshorten-64-to-32] uLongf dest_len = *table_length; ~~~~~~~~ ^~~~~~~~~~~~~ ../../third_party/ots/src/ots.cc(776,33): warning: implicit conversion loses integer precision: 'unsigned long long' to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] out.length = end_offset - out.offset; ~ ~~~~~~~~~~~^~~~~~~~~~~~ ../../third_party/ots/src/ots.cc(793,21): warning: implicit conversion loses integer precision: 'const size_t' (aka 'const unsigned long long') to 'off_t' (aka 'long') [-Wshorten-64-to-32] if (!output->Seek(table_record_offset)) { ~~~~ ^~~~~~~~~~~~~~~~~~~ ../../third_party/ots/src/ots.cc(819,39): warning: implicit conversion loses integer precision: 'unsigned long long' to 'off_t' (aka 'long') [-Wshorten-64-to-32] if (!output->Seek(head_table_offset + 8)) { ~~~~ ~~~~~~~~~~~~~~~~~~^~~ ../../third_party/ots/src/ots.cc(826,21): warning: implicit conversion loses integer precision: 'const size_t' (aka 'const unsigned long long') to 'off_t' (aka 'long') [-Wshorten-64-to-32] if (!output->Seek(end_of_file)) { ~~~~ ^~~~~~~~~~~ BUG=879657 Change-Id: I7a69310b9672657f7373bdc79b6a4b4cb9181c12 Reviewed-on: https://chromium-review.googlesource.com/1199489 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:Behdad Esfahbod <behdad@chromium.org> Cr-Commit-Position: refs/heads/master@{#588149}
-
sebsg authored
Remove the master toggle. Add sublabels for the profile and credit card toggles. Add row to inform users if an extention is managing the toggles. Change the title from "Addresses" to "Addresses and more". Bug: 860526, 877801 Change-Id: I2d0d156108667d9463263f4e490761a506bf9a13 Reviewed-on: https://chromium-review.googlesource.com/1196924 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#588148}
-
Matthew Jones authored
Contextual search's observer is unreliable for show/hide events of the feature. This patch replaces the use of that observer with an observer that watches any overlay panel and its visibility. Bug: 878006 Change-Id: I271b61504ca99ceebe308f7a65bdb4c06ee64cc7 Reviewed-on: https://chromium-review.googlesource.com/1197166 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#588147}
-
Marina Ciocea authored
When running audio service sandboxed on Mac, the audio process is a daemon process and should not connect to launchservicesd. Bug: 874785 Change-Id: I84ffe96fea85d3d54fb9b1cca1d441b5d6f085a1 Reviewed-on: https://chromium-review.googlesource.com/1194073Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#588146}
-
chrome://webrtc-logs/Elad Alon authored
Before this CL, chrome://webrtc-logs/ only displayed textual logs. After this CL, event logs are also displayed. Bug: 775415 Change-Id: Iadfaf6173b118edb11641736b566c96b346c376e Reviewed-on: https://chromium-review.googlesource.com/1189483 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#588145}
-
Christopher Cameron authored
Take the existing BridgedNativeWidgetHost and break it into two parts - a mojo interface views_bridge_mac::mojo::BridgedNativeWidgetHost - a helper and "stuff we haven't mojo-ified-yet" interface BridgedNativeWidgetHostHelper - this is not named BridgedNativeWidgetHost to avoid conflicts - this will be moved to //ui/views_bridge_mac soon (build is tangled) Add mojo support for ui::DialogButton, because it's used by this interface. For keyboard event handling, use the BridgedNativeWidgetHostHelper interface because a mojo-compatible interface would be hard for the callers to use. Bug: 859152 Change-Id: If6802ab4d6e518184cd3fa57eef5d8a510b80e59 Reviewed-on: https://chromium-review.googlesource.com/1198014Reviewed-by:
-
Antonio Gomes authored
TBR=dullweber@chromium.org (for tools/traffic_annotation/summary/annotations.xml) BUG=773295 Change-Id: Id47e63bd76376712ab8f0a8a68edd501d8db4227 Reviewed-on: https://chromium-review.googlesource.com/1197045 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#588143}
-
James Wallace-Lee authored
When a tab-modal dialog is shown, the page underneath it is inert. But NVDA reads the page underneath the dialog when users press Insert+B to read the whole dialog. To fix this, we hide the rest of the browser from the accessibility tree when a tab-modal dialog is visible by modifying AXPlatformNodeDelegate::PopulateChildWidgetVector to return only the dialog. Bug: 775680 Change-Id: I2a5ec2eeef5ffe50ebd8819836c89ae73ddfdd36 Reviewed-on: https://chromium-review.googlesource.com/1189054 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#588142}
-
Xing Liu authored
This CL obseletes two expired histograms. And update the expired date for several others. These metrics are kept: Download.DeleteRetentionTime.Video, Android.DownloadManager.ViewRetentionTime.Video: This is recent work that PM may not have time to check the data yet. Download.ParallelDownloadAddStreamSuccess, Download.ParallelDownloadRequestCount: Still useful to monitor feature health. Bug: 876072,876070 Change-Id: Iab713f6dccf674556bd1d67d16b2f99bb3c29d5a Reviewed-on: https://chromium-review.googlesource.com/1199491Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#588141}
-
Ovidio Henriquez authored
This change adds validation checks to the USBDeviceFilter parameters passed into navigator.usb.requestDevice. Bug: 854703 Change-Id: I921a7f30a9e2ec5d46d3a74801de594565ab8a6f Reviewed-on: https://chromium-review.googlesource.com/1196034Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#588140}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a4b67d055334..4259762b3597 git log a4b67d055334..4259762b3597 --date=short --no-merges --format='%ad %ae %s' 2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@4259762b3597 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ie4d420f3db00e4c39a0038a227c7453b332fbeef Reviewed-on: https://chromium-review.googlesource.com/1199690Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588139}
-
Dominick Ng authored
With UserActivationV2, user gestures no longer expire in 1 second. This CL consumes the user activation when the method is called in order to avoid multiple usages of the beforeinstallpromptevent.prompt() method with only one activation. This CL also fixes a test to trigger beforeinstallpromptevent.prompt() on keyUp rather than keyPress. This avoids a race condition where the user activation is generated *after* the consuming call to prompt(), causing subsequent tests to fail as they assumed the gesture had been consumed when it was actually being immediately regenerated. BUG=869756 Change-Id: Ie9249c0933a5c8f263de4171ec2559cd4f0e80f8 Reviewed-on: https://chromium-review.googlesource.com/1196622Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#588138}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/2b59aaeee137..d636a4fae3c1 git log 2b59aaeee137..d636a4fae3c1 --date=short --no-merges --format='%ad %ae %s' 2018-08-31 dschuff@chromium.org Make posix code compile with -Wimplicit-fallthrough Created with: gclient setdep -r src/native_client@d636a4fae3c1 The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:868204 TBR=mseaborn@chromium.org Change-Id: Ic373070648e879ba67572bff0d849362f6da1ff3 Reviewed-on: https://chromium-review.googlesource.com/1199692Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588137}
-
Eric Karl authored
We currently unlock pre-decoded images after 2 frames of any type. This doesn't always give callers a chance to use their images (if main thread is a bit backed up). Instead we should wait for the caller to actually use the image. Additionally, we drop images after 250ms to prevent excessive growth if a user fails to use images in a timely manner. See the linked bug for example traces which show the benefits. This re-land updates image_decoder_runner.js to avoid errors due to variable decoding times leading to image cache exhaustion. R=khushalsagar Bug: 869491 Change-Id: I90c6665684b74c779810b6dee963b2a62b26cb2a Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1159203 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#583171} Reviewed-on: https://chromium-review.googlesource.com/1196235Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#588136}
-
Leonard Grey authored
GPU v1 sandbox removes condition since we don't have the os-version variable there (per offline discussion). Bug: 879646 Change-Id: I06b29d1c6b4b6fd621a5b2497b0a2b78fe36c85f Reviewed-on: https://chromium-review.googlesource.com/1200184Reviewed-by:
-
Marton Hunyady authored
Rename the following values for better understanding and consistency: - RollbackWithFullPowerwash to RollbackAndPowerwash - RollbackWithRestoreOnly to RollbackOnlyIfRestorePossible Bug: 878736 Change-Id: Ia617d4e6402b3ad5cd5a0791735160b8dbe593b3 Reviewed-on: https://chromium-review.googlesource.com/1196376Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Marton Hunyady <hunyadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#588134}
-
Clark DuVall authored
This reverts commit 22b92b16. Reason for revert: Fixed bug where listeners would not be notified when waiting for initial connection status. This change fixes the bug and adds a regression test. In addition, this puts the change behind the ResourceRequestAllowedMigration feature, as suggested by asvitkine@. We can test this on Canary to make sure the Variations.SeedFreshness metric is not affected. Note that the Variations.ResourceRequestsAllowed will have different behavior with this change, as now instead of just sending RESOURCE_REQUESTS_ALLOWED when the network is connected, it will send RESOURCE_REQUESTS_NOT_ALLOWED_NETWORK_STATE_NOT_INITIALIZED and then RESOURCE_REQUESTS_ALLOWED_NOTIFIED. This hopefully should not affect Variations.SeedFreshness. See diffs starting at Patchset 1 for changes from last reland. Some of the old code needed to be added back to support both versions behind the feature flag. Original change's description: > Revert "Reland "Reland "Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker""" > > This reverts commit 34141782. > > Reason for revert: Caused Finch seed freshness regression, see http://crbug.com/879252 and > http://crbug.com/879115 > > Original change's description: > > Reland "Reland "Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker"" > > > > This is a reland of e00fddec > > > > Needed to initialize variables in ChromeBrowserMainBrowserTest for asan/msan. > > Verified this works with msan build. > > > > Original change's description: > > > Reland "Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker" > > > > > > This is a reland of a9ed46b7 > > > > > > ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange > > > was flaky in the original change. Added logic in the test to wait for the > > > connection type change. > > > > > > Only diffs from original are in chrome/browser/chrome_browser_main_browsertest.cc > > > > > > Original change's description: > > > > Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker > > > > > > > > A getter is used for NetworkConnectionTracker because some services that > > > > use ResourceRequestAllowedNotifier are initialized early in browser > > > > startup (e.g. VariationsService), and only perform the initialization > > > > of ResourceRequestAllowedNotifier later on the UI thread. The getter > > > > allows us to run get the connection tracker at that point so we don't get > > > > DCHECKs about being on the UI thread when running > > > > content::GetNetworkConnectionTracker(). > > > > > > > > This also moves the NetworkConnectionTracker in ios/ from BrowserState to > > > > ApplicationContext, which is available everywhere. It also matches non-IOS > > > > usage more closely, since we have it as a global there. > > > > > > > > Bug: 868021 > > > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > > > > Change-Id: I130c6b47feb90f0f7f0776ccc65666414a1ae802 > > > > Reviewed-on: https://chromium-review.googlesource.com/1180360 > > > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > > > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > > > > Commit-Queue: Clark DuVall <cduvall@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#584849} > > > > > > TBR=eugenebut@chromium.org,rsesek@chromium.org,rmcelrath@chromium.org,jam@chromium.org > > > > > > Bug: 868021 > > > Change-Id: I5941b72474657159f0d4a1e6667fd77a3c475887 > > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > > > Reviewed-on: https://chromium-review.googlesource.com/1185602 > > > Reviewed-by: Clark DuVall <cduvall@chromium.org> > > > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > > > Commit-Queue: Clark DuVall <cduvall@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#585387} > > > > TBR=eugenebut@chromium.org,rsesek@chromium.org,rmcelrath@chromium.org,jam@chromium.org > > > > Bug: 868021, 876861 > > Change-Id: I46fccf072d0b3080603e97c73ff055ac7c45e723 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > > Reviewed-on: https://chromium-review.googlesource.com/1187081 > > Commit-Queue: Clark DuVall <cduvall@chromium.org> > > Reviewed-by: Clark DuVall <cduvall@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#585565} > > TBR=jam@chromium.org,eugenebut@chromium.org,rsesek@chromium.org,rmcelrath@chromium.org,cduvall@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 868021, 876861, 879252, 879115 > Change-Id: If0417f53386a94de0ec3b64c283df123c673ec03 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs > Reviewed-on: https://chromium-review.googlesource.com/1197325 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587694} TBR=eugenebut@chromium.org Bug: 868021, 876861, 879252, 879115 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2190d82f8de1188763b6f1bb1de2b8762d23aa07 Reviewed-on: https://chromium-review.googlesource.com/1198102 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#588133}
-
John Budorick authored
Change-Id: I6bfcf3efbe4dbcfa769afb77e732050f6527703c Reviewed-on: https://chromium-review.googlesource.com/1199766Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#588132}
-
Sébastien Séguin-Gagnon authored
From Enabled to FullLaunch Change-Id: I7f6c6ccc924d7aa012e648e0c5eab9c3fe289494 Reviewed-on: https://chromium-review.googlesource.com/1199563Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
-
François Beaufort authored
This makes sure Picture-in-Picture window always shows up inside the work area when surface ID is updated. Bug: 873657 Change-Id: Ibc9a640d527f51e5311a411b86af23eb61617f37 Reviewed-on: https://chromium-review.googlesource.com/1196363Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#588130}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1940d7df3f6d..68de241167e0 git log 1940d7df3f6d..68de241167e0 --date=short --no-merges --format='%ad %ae %s' 2018-08-31 gmeinke@chromium.org parallel_emerge: remove saving of install plan Created with: gclient setdep -r src/third_party/chromite@68de241167e0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Icdcd82d4d9376b0ad769a532b0715c15610de554 Reviewed-on: https://chromium-review.googlesource.com/1199693Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588129}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cd6bcbe53ba7..6fc719e87628 git log cd6bcbe53ba7..6fc719e87628 --date=short --no-merges --format='%ad %ae %s' 2018-08-31 zmo@chromium.org Remove removed folder from telemetry isolate 2018-08-31 chiniforooshan@chromium.org Tracing: Fix an input latency bug 2018-08-31 pasko@chromium.org devil: refactor perf_control.py for upcoming N5X support 2018-08-31 anthonyalridge@google.com Improve dot stacking algoritm to handle small numbers. 2018-08-31 anthonyalridge@google.com Flip axes for CFG. 2018-08-31 achuith@chromium.org oobe: Catch WebSocketException. Created with: gclient setdep -r src/third_party/catapult@6fc719e87628 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879523,chromium:383566,chromium:866423,chromium:866423,chromium:879353 TBR=sullivan@chromium.org Change-Id: Ieb839c3ef97435a3479cfb2b98d5441308e1dd70 Reviewed-on: https://chromium-review.googlesource.com/1199691Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588128}
-
Alexandr Ilin authored
This CL adds end to end tests for the LoadingPredictor. There are two categories of tests: * Web platform link rel features tests. * Learning from past navigations tests. Bug: 602396 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic51c77f7289ec08b99341ef1d51a6fa01c64309b Reviewed-on: https://chromium-review.googlesource.com/1185191 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#588127}
-
Chris Palmer authored
Like IPC, but for code that has heightened memory-safety requirements. Bug: None Change-Id: I9a7e2ba77b140e560f05cb850136697f3c5fb95a Reviewed-on: https://chromium-review.googlesource.com/1196006Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
