- 07 Nov, 2019 40 commits
-
-
Raymond Toy authored
Since the baseLatency value is fixed after construction, compute the value when the AudioContext is constructed and cache the value so that any queries just return the value from the slot. Bug: 1005150 Change-Id: I0a4b8c4fb42deb5721f0ecdce5a8bc3b3c4cb26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903750Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#713643}
-
Hongchan Choi authored
See details: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWwsSBUZsYWtlIlBjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFBhc3N3b3JkTWFuYWdlckJyb3dzZXJUZXN0LkZpbGxXaGVuRm9ybVdpdGhIaWRkZW5Vc2VybmFtZQw TBR=dvadym@chromium.org Bug: 1022531 Change-Id: I6886d88aa677c1791510babfeefe605fb2bedd42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904547Reviewed-by:
-
Scott Violet authored
BUG=1018148 TEST=none Change-Id: Icb07328be04799cd4d7c87d4f07b47976aa33982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904501Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#713641}
-
Jacob DeWitt authored
It is no longer needed, now that WebVR is gone. Change-Id: I7bfca2156c06a447439c42b08673e5d422daf628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893526Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#713640}
-
Trent Apted authored
This allows client code to type-check JS with (e.g.) js_type_check("closure_compile") { closure_flags = default_closure_args + [ "jscomp_error=strictCheckTypes", "jscomp_error=reportUnknownTypes", ] ... } for picking up a wide class of type errors that otherwise slip through. Note the maintenance cost of actually _landing_ a rule with `reportUnknownTypes` is probably too high. The purpose of this CL is to at least allow developers to temporarily add reportUnknownTypes to validate their own type coverage accurately in a chrome developer checkout. Suppresses: ../../ui/webui/resources/js/assert.js:**: ERROR - [JSC_UNKNOWN_EXPR_TYPE] could not determine the type of this expression 20: if (!condition) { ^^^^^^^^^ 26: const global = function() { ^^^^^^^^^^^^ 27: const thisOrSelf = this || self; ^^^^ 29: thisOrSelf.traceAssertionsForTesting; ^^^^^^^^^^ 30: return thisOrSelf; ^^^^^^^^^^ 32: if (global.traceAssertionsForTesting) { ^^^^^^ 37: return condition; ^^^^^^^^^ Bug: 1000989 Change-Id: I73564b17688df1b08d2a2eb6f78177dcde39faa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902182Reviewed-by:Dan Beam <dbeam@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#713639}
-
Collin Baker authored
Bug: 1009122 Change-Id: Ibb162f7a9766083be5cdd17f40f88d6a049eb351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904611Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#713638}
-
Andrey Kosyakov authored
Bug: 1022173 Change-Id: Ifa07c62fda098ba0cbdf7f62f50cf9a98b29876a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902475 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#713637}
-
Sean Topping authored
Updates the ownership model of CastWebView so that users "borrow" the CastWebView, returning ownership to CastWebService when the user goes out of scope. Web page lifetime can be extended beyond the lifetime of the user, facilitating smooth transitions between pages (no intermediate black screen) and simplifying logic for extended shutdown. Merge-With: eureka-internal/313200 Bug: internal b/77879457 Bug: internal b/130320237 Test: Start multiple apps in sequence, verify successful transition with no crashes. Change-Id: Ic03217ed6d3abb8a74d012c9d6b11bd1a8d92c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895504 Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#713636}
-
Aaron Colwell authored
Temporary fix that creates an exception for 'no access' URLs like chrome-native://history. These URLs can cause a origin mismatch in the commit code because of slight differences between how url::Origin and blink::SecurityOrigin handle 'no access' URLs. This is intended as a low risk change that can be easily merged to the M79 branch. Bug: 1016711, 923144 Change-Id: I8ab833744f45ebfbc489118313c59d7bbfdaff78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900358 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#713635}
-
Thomas Guilbert authored
This CL adds the plumbing necessary in WMPI to initiate and complete a requestAnimationFrame call. For the moment, WebMediaPlayerClient doesn't do anything with the frame returned, but this will be updated in upcoming CLs. Bug:1012063 Change-Id: I99c951bf0d6317bb81986166e57ec250d47dc1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900350 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#713634}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5d41eaf0f6ae..f0d1100a7149 git log 5d41eaf0f6ae..f0d1100a7149 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 lalitm@google.com Merge "trace_processor: fix test failure and swap around counter <-> counter_values" Created with: gclient setdep -r src/third_party/perfetto@f0d1100a7149 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic8f4cc210e52d8a7de8af66fc67f61bbde32e63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904455Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713633}
-
Xiyuan Xia authored
This reverts commit e6093e9b. Reason for revert: The CL causes memory corruptions on linux-trusty-rel and msan bots, which triggers crash in random places (mostly in cc::Animation::DetachElement somehow). See https://crbug.com/1021553 Original change's description: > Reland "Fix emission of AtkValue property change signal" > > This version adds protected memory support to handle calling ATK methods > dynamically on the CFI bot. > > Original change's description: > > Reland "Fix emission of AtkValue property change signal" > > > > This version checks at runtime for atk_value_set_value during testing. > > This should allow the change to work on bots running trusty. > > > > Original commit message: > > > > > The introduction of text-change signals for the omnibox included a > > > regression that prevented the emission of AtkValue property change > > > signals. Fix this error and also add an implementation of > > > atk_value_set_value. The implementation is used in a test to verify the > > > correct behavior. > > > > > > The fix is that we correct the misuse of a logical operator and now > > > always try to emit AtkValue property change events when receiving the > > > kValueChanged event in AXPlatformNodeAuraLinux. > > Bug: 1015387 > Bug: 1017177 > Bug: 1017548 > > Change-Id: Iadaea4569944ad0a1be0e1211bbce4ed2c4f6935 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879255 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com> > Commit-Queue: Martin Robinson <mrobinson@igalia.com> > Cr-Commit-Position: refs/heads/master@{#710699} TBR=mrobinson@igalia.com,tikuta@chromium.org,jdiggs@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015387, 1017177, 1017548, 1021553 Change-Id: Ie661eeb75dd42ddff34e2ff04623bf2b9af30cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904504Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713632}
-
Will Harris authored
BUG=1016906 Change-Id: I601f1c1cc3f23c5598d5bedf3b22ad6fbf810cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904306Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#713631}
-
Andrew Xu authored
When ScrollableShelf is enabled, the shelf icon under drag is actually the proxy icon created by ScrollableShelfView while the original shelf icon is transparent. However, when dragging an icon which is already pinned on Shelf from AppsGridView, if the drag gets canceled, the original shelf icon fails to show. This CL fixes such an issue. A unit test is created for this scenario. Bug: 1021768 Change-Id: Ibfce9ae3c59c21ac7d7e515b3a3a733e453fe5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902511Reviewed-by:
-
Trent Apted authored
IIFE is "Immediately Invoked Function Expression". It wraps the compiled output like (function () { <compiled code> }).call(this);. This is the recommendation given at http://go/js-practices/build-rules#use-isolation-modeiife-or-equivalent Without it, closure-compiled symbols pollute the global JS context and can prevent mojo bindings being used in a regular/standalone closure-compiled app. E.g., errors like, JS ERROR: '[..:ERROR:CONSOLE(1)] "Uncaught SyntaxError: Identifier 'ra' has already been declared" Bug: 996088 Change-Id: Icef1a1c0d14a3f2b8cefbce12e08348a8c63b9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903228Reviewed-by:Ken Rockot <rockot@google.com> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#713629}
-
Hongchan Choi authored
See details in: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVycgsSBUZsYWtlImdjaHJvbWl1bUBjb250ZW50X3NoZWxsX3Rlc3RfYXBrQG9yZy5jaHJvbWl1bS5jb250ZW50LmJyb3dzZXIuSW50ZXJzdGl0aWFsUGFnZVRlc3QjdGVzdENsb3NlSW50ZXJzdGl0aWFsDA TBR=jinsukkim@chromium.org Bug: 1022324 Change-Id: I36eb261d9f8c0f33884b2c40ee5d6f92aaeae494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903541Reviewed-by:
-
tby authored
The metrics provider class is going to be almost completely rewritten for the framework. It will make future CLs cleaner to start at a blank slate. Bug: 1016655 Change-Id: Ib0e02d7632df11b01167a566db4eac4cbda6acab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903107Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#713627}
-
Miyoung Shin authored
The reason for the flaky Mojo connection of ContentSettingsManager was that |content_settings_manager_| tried to connect to its receiver via BrowserInterfaceBroker in ContentSettingsAgentImpl ctor once, but BrowserInterfaceBroker could be reset before |content_settings_manager_| was connected. This CL ensures its connection to retry in DidCommitProvisionalLoad if it is not connected. Bug: 936482 Change-Id: I29db1ea13e2fa4de49f431d07ac249ed6e318d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897576Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#713626}
-
David Benjamin authored
rsleevi pointed out this didn't need to be thread-affine. (I've long since lost track of what all our random PostTask hooks do...) Bug: none Change-Id: I6d7dc61684202383787012853bb55fab8376d42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904123 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#713625}
-
Zhongyi Shi authored
QuicChromiumPacketReader when processing probing result (aka probing reader), may gets deleted by the QuicChromiumClientSession while the connection stays open. This change grabs a weak_ptr before calling up to session (visitor) and stops future reads if the reader is invalid. Bug: 1014092 Change-Id: I4a1ccc437692b9845c2cb8bf0c6bcc1feb1b7610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904526Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#713624}
-
Hazem Ashmawy authored
Polish WebView crash UI layout: - Use android material theme and support dark theme. - Use an expandable list to show crashes where we show the important info (package name and crash capture time in the header) and show variation keys, upload status, report button in the expanded body. - Use a more descriptive string for the reporting button "File bug report" instead of "Provide more info". - For better visualization, show app icon next to package name to be easy to find by eye. - Use ListViewAdapter#notifyDataSetChanged() instead of creating new adapter to optimize crash list updates. - Update MainActivity to use the new two_line_list_item layout. Bug: 948923 Test: Manually inspect the UI on SystemWebView on Android P and Android Q with dark mode switched on/off. Change-Id: Ic9d4fffc6f24a409f06927b91b160280c5781e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899371 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#713623}
-
Daniele Castagna authored
This CL adds support for dbus "AmbientColorTemperatureChanged" signal. A new method AmbientColorChanged is added to PowerManagerClient and it will be called every time powerd emits a new ambient color temperature. A prototpe using the new signal can be found here: crrev.com/c/1883289 Bug: b/138731765 Test: chromeos_unittests --gtest_filter=PowerManagerClientTest.ChangeAmbientColorTemperature Change-Id: Idf6462e90f4c378cd03dfd131434e045748deaf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900432 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#713622}
-
Mingjing Zhang authored
This CL changes the tracker's trace object to a stringstream, allowing the logging of more types of data. This CL also takes advantage of said feature to log |begin_main_frame_data_.previous_sequence| and |args.sequence_number| in ReportBeginMainFrame() and ReportMainFrameCausedNoDamage(). Bug: 1017291 Change-Id: I81330b10fa2347658587ee1f9e320fb185ae35cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903609Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#713621}
-
liberato@chromium.org authored
SmoothnessHelper records the worst-case observed dropped frame ratio among fixed-length segments of a video playback. It records these, along with features describing the playback to a LearningTaskController for the MediaCapabilities ML experiment. Change-Id: Iaecd5f71af9b4439ac87c9c00d7aa453b3b4e8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863386 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#713620}
-
Joel Hockey authored
Added in https://codereview.chromium.org/2149323003, but currently has no callers. Change-Id: Ieb1de40e9a20f563b060e30db71516d68cdb6ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903172Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/500af51d..a9c5d494 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ied77523b0c9e2b161f4c7b9b8c8d8c59ee6293a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902442Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713618}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/12cea8d6c429..81a8d282d356 git log 12cea8d6c429..81a8d282d356 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 mtklein@google.com Reland "hook up float comparisons to x86 JIT" 2019-11-07 herb@google.com Remove unused methods from SkStrike 2019-11-07 mtklein@google.com avoid the JIT on MSAN builds 2019-11-07 halcanary@google.com SkPDF/docs: note that Sfntly subsetter is deprecated 2019-11-07 herb@google.com One glyph() to rule them all!!! 2019-11-07 reed@google.com flesh out blendmodes through Screen 2019-11-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-07 robertphillips@google.com Use GrProgramInfo's primitiveType field 2019-11-07 mtklein@google.com Revert "hook up float comparisons to x86 JIT" 2019-11-07 egdaniel@google.com Add handling of failed framebuffer creation in vulkan. Created with: gclient setdep -r src/third_party/skia@81a8d282d356 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I6596a05a5f1c891e333a1e35adeb89a19cfc6e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904454Reviewed-by:
-
Javier Fernandez authored
This CL implements several tests, fundamentally for the 'line-break: anywhere' feature, to increase the coverage and evaluate different scenarios, combining different line-breaking CSS properties and values. They also consider text lines with different inline boxes and some corner cases that were recently discussed by the CSS WG and implemented already in other browsers. Change-Id: Ic6079a95df7adf265799ce51938433e14355b887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904077Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#713616}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 80-3943.1-1572866479-benchmark-80.0.3960.0-r1 to 80-3943.1-1572866479-benchmark-80.0.3961.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I08e9db631d8ca4b5a6a7f6959234ec7bcb99610c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903724Reviewed-by:
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/b47c6e25f9..5cb14a4f30 TBR=mjackson@microsoft.com Change-Id: I94f2e84e900f69c3115b1f6df416ed986e0deeb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904171Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#713614}
-
chrome://autofill-internalschrome://chrome-urlsVadym Doroshenko authored
Change-Id: Ic05a31d62eb7697474d6e2fd49a8a527cca9138b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904071 Auto-Submit: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
Henrique Nakashima authored
Specifically, order of modifiers and explicit braces. Refactor: https://chromium-review.googlesource.com/c/chromium/src/+/1901635 Bug: 889467 Change-Id: Idac01679dd7aa69360e65ea473b4b420ea46386b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904446Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#713612}
-
rajendrant authored
The earlier URL /connect is navigated internally by the data saver secure proxy checker. This could lead to confusion w.r.t. such bfcache features that could return the cached response instead. So navigating to a different URL. Fixed: 1019976 Change-Id: I6450c1f48c6b8c9f089261f9d1693218240ddd3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903929Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#713611}
-
Michael Crouse authored
This change enables the OptimizationGuideStore to be able to store and load PredictionModels for use by the optimization guide. The next change will add a similar interface for host model features. Bug: 1001194 Change-Id: I3ecacf7be29ce0378882ba9d5022003d6c899662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900399 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#713610}
-
Clark DuVall authored
When looking for untested parts of the public WebLayer API, found we don't have tests for ObserverList. This copies the tests from the //base version. //base runs these tests by including them in the content_shell instrumentation tests, so do the same thing here by including them in weblayer instrumentation tests. Change-Id: I7cbacf6efdb8c9f0bcdebc96cafdb7274b392d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903664Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/afa7840d8e0c..4e10964bf967 git log afa7840d8e0c..4e10964bf967 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 vapier@chromium.org cros lint: make no-op runs fast Created with: gclient setdep -r src/third_party/chromite@4e10964bf967 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I84e89f21c397689384fc565ed9b75ca6fa605ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904452Reviewed-by:
-
Andres Calderon Jaramillo authored
This CL makes the ImageDecodeAcceleratorStub handle failures in the ImageDecodeAcceleratorWorker more gracefully: instead of tearing down the GpuChannel, we just don't add an entry to the transfer cache. This should have the effect of just not drawing the image at raster time. The motivation is that tearing the channel down can make us go into a loop: when the channel goes down, the renderer will try to re-establish it and request the image decodes again which will probably cause the channel to be destroyed again. Ideally, these failures don't happen because the renderer is supposed to check that the image is supported by the hardware decoder before requesting a decode. However, in practice it could happen if the hardware decoder supported profile happens to be incomplete or if the image header is fine but the rest of the image is corrupt. This CL also makes all other failures in the IDAStub be handled in the same manner. visually on a Chromebook device. Bug: 1013502 Test: The IDAStub tests are adapted to the new behavior. Also tested Change-Id: I5648f1269e625bf23e75fe3ddbbbd2ffa6e5f913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855558 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#713607}
-
chromium-autoroll authored
Roll airmont AFDO profile from 80-3945.13-1572864139-benchmark-80.0.3960.0-r1 to 80-3945.13-1572864139-benchmark-80.0.3961.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I0df8594a3b639b5821800d5a90e2764a9e1cb1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903897Reviewed-by:
-
Thomas Tellier authored
Bug: 982161 Change-Id: I61ec64560044a73687ced8b8766d71db78f83180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903142 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713605}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 80-3943.1-1572873357-benchmark-80.0.3960.0-r1 to 80-3943.1-1572873357-benchmark-80.0.3961.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I48b360e3ace5b8a91120599d6282bb04aa668671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904566Reviewed-by:
-
