- 06 Aug, 2020 40 commits
-
-
Koji Ishii authored
This reverts commit fd0f9b34. This patch restarts collecting following histograms again, as we try to enable them on Win/Linux/ChromeOS, and the discussion restarted. > Stop collecting hyphenation histograms > > This patch removes following histograms: > Hyphenation.Open > Hyphenation.Open.File > > These are added to learn how long it will take to open > hyphenation dictionary. A concern was raised when I > implemented hyphenation on Android as the open operation is > synchronous. > > We do not see the data indicating needs to invest in > asynchronous hyphenation at this moment, and the data is > steady that further recording does not seem to be necessary. > > Bug: 975142 > Change-Id: I1d98eedf47a1afa5940f6e01b3c6fadcca4cbcdf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664092 > Reviewed-by: Emil A Eklund <eae@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#670299} Bug: 975142 Change-Id: I72ed8a0a085b873abcab1db86c28a0ef0aa81a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340065 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#795355}
-
Alexey Baskakov authored
This reverts commit 43a3abc8. Reason for revert: Fails MacOS 10.11 and 10.12 bots VTConfigUtil.GetImageBufferColorSpace_BT2020_* https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/53189 Original change's description: > Re-enable VTConfigUtil tests for BT.2020 HDR on 10.10 > > These should expect BT.709 when the proper color spaces are not > supported by the OS version. > > R=sandersd > > Fixed: 1113153 > Change-Id: I86805fc80904236d5051ece61ce6612e3b64e74d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339538 > Auto-Submit: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795310} TBR=dalecurtis@chromium.org,sandersd@chromium.org Change-Id: I92432c0bf73d1487553f41190346f7d79ae8e0ef No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340627Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#795354}
-
Hiroshige Hayashizaki authored
When an exception is thrown in workers, ExecutionContext::DispatchErrorEvent() is called [A] From V8Initializer::MessageHandlerInWorker() in some cases and [B] Directly (without MessageHandlerInWorker()) in other cases, which leads calling WorkerGlobalScope.onerror. When an exception is thrown from the WorkerGlobalScope.onerror handler, MessageHandlerInWorker() is called [A] reentrantly from MessageHandlerInWorker(), and [B] not reentrantly. Because MessageHandlerInWorker() contains a reentrant check, a part of unhandled exception handling is skipped only in cases [A], but not in [B]. This CL removes the reentrant check to always perform the unhandled exception handling, thus fixing the behavior of crbug/1112228. Skipping the reentrant check leads calling ExecutionContext::DispatchErrorEvent() from outer ExecutionContext::DispatchErrorEvent(), but DispatchErrorEvent() is already reentrantly called in cases [B], and DispatchErrorEvent() contains its own reentrant handling code. Bug: 1112228, 1111134, 1111750 Change-Id: I87b12ddad3fe082bea3429f8801563d08fc0cd6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332091 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#795353}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b72037527fd5..d2f4008a5291 2020-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 076a4e58205d to fa4b74d479aa (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I05034d85666284099d9404698f2c8af23f3a6611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340663Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795352}
-
Kenichi Ishibashi authored
Bug: N/A Change-Id: Id8050ad419632332b564cf5eee8e0475ee6e120f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340783Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#795351}
-
Joel Hockey authored
Bug introduced in crrev.com/c/2318945 / 86.0.4215.0 Fixed already in crrev.com/c/2326552 / 86.0.4218.0 This test verifies that even when Terminal has some pref values, it correctly merges with app values and creates a valid registration. Bug: 1113477 Change-Id: I3a51ae3713384284075677d2e531c28aa901e780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340345Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#795350}
-
Peter Kasting authored
This is useful for callers who never want to cancel callbacks and can guarantee the lifetime requirements. For example, callbacks bound on the same object that owns the CallbackList. Bug: 1113007 Change-Id: I258d029360213a689bf888cca662ae56dec4cd74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337537 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#795349}
-
Hiroshige Hayashizaki authored
Failing on Chromium and passing on Firefox and Safari. third_party/blink/web_tests/fast/workers/worker-onerror-04.html is removed because now it's covered by the WPT. Bug: 1112228 Change-Id: If407eb1c96b29357bbc0468e1a6abb30d2891447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331794 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#795348}
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/e3af529e511c..cdb7d2b9bc0d $ git log e3af529e5..cdb7d2b9b --date=short --no-merges --format='%ad %ae %s' 2020-08-02 ebrahim [docs] Update README.python.md with meson 2020-08-02 ebrahim [docs] Adopt CONFIG.md with meson 2020-08-02 ebrahim [docs] Remove packagers related part 2020-08-02 ebrahim [ci] Disable Travis CI 2020-08-02 ebrahim [meson] limit check-libstdc++ check to 0.55 2020-07-30 ebrahim [meson] Add darwin versions to library() 2020-07-31 grieger [ENOMEM] check vector status in cmap subsetting. 2020-07-31 grieger [ENOMEM] in GSUB ChainContext subsetting check maps for allocation errors. 2020-07-31 grieger [ENOMEM] Check result of vector resize in CBDT subsetting. 2020-07-31 ebrahim [ci] don't install rustc on linux-ci 2020-07-31 ebrahim [cff] Check for scalars array resize result 2020-07-30 grieger [ENOMEM] popragate packed/packed_map errors to the serializer. Will disable further modifications based on a bad state. 2020-07-30 grieger [ENOMEM] unchecked resize in CFF2. 2020-07-30 grieger [ENOMEM] Fix several instances of not checking resize in CFF. 2020-07-30 grieger [ENOMEM] check for unset current in serializer->length(). 2020-07-30 ebrahim Copy parts of README.md to README 2020-07-30 ebrahim [meson] minor, use null_dep one more place 2020-07-30 ebrahim Remove cmake build files 2020-06-18 ebrahim Add comparison against ttf-parser 2020-07-30 ebrahim [docs] Update TESTING.md with meson 2020-07-29 grieger [ENOMEM] fix memory leak if allocation fails during pop_pack(). 2020-07-29 grieger [ENOMEM] make serializer modification operations no-ops if it's in an error state. 2020-07-30 ebrahim [icu] Remove support for versions older than 49 2020-07-30 ebrahim [icu] Remove useless HB_UNUSED tags 2020-07-30 ebrahim [icu] Remove support of ICU versions before 42 2020-07-29 grieger [ENOMEM] Fix failure to check calloc return. Fixes https://oss-fuzz.com/testcase-detail/6246465148813312. 2020-07-29 grieger [ENOMEM] check resize() return. Fixes https://oss-fuzz.com/testcase-detail/5641892164009984. 2020-07-29 ebrahim [docs] Use untouched result of rsvg-convert for HarfBuzz.svg render 2020-07-29 ebrahim [ci] Install meson's master 2020-07-29 ebrahim minor spacing tweak 2020-07-29 ebrahim minor spacing tweak 2020-07-29 ebrahim minor spacing tweak 2020-07-29 ebrahim [ENOMEM] Fix buffer's content check logic 2020-07-14 ebrahim [fuzz] Implement failing allocator 2020-07-29 ebrahim [glib] Default to glib's script type handling 2020-07-28 grieger [subset] bail out of subsetting if plan allocation fails. 2020-07-27 ebrahim [tests] minor 2020-07-27 ebrahim [tests] Use TTFont of fonttools to avoid temp files 2020-07-26 hamidrezabayat76 Use fonttools's python package instead of cli 2020-07-25 ebrahim [ci] meson-gcc-mingw to crossbuild-win32 2020-07-25 ebrahim [releasing] unbreak the build 2020-07-25 ebrahim [releasing] Use release buildtype 2020-07-25 ebrahim 2.7.0 2020-07-23 razrfalcon Remove unused code from the Khmer shaper. 2020-07-22 ebrahim [meson] Rename 'gtk_doc' option to 'docs' 2020-07-22 ebrahim [ci] Don't run cov-analyze 2020-07-22 ebrahim minor 2020-07-22 ebrahim [fuzz] increase shape fuzzer timeout 2020-07-20 boboniboni [tests] fix PGO build testing 2020-07-20 ebrahim [ci] disable clang nightly installation (...) 2020-06-10 ebrahim [meson] Implement disabled state for cairo/freetype/icu 2020-06-09 nirbheek meson: Export symbols for a DLL when not building statically 2020-06-08 khaledhosny [coretext] Properly check for macOS 10.10 2020-06-06 ebrahim [meson] Remove with_libstdcxx build option 2020-06-05 behdad s/blacklist/blocklist/g 2020-06-05 ebrahim [meson] Add -Bsymbolic-functions 2020-06-02 ebrahim [meson] Make gobject and introspection features automatic 2020-06-05 ebrahim minor, improve the need for graphite comment 2020-06-03 reiter.christoph [meson] Only pass required dependencies to everything 2020-06-04 ebrahim [style] Hide behind HB_EXPERIMENTAL_API compile flag 2020-04-21 ebrahim [style] Adopt with meson 2020-02-08 ebrahim [style] give ptem value when asked for opsz 2019-08-04 ebrahim [style] New experimental API, hb_style_get_value 2020-06-04 ebrahim [meson] fix with_libstdcxx effect 2020-06-04 ebrahim [meson] Update subset tests list from autotools 2020-06-04 ebrahim [ci] fix meson-gcc-mingw bot 2020-06-04 ebrahim [ci] check workability of meson based dist 2020-06-04 ebrahim [ci] Deploy only when there is something to push 2020-06-04 ebrahim [meson] Fix gen-hb-version.py run 2020-06-04 ebrahim [meson] Remove amalgam build option 2020-06-04 ebrahim [ci] Move docs deployment from autotools to meson 2020-06-03 ebrahim [meson] fix gen script input 2020-06-03 ebrahim Use output names in update-unicode-tables.make 2020-06-03 ebrahim 2.6.7 2020-06-02 ebrahim Move unicode tables update script to its own make file 2020-06-02 ebrahim minor, fix hb-version.h generation for out-of-tree builds 2020-06-02 ebrahim minor fixes on src gen scripts 2020-06-01 ebrahim Build win32 artifacts using meson 2020-05-31 ebrahim [tests/aots] move the update script to update.py 2020-05-31 ebrahim [tests/test-rendering-tests] run git pull on correct dir 2020-05-31 ebrahim minor, fix extra dist list 2020-05-31 ebrahim [test/text-rendering-tests] Adopt the update script with meson 2020-05-31 ebrahim [test/text-rendering-tests] Update from upstream 2020-05-31 ebrahim [tests] Port text-rendering-tests update script to python 2020-05-30 ebrahim [meson] Categorize tests using `suite: [...]` 2020-05-30 ebrahim [ci] fix alpine build issue 2020-05-29 ebrahim [tests] Port check scripts to python 2020-05-29 ebrahim [meson] reflect chosen linker update 2020-05-29 ebrahim [meson] minor, find run-tests.py only once 2020-02-18 qxliu [subset] GDEF AttachList subsetting support 2020-05-29 ebrahim minor on python scripts 2020-05-29 ebrahim minor, use py3's open(encoding=) 2020-05-28 ebrahim minor, enable printing to stderr in run-tests.py 2020-05-28 ebrahim minor, use sys.exit print shorthand 2020-05-28 ebrahim minor, move scripts manuals to __doc__ 2020-05-20 qxliu [subset] ChainContext subsetting fix: add lookup index remapping 2020-03-30 simon More strictly follow noun/verb/identifier format for GPOS/GSUB lookups 2020-03-30 simon Reformat kerx/morx instrumentation to 'verb noun identifier' 2020-03-30 simon Add table index to lookup messages 2020-03-30 simon Instrument entering GSUB/GPOS tables Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org Change-Id: I397e890f896e74221788acf630172fb18cdbe5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336089 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#795347}
-
Fergus Dall authored
This is currently ignored by concierge when starting termina, but since termina can now be installed in multiple different locations we need concierge to start taking the value that chrome sets. Bug: 953544 Change-Id: I51b1ea50a5ae056d6af6baa0743a3cb0c8f8f5e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329126 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#795346}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f52572f002a6..dcb6f8084e45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6fac3870b889b705b164292b0719b4db16463d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340448Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795345}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a4a8199cf1a3..9a4b91647e23 2020-08-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I74cf115aed254642abb7e0f54e043e507c75df5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339800Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795344}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a19fe997b33..f7f6b8b6f018 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC loyso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: loyso@google.com Change-Id: Iab96829eaea4fac926c3efb50d9e3c9376469c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339413Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795343}
-
Koji Ishii authored
r795011 crrev.com/c/2313736 added tests for: * Enumerate all fragments for a |LayoutObject| across fragmentainers. * Enumerate all fragments for a |LayoutObject| within a specified item (line). but did not cover the case: * Enumerate all fragments for a |LayoutObject| within a specified fragmentainer (NGFragmentItems). This patch extends the tests to cover the last case. Bug: 1112657 Change-Id: Ia559421a09451c902c35f58346391666749da73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340405Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#795342}
-
David Munro authored
At 5 GiB you don't have enough free space for some common developer apps e.g. Android Studio, so bump the default up a little. Since our new default doesn't divide nicely into 1GiB increments (which, if they have enough free space, is the granularity we use) insert the default between the two closest ticks if it's not an exact multiple. Bug: chromium:1111869 Test: CQ, Manual Change-Id: I05a5103d1683a2012ec6f5ca76ba02bf872c543e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332095 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#795341}
-
Koji Ishii authored
|PostLayout| was designed to a) Return the current fragment set to |LayoutBox| if it is different from |this|, or b) Return |nullptr|. A case was found where there're no post-layout fragment available. Because reading such fragments is not guaranteed to be safe, this patch changes it to: b) Return |nullptr| if there were no post-layout fragments. a) Return the post-layout fragment if it is different. c) Return |this|. Also includes a few cleanups: 1. Support the new semantics in |PostLayoutChildLinkList|. It now skips fragments if there were no post-layout fragments. 2. Add |NGFragmentItem::PostLayoutBoxFragment|. 3. Remove |operator[]|, |front|, and |back| from |PostLayoutChildLinkList| because they are not used and do not support the post-layout concept. 4. Moved the implementation to |NGPhysicalBoxFragment| because it is only applicable to |NGPhysicalBoxFragment|. Bug: 965639 Change-Id: Iaa012fc4a79204f08e00728064ea8e1b0926d6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307770Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#795340}
-
Lei Shi authored
Current boundsForRange will clip the bounds to ancestors. This CL adds an optional boolean parameter, clipped, to the boundsForRange method. The default value of the parameter is true. When the clipped is set to false, the bounds will not be clipped to the ancestors of the nodes. This CL is a part of the fix for bug 775659. Bug: 775659 Change-Id: I804637a2e6a8ec695dc176b88bd55d12fbc7f8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335390 Commit-Queue: Lei Shi <leileilei@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#795339}
-
Aya ElAttar authored
This is a reland of 9b84489c after fixing google_update_policy_fetcher_win.cc Original change's description: > Remove the old version of PolicyMap::Set > > 1. Removed the old version of PolicyMap::Set, > which passes value as unique_ptr. > 2. Changed all the remaining refs use the new > version which passes value parameter as base::Value > instead of unique_ptr. > > Bug: 1092469 > Change-Id: Ie45bb05b603cedcad8119a65134c4f5f008964dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332191 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795078} Bug: 1092469 Change-Id: I4dfdf57753377ca49a6965b416e2a88c306f2ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339958Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#795338}
-
chrome://flagsThomas Lukaszewicz authored
This is a reland of 5da77d64 Original change's description: > Tab Search: Add chrome://flags entry for Tab Search > > This addition is necessary to allow users to disable the feature once > the experiment is enabled. > > Bug: 1099917 > Change-Id: I4e537a1fe92d1329c75ff8c190f92ce7f1cde8b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336020 > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794867} Bug: 1099917 Change-Id: I639aea54269a221d32049f98b715b4853c94f2bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339922Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#795337}
-
Fergus Dall authored
Also refactor the current installer code out of CrostiniManager Bug: 953544 Change-Id: Iad0850ffba616ac3f45adff63a5e21d57d3b5e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330111 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#795336}
-
adamta authored
When a user scrolls near the bottom of the NTP (with a variable offset), the Discover provider function for loading the next feed's page is called. Bug: 1085419 Change-Id: I26c493bc588905e0018902261eb3d050291a83ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237717 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#795335}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f52572f002a6..dcb6f8084e45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I05710ba5140fbf4d8dda397f29c2972217e6d73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339000Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795334}
-
Sophie Chang authored
Bug: 1110487 Change-Id: I78eab25150fd7424f06a3d9b6f244ad00e214b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333821 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#795333}
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/01ee4caa5ab5..50c5bbd8f04a $ git log 01ee4caa5..50c5bbd8f --date=short --no-merges --format='%ad %ae %s' 2020-08-05 jdrago Minor changelog tweak 2020-08-05 jdrago Fix incorrect 16-to-8 monochrome YUV conversion 2020-08-03 kornel Make decoding optional 2020-08-03 linkmauve Add an ignoreAlpha field to avifRGBImage 2020-07-28 dnovomesky Save support in gdk-pixbuf component 2020-07-31 jdrago Update changelog 2020-07-31 jdrago Only ever create one iref box, filled with multiple cdsc boxes 2020-07-24 asn cmake: Include avif INTERFACE_INCLUDE_DIRECTORIES first 2020-07-22 asn cmake: Use correct include dir for apps/shared 2020-07-22 dnovomesky Fix a crash in the gdk-pixbuf loader, removed unnecessary asserts 2020-07-21 ccom CMake: Add -Wno-error=c11-extensions for dav1d 2020-07-19 ccom CMake: Set C standard to c99 2020-07-19 ccom CMake: Only enable CXX if using libgav1 2020-07-16 wtc Move ptrU8,ptrV8,ptrU16,ptrV16 out of i for loop 2020-07-17 linkmauve Fix a crash in the gdk-pixbuf loader when error is NULL 2020-07-19 jdrago Disable libgav1 until abseil-cpp stops using CMP0077 on newer CMake versions Created with: roll-dep src/third_party/libavif/src R=dalecurtis@chromium.org Change-Id: I2b93528963d3a56802a40a8f788f6158e247b726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340070 Commit-Queue: Wan-Teh Chang <wtc@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#795332}
-
Kartik Hegde authored
Use the proper term "Problems" instead of the the generic "Messages" and add sync message. BUG=chromium:956783 TEST=unit_tests --gtest_filter=NetworkDiagnosticsImplTest.* Change-Id: I54e21cf1b85eb16c733178dfe8816c1f5cf7e0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337391Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#795331}
-
Ankit Kumar 🌪️ authored
Bug: 1030242 Change-Id: I1ec4145d993385ee06ac3718f9b80a8d88996ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325528Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#795330} -
Ted Meyer authored
these structs are already in the media namespace, they dont need media:: Change-Id: I2844d35cf27d46b860b4969ea5e1960d522f3d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339390Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#795329}
-
Hajime Hoshi authored
This CL enables UseCounterPageLoadMetricsObserver for back-forward cache. The page load's UKM ID is used to record the use counters even after the page is restored from the cache. It is because the metrics are per-page-load metrics and not belong to history navigations. Bug: 1112282 Change-Id: I791713e1c2b5bcf610c49d8866527f9be20c9376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334787Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#795328}
-
Peter Kasting authored
* Ordering better matches enum/member declaration order. * Most changes are just code movement, but in OnPaint() there's also some renaming and inlining of temps (+ resulting simplification). Bug: none Change-Id: Ia5046d91b701fabe9f31b69131de3d11e578706a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334086 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795327}
-
Mark Mentovai authored
Change-Id: Ia077c79f431afcb8af773af630aabea9c9a2e2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340173Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#795326}
-
Peter Kasting authored
Bug: none Change-Id: I24b64874e1ad946533dff9b491b8e6def2304362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332039 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#795325}
-
sczs authored
- ContentSuggestionsMediator uses DiscoverFeedDelegate to notify its Coordinator of Discover Feed Changes. - ContentSuggestionsCoordinator refreshes the Feed and sets a new ViewController (Created with the refreshed model) via its mediator. - Creates a DiscoverFeed Observer and its bridge in DiscoverFeedProvider. Bug: 1085419 Change-Id: If5b91d1cf9c99e164f4d9a50b5071ae65816350b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327846 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#795324}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I8aaa41f4779e5343221845efd42d7a2e99e071b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339293Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795323}
-
John Delaney authored
What: This is a speculative fix for a high failure rate of sqlite open errors seen with conversion feature enable. How: Attempt to create the conversion database directory if it does not exist before init. Why: Similar errors have been seen when using profile paths to initialize storage, and there is not a guarantee currently that the directory we are passed does exist. See https://crbug.com/1098019 Bug: 1112629 Change-Id: I895f2155dba3d6d6734769b6ef1f8872622c0a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340285 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#795322}
-
Kuo-Hsin Yang authored
When there are JavaScript memory leak, V8 ArrayBuffer could take more than 90% of available virtual memory size and causes out of memory errors in other modules (e.g. video playback) and crashes the renderer process. Limit V8 ArrayBuffer allocation to 50% of available virtual memory size so JavaScript memory leak would not crash the renderer process. Bug: chromium:1100299 Change-Id: I147d05d2d25660016dec3e5fa48848c03c516a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335629Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#795321}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f52572f002a6..dcb6f8084e45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I93782dcabcbe7dbc60fdc7ae99576aa9133fdbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340412Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795320}
-
Piotr Bialecki authored
We have moved away from allowing session reconfiguration, this change modifies implementation to rely on the requested features to decide whether detected plane information should be surfaced to the application or not. In addition, add "plane-detection" feature descriptor. Change-Id: I2070d1096ad31c451e295688c0be35ff149886a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333998 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#795319}
-
Ryan Hansberry authored
Implement mojom::Socket, a Mojo interface for interacting with device::BluetoothSocket. This implementation mirrors the implementation of tcp_socket.mojom: it uses a pair of Mojo DataPipes to stream sent and received data, instead of mirroring device::BluetoothSocket's Send() and Receive() methods. This CL only adds mojom::Adapter::ConnectToServiceInsecurely(), to allow clients to initiate a connection. A subsequent CL will add mojom::Adapter::CreateRfcommService() to allow listening for an incoming connection. This implementation has been manually verified by running a Nearby Share (go/nearby-chrome-bt) prototype on a Pixelbook, communicating with a Pixel 3. Please see design doc go/nearby-chrome-bt for more details. Bug: 1043300 Change-Id: Ice8110ef9bce905ab46cc38fee3110f8d0775644 Fixed: b:157750558, b:157484150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292871 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#795318}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ded65da11a18..a28c7896f97f 2020-08-06 bsheedy@chromium.org [Telemetry] Fix LFBM tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1108432,chromium:1111474 Tbr: oysteine@google.com Change-Id: I1504824aa5da5a7bd70a89e367701c9f7ad0cd1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340602Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795317}
-
Noah Rose Ledesma authored
Currently we do not support device switching for Cast sessions via the audio device selector in the zenith dialog. As such, the audio device selector view should not be added to cast zenith notifications. In order to distinguish cast notifications from local ones, a method was added to the MediaNotificationItem base class. Bug: 1104270 Change-Id: I16d57849b4370e6313c3cc8b4733d97d79af177f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321050 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#795316}
-