- 31 Jan, 2018 40 commits
-
-
Alexei Filippov authored
BUG=803276 Change-Id: I2076d974810c247ec79ac36897a54dc58e80c4a9 Reviewed-on: https://chromium-review.googlesource.com/894884Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#533189}
-
Maks Orlovich authored
Bug: 636400 Change-Id: Ic4a49a72dcae73f1bd2d909a0e86439f7c075061 Reviewed-on: https://chromium-review.googlesource.com/779742Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#533188}
-
Megumi Hattori authored
The reply button should be white when the textfield is not empty, and should be transparent white when the textfield is empty. However, when text is cut or pasted using mouse or finger and the textfield become empty or not, the reply button color does not change. This CL resolved this bug. Bug=803759 Change-Id: Ie307a924b41bddc88f60d9dc1b7ab230e639e0c7 Reviewed-on: https://chromium-review.googlesource.com/890843 Commit-Queue: Megumi Hattori <megumihattori@google.com> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#533187}
-
Xiaocheng Hu authored
This patch removes all call sites of DeprecatedDumpFrameTreeAsText, except the only one in ChromeRenderFrameObserver, which is improper. This is a preparation for fixing ChromeRenderFrameObserver without affecting other code paths. Bug: 803403 Change-Id: I1873f3759533873a3068b45cc55743b4bb9758d6 Reviewed-on: https://chromium-review.googlesource.com/891543Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#533186}
-
Hidehiko Abe authored
BUG=784732 TEST=Ran trybot. Change-Id: Icbb9c5596b045ca0c684cdad0343a2605d00dbb1 Reviewed-on: https://chromium-review.googlesource.com/856296Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#533185}
-
Joshua Bell authored
Issue reported by canary dogfooder: the promise returned by navigator.locks.query() would never resolve if no locks were held. In debug builds, this would DCHECK. The code would early-exit without running the callback in this case - a no-no. Added fix (return empty arrays) and test case. Bug: 807070 Change-Id: Ib4abd5d861c5ab259f7ea00355aebd006438508e Reviewed-on: https://chromium-review.googlesource.com/891584 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#533184}
-
Christopher Cameron authored
Add a mechanism for allowing an autoresize frame to resize the renderer's surface. When in auto-resize, make BrowserCompositorMac not update its size based on the NSView size. Bug: 805774 Change-Id: Ibc0b8b14ec7c1f4bdef30ac815d759f5894ab315 Reviewed-on: https://chromium-review.googlesource.com/892288 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#533183}
-
Dmitry Gozman authored
BigString uses BigBuffer internally to accomodate large strings. It maps to std::string and WTF::String and internally converts data to UTF8 similary to regular string. Bug: 776009 Change-Id: I05547f6f55f0a20dafd6a3d99e26b5cc2cbe2eed Reviewed-on: https://chromium-review.googlesource.com/891980 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#533182}
-
Wei Guan authored
BUG=803706 Change-Id: I5c1d7476d27e9ce35e9bd758351e6ebc22e43771 Reviewed-on: https://chromium-review.googlesource.com/884008Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Wei Guan <weigua@chromium.org> Cr-Commit-Position: refs/heads/master@{#533181}
-
Trent Apted authored
This reverts commit 02e508ce. Reason for revert: compile failure https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder%20(dbg)/62497 ../../ui/keyboard/keyboard_test_util.cc(99,17): error: 'keyboard::TestKeyboardUI::TestKeyboardUI' redeclared without 'dllimport' attribute: 'dllexport' attribute added [-Werror,-Winconsistent-dllimport] TestKeyboardUI::TestKeyboardUI(ui::InputMethod* input_method) Original change's description: > Use the centralized TestKeyboardUI instead of ash-test-specific ones > > This is mostly duplicate code. > > Bug: > Change-Id: Id152dc65ef53eac65d40ef38b6b9da3f962ae9ba > Reviewed-on: https://chromium-review.googlesource.com/832295 > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Blake O'Hare <blakeo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533168} TBR=oshima@chromium.org,yhanada@chromium.org,blakeo@chromium.org Change-Id: I0e7fedec0f8d5de8eb069bb2cd85f86009a4d55e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/895084Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#533180}
-
Ovidio Henriquez authored
This change ensures that tests that are ready to be migrated into wpt/ will contain consistent formatting. This includes a test_desc constant describing the test and consistent indentation. BUG=509038 Change-Id: If04b5cdd796709b8080960550cf216297e8d38f6 Reviewed-on: https://chromium-review.googlesource.com/891989 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#533179}
-
Trent Apted authored
This reverts commit 58ab87ff. Reason for revert: suspected for lsan browser_tests and mus_browser_tests failures since https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/25937 - AppBannerManagerBrowserTest.CheckOnLoadWithSufficientEngagementCancelBannerAfterPromptInHandler - AppBannerManagerBrowserTest.ExperimentalFlowWebAppBannerReprompt - AppBannerManagerBrowserTest.ExperimentalFlowWebAppBannerPromptNeedsGesture (and others in later runs)> Possibly timeout related. Original change's description: > Consolidate app banner testing. > > This CL removes several different app banner testing files, and replaces > them by calling the necessary JavaScript setup code in one test file. > For instance, all tests will no longer have the "appinstalled" title > overwriting, as that will only be active when the appropriate setup > JavaScript is run. > > This allows future tests to be more easily added, and reduces collisions > when manipulating the page title. > > BUG=806923 > > Change-Id: Ia28837b8675a2e1fe329cb1df1be4798ddb03d02 > Reviewed-on: https://chromium-review.googlesource.com/892182 > Commit-Queue: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532978} TBR=mgiuca@chromium.org,dominickn@chromium.org Change-Id: Ie030290324c689b3df616de9aa35b6e52e7584c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 806923 Reviewed-on: https://chromium-review.googlesource.com/895024Reviewed-by:
-
Claudio Magni authored
Currently some locales cannot be selected by the user as display UI, but this leads to a confusing experience because there are UI locales that are very similar (i.e. 'English' cannot be selected, but 'English (USA) can). This change fixes that. We increase the set of locales that can be selected and store the user selection in the Translate Prefs. Every time we read the Pref, we convert locales to their corresponding fallback if applicable. Bug: 719435 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1e41cb7d3a39160fbfb05571a573c1ebed2a7f91 Reviewed-on: https://chromium-review.googlesource.com/838726 Commit-Queue: Claudio M <claudiomagni@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@google.com> Cr-Commit-Position: refs/heads/master@{#533177}
-
Matt Mueller authored
Updates the test data to have the target cert be issued by a non-self-issued certificate so that it can catch this error. Change-Id: I2ea34a3c8c8864fe99a10b9931c8d022ca9de021 Reviewed-on: https://chromium-review.googlesource.com/894740Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#533176}
-
John Abd-El-Malek authored
This is a reland of e1c22cc3. The change didn't actually break the build, it was http://crbug.com/644525 Bug: 644525 Original change's description: > Move url_loader_unittest.cc and network_service_unittest.cc to services/network. > > Their content dependencies have been removed in previous changes. > > Bug: 753658 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: Ic632759ef35cfef4e707d29acdc361ae836e9b62 > Reviewed-on: https://chromium-review.googlesource.com/893651 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533113} Bug: 753658 Change-Id: If780785790fb2b56aff1d91ddeb781bab2e127a3 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/894895Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#533175}
-
Xing Liu authored
Currently Mojo Android bot can compile but will timeout during StartInstrumentation. This CL increases hard timeout for the swarm to wait longer. Failed bot log is here: https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.android%2Fandroid_mojo%2F19%2F%2B%2Frecipes%2Fsteps%2Fnetwork_service_content_browsertests__with_patch__on_Android%2F0%2Fstdout Bug: 783374 Change-Id: I153fa452e579aa5d4b3247e779756c89b929a692 Reviewed-on: https://chromium-review.googlesource.com/893902Reviewed-by:
Benjamin Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#533174}
-
Matt Reynolds authored
The Switch Pro controller is usable when connected by USB or Bluetooth, but defaults to a Bluetooth-only mode. This CL adds methods for recognizing Switch Pro controllers, sending the vendor-specific packets used for USB initialization and haptics, and reading controller data reports. BUG=801717 Change-Id: I076b001c5eda3c9e4900cb2a0ab19b78ef94d0da Reviewed-on: https://chromium-review.googlesource.com/891621Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#533173}
-
Andrey Lushnikov authored
This patch: - migrates TestMapping to use generic Persistence methods addBinding/removeBinding instead of creating a custom mapping algorithm. - removes enabling/disabling of automapping; instead, the automapping gets disposed. Since the removal of DefaultMapping, Persistence doesn't need to support different mapping algorithm implementations. BUG=805740 R=dgozman Change-Id: I5be46e4a3991011ae2bc7496619e4a1c9dcfb700 Reviewed-on: https://chromium-review.googlesource.com/892481 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533172}
-
Yoichi Osato authored
This patch marks LayoutSelection::LayoutSelectionStartEndForNG and FrameSelection::LayoutSelectionStartEndForNG const because of the function constness. Bug: 708452 Change-Id: I462fa178a9c656f184f43aac62eedff552290219 Reviewed-on: https://chromium-review.googlesource.com/892943Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533171}
-
David Bokan authored
This CL converts this test to use testharness.js assertions rather than js-test.js and a pixel test. The impetus for this is the pixel diff when root layer scrolling is turned on. The difference it not related to what this test is checking (and is actually correct when RLS is turned on). See the bug (comment #7) for more details. Bug: 781431 Change-Id: Ida7c287b616b4fd166b436e9957f28bf794098d4 Reviewed-on: https://chromium-review.googlesource.com/894365Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533170}
-
Yoshifumi Inoue authored
This patch introduces |VisibleUnitsWordTest.EndOfWordBasic| unit test to record current behavior as a preparation of the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Bug: 778507 Change-Id: Ic65a6a646806465c05b1a8fb7d5213beeb71e6e4 Reviewed-on: https://chromium-review.googlesource.com/892761Reviewed-by:
-
Blake O'Hare authored
This is mostly duplicate code. Bug: Change-Id: Id152dc65ef53eac65d40ef38b6b9da3f962ae9ba Reviewed-on: https://chromium-review.googlesource.com/832295Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#533168}
-
Kyle Horimoto authored
This UI is shown on the settings page when a phone tells the Chromebook that it does not have GmsCore notifications enabled. This CL: (1) Updates HostScannerOperation to accept an additional enum value indicating that GmsCore notifications are disabled. (2) Updates the settings page to show an extra step which is needed in some cases to enable notifications. Bug: 793936, 672263 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I65f34db384956189e6ea3c157a57f48bc4701fe4 Reviewed-on: https://chromium-review.googlesource.com/894729Reviewed-by: -
Daniele Castagna authored
With crrev.com/c/889863 we aligned SCANOUT{_CPU_READ_WRITE,} formats. This CL adds BGRX_1010102 to {_CPU_READ_WRITE,}. Additionally, it adds RGBA_8888 and BGRX_8888 to GPU_READ_CPU_READ_WRITE and GPU_READ_CPU_READ_WRITE_PERSISTENT, effectively aligning all the format lists for each allowed usage. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0b789b66e0380f23d6071351746fdf94a354871e Reviewed-on: https://chromium-review.googlesource.com/894150Reviewed-by:ccameron <ccameron@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
-
Yoland Yan authored
Use InstrumentationRegistry to get actual target context in the two service test cases. Andr remove BaseITR, BaseChromiumITR, and ChromeITR Bug: 807251 Change-Id: I9d945ce7c2ce264f84f10124af6b399cba690eef Reviewed-on: https://chromium-review.googlesource.com/894125Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533165}
-
Allen Vicencio authored
Implements Truncate for SmbFileSystem. Bug: chromium:757625 CQ-DEPEND=CL:879566 Change-Id: Iecf94821ec7237be1fcc07b693c0bdec35903d97 Reviewed-on: https://chromium-review.googlesource.com/889558 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#533164}
-
Dominick Ng authored
This CL adds the new omnibox vector icons for Touchable Chrome, and uses them in place of the existing icons when the kTouchableChrome feature is active. BUG=801583 TBR=bajones@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I38b593e8ee3d734eadef00ea8b31c69affffc493 Reviewed-on: https://chromium-review.googlesource.com/885666 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#533163}
-
Jeffrey Kardatzke authored
This fills out screen capture by implementing the permissions prompt and the session logic which performs the desktop capture with the GPU and copies the result to the GPU buffer passed from Android. It also adds a 'system_modal' parameter to the desktop picker dialog so that it will display properly over the Android windows. Design doc is here: goto/arcppscreencapture Bug: b:38452042 Change-Id: Ia2541a9494485704aa290e77aef1dca4578853e7 Reviewed-on: https://chromium-review.googlesource.com/887642 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Qiang Chen <qiangchen@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Zijie He <zijiehe@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#533162}
-
Dmitry Gozman authored
Bug: none Change-Id: I446ceb4903ef021aee24ad6a724c97c1d778b67a Reviewed-on: https://chromium-review.googlesource.com/894123Reviewed-by:
-
Findit authored
This reverts commit d5bd9807. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 533073 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q1YmQ5ODA3ZTViYTI0OTBiYzQxNjViN2FlNzg0OTJkOWJlNDgyMGEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/4001 Original change's description: > [CrOS Tether] Update connection retry attempt logic. > > Before this CL, we allowed 3 retries for the entire connection flow, > which includes advertising, scanning, creating a GATT connection, and > exchanging messages. However, it makes more sense to think of this as a > two-part process: > (1) Advertising and scanning. This portion always occurs when > attempting a BLE connection, even if the device we're trying to > contact is not nearby and cannot respond. > (2) Creating a GATT connection and exchanging message. This portion > only occurs when an Android host is nearby to respond to the > Chromebook. > > Connection attempts which fail in part (2) above indicate that the > device actually is nearby and can potentially connect; additionally > connection failures during this part of the connection often will > succeed on a retry. Thus, this CL adds extra connection retry attempts > if a previous attempt failed in part (2). > > Bug: 805218, 672263 > Change-Id: Ifbedc004b96905d3f77662c45bcf2a9210b06c57 > Reviewed-on: https://chromium-review.googlesource.com/889991 > Reviewed-by: Jeremy Klein <jlklein@chromium.org> > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533073} Change-Id: I60d645c8baf8c53eb46cbf9eb9341046db7e0c31 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 805218, 672263 Reviewed-on: https://chromium-review.googlesource.com/894290 Cr-Commit-Position: refs/heads/master@{#533160}
-
Evan Stade authored
Bug: none Change-Id: Ib070e4654f73821a0de3744647e72837dbda38fd Reviewed-on: https://chromium-review.googlesource.com/894424Reviewed-by:
-
Takuto Ikuta authored
I confirm that how -g0 affects stacktrace shown in test failure/crash. With -g1: https://chromium-review.googlesource.com/c/chromium/src/+/892540/1 With -g0: https://chromium-review.googlesource.com/c/chromium/src/+/892187/3 I summarize how stacktrace is shown on each builder affected by this CL. This CL does not change stacktrace. |--------------------------+---------------+------------------+---------------+------------------| | builder | -g0 crash | -g0 CHECK(false) | -g1 crash | -g1 CHECK(false) | |--------------------------+---------------+------------------+---------------+------------------| | android_n5x_swarming_rel | no stacktrace | correct | no stacktrace | correct | | cast_shell_linux | correct | correct | correct | correct | | ios-simulator | no stacktrace | no stacktrace | no stacktrace | no stacktrace | | linux-chromeos-rel | correct | correct | correct | correct | | linux_android_rel_ng | no stacktrace | correct | no stacktrace | correct | | mac_chromium_rel_ng | correct | correct | correct | correct | |--------------------------+---------------+------------------+---------------+------------------| I see improved link time of some large binary on (very slow) andrdoin_n5x_swarming_rel builder. With this patch: build stat https://chromium-build-stats.appspot.com/ninja_log/2018/01/30/slave603-c4/ninja_log.slave603-c4.chrome-bot.20180130-001251.4049.gz/table?dedup=true taken from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/350571 Without this patch: build stat https://chromium-build-stats.appspot.com/ninja_log/2018/01/30/slave604-c4/ninja_log.slave604-c4.chrome-bot.20180130-005043.1186.gz/table?dedup=true taken from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/350593 |-----------------------------------------+---------+-----------| | link time of each target | -g0 | -g1 | |-----------------------------------------+---------+-----------| | android_clang_arm/libmonochrome.so | 14.206s | 27.25s | | android_clang_arm/libwebviewchromium.so | 12.355s | 1m44.577s | | lib_components_unittests__library.so | 22.194s | 1m17.442s | | libwebviewchromium.so | 30.729s | 1m45.147s | | libmonochrome.so: | 31.862s | 1m33.027s | | lib_unit_tests__library.so | 53.444s | 44.943s | |-----------------------------------------+---------+-----------| This patch improved link time in most cases. Bug: 794423 Change-Id: I757a8a01bed0dea4c62e2f8ebfccc5a163d8cc18 Reviewed-on: https://chromium-review.googlesource.com/892187Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@google.com> Cr-Commit-Position: refs/heads/master@{#533158}
-
Takumi Fujimoto authored
This CL adds back the string-to-Mojo-origin conversion removed in http://crrev.com/c/769570. Assuming the crash seen in bug 787427 is due to users using outdated Media Router component extension (<=M59) which send origins as strings, this fixes the issue. Bug: 787427 Change-Id: If93782a3bca3ebb2ba8d50c7b42ccbef0ba4363e Reviewed-on: https://chromium-review.googlesource.com/894859 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#533157}
-
Allen Vicencio authored
Adds Truncate to SmbProviderClient and FakeSmbProviderClient CQ-DEPEND=CL:879387 Bug: chromium:757625 Change-Id: Iff2f62efc059a41ad4d15c3cbb18bafac277c690 Reviewed-on: https://chromium-review.googlesource.com/879566 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
-
Sarah Hu authored
This is to fix the crash case happened when we open user menu or the gaia dialog and then just kill chrome. Bug: 792579 Change-Id: I30d5e56bdf2b7e17b4f34de9e4935b42ee47c3dc Reviewed-on: https://chromium-review.googlesource.com/894888Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#533155}
-
Toni Barzic authored
Exposes chrome.management to the primary kiosk app. Subset of the API is disabled in kiosk - the following methods will return an error if called in kiosk: * launchApp * createAppShortcut * setLaunchType * generateAppForLink * uninstall * uninstallSelf BUG=800441 Change-Id: Ie3cf691904f9f4442bac104c1a6b6c543d126553 Reviewed-on: https://chromium-review.googlesource.com/861210 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533154}
-
Andrey Lushnikov authored
This reverts commit e0eac774. Reason for revert: this patch breaks DevTools protocol, see crbug.com/807483 Original change's description: > Always use backpressure for fetch > > Previously, backpressure would only be applied to fetch responses if the > Cache-Control: no-store header was set. This was to avoid blocking other > resource loads that might have to wait for the lock on the http disk > cache that was held by the resource load to which backpressure was being > applied. > > As of https://chromium-review.googlesource.com/684615 the disk cache > supports multiple concurrent writers and so this protection is no longer > needed. > > Remove support for the non-backpressure mode and always apply > backpressure. > > The fact that the body is no longer implicitly read is visible > to tests that observe the result of the fetch() via a side > channel, specifically inspector and browser tests. Fix such tests > to explicitly read the body to completion. > > Additionally, in order to satisfy the presubmit check, make > SharedMemoryDataConsumerHandle::Context::on_reader_detached_ a > OnceClosure. > > The implementation already implicitly ran on_reader_detached_ at most > once, because is_on_reader_detached_valid_ would be set to false by > ResetOnReaderDetached immediately after PostTask was called. Now this > has been made explicit by using OnceClosure. > > on_reader_detached_ is only reset on the writer_task_runner_ > thread. When the closure is not run this is implemented by the logic in > ResetOnReaderDetached(), the same as before. When the closure is run the > behaviour has changed slightly: the OnceClosure is moved into the task > that is posted to the writer_task_runner_ thread, where it will be > destroyed automatically after running. There's no nead for a separate > reset in this case. > > BUG=535793 > > Change-Id: I9d2b58e183b84640afc153ac99de08fdc2368240 > Reviewed-on: https://chromium-review.googlesource.com/861695 > Commit-Queue: Adam Rice <ricea@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530070} TBR=ricea@chromium.org,yhirano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 535793 Change-Id: I79a176496f6fada40ba8f2e4d95848421809ecee Reviewed-on: https://chromium-review.googlesource.com/894683Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#533153}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bde04194..27e3a1f6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I03e19c644e4aa366e9491a374d0873408dbe6356 Reviewed-on: https://chromium-review.googlesource.com/894762Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#533152}
-
Lei Zhang authored
Use more C++ and base/ features to simplify the code. Fix all the nits and lint errors as well. Change-Id: Ib3b80002bfd7b9df45ad535ddb94cdc086d0ca2f Reviewed-on: https://chromium-review.googlesource.com/890239 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#533151}
-
Dale Curtis authored
Ultimately this shaves a couple seconds of runtime off my local build, so it should help with timeouts on Android bots. This removes the following perf test cases since they don't correspond to well used codecs. Well used in this case means we see above 2% daily usage per relavant histograms: DemuxerPerfTest: - bear.avi - sfx_s16le.wav - bear.flac AudioPipelineIntegrationPerfTest: - sfx_f32le.wav - sfx_s24le.wav - sfx_u8.wav - sfx.flac It replaces the above audio tests with more appropriate ones reflecting actual usage: - sfx.mp3 (mp3) - sfx.ogg (vorbis) - sfx.m4a (aac) This also splits out a couple chunk TEST() blocks into parameterized tests for cleanliness, though that won't improve performance since we run perf tests --single-process. BUG=803460 TEST=none Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iebac045d09c867eb3cc7f867d62e8959aa094e66 Reviewed-on: https://chromium-review.googlesource.com/893437 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#533150}
-
