GitLab

Remove dead code from DocumentOrderedMap:
- clear() method is never used
- checkConsistency() is declared but unimplemented
- "wtf/HashCountedSet.h" include is no longer needed

R=esprehn, adamk

Review URL: https://codereview.chromium.org/138573003

git-svn-id: svn://svn.chromium.org/blink/trunk@165118 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It causes performance problems. See
https://code.google.com/p/chromium/issues/detail?id=331076

Micro-benchmarks like http://jsperf.com/setting-document-title regress
about one magnitude.

We need to figure out whether the spec should change or if the CL
could be written in a less performance-intrusive way, or if it's a
performance penalty we accept. So revert for now.

The follow-up "Inhibit title updates when removing children before
setting new value" is reverted too since it has no value without the
first patch.

Reverted CLs:

https://codereview.chromium.org/128603002
https://codereview.chromium.org/107513013

BUG=331076

Review URL: https://codereview.chromium.org/138213005

git-svn-id: svn://svn.chromium.org/blink/trunk@165117 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The same functionality is already in SVGGraphicsElement.

Review URL: https://codereview.chromium.org/138923003

git-svn-id: svn://svn.chromium.org/blink/trunk@165116 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Break out the handling of GC_M_MASK (multiple uchar category) into
separate inline function as a part of the effort to clean up the
logic to allow proper handling of script_common.

BUG=311372
R=leviw@chromium.org

Review URL: https://codereview.chromium.org/138553003

git-svn-id: svn://svn.chromium.org/blink/trunk@165115 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also devirtualize it along with dispatchInputEvent.

Based on http://trac.webkit.org/changeset/150805 by Andreas Kling.

Review URL: https://codereview.chromium.org/138003005

git-svn-id: svn://svn.chromium.org/blink/trunk@165114 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes the followings:
 - AXObject::selectedText
 - AXRenderObject::selectedText, which is an override of AXObject::selectedText
 - AXRenderObject::stringForRange and HTMLTextFormControlElement::selectedText,
   which are used only by AXRenderObject::selectedText.

BUG=none
TEST=none; no behavior changes

Review URL: https://codereview.chromium.org/137783006

git-svn-id: svn://svn.chromium.org/blink/trunk@165113 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We hold a small ring-list cache of recently-emptied pages, and only free the
oldest entry in the ring list when the cache is full. This makes us hold on to
a little bit of unused memory, but in return we do now eventually free the last
slot span in any given bucket, which would have been held indefinitely before.

This patch is a sufficient generic replacement for the bandaid added in
https://code.google.com/p/chromium/issues/detail?id=330798; accordingly, the
bandaid is removed. In fact, we now seem to be +4% faster than _before_ the
original regression.

BUG=332282

Review URL: https://codereview.chromium.org/133863006

git-svn-id: svn://svn.chromium.org/blink/trunk@165112 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make generated Callback bindings classes FINAL and add OVERRIDE to their virtual
methods.

R=haraken
BUG=333316

Review URL: https://codereview.chromium.org/138613002

git-svn-id: svn://svn.chromium.org/blink/trunk@165111 bbb929c8-8fbe-4397-9dbb-9b2b20218538

period simpler.

We will need to have Members and Persistents instead of RefPtrs.
On RefPtrs the methods that correspond to raw and clear are called
get and release. Unify on the RefPtr methods to make the transition
period code simpler.

Fix comparison operators that were unused and did not work because
they accessed private members.

R=haraken@chromium.org, wibling@chromium.org, zerny@chromium.org, erik.corry@gmail.com
BUG=

Review URL: https://codereview.chromium.org/138203002

git-svn-id: svn://svn.chromium.org/blink/trunk@165110 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The TestGCScope only needs to stop and resume threads. It should not
change the state of the heap. The old code made the heap consistent
for scanning which cleared all freelists and never rebuild them.

R=haraken@chromium.org, erik.corry@gmail.com, wibling@chromium.org
BUG=

Review URL: https://codereview.chromium.org/138273003

git-svn-id: svn://svn.chromium.org/blink/trunk@165109 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=239771
R=haraken
NOTRY=true

Review URL: https://codereview.chromium.org/131183002

git-svn-id: svn://svn.chromium.org/blink/trunk@165107 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I'm seeing this taking up a big portion of FrameView::layout in my trace.

Review URL: https://codereview.chromium.org/138823003

git-svn-id: svn://svn.chromium.org/blink/trunk@165106 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As a part of RenderBlockLineLayout.cpp refactoring, I'm moving out LineLayoutState into a separate
file. I'm doing the refactoring step by step, the progress is tracked under 316347 tracking issue.

BUG=334363

Review URL: https://codereview.chromium.org/138773002

git-svn-id: svn://svn.chromium.org/blink/trunk@165105 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Levi is already an OWNER and owns a lot of the code that has now been
moved to platform.

R=eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/139043002

git-svn-id: svn://svn.chromium.org/blink/trunk@165104 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts 164797

R=abarth@chromium.org,eseidel@chromium.org
BUG=329603

Review URL: https://codereview.chromium.org/133273007

git-svn-id: svn://svn.chromium.org/blink/trunk@165102 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The checkForRepaintDuringLayout is needed for both the non-repaintAfterLayout
and the repaintAfterLayout case. So, I've split the method into checkForRepaint
and checkForRepaintAfterLayout which are used as needed.

This change pointed out a few missing LayoutRectRecorder entries that have
been added to fixup LayoutTests.

BUG=310398

Review URL: https://codereview.chromium.org/129853005

git-svn-id: svn://svn.chromium.org/blink/trunk@165101 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adds layout test to verify that attempt to set
SourceBuffer's append mode fails when enough data has been
appended for the buffer to be in the middle of parsing a
media segment.
Also, removes default WebSourceBuffer::setMode()
implementation now that Chromium WSBI::setMode() has landed.

R=acolwell@chromium.org,jamesr@chromium.org
BUG=249422
TEST=All mediasource layout tests pass locally on Linux

Review URL: https://codereview.chromium.org/136523004

git-svn-id: svn://svn.chromium.org/blink/trunk@165100 bbb929c8-8fbe-4397-9dbb-9b2b20218538

|isSelfCollapsingBlock| should only be called on an object after it has had layout. In order to enforce this with an ASSERT I had to account for a couple of things I hadn't previously considered:

- In a couple of places we look at the previous child sibling and check whether it's selfCollapsing. When we do that we need to be sure that it's a normal flow block we're looking at.

- Placeholder elements are not laid out until the dimensions of their parent text control are known, so they don't get layout until their parent has had layout - this is unique in the layout tree and unfortunately when we call isSelfCollapsingBlock on them we find that they still need layout. Since placeholder elements only exist when they have content we can enforce the rule that they are never self-collapsing.

- When we are in partial layout and have entered layoutBlockChildren to layout one or more children we should return early when we are done. The current behaviour, which ignores the rest of the children and then adjusts the height of the parent block with the current margin information, is unnecessary and likely to be wrong.


BUG=

Review URL: https://codereview.chromium.org/129873004

git-svn-id: svn://svn.chromium.org/blink/trunk@165099 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No change in behavior, as ShadowRoot::baseURL still delegates to its Document.

BUG=311682
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/126443005

git-svn-id: svn://svn.chromium.org/blink/trunk@165098 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It turns out thse two classes share a lot of code, so move it to the common
base class RenderSVGBlock

Review URL: https://codereview.chromium.org/136723007

git-svn-id: svn://svn.chromium.org/blink/trunk@165097 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I also moved the EventTarget code into TextTrack, because audio and video
tracks aren't event targets.

BUG=249427

Review URL: https://codereview.chromium.org/92783002

git-svn-id: svn://svn.chromium.org/blink/trunk@165093 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Missing initializer from https://codereview.chromium.org/131223003

Review URL: https://codereview.chromium.org/137313006

git-svn-id: svn://svn.chromium.org/blink/trunk@165092 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=165084

BUG=326138,314499,329201,331781
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/133273008

git-svn-id: svn://svn.chromium.org/blink/trunk@165091 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Never send a referrer header if the referrer is not a web url (https://codereview.chromium.org/136583002/)

Reason for revert:
This is the probable cause for the failing browser test CorrectReferrer. See:

http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/1302/steps/browser_tests/logs/CorrectReferrer

http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/5398/steps/browser_tests/logs/CorrectReferrer

http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/543/steps/browser_tests/logs/CorrectReferrer

Original issue's description:
> Never send a referrer header if the referrer is not a web url
> 
> BUG=none
> R=abarth@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165085

TBR=abarth@chromium.org,jochen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/133863003

git-svn-id: svn://svn.chromium.org/blink/trunk@165090 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch resets old execution line location on pretty-printing as it
will be set later as soon as it's live location will be updated.

BUG=334188

Review URL: https://codereview.chromium.org/131743005

git-svn-id: svn://svn.chromium.org/blink/trunk@165089 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change replaces StorageQuotaChromium with StorageQuotaClient for cleanup.


BUG=n/a
TEST=webkit/tools/layout_tests/run_webkit_tests.sh storage/\*

Review URL: https://codereview.chromium.org/133503002

git-svn-id: svn://svn.chromium.org/blink/trunk@165088 bbb929c8-8fbe-4397-9dbb-9b2b20218538

EME WD uses 'needkey' event (EME v0.1b was 'webkitneedkey').
This change adds support for the new event while retaining
support for the previous event.

BUG=224786
TEST=new test added

Review URL: https://codereview.chromium.org/134663005

git-svn-id: svn://svn.chromium.org/blink/trunk@165087 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
This patch is the most probable cause of the failing content_browsertests:

AccessibilityModalDialogInIframeOpened
AccessibilityModalDialogOpened
AccessibilityModalDialogStack

See:

http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/529

http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/13227

http://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/22361

http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/5388

I could not reach the patch author on IRC due to the time zone difference.

Original issue's description:
> Make ancestors of modal <dialog> inert
> 
> As per spec change: http://html5.org/r/8343
> 
> Now, document.body is also inert. Previously events that
> "skipped" an inert node were fired on document.body; now,
> they are fired on document.
> 
> Test: modal-dialog-ancestor-is-inert.html
> Also, other tests cover some of this behavior and have
> expectations updated.
> 
> BUG=329407
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165040

TBR=esprehn@chromium.org,falken@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=329407

Review URL: https://codereview.chromium.org/138183003

git-svn-id: svn://svn.chromium.org/blink/trunk@165086 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/136583002

git-svn-id: svn://svn.chromium.org/blink/trunk@165085 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Image diffs are still present after a manual rebaseline pass.

BUG=314499,326138,329201,331781
TBR=robert.phillips@google.com

Review URL: https://codereview.chromium.org/138403002

git-svn-id: svn://svn.chromium.org/blink/trunk@165084 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://www.w3.org/TR/SVG11/types.html#InterfaceSVGElement

The test passes in Firefox Nightly, IE11 Release Preview and Opera 12.16.

BUG=310298

Review URL: https://codereview.chromium.org/138433003

git-svn-id: svn://svn.chromium.org/blink/trunk@165083 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Implement the polygon fill-rule part of http://dev.w3.org/csswg/css-shapes/#basic-shape-interpolation.

Review URL: https://codereview.chromium.org/132643006

git-svn-id: svn://svn.chromium.org/blink/trunk@165082 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Protect FrameLoader::m_frame in FrameLoader::loadHistoryItem() to
keep it from being destroyed if a popstate event handler, dispatched
via FrameLoader::loadInSameDocument(), removes the frame from the
parent document.

BUG=334239

Review URL: https://codereview.chromium.org/138213002

git-svn-id: svn://svn.chromium.org/blink/trunk@165081 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Path::pointAtLength and Path::normalAngleAtLength both call
Path::pointAndNormalAtLength to do the work.
SVGTextLayoutEngine::layoutTextOnLineOrPath call the two former, which
means it'll setup and process the path twice.

Change the two calls into one call to pointAndNormalAtLength to reduce
the work required.

BUG=135310

Review URL: https://codereview.chromium.org/135853005

git-svn-id: svn://svn.chromium.org/blink/trunk@165078 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Create our own blink_heap run_all_tests target to avoid piggy-backing on wtf's. (https://codereview.chromium.org/138133002/)

Reason for revert:
Broke compile.

Original issue's description:
> Create our own blink_heap run_all_tests target to avoid piggy-backing on wtf's.
> 
> We used to use wtf's run_all_tests target to run out blink heap unittests. That causes a problem when we want to initialize our heap since we cannot call Heap::init/shutdown from wtf's RunAllTests since it cannot/should not depend on blink heap.
> 
> R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, vegorov@chromium.org, zerny@chromium.org
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165073

TBR=ager@chromium.org,erik.corry@gmail.com,haraken@chromium.org,vegorov@chromium.org,zerny@chromium.org,wibling@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/138443002

git-svn-id: svn://svn.chromium.org/blink/trunk@165077 bbb929c8-8fbe-4397-9dbb-9b2b20218538

"Execution" => "V8Execution"
"MinorGC" => "V8MinorGC" and "DOMMinorGC"
"MajorGC" => "V8MajorGC" and "DOMMajorGC"
etc

Review URL: https://codereview.chromium.org/131203009

git-svn-id: svn://svn.chromium.org/blink/trunk@165076 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=326139
TBR=tdanderson

Review URL: https://codereview.chromium.org/138423002

git-svn-id: svn://svn.chromium.org/blink/trunk@165075 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add 3 more values, according to
http://dev.w3.org/csswg/css-writing-modes/#propdef-unicode-bidi

R=aandrey, eustas, vsevik
BUG=334096
NOTRY=true

Review URL: https://codereview.chromium.org/136153003

git-svn-id: svn://svn.chromium.org/blink/trunk@165074 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We used to use wtf's run_all_tests target to run out blink heap unittests. That causes a problem when we want to initialize our heap since we cannot call Heap::init/shutdown from wtf's RunAllTests since it cannot/should not depend on blink heap.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/138133002

git-svn-id: svn://svn.chromium.org/blink/trunk@165073 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Update more core classes to use OVERRIDE / FINAL when needed. Those are
useful for error checking or performance when the compiler supports it.

These were found using the chromium style clang plugin.

R=eseidel, esprehn
BUG=333316

Review URL: https://codereview.chromium.org/137943002

git-svn-id: svn://svn.chromium.org/blink/trunk@165072 bbb929c8-8fbe-4397-9dbb-9b2b20218538