GitLab

Allow WebView.loadUrl-family functions to terminate execution of JS code that
seems to be stuck in a loop.

BUG=390906

Review URL: https://codereview.chromium.org/366913006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281715 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 291b1ce3.

BUG=392117
NOTRY=true
TBR=starodub

Review URL: https://codereview.chromium.org/371343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281714 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/360893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281713 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281712 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff dslomov@chromium.org in case of problems.

TBR=dslomov@chromium.org

Review URL: https://codereview.chromium.org/372953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281711 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281710 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177638:177644&mode=html
TBR=pilgrim@chromium.org,yutak@chromium.org
BUG=

Review URL: https://codereview.chromium.org/375833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281709 0039d316-1c4b-4281-b951-d872f2087c98

AppListService's RecordStartupTimings is currently broken. To completely
fix, it needs to incorporate the Profile* that StartupBrowserCreatorImpl
wants to load, which is not currently passed in.

This change adds AppListService::HandleLaunchCommandLine, abstracting
away the details of initializing, showing, and recording UMA for the app
list. A follow-up will fix RecordStartupTimings.

BUG=382793

Review URL: https://codereview.chromium.org/350883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281708 0039d316-1c4b-4281-b951-d872f2087c98

crrev.com/255933006 landed blacklisting for BlackMagic
cameras in Mac: QTKit would be used instead of AVFoundation
for these devices.

The code was based on the assumption that these cameras
have a USB vendor ID but this is not correct since they
use a Thunderbolt connection, i.e. PCIe, and another
crrev.com/366593003 is going to prevent GetModel().

This CL changes to using a characteristic substring of
the uniqueId.

TEST: Plug in a Blackmagic, f.i. an UltraStudio Mini
Recorder (doesn't need any camera connected to it) and
check enumerate devices, there should be a multiplicity
of devices with a "QTKit..." prefix, indicating there was
a blacklisting process.

BUG=347371

Review URL: https://codereview.chromium.org/362323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281707 0039d316-1c4b-4281-b951-d872f2087c98

BUG=389621

Review URL: https://codereview.chromium.org/376853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281706 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Separate client and server pushed streams limits. (https://codereview.chromium.org/367963003/)

Reason for revert:
[Sheriff] This breaks asan:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/3768
http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%282%29/builds/3271

Original issue's description:
> Separate client and server pushed streams limits.
> Reject push streams which exceed the limit.
> 
> For now, the browser will send RST_STREAM with REFUSED_STREAM status.
> This mimics mod_spdy behavior.
> 
> BUG=170544, 377538
> 
> R=jgraettinger@chromium.org
> 
> TEST=SpdySessionTest.PushedStreamShouldNotCountToClientConcurrencyLimit
>      SpdySessionTest.RejectPushedStreamExceedingConcurrencyLimit
>      SpdySessionTest.IgnoreReservedRemoteStreamsCount
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281698

TBR=jgraettinger@chromium.org,baranovich@yandex-team.ru
NOTREECHECKS=true
NOTRY=true
BUG=170544, 377538

Review URL: https://codereview.chromium.org/377903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281705 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372316
TBR=pastarmovj@chromium.org

Review URL: https://codereview.chromium.org/360303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281704 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281703 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/f99f884cd82528684779e40413f1ceaf277dad2d..ff644145242631a46d9dce6cb99c97f9340f172c

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=jcgregorio@google.com
BUG=

Review URL: https://codereview.chromium.org/372843008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281702 0039d316-1c4b-4281-b951-d872f2087c98

Now the bubble is not shown when the user denies the translation too
often, and this states are saved at prefs. This CL enables uses to see
and reset these prefs at chrome://translate-internals.

BUG=379035
TEST=manual

Review URL: https://codereview.chromium.org/370523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281701 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/362923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281699 0039d316-1c4b-4281-b951-d872f2087c98

Reject push streams which exceed the limit.

For now, the browser will send RST_STREAM with REFUSED_STREAM status.
This mimics mod_spdy behavior.

BUG=170544, 377538

R=jgraettinger@chromium.org

TEST=SpdySessionTest.PushedStreamShouldNotCountToClientConcurrencyLimit
     SpdySessionTest.RejectPushedStreamExceedingConcurrencyLimit
     SpdySessionTest.IgnoreReservedRemoteStreamsCount

Review URL: https://codereview.chromium.org/367963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281698 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nick@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/376833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281697 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Signedness mismatch

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/371153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281696 0039d316-1c4b-4281-b951-d872f2087c98

Migration of code from ContentViewCore to NavigationController to avoid ContentViewCore abstractions.

Review URL: https://codereview.chromium.org/369503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281695 0039d316-1c4b-4281-b951-d872f2087c98

Corrects the regression of [a-z] keys for non-US layouts would have wrong VKEY code if CAPSLOCK is on.

For example, Ctrl+A with Caps used to work for FR keyboard, but after cl 357613002, it doesn't work. The root cause is that cl 357613002 tries the remove the modifier states for the xkeyevent for its keysym for [a-z0-9]  keys but only considered the shift/altgr states, not capslock & other states. 

BUG=386066
TEST=Verified on Pixel device.

Review URL: https://codereview.chromium.org/376463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281694 0039d316-1c4b-4281-b951-d872f2087c98

Several tests were intended to verify muxed content behavior, but
are not actually using muxed clusters. This is a precursor change
that makes the use of muxed clusters more explicit. There are
only slight changes to some of the tests to make them properly reflect
the original intent. A followup change will actually create proper
muxed clusters and make any necessary updates to the test expectations.

Review URL: https://codereview.chromium.org/361303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281693 0039d316-1c4b-4281-b951-d872f2087c98

Delegated renderer disabled for layout tests (as on other platforms).

BUG=314190
TBR=piman

Review URL: https://codereview.chromium.org/374643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281692 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392037
TEST=base_unittests --gtest_filter=ThreadLocalStorageTest.*

Review URL: https://codereview.chromium.org/379503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281691 0039d316-1c4b-4281-b951-d872f2087c98

One Windows and Mac, continue to use a whitelist of app ids.

BUG=353449
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/286203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281690 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281689 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177624:177637&mode=html
TBR=pilgrim@chromium.org,yutak@chromium.org
BUG=

Review URL: https://codereview.chromium.org/372183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281688 0039d316-1c4b-4281-b951-d872f2087c98

I'm only 50% sure I got everything right when adding the WPR archive etc, so any guidance appreciated.

BUG=391197

Review URL: https://codereview.chromium.org/367283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281687 0039d316-1c4b-4281-b951-d872f2087c98

Insertion text handles should be hidden when the underlying text changes. As
such, add a hook to notify the AdapterInputConnection embedder of an IME event 
when text is deleted, in turn hiding the insertion handle.

BUG=389444

Review URL: https://codereview.chromium.org/351403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281686 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391520
TBR=caitkp@chromium.org

Review URL: https://codereview.chromium.org/378763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281685 0039d316-1c4b-4281-b951-d872f2087c98

According to our style guide, in unit tests, the tested file's header should
be first.

TEST=Not related. Refactoring only.
BUG=248427

Review URL: https://codereview.chromium.org/372963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281684 0039d316-1c4b-4281-b951-d872f2087c98

This patch just adds the flag. The implementation will be committed later.

BUG=305511
TEST=none

Review URL: https://codereview.chromium.org/374803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281683 0039d316-1c4b-4281-b951-d872f2087c98

Now there is a but that the bubble is shown even though the window is minimized.
This CL fixes this bug.

BUG=389014
TEST=manual

Review URL: https://codereview.chromium.org/364053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281682 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281681 0039d316-1c4b-4281-b951-d872f2087c98

Eliminate SyncFileSystemService from SyncProcessRunner to inject its dependency from tests.

BUG=344769

Review URL: https://codereview.chromium.org/377563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281680 0039d316-1c4b-4281-b951-d872f2087c98

Use the same computation as is used in DelegatedFrameHost.

A separate patch will rename viewport_size.

BUG=391386
TBR=danakj

Review URL: https://codereview.chromium.org/375793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281679 0039d316-1c4b-4281-b951-d872f2087c98

Pass BookmarkModel* to UpdateStarredStateOfMatches().
StringForURLDisplay() is only used in two places:
 - base_search_provider.cc: This is the only caller which passes true as |check_accept_lang|.  Move the code to read kAcceptLanguages pref to this file.
 - history_url_provider.cc: Pass empty string as |languages| from this file.

Add Profile* for subclasses as a member if needed.

BUG=388515
TEST=git cl try

Review URL: https://codereview.chromium.org/369423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281678 0039d316-1c4b-4281-b951-d872f2087c98

Keep-alive above 250ms causes PseudoTCP to reset congestion window
between messages, making connection much less responsive.

BUG=391991

Review URL: https://codereview.chromium.org/376763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281677 0039d316-1c4b-4281-b951-d872f2087c98

We are systematically removing results.Add() callsites and replacing them
with results.AddValue() callsites. I've done scirra.py and sunspider.py,
and nednguyen@ is doing more in the tools/perf directory.

BUG=346958

Review URL: https://codereview.chromium.org/372163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281676 0039d316-1c4b-4281-b951-d872f2087c98

In the current implementation, ServiceWorkerVersion controls its status based
on event notifications (eg. ServiceWorkerVersion::OnInstallEventFinished).

But the spec algorithm requires to manage the status more flexibly during
registration process. For example, the version should be set to INSTALLED
status after associated to the documents because the page should be able to
see '.waiting' on 'onstatechange' event.

Because of this reason the register job should manage the status of the version.

(Spec) https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html


BUG=379012
TEST=content_unittest --gtest_filter=ServiceWorker* 
TEST=run_webkit_tests.py http/tests/serviceworker/waiting.html

Review URL: https://codereview.chromium.org/369063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281675 0039d316-1c4b-4281-b951-d872f2087c98