- 09 Oct, 2020 40 commits
-
-
Justin Donnelly authored
This feature was launched on Android earlier this year, on iOS a month ago in http://cl/333090325 and enabled by default in https://crrev.com/c/2391644. Bug: 964049 Change-Id: Ied519b568108be661bda990aedde09d2c4e74a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462174Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#815774}
-
Alex Turner authored
Currently, local font lookups are instrumented with a digest of the lookup value and a digest of the resulting typeface being recorded. We expand this recording for successful local font lookups: we now also record a digest of the resulting typeface's PostScript name with the typeface digest. This will allow the identifiability study to measure the diversity of installed typeface files with the same PostScript name (for example, differing versions of the same typeface) and thus evaluate the privacy impact of that variation. Bug: 1136210 Change-Id: Id7ac6229db287af776474f43abd200c51319992e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453439Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#815773}
-
Brian Geffon authored
This is primarily a plumbing CL with the more logic being added later. This CL introduces an opaque container which will contain the internal details for userspace swap. This container will hold the userfaultfd, the swapfile, and all metrics associated with what's on disk and what has been reclaimed. Later this structure will also contain all swapped region tracking (follow up CL). This CL is the final piece to connect the performance manager policy and mechanism to the internal implementation which PM doesn't need to worry about. No further CLs _should_ be required in the performance manager code. Bug: chromium:1067833 Change-Id: I5fb946c7e013826dddcd9c5f0b7a34107f926e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456512 Commit-Queue: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#815772}
-
Gavin Williams authored
Make the Chrome settings Download page only one stop in ChromeVox. Video: http://crbug/986417#c18 Fixed: 986417 Change-Id: I13da58bf74c1aa0c8dc0cb0059668325e3ce9f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462385Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#815771}
-
Xinghui Lu authored
The color of "turn on enhanced protection" should be consistent with the color of "Learn more". light mode before: http://screen/8WidHUNBBQmzKgi after: http://screen/3NR2qbG2f2P9zTq dark mode before: http://screen/BN2CLeG6XCyuqPU after: http://screen/KraWTSsegRer2Zq Bug: 1130721 Change-Id: I761731b565253cf800ef54999959ede0fc67c6ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463592Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#815770}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I3d3f6178739b5873ad8789a71b05967db40f85da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464062Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815769}
-
rbpotter authored
Bug: 1136703 Change-Id: If1370e61db35049f12e22beb6219651056b326ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461801 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#815768}
-
behdad authored
The flaky story on perf cq windows is marked as experimental to prevent further flakiness. Bug: 1134251 Change-Id: Ie99b7b0d62b22c86105a53fbca74d0eeb322b514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462392 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#815767}
-
Ben Kelly authored
Bug: 1035448 Change-Id: I260e31f0815a0c81611eea9eb45f9d80b2019d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461718 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#815766}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/815983783a76..109c355900d1 2020-10-09 fmayer@google.com Merge "Document LD_PRELOAD heapprofd library." 2020-10-09 fmayer@google.com Merge "Allow to set base pointer for referred objects." 2020-10-09 ngeoffray@google.com Merge "Add liblog as a dependency of libperfetto_client_experimental." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic2e5332615bbeff1d95b127fe2768091d8f3c250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463734Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815765}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602244639-8a31cdfac3c26c19c9de644309ff096c0a612320.profdata to chrome-linux-master-1602266368-0e61a032fa7157fa29bc804c0d7295bad87c6193.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iceb0b43daa615d4654c58a6fe785943d67f3d400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463924Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815764}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602244639-6cd23926ee4e898bd11627c63cc4edf5ffd59847.profdata to chrome-mac-master-1602266368-92d2928e0040ad47ba60bbcac401f36efe1994de.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5b508adc930790dad2c098d5242fb76e2180b782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463767Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815763}
-
chrome://sandboxAlex Gough authored
These are present in the 20226 insider SDK. Not all values are used in Chromium but it is easier to keep this up to date with Winbase.h. Tangentially related to enabling CET in Chrome. Bug: 1131225 Change-Id: I6b2705c8fbcd1331ce32038c76f3483c8250c867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461598Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#815762}
-
Aaron Leventhal authored
Bug: 1136880 Change-Id: I32ccf9c9e02a845bd83739f93dc66ef57ea0ff4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463325 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#815761}
-
Liquan (Max) Gu authored
Change: * Adds createWithPathPrefix() method so that the tests can use any resources in the repository. This is needed because new test resources live in the clank directory, while the default search path is "components/test/data/payments/" Bug: 1091475 Change-Id: Ia7b756eaf2414043c864e7afc6498eb796a08d93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456150Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#815760}
-
Eric Lawrence authored
The ability to filter Netlog by source is a performance optimization that is no longer relevant now that realtime net-internals monitoring is no longer available. Bug: 1136881 Change-Id: I30ef886e0bcaefd0c0b06d30db89bc6236fd8c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463802Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#815759}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ic92d7d6bdd2024c71eb7996a3a1eadb92cd8b6ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463735Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815758}
-
Garrett Beaty authored
Bug: 1122660 Change-Id: I2271da88e70ef2cf9f6a0e406a8b8dadd744f5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462239Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#815757}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/658ae8fc6aba..7563a4878789 2020-10-09 michaelludwig@google.com Revert "SkDevice::drawSpecial accepts arbitrary matrix v2" 2020-10-09 bsalomon@google.com Use BackendSurfaceFactory in Vk protected unit tests. 2020-10-09 kjlubick@google.com [canvaskit] Clean up some APIs related to Path factories 2020-10-09 johnstiles@google.com Improve performance of SymbolTable lookups. 2020-10-09 johnstiles@google.com Improve codegen for gradients. 2020-10-09 egdaniel@google.com Suppress another version of the vulkan validation error. 2020-10-09 ethannicholas@google.com moved SkSL FieldAccess data into IRNode 2020-10-09 adlai@google.com Migrate abandonment & reset methods to GrDirectContext 2020-10-09 ethannicholas@google.com SkSL enum changes 2020-10-09 egdaniel@google.com Suppress vulkan validation layers bug. 2020-10-09 ethannicholas@google.com more SkSL IRNode refactoring 2020-10-09 egdaniel@google.com Make sure the normal GrProgramDesc handles input attachment key. 2020-10-09 michaelludwig@google.com SkDevice::drawSpecial accepts arbitrary matrix v2 2020-10-09 brianosman@google.com Reorganize how SkSL includes are parsed and stored 2020-10-09 johnstiles@google.com Reland "Add sk_Caps.builtinDeterminantSupport and use it in cross()." 2020-10-09 adlai@google.com Reland "Merge GrContext::init into GrDirectContext ..." 2020-10-09 johnstiles@google.com Add test for sk_Caps.mustGuardDivisionEvenAfterExplicitZeroCheck. 2020-10-09 johnstiles@google.com Add test for sk_Caps.inBlendModesFailRandomlyForAllZeroVec. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I7abc9cc004f9135b668c71acd2a6b28d78f98544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463863Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815756}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/51b03d58fb17..0aca3ca9427d 2020-10-09 capn@google.com Fix depth bias calculations 2020-10-09 capn@google.com Move interpolant clamping out of interpolate() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I74a53f6b69002c209d42c991be2bbd0a768ff636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463783Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815755}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ic1170d5e557f78beac1fed0b92e6dce812723b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463590Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#815754}
-
Peter Kotwicz authored
BUG=None Change-Id: I094e2cb0edc01312f1200773e09bc842727b78ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453925Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#815753}
-
Carlos IL authored
Forms that set their target to a javascript: scheme URL were being tagged as mixed content, this CL fixes that. Bug: 1135173 Change-Id: I1b185bef9e1dc41d97736f3a1c96de510fb7eef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451510 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#815752}
-
Max Curran authored
This connection will eventually allow Chrome Translate to log metrics with the relevant TranslateMetricsLogger. The TranslateManager will keep a WeakPtr to the newest relevant TranslateMetricsLogger. Any part of Chrome Translate can request this “active” TranslateMetricsLogger in order to log metrics and/or events. In the event this WeakPtr is null, the TranslateManager will return a NullTranslateMetricsLogger (a null implementation of TranslateMetricsLogger), so that the callee doesn’t have to check if the returned value is null or not. Bug: 1114868 Change-Id: Ifa775ccd5918d4111e8b4ae44ea7f1c1ea034043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419260Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Max Curran <curranmax@chromium.org> Cr-Commit-Position: refs/heads/master@{#815751}
-
mark a. foltz authored
Clarify comments about the use of the Origin: header in dial_url_fetcher.cc. Also add a TODO to replace it with a proper origin. Bug: 1135835,1136284 Change-Id: I930f78a8a9722caeaa6442541c62ca69786fa9da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462938 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Auto-Submit: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#815750}
-
Tommy Steimel authored
This CL adds a slot into the Kaleidoscope toolbar so that we can insert a settings button. Bug: b:150614426 Change-Id: Id417c9a9aed2f3c609283dd52262ab454f730b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461940 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#815749}
-
Daniel Classon authored
Adds a new version of the RecordSettingChange function that takes a mojom::Setting and the value of the setting change. Marks the old function for deprecation and uses the new function in the user action tracker. Adds in a top level metric to record which settings were changed. Also adds in metrics for the Files Page. Bug: 1133553 Change-Id: Ie232d6375c66dabfd8493d4657c8bacea915fc1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441950Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Classon <dclasson@google.com> Cr-Commit-Position: refs/heads/master@{#815748}
-
Sorin Jianu authored
This CL introduces a --tag command line argument and handing of metainstaller tags. If the tag is present in the metainstaller, then the tag is extracted, and the updater is invoked with --tag. This removes the hardcoded --install command line argument that the metainstaller had temporarily used so far. For now, the metainstaller could be invoked in one of the following ways: 1. sign and tag it (using the steps in the design doc), then run it without arguments. 2. run it with --tag=appguid={8A69D345-D564-463c-AFF1-A69D9E530F96} 3. run it with --install --app-id={8A69D345-D564-463c-AFF1-A69D9E530F96} There is a fix in the sign.py script to copy the build contents instead of compressing them, to keep the repacked archive similar to what it was before signing. The metainstaller code does understand BCJ (but it understand BCJ2) so in the future, if compression is needed, use BCJ2 and LZMA. Bug: 1128751 Change-Id: I368a3c5f05f7b091f860c0953ed062630832261a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463524Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815747}
-
rbpotter authored
Add input_files and input_files_base_dir arguments for generate_grd, to allow inclusion of files that are not preprocessed and therefore included in the manifest in the grd file. Additional updates to generate_grd: - Rename rollup files that aren't shared.rollup.js - Set file type in the grd as "chrome_html" for HTML/JS files - Adding tests Started from: https://chromium-review.googlesource.com/c/chromium/src/+/2443211 by dpapad@ Also removing some unnecessary kGeneratedPath constants from various Web UI controllers that have been updated to use autogenerated grd files. These autogenerated files contain resource_path properties for each <include>, so stripping the generated portion of the path in webui_util.cc is no longer necessary. Bug: 1132403 Change-Id: Ia707d48fe348b168dce6bf806099ffd209385bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463333 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#815746}
-
Zhenyao Mo authored
Currently we have a DCHECK for the returned result. If it ends up failing, then the event wait is forever. BUG=1060785,1077725 R=sunnyps@chromium.org Change-Id: I574831aef3cecab6989f4bd0ec5ce79512472f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463529 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#815745}
-
Yu Su authored
We want to run experiments to set Youtube iOS network traffic as NET_SERVICE_TYPE_AV. Thus we want to make Cronet be able to set iOS socket network service type by using the experimental option from a cronet application. Bug: 168256315 Change-Id: Id6371be70323c3ece724d8d33bd89395cd99211f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461041Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Yu Su <yuyansu@google.com> Cr-Commit-Position: refs/heads/master@{#815744}
-
David Roger authored
This CL adds more logging to understand the circumstances of a profile being deleted. In particular, it adds a metric Profile.DeleteProfileContext and a histogram suffix Profile.State.*_UponDeletion. Bug: 1136483 Change-Id: I10204a435012ad64b67061e5050d9eec2c28da84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461230Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#815743}
-
Becca Hughes authored
Adds the variations header that communicates experiment state to the server. This will be used for launch gating. Change-Id: If0b8d3175bd4856a0e255d67792da424f0ce80bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463551 Auto-Submit: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#815742}
-
Ken Rockot authored
Generated JS bindings will unconditionally attempt to send a response when a message implementation resolves the response promise. If the corresponding endpoint has already been closed, this send will fail with a cryptic error due to some partially destroyed state within InterfaceEndpointClient. This change makes InterfaceEndpointClient tolerate such uses by silently ignoring them. Fixed: 1136949 Change-Id: I3102d6b8f96d9d0e5683c9c497eb7b6f22b12be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463586 Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#815741}
-
Peter Kasting authored
Bug: 772945 Change-Id: Ief4d0b5df967bda4a2f9fde0746f57d443d3d1f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460871 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#815740}
-
Mason Freed authored
Now that [1] Web Components V0 has been completely disabled, these V0-only tests can be removed, and the virtual test suite can also be deleted. This is a *very* large CL, but it only consists of file deletions. Three folders contain most of the deleted tests, but there are also a few from the http/tests/* folders. Here is the complete list: web-components-v0-only/* virtual/web-components-v0-disabled/* http/tests/htmlimports/* http/tests/custom/xhr-response-does-not-have-registry.html http/tests/custom-elements/no-registry-test.html http/tests/devtools/import-open-inspector.js http/tests/devtools/elements/html-link-import.js http/tests/devtools/elements/styles-3/style-rule-from-imported-stylesheet.js http/tests/devtools/network/network-imported-resource-content.js http/tests/devtools/resource-tree/resource-tree-htmlimports.js http/tests/linkHeader/link-rel-import-css-rule-capital.html http/tests/security/contentSecurityPolicy/nonces/import-enforce-allowed.php http/tests/security/contentSecurityPolicy/nonces/import-enforce-blocked.php http/tests/security/contentSecurityPolicy/nonces/import-multiple-allowed.php http/tests/security/contentSecurityPolicy/nonces/import-multiple-blocked.php http/tests/security/contentSecurityPolicy/nonces/import-reportonly-allowed.php http/tests/security/referrer-policy-attribute-import-no-referrer.html http/tests/subresource_filter/resource-in-import-disallowed.html [1] https://chromium-review.googlesource.com/c/chromium/src/+/2195005 Fixed: 1081941 Bug: 937746 Change-Id: Iec984fb1caed708a6d7959fe153426e59ffadf74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454693Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#815739}
-
Mario Bianucci authored
This is a reland of 1d11f9fd The original CL was reverted because of InputHandlerProxyEventQueueTest.VSyncAlignedGestureScrollPinchScroll failing on ChromiumOS MSan builders. This test was flaky in the exact same way prior to my change according to the flakiness dashboard, and ASan and TSan variants are already disabled for what is likely the same issue. The tests fails at roughly the same rate both with and without this CL. Therefore, I spoke with the reverter and we decided it was acceptable to disable the test on MSan. It is disabled on ASan and TSan via crbug.com/1029250, and I will leave a comment there about MSan also being disabled. Original change's description: > De-couple PredictionMetricsHandler from specific histograms > > PredictionMetricsHandler appears to be designed to work for anything > that is predicting points. However, it currently only reports metrics > in the Event.InputEventPrediction.Scroll* histograms. De-couple the > class from these histograms so it can be used for things only than > scroll metrics. > > Bug: 1133785 > Change-Id: Ib34129fc46b20b45810cbd5ca195483e88c513e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441197 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Commit-Queue: Mario Bianucci <mabian@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#813813} Bug: 1133785 Change-Id: Id02ea108e0f74f4f454049b5957bb7f10287cc8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451591Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#815738}
-
Prakhar authored
This is mirrored by mac-rel (https://source.chromium.org/chromium/chromium/tools/build/+/master:recipes/recipe_modules/chromium_tests/trybots.py;l=1118;drc=eec8bcd5de88cb9da93b59ed44fa13b9303dfc0f) Bug: 1024915 Change-Id: Iac6ef3b406e599418d182eca88ca5107bd8e4b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462985 Commit-Queue: Prakhar Asthana <pasthana@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Prakhar Asthana <pasthana@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#815737}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b3c2e9be46bc..99db0de96759 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lukasza@google.com,flackr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: lukasza@google.com,flackr@google.com Change-Id: I451429bdd94e9dedf0a81ff9789b11d9f067dd28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461700Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815736}
-
Yifan Luo authored
Bug: 1116418 Change-Id: I0f845c83261144b9b50c1ac5adbe30ce89dd2576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450324 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#815735}
-