- 27 Jul, 2018 19 commits
-
-
Wenzhao Zang authored
1) |getLaunchableApps| should only return launchable apps, but not all of the apps would necessarily be ready. (Non-ready apps becomes ready normally after ~10s after user session starts.) 2) |launchApp| can be used to launch non-ready apps. A spinner will be shown on the shelf and the app will launch after it becomes ready. Bug: 819404 Change-Id: I6569043226f38b6905687defb4be95554a5e5511 Reviewed-on: https://chromium-review.googlesource.com/1141349 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#578509}
-
Donna Wu authored
This is a preparing CL for USB servicification which introduced WebUsbDeviceManager and its unit test. As designed, all permission management for USB devices will be consolidated within //chrome. Permission checking code in //device/usb will be moved out to this new class WebUsbDeviceManager. BUG=699790 Change-Id: I60580152ec31d1962dfdce616bd5b3729a3e60cc Reviewed-on: https://chromium-review.googlesource.com/1121971Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Donna Wu <donna.wu@intel.com> Cr-Commit-Position: refs/heads/master@{#578508}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/52660b68f115..17f184f10975 git log 52660b68f115..17f184f10975 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 bhthompson@google.com Add additional comments around paladins running HW tests Created with: gclient setdep -r src/third_party/chromite@17f184f10975 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If821a833572a7a5b66eb1dc39cc64cab99aae604 Reviewed-on: https://chromium-review.googlesource.com/1151971Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578507}
-
Nigel Tao authored
This commit is a rename. No features were added or removed. Prior to this commit, the only user of //chrome/browser/extensions/FaviconDownloader was //c/b/e/BookmarkAppHelper. Future commits will add code to //chrome/browser/web_applications so that, when installing web applications, a shared code path will download icons and re-scale if necessary. The class was renamed from FaviconEtc to WebAppIconEtc because such icons might not be favicons, in the sense of the `served on /favicon.ico` or `<link rel="icon" etc>` conventions. For example, https://events.google.com/io2016/manifest.json lists multiple app icons that aren't favicon icons. The class was moved because code in the newer //c/b/wa directory aims to not explicitly depend on code in //c/b/e, although dependencies from //c/b/e to //c/b/wa/components is OK. Change-Id: Id2808965c41b497eee92585c62374734db20ef42 Reviewed-on: https://chromium-review.googlesource.com/1149666 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578506}
-
Nate Chapin authored
* Don't take a timeout in ThreadableLoader constructor * Rename OverrideTimeout() to SetTimeout(), use it as the only way to set a timeout. * Stop using base::Optional for the timeout. The more I look at it, the less it adds, especially when the timeout isn't passed in the constructor. TBR=peter@chromium.org,yhirano@chromium.org Change-Id: I8d2e7f1099110399e0fe187432b04760fbc79cac Reviewed-on: https://chromium-review.googlesource.com/1150865 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#578505}
-
Nicholas Verne authored
Bug: 866752 Change-Id: I34056730480bb7ad52b01f6ec045ee936b5f016b Reviewed-on: https://chromium-review.googlesource.com/1151041Reviewed-by:
Renée Wright <rjwright@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#578504}
-
Jiajia Qin authored
With this patch, we can compile and run a basic compute shader. Bug: 859249 Change-Id: I4b0c3fe35b70f9daa82a7783521e0aea9c57fdc9 Reviewed-on: https://chromium-review.googlesource.com/1151050Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Cr-Commit-Position: refs/heads/master@{#578503}
-
Shakti Sahu authored
Bug: 867693 Change-Id: I0d3795b4c456d89fa16c38984ddf6a89a21f8f1b Reviewed-on: https://chromium-review.googlesource.com/1150924 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#578502}
-
Anand K. Mistry authored
This is dead code. A follow-up CL will remove this dbus method from cros-disks. BUG=None Change-Id: Iec688692f112a267b5aa8ec428bd067ff0e80119 Reviewed-on: https://chromium-review.googlesource.com/1151037 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Ben Chan <benchan@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#578501}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/254538b955bd..079812cefdd9 git log 254538b955bd..079812cefdd9 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-26 vadimsh@chromium.org [cipd] Bump client (+vpython) v2.1.0 (521b9b6477) => v2.2.2 (03693197fe). 2018-07-26 vadimsh@chromium.org [cipd] Try to bootstrap CIPD from scratch if selfupdate fails. 2018-07-26 ehmaldonado@chromium.org metrics_utils: Print notice to stderr. 2018-07-26 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@079812cefdd9 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:821194,chromium:867729,chromium:821194,chromium:832386 TBR=agable@chromium.org Change-Id: I0eb1d5d4e51b7559bee1647b84f8c420459b831b Reviewed-on: https://chromium-review.googlesource.com/1152248Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578500}
-
David Black authored
See bug for additional details. Bug: b:110416447 Change-Id: Id5323c5040e1b32326a8caa8d06a41749f0d92fa Reviewed-on: https://chromium-review.googlesource.com/1151714 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#578499}
-
tzik authored
Some WebRTC's ref-counted objects are implicitly stored into base::scoped_refptr instead of rtc::scoped_refptr through base::Bind. And an upcoming base::Bind update disables this case of auto wrapping. This CL replaces it to rtc::scoped_refptr by wrapping the pointer with rtc::scoped_refptr explicitly. Bug: 866456 Change-Id: Id8a9dd622f5aa5b9c843ec7ec43e0d390a0777db Reviewed-on: https://chromium-review.googlesource.com/1145147Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#578498}
-
Amy Qiu authored
Create new recordings for pages in key_desktop_move_cases to ensure current websites are used. Bug: 852530 Change-Id: Ia216e388edf269a0462f014f90bbe22be0a68916 Reviewed-on: https://chromium-review.googlesource.com/1150691Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#578497}
-
Ryan Sturm authored
RenderFrameHost could be deleted while there is a message round trip occuring if shut down happens at the perfect time. Keeping BrowserContext is much safer. Bug: 868112 Change-Id: Ia9da7c64378f90a00e2c0bb07b1d3b24bf882ee1 Reviewed-on: https://chromium-review.googlesource.com/1152362Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#578496}
-
Xiyuan Xia authored
Add KioskAppManager::Get()->SetEnableAutoLaunch(true) when setting up auto launch kiosk so that SCREEN_KIOSK_AUTOLAUNCH does not gets into the way to break the test. Bug: 859715 Change-Id: I940ff9f275cc8a2d450e0338366f1702eb8277f0 Reviewed-on: https://chromium-review.googlesource.com/1148899Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#578495}
-
Yutaka Hirano authored
This CL also removes RequestIsHistoryNavigation runtime enabled flag as the feature has been shipped. Bug: None Change-Id: Iaab8a8dc4ac8044c64fa68f24973c95b7fe9943a Reviewed-on: https://chromium-review.googlesource.com/1151186Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#578494}
-
Justin Novosad authored
The code was failing to flush deferred rendering commands recorded by Canvas2DLayerBridge before dispatching animation frames. This CL does not fix the problem completely: there is still an issue when the canvas is not gpu-accelerated BUG=867601 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I32db0759af549ec6cd09ca677fff4ee215cae49e Reviewed-on: https://chromium-review.googlesource.com/1152028Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#578493}
-
James Zern authored
https://chromium.googlesource.com/webm/libvpx.git/+log/2c45cd174a95..3b921d49b07a $ git log 2c45cd174..3b921d49b --date=short --no-merges --format='%ad %ae %s' 2018-07-25 marpan vp9: Modify condition for force test of intra 2018-07-25 marpan vp9: Avoid early breakout on slide change 2018-07-24 jzern vp9: fix OOB read in decoder_peek_si_internal 2018-07-25 marpan Revert "vp9: Adjust reset segment for real-time screen-content" 2018-07-25 jingning Clean up get_overlap_area function 2018-07-24 jingning Factor out mode estimation process in tpl model build 2018-07-24 yaowu Improve help message for arnr-type 2018-07-24 huisu Fix typos in txfm_rd_in_plane() 2018-07-24 marpan vp9: Modify logic for flat blocks in nonrd-pickmode. 2018-07-24 wtc Check size limit in vpx_realloc_frame_buffer. 2018-07-24 slavarnway VPX: avg_intrin_sse2.c, avg_intrin_avx2.c cleanup 2018-07-24 paulwilkins Limit min Q for normal frames. 2018-07-23 marpan vp9: Adjust reset segment for real-time screen-content 2018-07-23 slavarnway VPX: Improve HBD vpx_hadamard_32x32_avx2() 2018-07-23 jingning Pass in block size for motion search function 2018-07-22 jingning Make the tpl model update operated in 8x8 block unit 2018-07-23 jingning Refactor overlap area computation 2018-07-23 slavarnway VPX: Add vpx_hadamard_32x32_avx2 2018-07-20 huisu Add prune_ref_frame_for_rect_partitions feature 2018-07-22 jingning Map coding block size to transform block size (...) Created with: roll-dep src/third_party/libvpx/source/libvpx R=tomfinegan@chromium.org Bug: 867792 Change-Id: I196965bee2e278b011cde10ad677b7f69aff0ef1 Reviewed-on: https://chromium-review.googlesource.com/1151052Reviewed-by:
Johann Koenig <johannkoenig@google.com> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#578492}
-
Shakti Sahu authored
Moved ListItemViewHolder into separate classes into separate package Bug: 867693 Change-Id: Ia5aa1f131882b6c8d4d695f99db92a1a42815b1a Reviewed-on: https://chromium-review.googlesource.com/1150852Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#578491}
-
- 26 Jul, 2018 21 commits
-
-
Shakti Sahu authored
Bug: 866183 Change-Id: Ifc7f60c27b8d558446eafe55d813e629a51b523d Reviewed-on: https://chromium-review.googlesource.com/1145866 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#578490}
-
mrefaat authored
More context in crbug.com/822518 Bug: 850760, 822518 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I66e86fdc9813456ead16b1c43c41ac218ff2ac0a Reviewed-on: https://chromium-review.googlesource.com/1147861 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#578489}
-
Bo Liu authored
Spinning begin frame is relatively cheap, but spinning invalidates in hope of reducing latency when scheduler can draw is a bit too expensive to be worthwhile. So avoid invalidate in this situation. Bug: 864436 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I56a5dc466f0fe8f99428a83fbec21a8530a4a40a Reviewed-on: https://chromium-review.googlesource.com/1150961Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#578488}
-
Oystein Eftevaag authored
Roll src/third_party/perfetto/ e0f20f188..ae0c5273b (6 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/e0f20f1882cb..ae0c5273bfa1 $ git log e0f20f188..ae0c5273b --date=short --no-merges --format='%ad %ae %s' 2018-07-26 michaschwab Time Axis 2018-07-26 michaschwab Pan and Zoom 2018-07-26 hjd perfetto-ui: Make ControllerProxy a global 2018-07-26 primiano Non-functional refactorings of ftrace controller/sink/metadata 2018-07-26 dproy Rename pieces of track and inline TrackShell 2018-07-25 primiano Wait for producers to ACK the stop when disabling the trace. Created with: roll-dep src/third_party/perfetto TBR=primiano@chromium.org Change-Id: I19070966bfcc21bbe65905f23f3418938bb5209e Reviewed-on: https://chromium-review.googlesource.com/1152177Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#578487}
-
Kai Ninomiya authored
This function assumes `image` will be a valid pointer, but previously we only DCHECKed this. Meanwhile, we've seen intermittent fuzzer reports (all duped into this main bug), and I was able to find some crash/ reports in the wild, that indicate that image may actually come out false. See http://crbug.com/859623#c21 for investigation into why this would happen. Bug: 859623 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7218c279400f2e062e271527b3c3b501bdf3856f Reviewed-on: https://chromium-review.googlesource.com/1150373 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578486}
-
Andrey Lushnikov authored
This way we avoid the limitation on maximum IPC message size. BUG=797817 R=dgozman Change-Id: Ic4065d4b5b7b957effeb10f72b432320cd977be7 Reviewed-on: https://chromium-review.googlesource.com/1152240 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#578485}
-
Nate Chapin authored
Bug: 865950 Change-Id: I8c35b78802b5ccafbfd0433c9e6bee4b04bb4136 Reviewed-on: https://chromium-review.googlesource.com/1145872 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#578484}
-
David Tseng authored
The |abstractNameFromContents| output rule gets used for roles that require ChromeVox to compute a name based on descendant nodes. Bug: 868019 Change-Id: I97edd91bdbb521bf423fdaaa43c4b867d5194b2c Reviewed-on: https://chromium-review.googlesource.com/1152032 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#578483}
-
kristipark authored
Tile layout was modified in https://chromium-review.googlesource.com/c/chromium/src/+/1142504. Bug: 867140, 854072 Change-Id: I3f0bc08442cd91f2fafef35afd47c0a9edd2da94 Reviewed-on: https://chromium-review.googlesource.com/1150913 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#578482}
-
Cathy Li authored
The experiment was not successful and we decided to not pursue this route further in favor of better experiences. Change-Id: I6922b0784049eabda8175b04e423e7e83d5d0de1 Reviewed-on: https://chromium-review.googlesource.com/1147093 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Edward Jung <edwardjung@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#578481}
-
Bret Sepulveda authored
Bug: 867557 Change-Id: I0c982fc17740e1de9f458b92e7782aa00dc463eb Reviewed-on: https://chromium-review.googlesource.com/1150501 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#578480}
-
Ovidio Henriquez authored
This change removes the WebUSB on Shared Worker web platform tests, since the feature is not yet implemented in any browser. Bug: 841510 Change-Id: I6cd09c245edcd69799b39701b82ba1510caf845e Reviewed-on: https://chromium-review.googlesource.com/1151752Reviewed-by:
Chong Zhang <chongz@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#578479}
-
Devlin Cronin authored
Update some cast dependencies to use the target name from the BUILD.gn file, rather than the generated target name. This is clearer, since these targets are specified within the BUILD.gn file at the location, and also removes one duplicate target dependency. Also prevent targets from depending on the generated target names by restricting their visibility to the output static library. Bug: None Change-Id: Ib87f2d90edab44e52569e29b6c1675238df6efdc Reviewed-on: https://chromium-review.googlesource.com/1150935Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578478}
-
Weidong Guo authored
Instead of using icon top padding and spacing between icon and title, it is easier to maintain if we are using bottom padding. After we remove the bottom padding, we can using ClampToCenteredSize() to calculate the expected bounds for app icon, folder icon and focus which are of different size. Screenshot: https://screenshot.googleplex.com/35xH6uoDkyL Bug: 868085 Change-Id: I1a844f7b08bba76f8fb031992d012e2a513eaca5 Reviewed-on: https://chromium-review.googlesource.com/1152227Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#578477}
-
Zach Helfinstein authored
Bug: 865260 Change-Id: Ied9a9068518cdbc9e05a42cace066c110c0c0e05 Reviewed-on: https://chromium-review.googlesource.com/1147494Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#578476}
-
Justin Novosad authored
BUG=789232 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic142b7099f0a813764e750b23236822b53f894fa Reviewed-on: https://chromium-review.googlesource.com/1151906 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#578475}
-
Scott Violet authored
This reverts commit 2ae89dce. Reason for revert: net_unittests seems to be consistently failing after your patch landed. First failure is here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator/35922 . net_unittests hangs when it gets to MultiThreadedProxyResolverTest.CancelCreate Original change's description: > Change ProxyResolutionService API to use std::unique_ptr<Request> instead of raw pointers. > > Bug: 479898 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I3d1b89fc33ebae27f6ab4007eceffb9eb6134ef6 > Reviewed-on: https://chromium-review.googlesource.com/887598 > Commit-Queue: Matt Menke <mmenke@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578436} TBR=stevenjb@chromium.org,sky@chromium.org,eroman@chromium.org,boliu@chromium.org,mef@chromium.org,mmenke@chromium.org,lilyhoughton@chromium.org Change-Id: I17026b358225cc01884be96ca5b69dcd9f885e5d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 479898 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1152368Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#578474}
-
James Cook authored
The existing code updates the text input caret highlight by observing input method state. This works in classic ash because the input method is shared globally across ash and browser code. This doesn't work with remote apps because ash can't see the input method in the remote process. The caret doesn't work in mash because the ash process can't see the browser's input method. Add support for a11y to observe the input method objects created by the browser's input method driver / bridge. Explicitly forward the text caret bounds to ash, which then updates the highlight. Bug: 867110 Test: added to ash_unittests and browser_tests Change-Id: I27058e091ad5a597de4ab644654df8d535e95b72 Reviewed-on: https://chromium-review.googlesource.com/1151897 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#578473}
-
Yuwei Huang authored
Some users complain about background audio player being muted by the app. This CL overrides some settings in the AudioSession to allow audio from the app to be mixed with sounds from other apps. Bug: 868088 Change-Id: I10af925e3eb488498ab83df25cbd77cea8ebd186 Reviewed-on: https://chromium-review.googlesource.com/1152182Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#578472}
-
Xiaocheng Hu authored
The above mentioned function is supposed to enter a line box child to find positions in inline descendants. In some situations, the inline formatting context have have direct non-inline child (e.g., abs-pos float), which should be ignored. This patch removes the existing redundant branch that enters non-line- box children, to fix failure in fast/shapes/shape-outside-floats/shape-outside-clip-path-selection.html. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I834544692d6cc8d9fc4340fb55ffb1bbe53f1276 Reviewed-on: https://chromium-review.googlesource.com/1151947 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#578471}
-
Alexander Alekseev authored
This CL updates HID detection screen with new style. Bug: 852046 Change-Id: Ibba68ae848efeb7518ec1942719da666f5f92f24 Reviewed-on: https://chromium-review.googlesource.com/1150970Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#578470}
-