- 01 Oct, 2019 40 commits
-
-
Anastasia Helfinstein authored
Bug: None Change-Id: Icf3fa74c760378f73b536fbf59e224cc879832e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830140 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#701717}
-
Fredrik Söderquist authored
After having been separated for a bit, CalculateAnimationRepeat(...) and its companion CalculateAnimationPercent(...) can now be merged again. While doing this, eliminate the float epsilon tricks in favor of integer epsilon tricks (and attempt to comment on what is being done). Bug: 998526 Change-Id: Id1d7367672f46886e466b42e49be8dd968fbd1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833587 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#701716}
-
gogerald authored
This is the first patch of splitting the bigger one https://chromium-review.googlesource.com/c/chromium/src/+/1797069 Screenshots: https://drive.google.com/file/d/1bmR-hfo1XQsaB61MbGUSmRjAIOyypaEj/view?usp=sharing https://drive.google.com/file/d/1opItnNVwGI-eRJxlN6M2hxurS88D4btX/view?usp=sharing https://drive.google.com/file/d/1ElJLgbogCb-f-D5vO6hmjC5SznxxWZKc/view?usp=sharing https://drive.google.com/file/d/1RU88SHUqFqSu_VhxrdyfVTSSWJcMdn3i/view?usp=sharing https://drive.google.com/file/d/1JQZAiFVOcQSeU9N8XOK7Zyh7TL5xT6Vk/view?usp=sharing Bug: 982018 Change-Id: Iec9086c6538d29208ba92b106985bb04f0148983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817106 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#701715}
-
Josh Nohle authored
- Merge redundant cryptauth_better_together_feature_types.cc/h into cryptauth_feature_type.cc/h. - Change the strings from camelcase to uppercase-underscore format--the format the CryptAuth server uses. - Add function to convert from multidevice::SoftwareFeature to a feature type string. This will be needed to build BatchSetFeatureStatuses requests. Bug: 951969 Change-Id: I4e516b2790edbb5ca2c08261fec3f59f35ab4994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834062 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#701714}
-
Akihiro Ota authored
This changes the behavior of ChromeVox LanguageSwitching to fall back on the browser UI language, instead of the current language, if we can't make a confident language switch. The previous scheme became an issue when navigating through certain UI elements, such as those in the status tray, which do not have a detected or author-provided language. So if we switched to German and immediately started navigating through the status tray, all elements would be announced in German, even if the system language is English. This change fixes the undesired behavior. This change also adds a test to confirm new behavior and does some clean up around the LanguageSwitching code. Bug: 1000284 Change-Id: I85c5b67a17e292dda95a16b144b7a45ea8448f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827669Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#701713}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fc2b2deb2628..a66d10dcbbfc git log fc2b2deb2628..a66d10dcbbfc --date=short --no-merges --format='%ad %ae %s' 2019-10-01 bhthompson@google.com Set R76 release branch N PFQ to gandof Created with: gclient setdep -r src/third_party/chromite@a66d10dcbbfc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Icc309f89dbc068ae5c5c0fd8254d3d94c2627f3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832997Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701712}
-
Dirk Pranke authored
We are in the process of dropping support for the jumbo configuration; removing it from the CQ is the first step. Bug: 994387 Change-Id: Ia333d1b4bb6b1f869425f924123cd237193a6ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834205Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#701711}
-
Fredrik Söderquist authored
When an interval restarts we won't necessarily get a new interval, but just adjust the current interval (which could then potentially end). Change CheckAndUpdateInterval(...) to reflect this, and narrow the restart criteria in UpdateActiveState(...). UpdateActiveState(...) was also only checking for "inactive" -> "active/frozen" transitions to 'begin', but we need to check for transitions from "frozen" as well. Also re-order the check for 'end' so that it is before the one 'begin'. This will mean that events should get dispatched like: 'begin', 'end', 'begin' and 'end' when we encounter a restart (like in the testcase), rather than as previously: 'begin', 'begin', 'end' and 'end'. Bug: 998526 Change-Id: I56b2391fdcc22f3a22332d6eeb6aa469225497f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821922 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Daniel Rubery authored
This CL adds a result enum to the PhishingDetector Mojo interface. This allows a non-successful feature extraction to be reported. There is now only one (known) situation where the callback may not return in a reasonable time frame: If the page text is not captured for the requested page, the ClientSideDetectionHost will wait, in hopes the page text is captured. This CL adds metrics to see how often the page text recapture actually occurs, for future evaluation of this behavior. This does have a small behavior change for the ClientSideDetection models, which used to reclassify the current page if the scorer is updated. Since scorer updates are so rare, this case now immediately returns. Bug: 995466 Change-Id: I48cb432c38e0c62723e126bb2335aaba9d03bb02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820104Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#701709}
-
Alexander Timin authored
It turns out that fetch() and XMLHttpRequests are now tracked as network requests. This patch adds tests to verify this behaviour. This patch also slightly improves tracing for active feature detection. R=kouhei@chromium.org,arthursonzogni@chromium.org Change-Id: I368f3b52ba8930269bef284f98bd1831944633f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825419 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#701708}
-
Fredrik Söderquist authored
When we're updating an interval and get a new interval notifications are sent to all dependent syncbases. These dependents may in turn deliver notifications back to the original timed element, which would recursively update its interval - potentially clobbering the current one. Instead of doing that, leave the notification function early if we detect that we're in the process of notifying dependents, and then let the regular interval update code pick up and process the new instance time(s). This means we can notify dependents in more logical ways (i.e directly after updating |interval_|) rather than setting |interval_has_changed_| and let UpdateSyncBases() do the notifications. UpdateSyncBases() remains for now, but will be removed in a follow-up. Bug: 998526 Change-Id: I2ace98c3443fd95645df724e5532465f4ca307f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832807 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Yang Guo authored
This enables showing more details in the Timeline Panel. Steps to use: - Run chrome with --enable-ui-devtools - Navigate to chrome://inspect#other - Connect to UiDevToolsClient - Record a performance trace Change-Id: If8af634f894f937bd4192c774bedf105b8563a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767717Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#701706}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8c500751cd1c..1e9112fbb472 git log 8c500751cd1c..1e9112fbb472 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 mtklein@google.com roll mips toolchain to gcc 8 Created with: gclient setdep -r src/third_party/skia@1e9112fbb472 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: Ia20fb0581928de7d2be571ce946854b78b7440b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832995Reviewed-by:
-
David Van Cleve authored
This change resolves the issue described in crbug.com/612601 (internal) by changing the existing ternary implementation of TimeDelta::FromDouble into a call to saturated_cast. Back in 2016, when TimeDelta::FromDouble's current control flow was written (https://crrev.com/1976703005), there was some concern about using saturated_cast here because TimeDelta's permitted values ranged from Max() to -Max() at the time. jyasskin implemented a safe version [1] that met the [-Max(), Max()] requirement, but it looks like the CL got lost somewhere before landing. As of February 2018 (crrev.com/c/539058), the internal value of TimeDelta can now range over all int64_t's, so the desired semantics of TimeDelta::FromDouble are now those of saturated_cast<int64_t>. [1] https://codereview.chromium.org/1976703005/diff/100001/base/time/time.h#newcode627 Test: Expanded time_unittest Bug: 612601 Change-Id: Id00bdad9e732a22f0765c228b65ac6d65aa8b3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830114Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#701704}
-
Fredrik Söderquist authored
This splits said method into one that dirties the interval state in the time container and one that schedules an actual update. For one of the current cases we can trivially remove the scheduling of an update because it isn't needed. Bug: 998526 Change-Id: I9ec5af56c85c914fca0608fb2254f75bf093e415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829715 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
ckitagawa authored
This CL introduces a FileManager class for managing the top level paint_preview/ directory and the immediate per-url subdirectories. All creation/deletion of these directories should occur through this class. However, files within the per-url subdirectories can be modified by any component of paint_preview (primarily the capture and compositing code). This class will be an integral component of a higher level manager class. The manager will call into this class when it needs to perform a capture or do deletion. Bug: 1010042 Change-Id: I7b45a8f730837fcc1d0262ab0dcf3c89698974f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833289 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#701702}
-
Kelvin Jiang authored
This CL moves RulesetManager::Action to its own file: request_action.h This refactor is a precursor for RulesetMatcher to return actions when actions contain a rule ID and source type. Bug: 967942 Change-Id: Ia0ce3d48959509ed31d65d647a88a55ce2ead478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832625 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#701701}
-
Long Cheng authored
Run third_party/closure_compiler/roll_closure_compiler to update closure_compiler/externs/chrome_extension.js and revert closuer_compiler binary. Change-Id: Ia2bb9afeaa38623808e81515043714ff8c0e05f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814389Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#701700}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/deb28ea45d0d..c15160f3ab08 git log deb28ea45d0d..c15160f3ab08 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 rharrison@chromium.org Rolling 4 dependencies Created with: gclient setdep -r src/third_party/dawn@c15160f3ab08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I49e1f45229789a87d65ec5009dffad03913635e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832996Reviewed-by:
-
Kevin Bailey authored
Solely a documentation change: Make clear what state a new alert bug should be in, and conditions for changing. Bug: 1006570 Change-Id: I991fe799d620394cac0dfe35624b92d4b3fd60f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832698 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
-
Peter Boström authored
This set of classes are intended to remove the need to override OnBoundsChanged on Views to set |kHighlightPathKey|. Whenever a path is needed the generator gets asked to generate one. Bug: chromium:1007546 Change-Id: I756e0e66d13dab03adf13e7024fea82b571d6a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825865 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#701697}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5a8a51c2..9c6064a4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib5f657c248b393daa699a835580cfed181536969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833805Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701696}
-
Ian Struiksma authored
As list of actions available grows the same code is replicated for each action execution method. This CL adds a couple helper methods: ExtractFrameAndVerifyElement SimulateKeyPressWrapper To encapsulate some logic in one place. Add CloseTab and PressSpace actions to captured sites framework Fixed multiple tests by adding additional methods and reviewing the stored site recipe files. Bug: 984664 Change-Id: I5ceb03e92e76e4dfaeff77e9b456961331e04b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828230 Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#701695}
-
Tommy Li authored
It's been inactive since M77. Bug: 975323 Change-Id: I68bed0983474f12a3fbf5ffbc53641878f5d25bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832298 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#701694}
-
Oystein Eftevaag authored
TBR=perezju@chromium.org NOTRY=true Bug: 1009838 Change-Id: Id337a4ccf744ccafba49db0b2b51d543f29ea8b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834281 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#701693}
-
Yasmin Molazadeh authored
This reverts commit 7b3cdc42. Reason for revert: <INSERT REASONING HERE> Original change's description: > Check enterprise policy on the receiver side for the Shared Clipboard feature. > > Bug: 1005813 > Change-Id: I7c135ef3a969bd774c735f89fa82413c73aa9ecb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825601 > Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701059} TBR=mvanouwerkerk@chromium.org,yasmo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1005813 Change-Id: I987d4ef62b14078c6d5d47adb6866dcf435344db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834181Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701692}
-
siyua authored
Add existing functionality to local card migration icon. Previously it has a label fade-in/-out animation. Disable that and replace with the new animation when experiment is enabled. Also move loading indicator to PageActionIconView so that child view does not need to know. Bug: 964127 Change-Id: I2024c6d9ed23eea261b733dece833a9072faeced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828345 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#701691}
-
Toby Huang authored
The feature kSupervisedUserInitiatedExtensionInstall is default- disabled, but if enabled, allows legacy supervised users to remotely send approval requests to their "custodian". For go/unicros-extensions-dd, we will instead use local parental approval. This CL removes the code from SupervisedUserService that sends the remote approval request. Bug: 1004851 Change-Id: Ia30102c301f720cfc609b6aa093285bb4f839f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816450Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#701690}
-
Xida Chen authored
This reverts commit 19278ca1. Reason for revert: revert to get more info when fails. Original change's description: > Disable FeedbackTest.AnonymousUser on win > > TBR=hbos@chromium.org > NOTRY=true > > Bug: 1010031 > Change-Id: I9ad685d4f58729f3ac6296e3aa7297c315261660 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832987 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701554} TBR=hbos@chromium.org,xidachen@chromium.org Change-Id: I633f71db63c04f52e92d43fabf70a580b4542829 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1010031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832700Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701689}
-
Mathias Bynens authored
This patch adds support for emulating CSS media features in general. For now, explicit presets are added for `prefers-color-scheme: light` (useful when the developer has enabled dark mode at the OS level) and `prefers-color-scheme: dark` (useful when the developer has enabled light mode at the OS level), as well as `prefers-reduced-motion: reduce`. The new UI is available in the Rendering drawer. The new settings are also accessible through the Command Menu. As Chrome implements support for additional CSS media features in the future, we can expand the current UI accordingly using the same mechanism introduced by this CL. CSS media features: https://drafts.csswg.org/mediaqueries-5/#mf-user-preferences Boring but useful demo/test page: https://mathiasbynens.be/demo/css-media Design doc: https://goo.gle/devtools-dark-mode Bug: chromium:1004246 Change-Id: I7dd067ea1659c6f27872c4f7a5464896618d1663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832206Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Yi Xu authored
WebGLRenderingContextBase::GetImage failed to restore the FrameBuffer to its original frame buffer binding. This caused the framebuffer to be lost and unable to new updates on screen. Bug: 1008077 TBR=thakis@chromium.org Change-Id: Idae5bcef59b65a6002f4b62642e799bf59882111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831006 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#701687}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9203f768126d..b4137027e4aa git log 9203f768126d..b4137027e4aa --date=short --no-merges --format='%ad %ae %s' 2019-10-01 ilkos@google.com Merge "Do not consider invalid callstacks" 2019-10-01 fmayer@google.com Merge "Check ProfilePacket.index in Trace Processor." 2019-10-01 taylori@google.com Merge "perfetto-ui: Prevent double incrementing search index" 2019-10-01 treehugger-gerrit@google.com Merge "Add buildflag for local symbolizer" Created with: gclient setdep -r src/third_party/perfetto@b4137027e4aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Id8a4c03070a30c3c644656be1354814e647f4556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832993Reviewed-by:
-
John Chen authored
This reverts commit 4df5ee8d. Reason for revert: Report of wrong screenshot size Original change's description: > [ChromeDriver] Fix screenshot size on Retina > > Fix screenshot size on Retina screen by setting scale = 1 / device_pixel_ratio > > Bug: chromedriver:752, chromedriver:2683 > Change-Id: I1b378e2cda6f8b52f67337c754ae18cf2cb8130f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772436 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Tatiana Buldina <buldina@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692284} TBR=johnchen@chromium.org,buldina@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/141649053, chromedriver:3154, chromedriver:752, chromedriver:2683 Change-Id: I51b850771f8aea11686883f3cc5bb99b0c6ca838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834162Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701685}
-
Matt Menke authored
Bug: 1002213 Change-Id: I4dce2662917042fe78ed8335a7f13db493cdee60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829748Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#701684}
-
Sven Zheng authored
Reset the test account is a required step for e2e test. With this change, we can have at least 21 e2e tests passing. Other tests have failed because my account is blocked by server(429 too many requests). Next steps will be: 1 Resolve the server issue. 2 Add passing tests to CI. Bug: 992143 Change-Id: I848ded79bd6f722fda42ccbdda7ee5b12f7042be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829469 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#701683}
-
Vladimir Levin authored
This patch cleans up the imperative version of the API by removing the idl and all other associated functionality that is no longer accessible. R=chrishtr@chromium.org, rakina@chromium.org Bug: 882663 Change-Id: Ib355eb79b4c68d56425132570ec84bd93ec5bae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832281 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#701682}
-
Maksim Sisov authored
FlashFrame method is meant for flashing a native window to draw attention to it. However, not all the platforms support that. Thus, there is a default no-op impl of that method in the PlatformWindowBase. As I know, currently X11 and Windows backends support that. No functional changes are done in this patch. Just moving the code to the "right" place. Bug: 990756 Change-Id: Ib463ba75b0cdf5e49e705f0425241e242759adcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831897 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Etienne Pierre-Doray authored
To investigate BLOCK_SHUTDOWN tasks posted after shutdown (see bug). Bug: 997754 Change-Id: Ie939ee242f56ab4ba25e6a67d640ad7873d3ad4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827938Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#701680}
-
Raymond Toy authored
Add time histogram to measure the length of the impulse response for a ConvolverNode. Bug: 998154 Change-Id: I8167cbfe51edea0e072ad571095c6f11d5b12526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773418 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#701679}
-
Wei Li authored
Survey's overflow style was changed from 'hidden' to 'scroll' recently(https://critique.corp.google.com/#review/270089435). That causes the scroll bars always show up which is undesirable for us. This CL overrides the overflow style to be 'auto' so that scroll bars only show up when needed. BUG=1009757 Change-Id: I0b9edd27984bcdba8f4c9f1e27f4e4c26650ab57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832633 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#701678}
-
