- 23 Apr, 2019 40 commits
-
-
Andrew Grieve authored
Saves a couple of seconds of build time for base bundle modules, and simplifies the GN logic for resources. Also fixes chrome_apk using unoptimized arsc file when lemon is enabled (broken by 2e296d82). Simplifies temp file usage in compile_resources.py by having all outputs go to the staging directory. Removes cruft: * Unused --no-compress flag * Unnecessary "Touch()" of R.txt Bug: 950233 Change-Id: Ida77380e8038002435ec3d320105d9feaa3c2136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568568 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#653275}
-
Liquan(Max) Gu authored
Background image is different from normal image in that one node could have multiple background images, while a normal image is one node by itself. Currently we are using node id to track all of the background images attached to a node. All of the background images attached to one node are regarded as one image (tracked by one ImageRecord) in FCP++. We should track each background images separately instead to have higher resolution to the background image behaviors. This CL will address this issue. We will use the DOM node id and the style image pointer as a pair to be the id. Bug: 936149 Change-Id: I6302872dbd2a2b3e082eeeaa7720354eced50275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554426Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#653274}
-
Marc Treib authored
Change-Id: Ic7b851d7330c1f2bded6fce997119412556657e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578547 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#653273}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I22998e1256224efe720a00fda4770b51c06b2200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577921 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#653272}
-
Eric Roman authored
Net.FtpDataConnectionErrorCount Net.FtpDataConnectionErrorHappened Net.FtpServerTypeCount2 Net.HadFtpServerType2 Change-Id: If26b1b2b78d02065ae53a9e09f3935e350ed1955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577778 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#653271}
-
Gang Wu authored
Build will break if feed is disabled when building, so remove feed's enum from Zine. Bug: 955492 Change-Id: I039c97755c93636264e613812f035ac800ac6f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579179Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#653270}
-
Ian Kilpatrick authored
As above, drive-by audit of the code, and noticed a lot of unused methods. Removes / makes the methods private if internal only. Change-Id: I2f61f21e29cffe9b96b29d5b8aa696c3ca842b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579243Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#653269}
-
Ehsan Karamad authored
This CL extracts the postMessage code from MimeHandlerViewContainerBase class into its own PostMessageSupport class. This refactor helps shaving off more code from MimeHandlerViewFrameContainer by eventually reducing it down to a basic subclass of PostMessageSupport::Delegate instead of the more heavy weight MimeHandlerViewContainerBase. TBR=thestig@chromium.org,lazyboy@chromium.org Bug: 659750 Change-Id: I88845d96d30a5426026831aef2b45edd15971c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576807Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#653268}
-
Bruce Dawson authored
When profiling unit_tests for various performance issues it is hard to find the main thread if it isn't named - so name it. Change-Id: I01eb3014bb896c095358abd7f778df4b043c3581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577788Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#653267}
-
Regan Hsu authored
This CL changes the color of the title bar (which excludes the webui). Bug: 950007 Change-Id: I9cdcc27ce9ba7a4f9f49363f114f1b0f802dfeb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578239 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#653266}
-
Reilly Grant authored
This is a simple first step towards refactoring ChooserContextBase to take url::Origins for all of its origin parameters. This method is the easiest to convert first. Bug: 951785 Change-Id: Ib662fca93ff459cb01488d1503cd88c2bd2703f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559703 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#653265}
-
Eric Roman authored
Those requests will instead fail with the more generic ERR_TUNNEL_CONNECTION_FAILED. Bug: 928551 TBR: mfoltz@chromium.org,benwells@chromium.org,atwilson@chromium.org Change-Id: I3a41c2b52a30fbe75bcf8c6490c5c7162f80f68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577685 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#653264}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ab1a9efe..33a2e1ab Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9f303938edd0534e59f9c6816f0ae648504adcd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577929Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653263}
-
Chris Harrelson authored
Even if we omit a mask layer, the content isolation node needs a stable_id if it gets a render surface. Also, the stable_id needs to stay stable, because the id is used to track damage and re-use render surfaces. For this reason, we need to continue storing a list of SynthesizedClips, even if they don't have layers. Bug: 953933 Change-Id: Ied9b508072ee82f592561517bd8c067c927eabe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576231Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#653262}
-
Tim Song authored
Because the notification count label is not focusable, when ChromeVox is enabled, we should say the number of notifications upon focusing on the clear all button. TEST=manually verified BUG=954688 Change-Id: I1e62053ff46a76fbfa775d31b5f33497eda00630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577696Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#653261}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/707ed9974cb3..652edcc30204 git log 707ed9974cb3..652edcc30204 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 swiftshader.regress@gmail.com Regres: Update test lists @ 707ed997 Created with: gclient setdep -r src/third_party/swiftshader@652edcc30204 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I8dc677ce0f743974a93c9d8d5a0065e0e8fefd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578431Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653260}
-
Peter Kasting authored
Bug: 940135 Change-Id: I041df41a27c38f6dad5f0c5033e748523d6b7192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576221 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#653259}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/22219acb4b58..5929b0ffd0d5 git log 22219acb4b58..5929b0ffd0d5 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 fmayer@google.com Merge changes I2dfa0347,I951ff7a7 2019-04-23 hjd@google.com Merge "perfetto_cmd: Add user guardrail" Created with: gclient setdep -r src/third_party/perfetto@5929b0ffd0d5 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ica7bbd031c75bd9640c515397865bc27b3560aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579239Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653258}
-
Sammie Quon authored
Test: ash_unittests TabletModeControllerTest.TabletModeTransitionHistograms* Bug: 948707 Change-Id: I4873218519e6462a13f299a3ecb7bbb0cef5aa01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562717Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mitsuru Oshima (Slow 4/22-26) <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#653257}
-
Richard Knoll authored
Windows 10 native notifications need at least one action button to support the "requireInteraction" feature. We show a "close" button by default but ignored the event after passing it to chrome through notification_helper. This now handles the close event in those cases and forwards the event to the service worker. Bug: 950363 Change-Id: Ibdf66e302836f38f90d32675d68d77f13d568397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579080Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#653256}
-
Peter Kasting authored
* nullptr * Rewrite DesktopMediaListView::Layout() to loop over rows and columns instead of directly over children, which shortens the code * .empty() * OmniboxPopupContentsView is guaranteed to have GetMaxMatches() children (see constructor), so can use range-based for there * Don't bother with constants for object indexes in unittest code where they add no clarity * Don't reuse temps for different things * Shorten code * Init members in declaration * Avoid string construction using EXPECT_STREQ Bug: none Change-Id: I3b7531e4dacfa8836a63f7118eac7293c9a89595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576225Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#653255}
-
Bruno Santos authored
Bug: 927809 Change-Id: I908609c9253820ec2508c12e82fec687c7728b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579279Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#653254}
-
Becky Zhou authored
TBR=bsheedy@chromium.org Bug: 955516 Change-Id: I7fa59b0567e3f4d5f8e0986b3d5f3bd0e5b8f533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579226Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#653253}
-
Aditya Keerthi authored
The Windows Thread Pool API provides a CallbackMayRunLong method to indicate that a callback may not return quickly. The thread pool can use this information to better determine when a new thread should be created. This CL teaches PlatformNativeWorkerPoolWin about ScopedBlockingCall in order to determine whether a callback will return quickly. A BlockingObserver is registered before running a task in the work callback. If the task contains a ScopedBlockingCall, the observer is notified, and will call CallbackMayRunLong on the appropriate PTP_CALLBACK_INSTANCE. Bug: 756547 Change-Id: If04d2c5e01b00960dc510e94ff89525036c2ae67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574229 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#653252}
-
Oleh Lamzin authored
Subscribe on UsbPowerShare local state prefs and pass it to ChromeOS side. BUG=b:130014793 TEST=chromeos_unittests && ash_unittests Change-Id: I6cf3f65923693206b3c004078e7ada74153a27fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569015 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#653251}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8aa2edb1. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e921520 "[Code Health] Remove unnecessary reference file for web test" 40465b74 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" e28269b6 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." aff3c8fe "Add tests for crbug.com/363609 and crbug.com/954591" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I8be51b06ae54a62eae2e16b74fd4a18771b0b4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576335Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653250}
-
Daniel Bratell authored
Since we had a bug because of this missing check, let's not repeat it. Bug: 949535 Change-Id: Ic3ef619403dfcc3ecb8ffecd5f1e2cc80681dc94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552830Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Auto-Submit: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#653249}
-
Ryan Hansberry authored
Change-Id: I38b452c7d5ff9a634e91453e2cee3e0e99fe2b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578585 Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#653248}
-
Sujie Zhu authored
Extract IsCreditCardSupport function to payments_util so that later Upstream and migration can share this util function. Bug: 954367 Change-Id: Ib598ba8eea230ee741706b2bf17b0dd8a1746ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574885 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#653247}
-
Victor Hugo Vianna Silva authored
Removing code in Wallet USS that is no longer necessary. Final step in solving https://crbug.com/880735. Bug: 880735 Change-Id: Ie316eee735dd4b586eed1b90a1541c986e485c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570035Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Auto-Submit: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#653246}
-
Pavel Yatsuk authored
On touchless devices context menu should be shown through ModalDialogManager. Mechanism of triggering for context menu is also different. This change adds functionality to ContextMenuManager to display context menu given ContextMenuManager.Delegate of the item in focus. It is part of a bigger change described at doc/1JUcJNyVM3qNCIl2BMmfVu4d_ctQELhjQq8Rn4K_jxgk In this CL: - Extract handling code from ItemClickListener to be reusable between the two methods of showing the menu. - Add code to build menu item and menu PropertyModel - Add code to show menu and handle interactions - Cleanup: remove public closeContextMenu and adjust callers. - Cleanup: Fix the issue where item's OnAttachStateChangeListener#onViewDetachedFromWindow was causing redundant calls to closeContextMenu when the item was scrolled out of view. BUG=937445 Change-Id: I6e4942fed0f7702dcef4cb5e4e252dec9667e3a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574689 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#653245}
-
Elly Fong-Jones authored
Bug: None Change-Id: I54182aba33401292d5df0c382a6715a9cc76dc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577936 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#653244}
-
Eric Karl authored
Ensure that resources locked via LockForExternalUse are passed to SkiaOutputSurface::ReleaseCachedResources, allowing SkiaRenderer to clean up its cache. This avoids runaway cache growth / memory leaks we were seeing. Also adds test coverage. Bug: 954595 Change-Id: I4d86ee59096f08c7e876a1aeee0f40d042683e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576024Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#653243}
-
Wez authored
This reverts commit 0da11cae. Reason for revert: This change was reverted down-stream, so reverting it here to keep things consistent. Original change's description: > Use CastSysInfoDummy for fuchsia > > This is a temporary solution until we implement a Fuchsia version of > CastSysInfo. The only downside to using the dummy is that the strings, > such as serial number, model, build, etc are all faked out. > > Bug: internal b/126768956 > Test: CQ > Change-Id: I3364d87c57d7f40dbe2d1e80b19bb2f02532512b > Reviewed-on: https://chromium-review.googlesource.com/c/1496419 > Reviewed-by: Yuchen Liu <yucliu@chromium.org> > Auto-Submit: Aidan Wolter <awolter@chromium.org> > Commit-Queue: Aidan Wolter <awolter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636644} TBR=yucliu@chromium.org,awolter@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: internal b/126768956 Change-Id: I2d5017748da975de8516888f24ac62b9e8e00bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578185Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#653242}
-
Raymond Toy authored
Remove BreakConnection() function. It was only called from ReleaseActiveSourceNodes, which is only called Uninitialize from the main thread. Thus BreakConnection is never called from the audio thread, so it always called BreakConnectionWithLock (after getting the graph lock). So, just change ReleaseActiveSourceNodes to get the graph lock and call BreakConnectionWithLock directly instead of call BreakConnection. This method is now unused, so remove it. This also means that AddDeferredBreakConnection is never called so remove that too. And that implies that we never add anything to deferred_break_connection_list_ so that can be removed too. This is a first step in breaking connections on the main thread. Bug: 942128 Change-Id: I712f55558e15a80aadd90573cc292355bb83bef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524692 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#653241}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11c47f6e5f74..5c2db7bce046 Created with: gclient setdep -r src-internal@5c2db7bce046 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: Ic941b81e733146fa4f3e48efb04efdfb9966d5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578437Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653240}
-
Nicolas Ouellet-payeur authored
Bug: 955441 Change-Id: I00bf4a10d8849d0e30045b616fb6f7bc69694ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578940Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#653239}
-
Camille Lamy authored
This CL adds support for passing a custom Origin to be used at commit time in NavigationSimulatorImpl. Bug: 728571 Change-Id: Ieaef85f7add5de633187635152a7e081917b6215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578750 Auto-Submit: Camille Lamy <clamy@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#653238}
-
Stephen Martinis authored
They currently aren't being parsed correctly, due to the additional args looking like command line arguments the merge_results.py script wants to process. This changes it to require a JSON serialized array of strings, which won't be consumed by the parser. We can't use nargs='*' because we already use that to receive the list of input test results. Bug: 923711 Change-Id: I5709ffdcdce653e8f46b4ef6c3b8ae2cc9579127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572805Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#653237}
-
Mohamed Abdelhalim authored
This is the second part of splitting https://chromium-review.googlesource.com/c/chromium/src/+/1554767 Next steps: Move the remaining members from NavigationHandleImpl to NavigationRequest, and merge NavigationRequest::NavigationHandleState into NavigationRequest::NavigationState. Bug: 916537 Change-Id: Iff2193f6167f12301b84ae35be5ba6cdb1c5356b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578543Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#653236}
-