GitLab

Call UpdateOpenTabURLs inside FeatureExtraction so we can have
urls logged as well.

Bug: 784232
Change-Id: I403cafbfe9f2691fdcfc7a83b0d85219c487884e
Reviewed-on: https://chromium-review.googlesource.com/802655
Commit-Queue: Renjie Liu <renjieliu@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520838}

User interaction with NotificationViewMD should fire the appropriate
callback methods defined in MessageViewDelegate.

Especially, with the interaction in the actions row, we should fire
- ClickOnNotificationButon
- ClickOnNotificationButtonWithReply

This CL adds the following unit tests to test these callbacks.
- TestActionButtonClick
- TestInlineReply

TEST=message_center_unittests
BUG=789057

Change-Id: Iba71e1f928830071fe73a7e49feb44efe493c8dd
Reviewed-on: https://chromium-review.googlesource.com/799592
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520837}

BUG=789375

Change-Id: I752b5eb006f43df0949374acac464793db92115d
Reviewed-on: https://chromium-review.googlesource.com/795550
Commit-Queue: Wei Guan <weigua@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520836}

Check whether the tab was recently audible (last 2 seconds) when logging
the TabManager.TabMetrics UKM.

Bug: 784639
Change-Id: I755305fecf1c13668219e972ad41312da91ca568
Reviewed-on: https://chromium-review.googlesource.com/795175
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520835}

enum ServiceWorkerFetchEventResult does not have to be a common type for
both browser and renderer code, this CL moves it out of
content/common/service_worker/service_worker_types.h, and also removes
the unnecessary IPC traits for it from
content/common/service_worker/service_worker_messages.h.

BUG=789854
TBR=tsepez@chromium.org

Change-Id: I6bda299731b71b8b5f9c493b1a785b7f9889f45b
Reviewed-on: https://chromium-review.googlesource.com/799551
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520834}

Change-Id: I7263f9f0291b14f5bc0e4831b371465b073ebc96
Reviewed-on: https://chromium-review.googlesource.com/786639Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520833}

This relands 290a7939 which was
reverted by 16af3fb6, except
that it omits the changes to test that flaked.

TBR=asvitkine

Bug: 761524
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I6d68e0a7cab7307544c4ddda5df3d153bc3d69a4
Reviewed-on: https://chromium-review.googlesource.com/802415
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520832}

Bug: 778749
Change-Id: I34f85b22f6b292c05820cf010471d8fb9f861e3b
Reviewed-on: https://chromium-review.googlesource.com/789412Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ravi Mistry <rmistry@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520831}

OOBE screens has min-height:640px. If a user changed the display setting to
lower resolution (e.g. 640x400), the bottom part of migration UI will be hidden.
This CL make the migration UI shrinkable based on the screen resolution to make
the "Update" button in the bottom always visible to the user.
(See attached screenshots on the bug.)

Since we don't have enough time to test it before M63 goes stable, this change
applies only to the migration screen to minimize the impact.
Other OOBE screens will be OK without the patch since users will see them before
they can change the display resolution.

Bug: 787393
Test: Manually tested on kevin by setting screen resolution to 640x400.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9d092deb556b8ca0beda6db39c35d48bff223b09
Reviewed-on: https://chromium-review.googlesource.com/800190
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520830}

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957
This CL was uploaded by git cl split.

R=svaldez@chromium.org

Change-Id: I9de4d060616eb3f3eabe736033545eec93fc7dd6
Reviewed-on: https://chromium-review.googlesource.com/798912Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520829}

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1c7240c773aa3f71d2bb7158e8f76aa7340b0f2d
Reviewed-on: https://chromium-review.googlesource.com/790010Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520828}

This covers //net/base to //net/dns in alphabetical order.

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957

Change-Id: I72d8a83ee86d833dc2caa0c3b9103689439bf443
Reviewed-on: https://chromium-review.googlesource.com/789971Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520827}

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957

Change-Id: Ib4d1680c615407583a6ad72ce51634d2f444db99
Reviewed-on: https://chromium-review.googlesource.com/789742Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520826}

The library Motion Interchange for Objective-C is a new dependency
of the Material Components for iOS. Library description:

    This library defines a format for representing motion in
    Objective-C and Swift applications. The primary data type,
    MotionTiming, allows you to describe the duration, delay,
    timing curve, and repetition for an animation.

Bug: 785248
Change-Id: I8a86c3df9832635911c284f637fe0482d774a1c8
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/802086Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520825}

Facebook Messager uses a combo box role with a content editable. Since we are flattening the contents of all combo, search and text box roles, this causes a mismatch between the contents and the AXPositions for e.g. word offsets.
Another problem is that we are relying on various ways to determine whether an object is a text control and if its native or not. With this patch, we unify the logic into a few simple tests that rely on Blink to tell us whether:
A) An object is at the root of a text field.
B) Whether the contents are richly editable.
We need to present plain and rich text contents in a flattened manner on Mac and rich text contents in a non-flatten manner on Win, regardless of the method used to make them plain or rich. For example, it doesn't matter if a content editable, design mode, or the CSS style "user-modify: read-write"  was used, we would still want to show the children on Win. Similarly, if the CSS style "user-modify: plain-text-only" is used we would still want to hide the children on both platforms.
R=aleventhal@chromium.org, dmazzoni@chromium.org

Bug: 732218
Change-Id: I7b3c56531c8f22fc7622d894d6cf40e4b896bd94
Reviewed-on: https://chromium-review.googlesource.com/734192
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520824}

This CL is a followup for a comment in CL 792537. There's no user facing
effect of this change. This changes the calls used to hide/unhide an the
dev tools in the toolbar.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7da1f779b48f942bfb708a4c574c0881269ca3ec
Reviewed-on: https://chromium-review.googlesource.com/798013Reviewed-by: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520823}

BUG=788704

Change-Id: Iedd0fb694e88db9a492f9b670f1e1fd177120a10
Reviewed-on: https://chromium-review.googlesource.com/802402Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520822}

In VerifyCustomHandlerURL, though it should check the URL validation after removing
'%s' in the given URL, it has checked it original URL even though it already removed
'%s'. This CL fixes it as well as adds a new invalid URL test case to the tests.

Additionally, we need to fix 2 tests of registerProtocolHandler in the protocol.html of wpt.
According to the spec, If the %s placeholder is in the scheme, host, or port parts of the URL,
this should throw a SecurityError exception forcibly. However, the 2 tests have been checked
if it throws a syntax error. Fixed it too.

Spec: https://html.spec.whatwg.org/multipage/webappapis.html#custom-handlers

TEST: Add a new invalid url test to http/tests/navigatorcontentutils.
      external/wpt/html/webappapis/system-state-and-capabilities/the-navigator-object/protocol.html

Bug: none
Change-Id: I11f3c626b767b6fdc880bda157741d68d67ee001
Reviewed-on: https://chromium-review.googlesource.com/796252
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520821}

Using wpt-import in Chromium 3a945192.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/6550

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts

TBR=qyearsley

No-Export: true
Change-Id: Ifaeccc6a63d8e9b9001ad617decb59c7ca0b7fb4
Reviewed-on: https://chromium-review.googlesource.com/801856
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520820}

This reverts commit 38f08f4e.

Reason for revert: Causing test failures

This patch landed between https://chromium-review.googlesource.com/c/chromium/src/+/774120 and it's revert https://chromium-review.googlesource.com/c/chromium/src/+/802357. The revert was as the original patch made a test flaky, but it caused several tests to start failing on all bots (it does seem to have reverted cleanly):

(sample: https://chromium-swarm.appspot.com/task?id=3a286e5fea70e510&refresh=10&show_raw=1)
ProcessMemoryMetricsEmitterTest.FetchAndEmitMetricsWithExtensions
PageLoadMetricsBrowserTest.NewPage
ProcessMemoryMetricsEmitterTest.FetchAndEmitMetricsWithHostedApps
ProcessMemoryMetricsEmitterTest.ForegroundAndBackgroundPages
ProcessMemoryMetricsEmitterTest.FetchAndEmitMetrics
ProcessMemoryMetricsEmitterTest.FetchThreeTimes
ProcessMemoryMetricsEmitterTest.FetchDuringTrace

Reverting this patch seems to fix the failures...

Original change's description:
> content: Fix MojoUkmRecorder setup for compositor UKMs.
> 
> The binding of the mojo interface used for recording UKMs by the
> compositor is incorrect, the interface needs to be bound to a service
> using the service connector to start the connection.
> 
> Clone the Connector and pass it to the factory used on the compositor
> thread to do the binding. Its necessary to clone it for the connector
> access to be thread-safe.
> 
> R=​piman@chromium.org
> 
> Change-Id: I1e20e64a6a6500e9c548599f4893d70a028574a7
> Reviewed-on: https://chromium-review.googlesource.com/798538
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520709}

TBR=holte@chromium.org,khushalsagar@chromium.org,piman@chromium.org

Change-Id: If957995149909408de3b916d96151c7b906eea1a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/802934Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520819}

The size is set earlier as speech_result->SetSize(kVoiceSearchRecognitionResultTextWidth, 0)
The removed code is creeped in after a rebase.

Bug: NONE
TBR: cjgrant
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8a92d8bc5b26fe9445230af9fbed95090049c33f
Reviewed-on: https://chromium-review.googlesource.com/802794Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520818}

Make IsThrottable return false when it's throttled by WebFrameScheduler.

Bug: 785770
Change-Id: Idb075c759a10636b406505287b3a1139db54678b
Reviewed-on: https://chromium-review.googlesource.com/799539
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520817}

Bug: 727775
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I9a6f9c87cf7dcaddea526c79880b649d39c47492
Reviewed-on: https://chromium-review.googlesource.com/801455Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520816}

Bug: 773928, 789408
Change-Id: I66009509ad601756ec0281a66fd093ee7fc96477
Reviewed-on: https://chromium-review.googlesource.com/802175Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520815}

This CL implements ResourceLoadScheduler::SetPriority which
re-prioritizes a pending request when RendererSideResourceScheduler
feature is enabled.

Bug: 785770
Change-Id: I0b001f64b5667085a020364c0a419b8f003804cf
Reviewed-on: https://chromium-review.googlesource.com/798950
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520814}

https://chromium.googlesource.com/catapult.git/+log/3ebc2fd9fe64..280aff07f5fc

$ git log 3ebc2fd9f..280aff07f --date=short --no-merges --format='%ad %ae %s'
2017-11-30 eakuefner [Dashboard] Fix tests when html5lib is provided
2017-11-30 simonhatch Remove original addSeriesGroup and rename addSeriesGroup2.
2017-11-30 rnephew [Telemetry] Add test Expectation file parser for TA/DA telemetry integration.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ic533194b19e38b8ae6f7fb4e05cd8830641e9b09
Reviewed-on: https://chromium-review.googlesource.com/802394
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520813}

Toolbar Coordinator creates a property animator animation for expanding the location bar.
ToolbarViewController expands the locationBarContainerView by changing its constraints.

Bug: 784592
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I36414e22a887cd0752cbece06058bf1d67eaec18
Reviewed-on: https://chromium-review.googlesource.com/798752
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520812}

This will not change the functionality now, but will be used
when caption is moved to chrome for ARC++ apps.

BUG=762816

Change-Id: Ia25d13eba37b31677a265b9f3e8b09953a5dd8e5
Reviewed-on: https://chromium-review.googlesource.com/786545
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520811}

Followup to https://chromium-review.googlesource.com/c/chromium/src/+/800950

Bug: None
Change-Id: If1bbf18575ca1b0562499c899960ac003a7678c9
Reviewed-on: https://chromium-review.googlesource.com/802474
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520810}

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I084dedb73e3b5ccc0d958aef88c54e0d8cf820bd
Reviewed-on: https://chromium-review.googlesource.com/795492
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520809}

The gfx::PresentationFlags is defined as enum class(the new c++ style),
but the binary operator | can not be used for enum class. So this CL
changes enum class to enum. And because the old enum style doesn't
have a scope, to avoid polluting gfx namespace, this cl also moves
the gfx::PresentationFlags into struct gfx::PresentationFeedback.

Bug: 776877
Change-Id: I4a16b6e4766199aabf2d006b07be6413b2a80c3b
Reviewed-on: https://chromium-review.googlesource.com/801756
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520808}

If there are any non-composited position:sticky objects that stick
to the root layer, then we must force main thread scrolling to
prevent an "over-scrolling" effect.

BUG=711468
R=skobes@chromium.org,pdr@chromium.org,bokan@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Change-Id: I4c36eaf118b8d4d0078c4d5c5e8b633eb71fe733
Reviewed-on: https://chromium-review.googlesource.com/797221
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520807}

"unsafe-eval" CSP directive is enabled in
WorkerOrWorkletScriptController::Evaluate(). This function is called for classic
script evaluation, not for module script evaluation that worklets depend on.
This means the current implementation doesn't work for worklets.

To enable the directive for worklets, this CL moves the part from Evaluate() to
InitializeContextIfNeeded() that is supposed to be called for both classic and
module script evaluation.

This CL also fixes ExecutionContext handling in
CodeGenerationCheckCallbackInMainThread(). This path is called not only from
Document but also from PaintWorklet.

This change is tested for workers by existing CSP tests, and will be tested for
worklets by tests to be added by a following change:
https://chromium-review.googlesource.com/c/chromium/src/+/771051

Bug: 773786
Change-Id: I29232a4297b2f4819f1fe28f3230fc7ea4f769f6
Reviewed-on: https://chromium-review.googlesource.com/799654Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520806}

We are getting an NPE on stable for getAssetStatements and it is not
entirely clear from where from the crash stack. The metadata being null
here seems to be the most likely culprit. Adding a null check for that
as a bandaid fix.

BUG=787831
TBR=mariakhomenko@chromium.org

Change-Id: Ie538e4dda791de27d87c2359671037fa75fcc12b
Reviewed-on: https://chromium-review.googlesource.com/802089
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520805}

This reverts commit 6edaf9cb.

Reason for revert: revert for crbug.com/790750

Original change's description:
> mash: make ash learn/control SpokenFeedbackEnabled
> 
> changes:
> - Move Is{Toggle}SpokenFeedbackEnabled code to ash, which used to be
>   AccessibilityDelegate and called into chrome. This won't work in
>   mustash world. This change breaks the delegate way, by having prefs
>   in ash, the Is{Set} could be done in ash.
> - Change ToggleSpokenFeedbackEnabled to SetSpokenFeedbackEnabled to
>   align with other method names.
> 
> feedback enabled update the tray icon visibility. This is one step
> forward.
> 
> Bug: 594887
> Test: tested on emulator with --mash. Could see toggling spoken
> Change-Id: I3a9c4277f6d1e8bfb2b03777011f6f2f9055d296
> Reviewed-on: https://chromium-review.googlesource.com/777780
> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519898}

TBR=jamescook@chromium.org,xiyuan@chromium.org,warx@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 594887, 790750
Change-Id: I29bb0871036990b8e72ff22897575825d3e1674d
Reviewed-on: https://chromium-review.googlesource.com/802615Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520804}

This test was "failing" in root-layer-scrolls mode but it wasn't related
to what this test is checking. Since this test just dumps the layer tree
it was reflecting changes to where scroll offsets are reported in the
tree.

I've rewritten the test to use testharness.js removing all expectation
files and replacing them with a simple assertion that the scroll offset
isn't changed by drag selecting text.

Bug: 781431
Change-Id: I8391caeea794cbdaebfb2b7b86e5c3d9da6268fa
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Reviewed-on: https://chromium-review.googlesource.com/802178Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520803}

Changing SafeManifestParser to use the SafeXmlParser service instead of
having a dedicated Mojo interface for doing the parsing of extension
manifests.
SafeXmlParser parses the XML in a sandboxed process and returns a
base::Value that can be traversed in the browser process.

As a result, the mojom, traits, typemap files have been removed.
The implementation of the parsing has been moved to
safe_manifest_parser.cc.

The update_manifest_unittest.cc was moved to
safe_manifest_parser_unittest.cc and split into several tests (no
changes to the logic).

Bug: 786613
Change-Id: Ia586ea0e9689d45130013b6d4d992318eb9b7dc4
Reviewed-on: https://chromium-review.googlesource.com/777939
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520802}

Convert some bare new()s and a theoretical memory leak into
MakeUnique's.

Bug: 
Change-Id: I1e80714c42f2d7575e774ffdbe2b8f2d5c83c6de
Reviewed-on: https://chromium-review.googlesource.com/801350
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520801}

Reason for revert: crashers.

TBR: piman@chromium.org
Bug: 789436
Change-Id: I34a72d3f528189099be6c67eb671809e052a1cb3
Reviewed-on: https://chromium-review.googlesource.com/801993
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520800}

With this CL, ResourceLoader puts priority information to
ResourceLoadSchedler when RendererSideResourceScheduler feature is
enabled.

Bug: 785770
Change-Id: I4b18df640770e9bc775eae7305d6e858155e82de
Reviewed-on: https://chromium-review.googlesource.com/795632
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520799}