- 29 Sep, 2020 40 commits
-
-
Yi Gu authored
This test has been flaky for a while. See the bug for details. TBR=arthursonzogni@chromium.org Bug: 1133342 Change-Id: I115c2bd2c84958e2e9f46bd9c0f378756af3c9eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436764Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811753}
-
Hans Wennborg authored
Otherwise Python doesn't find git when it's available as git.bat: >where git c:\src\depot_tools\git.bat >python tools\clang\scripts\build.py --llvm-force-head-revision [...] Traceback (most recent call last): File "tools\clang\scripts\build.py", line 1098, in <module> sys.exit(main()) File "tools\clang\scripts\build.py", line 498, in main CLANG_REVISION = GetCommitDescription(checkout_revision) File "tools\clang\scripts\build.py", line 180, in GetCommitDescription ['git', 'describe', '--long', '--abbrev=8', commit]).rstrip() File "c:\src\depot_tools\bootstrap-3_8_0_chromium_8_bin\python\bin\lib\subprocess.py", line 216, in check_output process = Popen(stdout=PIPE, *popenargs, **kwargs) File "c:\src\depot_tools\bootstrap-3_8_0_chromium_8_bin\python\bin\lib\subprocess.py", line 394, in __init__ errread, errwrite) File "c:\src\depot_tools\bootstrap-3_8_0_chromium_8_bin\python\bin\lib\subprocess.py", line 644, in _execute_child startupinfo) WindowsError: [Error 2] The system cannot find the file specified Bug: 1015315 Change-Id: I403a0cb4006f274e4a438e6d69fbbb5540b97570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438056 Commit-Queue: Reid Kleckner <rnk@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#811752}
-
Yue Li authored
Bug: b/150034512 Test: Run existing tests Change-Id: I1a0349a96fe1c640d0611e174410861ab4864e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431792Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#811751}
-
Mehran Mahmoudi authored
There's a NullPointerException crash caused when a tab is closed while paint preview is fading out. This fixes that. Bug: 1133170 Change-Id: I3d3b025fdc70ea83113c09a054f7120555e51f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437739 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#811750}
-
Mihai Sardarescu authored
Bug: None Change-Id: I02dd687be094041cbccafd4618170fc8863e8b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428924 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#811749}
-
Jacob Kopczynski authored
Does not include official builders, which go elsewhere Bug: chromium:1127088 Change-Id: I7ab85f76c9a1bd0b23d6c76c9635487ea51d29e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435927 Auto-Submit: Jacob Kopczynski <jkop@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Jacob Kopczynski <jkop@chromium.org> Cr-Commit-Position: refs/heads/master@{#811748}
-
Mugdha Lakhani authored
To determine whether: 1. Using a CrashReporter when there are no crashes adds undesirable latency. 2. Uploading an existing crash takes too long. Bug: 1133240 Change-Id: I22e766275418ef119f97952b02f553105f115d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437950 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#811747}
-
Paula Vidas authored
This CL adds to DoNotUseOldInvalidationsAtAll test a check that interested topics (for old invalidations) are cleared upon construction of SyncEngineImpl. To allow that, the construction of SyncEngineImpl is moved from SetUp() to a helper method. Bug: 1082115 Change-Id: I94be0c2c781b62ab2f5464c43b4efe86c277d9fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437395 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#811746}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 18 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-12-28. TBR=chromium-metrics-reviews@google.com Change-Id: Ieb44b3da39802189acb99b61b2e890458865752b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437348Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#811745}
-
Olivier Yiptong authored
This changes the permission string for the Font Access API so that it succinctly explains the use-case for the API to the end-user. The string is not ideal, because at best, it does not guarantee that the API will be used for that purpose, and at worst, it is lying (e.g. one may use the API for other legitimate purposes). That said, that's the compromise we've landed on to test this API with users. Bug: 1043306 Change-Id: I30b31bcae8a39f942021ef87f88a53ed3453d3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437090 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#811744}
-
Jazz Xu authored
This CL adds a |hide_artwork_timer_| which makes the artwork view wait for a certain delay to disappear when receiving an empty artwork. This avoid flashing relayout between sessions when loading artwork. (e.g. Getting an empty artwork in a new session, and artwork comes in later because of slow network, which will makes the artwork view disappear and reappear.) Bug: 1128883 Change-Id: Iae6693af7dc6d21559c9f9a8190169b23b9cab35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427586Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811743}
-
David Van Cleve authored
We're observing a surprising number of Trust Tokens issuance failures; this CL adds some logging to help understand whether the cause is due to a failure during request helper construction, i.e. during lightweight precondition checking prior to the operations' main cryptographic and storage-dependent logic. Bug: 1128174 Change-Id: I3f80dec197f7dd46ddbb9b3ba5df39c0c36750f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434733Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#811742}
-
Mike Wittman authored
Third in a series factoring the ThreadProfiler platform specific configuration state from the code that takes action on the state. Defines a GetEnabledRate function that returns how frequently the profiler should be enabled overall, in support of a synthetic experiment. The end goal is to reduce the configuration complexity, to support enabling per-thread on Android. Bug: 1129939 Change-Id: Ib0b23e2c56ff45644c521157789bbf1c1dc64261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424671 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#811741}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1601304808-a0959ded2b2639d64197cdec426ae296818dc3ae.profdata to chrome-win64-master-1601358844-5f86e8497cfc6487ab81eec807b8b1aeda6b4d6d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org Change-Id: I03e3786236a332459efa99e2830750a1fb355442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438155Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811740}
-
Ehimare Okoyomon authored
Bug: 1077766 Change-Id: I9a925df2f9a4e064f41cb6db16e9e29558b88368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437951Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#811739}
-
Aaron Leventhal authored
- Display: none objects should not get an accessible name. - EnsureComputedStyle() should not be called during a potentially unsafe time. This is fixed by calling it during Init(), in cases where it will likely be needed (inside a display:none subtree). - Remove unnecessary and often incorrect heuristic for determining when inside an aria-labelledby or aria-describedy calculation. This flag is already passed in via recursion when following that kind of relation. - Do not recurse into children that are explicitly hidden - Improve explicitly hidden computation for CSS visibility. Explicitly hidden means that the element was specifically hidden, and that it didn't just inherit the fact that it's hidden. - Improve results in name-calc-visibility, where an element explicitly referenced by aria-labelledby wasn't included in the name because it was visibility:hidden element. Elements that are explicitly referenced must be included in a name or description even if they are hidden. TBR: dmazzoni@chromium.org Bug: 1130436 Change-Id: I49095f64940e4c3695382797b2ecf93277d0b56c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435332Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#811738}
-
Xiaodan Zhu authored
The overview gesture is changed when the reverse scrolling option is turned off in M87. The notification should be shown when the user turns off the reverse scrolling. Bug: 1107183 Change-Id: I4f1113a815d1594a4428834406471a2fb577d1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436949Reviewed-by:
-
Mihai Sardarescu authored
Bug: NONE Change-Id: I351d102d2d9a25d81c15417f7fdba72ac3028855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429063 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/76404b01d531..68983d39e5ce 2020-09-29 treehugger-gerrit@google.com Merge "Added dynamic tables for preceding and following flows" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1eb9d35ed900ff41f11632963f44947ace87a3e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438165Reviewed-by:
-
arthursonzogni authored
The WPT testharness.js is defining: ``` WindowTestEnvironment.prototype._forEach_windows = function(callback) { // Iterate over the windows [self ... top, opener]. The callback is // passed two objects, the first one is the window object itself, the // second one is a boolean indicating whether or not it's on the same // origin as the (...) ``` This causes some postMessage to be sent cross-window. They are detected by the Cross-Origin-Opener-Policy-Report-Only. In general, we must ensure that testharness.js isn't used together with access checks. This patch removes the ones for all the tests depending on test-access-property.js Bug: 1090273 Change-Id: I9f13406783d4f5a1d28205b6492ab1b3318c50b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436743Reviewed-by:Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#811734}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /components/paint_preview This CL was uploaded by git cl split. R=mahmoudi@chromium.org Change-Id: I64f78a148bd456e687c1f0948904776925d3ba3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435699 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#811733}
-
Randy Rossi authored
Switching flutter bridge to use the default action verb kClick rather than the boolean attribute kClickable. The boolean attribute was added specifically for Android and has unwanted side-effects including not allowing nodes marked clickable to have navigable descendants. This CL removes a previous work around that was caused by using clickable attribute. Also changing the touch exploration controller to always issue a simulated tap. Ax gestures do not always get propagated to the tap listener via the flutter bridge. This will make for a better user experience for some ui elements that require simulated taps. Bug: None Test: Local display assistant build, unittests Change-Id: I8bb9204d78ef61bb8afc727b9b6b41e2ca05390c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431557Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#811732}
-
Mandy Chen authored
Shortcut deletion result should be false when the shortcut file isn't deleted. Currently the condition is the opposite, which indicates the file is deleted. Bug: 1108109 Change-Id: Id002221b24f50d4b8e3ed931ad71fe9001a0635a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427425Reviewed-by:
Phillis Tang <phillis@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#811731}
-
Haiyang Pan authored
This reverts commit f6c32bf7. Reason for revert: The pool is in a good shape now: http://shortn/_50OsDGj4Ll, and Pie and M CQ do not have test regression Original change's description: > Revert "luci: increase the experimental percentage to 20 from 5 for MM-x86-rel" > > This reverts commit 4f50dcad. > > Reason for revert: Revert to release resource for Android M CQ builder as the bot usage is high now: http://shortn/_6Egeg4knUp > > Original change's description: > > luci: increase the experimental percentage to 20 from 5 for MM-x86-rel > > > > The builder runs a smaller test suite since crrev.com/c/2422710. > > The GCE capacity should be able to hold more traffic. > > > > Bug: 997376, 1127110 > > Change-Id: I23c9bb5b55aa5f335dea3bdc1817c4793fcf9eb0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429249 > > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > > Commit-Queue: Haiyang Pan <hypan@google.com> > > Cr-Commit-Position: refs/heads/master@{#811299} > > TBR=liaoyuke@chromium.org,hypan@google.com > > Change-Id: Iddef5694a45ec74fcfd4bb478008963bde2fcf5c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 997376 > Bug: 1127110 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436854 > Reviewed-by: Haiyang Pan <hypan@google.com> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#811409} TBR=liaoyuke@chromium.org,hypan@google.com # Not skipping CQ checks because this is a reland. Bug: 997376 Bug: 1127110 Change-Id: I33eca2c7caf5991ed82835d5f01d66daf871eec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437700Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#811730}
-
Ahmed Fakhry authored
This reverts commit 58ff1ecf. Reason for revert: Causes consistent failures on linux-chromeos-chrome BUG=1133358 Original change's description: > [Autofill] Add fieldtrial testing config for feature > AutofillEnableStickyBubbleAndUpdatedLogging. > > For more details about the feature please refer to > go/sticky-payments-bubble-dd. > > This feature is currently running 50% in Canary/Dev. > So added this to fieldtrial_testing_config and get ready for Beta. > > Also fixed some tests that will be obsolete when this feature is > launched. > > Bug: 1070799 > Change-Id: I3061a5de8c94e5a7e453e84615d9807fc0baa6b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424078 > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Commit-Queue: Siyu An <siyua@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811449} TBR=mpearson@chromium.org,estade@chromium.org,siyua@chromium.org Change-Id: I7dd8c3382a31cd66a0e9f6876346d8feb0224954 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1070799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438609Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#811729}
-
Bill Budge authored
- Adds a check that V8 did serialize the Wasm Module when receiving the OnModuleCompiled callback. Bug: chromium:1126862 Change-Id: Ie329372b14785a3975f5f8dce5f9ef49b74ec95c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406589Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#811728}
-
Thomas Lukaszewicz authored
This CL adds a UMA histogram to track the API performance of the getTabs() API for TabSearch. Matching WebUI CL below: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3291206 Bug: 1099917 Change-Id: I8ddfddd5197f0d0641a3dcc3bf6c86fe118c07fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432589 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#811727}
-
Tomasz Śniatowski authored
Make it so targets that set enable_desugar=false end up with desugar disabled, instead of still enabled. This affects at least the following targets that tried to disable desugar but it didn't work until now: //third_party/byte_buddy //third_party/accessibility_test_framework //third_party/google-truth Change-Id: I074c26e988311cc6d04dc0173da676f33b225283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437376 Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#811726}
-
Alice Wang authored
This is a reland of a5707a7d Original change's description: > [Android][Signin] Add observer to listen to monogram update > > This CL adds an observer to update ProfileDataCache when user's profile > photo(include monogram) from IdentityManager is updated. > > Bug: 1127886 > Change-Id: I0c70f72708e50dceb63eb122055315f7818cba06 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430984 > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Commit-Queue: Alice Wang <aliceywang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811237} Bug: 1127886 Change-Id: I999a07675d63595cd9e321fa3a224a4cfb7a0f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437430 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#811725}
-
Martin Rodriguez authored
This metric extend cl/2047063. This allow to collect the same metrics when policies are load from disk. Bug: 653849 Change-Id: I044c8236be37d28ea43c94c508088faa7e5b6d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422785 Commit-Queue: Martin Rodriguez <rodmartin@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
DimanNe authored
R=ioanap@chromium.org Bug: 1112804 Change-Id: Ib821db81a139c3bd01d22ca1319b2c749d45dda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421738Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#811723}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /components/plugins This CL was uploaded by git cl split. R=tommycli@chromium.org Change-Id: Ic82fae77b2f270d0b10e9354d903498d7c33117a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435331 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#811722}
-
Tommy Li authored
Add some comments about URLFixer, which should not be used on anything other than user-typed strings. Also warn that URLFixer deviates from GURL's logic with segmentation, which leads to Chrome parsing strings differently from GURL and Javascript's URL object. That is troublesome. This CL makes no code changes, just commentary updates. Bug: 1130091 Change-Id: Ib0302db96870c1fa4258541b2cd8a76a729b669a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437071Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#811721}
-
Egor Pasko authored
Tbr: erikchen@chromium.org Bug: 801006 Change-Id: I177ad5a127c2ff5e17b0d036351fe735f862b173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437436Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#811720}
-
Clemens Arbesser authored
Currently, we don't have a good way of transitioning lite scripts from CCT to regular tab. This changes the activity, but does not update the dependencies of the lite scripts, thus leading to crash when accessing those dependencies. As a workaround, this CL disables stops lite scripts when transitioning from CCT to regular tab. This is an edge case, so disabling this should not affect the scheduled LE. For a proper fix, we need to investigate how to update the dependencies such that lite scripts can continue safely. Bug: b/167947210 Change-Id: I1524805015766c69f463892a9bec4d5b9c5a284e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431484Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#811719}
-
Chris Sharp authored
Bug: 1018157 Change-Id: Ia4d5e4f1e09e5fa659c09b0eb68406b566e8a6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435665Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#811718}
-
Dan McArdle authored
The fuzzer discovered an input that uncovers non-idempotency in ContentSettingsPattern::Builder::Canonicalize. First, the function changes |parts->path| from "/.//" to "//". On a second call, the "//" is changed to "/". This CL repeats the path canonicalization until we reach a fixed point. Bug: 1117622, 1132957, 1128999 Change-Id: I96da902e50a4a9b654a7d4184ef4ad2c0689e705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406332 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
This is not a proper fix, but the workaround is safe and simple. There does not appear to be a good way for listeners of the BottomSheet to tell the difference between a swipe-down to PEEK state versus a swipe-down to dismiss. However, since lite scripts disable the PEEK state altogether, we can use the onSheetClosed(SWIPE) notification to workaround this issue for now. Bug: b/169237887 Change-Id: Iaf8158aa01d2259f993553860cb0825ca3a76ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428887Reviewed-by:
-
Anastasiia N authored
Point account_manager_* per-file OWNERS to OWNERS of Chrome OS Account Manager. Change-Id: Ie7d1a218182eaafdd5df6f06e950f1b4707c093d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438249Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#811715}
-
Michael Thiessen authored
The Feed setup isn't used by most tests and is required to happen once per process init, which make batching tests that use ChromeTabbedActivityTestRule more difficult. There's already a rule to do what CTATestRule was doing, so I've migrated the only test that seems to care about that setup to the FeedDataInjectRule. Bug: 989569 Change-Id: I8142a3904276a294356789f246d977c93f6e48a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437691Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#811714}
-
