GitLab

https://skia.googlesource.com/skia.git/+log/2fcd4a480dee..dc87c95382d5

$ git log 2fcd4a480..dc87c9538 --date=short --no-merges --format='%ad %ae %s'
2017-04-28 brianosman Combine GPU flush with semaphore API
2017-04-28 reed remove unused yuv methods
2017-04-28 reed change drawAtlas to behave like drawVertices

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: I9c3de9d586760183d1bff973d2b30cb204bd89ed
Reviewed-on: https://chromium-review.googlesource.com/490515Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468127}

https://pdfium.googlesource.com/pdfium.git/+log/66568bcd683d..60cd033adf6c

$ git log 66568bcd6..60cd033ad --date=short --no-merges --format='%ad %ae %s'
2017-04-27 thestig Remove dead dimensions code in fxbarcode.
2017-04-28 thestig Fix stack overflow in CFieldTree::Node::GetFieldInternal().

Created with:
  roll-dep src/third_party/pdfium
BUG=716523


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I0e8b85c630a34df3178043e4a5fd729201d45858
Reviewed-on: https://chromium-review.googlesource.com/490806
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468126}

It has been missing from .gn files for a while.

The test looks very similar to chrome/browser/content_settings/content_settings_usages_state_unittest.cc
and it looks like we just forgot to delete it in
https://chromiumcodereview.appspot.com/19375002

BUG=661774

Review-Url: https://codereview.chromium.org/2852483002
Cr-Commit-Position: refs/heads/master@{#468125}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2827253003
Cr-Commit-Position: refs/heads/master@{#468124}

This also adds a stanalone_ash target that is the equivalent of
ash_shell_with_content but running in mushrome mode and without
content.

BUG=708287,706589
TEST=covered by tests
R=kylechar@chromium.org

Review-Url: https://codereview.chromium.org/2840043003
Cr-Commit-Position: refs/heads/master@{#468123}

There is another common main thread scrolling reason that needs
to be added. A scrollable area with an opaque background
is not a stacking context therefore we don't composite it for
now.

BUG=660907
TEST=ScrollingCoordinatorTest.StackingContextTest
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2841603003
Cr-Commit-Position: refs/heads/master@{#468122}

This change implements the creation of textures from a base texture and a patch, in order to reduce the size of assets necessary for rendering the controller in VRShell.

BUG=644562

Review-Url: https://codereview.chromium.org/2837973002
Cr-Commit-Position: refs/heads/master@{#468121}

For SPv2 we always paint effectively invisible content,
but during layerization we scrutinize effect node and
skip chunks that would be effectively invisible. This
simplifies code in SPv2 while still avoiding the
resource and processing overhead of creating, managing
and rastering a layer for that chunk.

BUG=713403
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2833883003
Cr-Commit-Position: refs/heads/master@{#468120}

Reland of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2839083002/ )

Reason for revert:
The patch has noting to do with the failing test. In fact if you look at the flakiness dashboard the test is very flaky there:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Finspector%2Ftracing%2Ftimeline-js%2Ftimeline-runtime-stats.html

Original issue's description:
> Revert of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2840463003/ )
>
> Reason for revert:
> Suspected cause of failure of virtual/threaded/inspector/tracing/timeline-js/timeline-runtime-stats.html in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)/builds/9644
>
> Original issue's description:
> > DevTools: fix aggregated donut chart cache population
> >
> > The check for stats cache availablity was made on the first task in the main thread
> > tasks list. If the first task happens to be filtered out, it never gets cache built for
> > it. Later the cache presence check would look for a cache on the first task, never find
> > it and forces recaching.
> >
> > BUG=714934
> >
> > Review-Url: https://codereview.chromium.org/2840463003
> > Cr-Commit-Position: refs/heads/master@{#467114}
> > Committed: https://chromium.googlesource.com/chromium/src/+/755b1656f38d135013f24ddd8b6ec046874beed2
>
> TBR=pfeldman@chromium.org,alph@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=714934
>
> Review-Url: https://codereview.chromium.org/2839083002
> Cr-Commit-Position: refs/heads/master@{#467223}
> Committed: https://chromium.googlesource.com/chromium/src/+/65df576fce3007b62084239cc8e37a45aea0368f

TBR=pfeldman@chromium.org,sashab@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=714934

Review-Url: https://codereview.chromium.org/2851823002
Cr-Commit-Position: refs/heads/master@{#468119}

The blacklist was introduced by crrev.com/2592233002 to make
thread checks stricter. The blacklist was to throttle the number
of build bot failures.
There are only few providers left and it causes a need for having
|is_enabled_| in MDM. So, remove this check.

BUG=643438

Review-Url: https://codereview.chromium.org/2844373002
Cr-Commit-Position: refs/heads/master@{#468118}

https://chromium.googlesource.com/libyuv/libyuv.git/+log/fc02cc3806a3..3b583396bf13

$ git log fc02cc380..3b583396b --date=short --no-merges --format='%ad %ae %s'
2017-04-24 fbarchard Disable CopyRow_MIPS
2017-04-18 brucedawson Avoid double compiles of libjpeg
2017-04-18 fbarchard Roll chromium_revision da7cc8ca..ce95e5d8 (465147:465389)
2017-04-18 kjellander Roll chromium_revision 7950721f..da7cc8ca (454907:465147)

Created with:
  roll-dep src\third_party\libyuv

The "Avoid double compiles of libjpeg" change will slightly reduce the number of
build steps and will also avoid hundreds of duplicate symbol warnings when
linking. Details in the bug.

BUG=706627

Review-Url: https://codereview.chromium.org/2841273003
Cr-Commit-Position: refs/heads/master@{#468117}

Revert of DevTools: Show screenshots on the main flamechart (patchset #3 id:40001 of https://codereview.chromium.org/2830343004/ )

Reason for revert:
Panning does not work, as well as HiDPI.

Original issue's description:
> DevTools: Show screenshots on the main flamechart
>
> The patch puts the screenshots on the frame bar and makes it expandable.
>
> BUG=705054
>
> Review-Url: https://codereview.chromium.org/2830343004
> Cr-Commit-Position: refs/heads/master@{#466821}
> Committed: https://chromium.googlesource.com/chromium/src/+/575cce8631ed083645523d47a35090d6ca6ccdfd

TBR=pfeldman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=705054

Review-Url: https://codereview.chromium.org/2854473002
Cr-Commit-Position: refs/heads/master@{#468116}

BUG=715627

Review-Url: https://codereview.chromium.org/2848953002
Cr-Commit-Position: refs/heads/master@{#468115}

This CL adds a few more layout tests that are failing on the Site
Isolation FYI bots.

BUG=716085

Review-Url: https://codereview.chromium.org/2845973006
Cr-Commit-Position: refs/heads/master@{#468114}

Right now, we are transitioning to LLD, and LLD has a different
map format (so, the analysis tool will need to be updated), as well as
suboptimal implementation that adds 60 minutes to the Chrome link time.

This will be reenabled when both of the blockers above are resolved.

BUG=716209,607968

Review-Url: https://codereview.chromium.org/2849583005
Cr-Commit-Position: refs/heads/master@{#468113}

BUG=716493

Review-Url: https://codereview.chromium.org/2847813004
Cr-Commit-Position: refs/heads/master@{#468112}

No change in production logic.

Visibility of elements must be checked by recursively checking the
visibility of parent elements, since any element inside an invisible
element will also be invisible.

This issue does not present itself in the Desktop layout, because
.hidden is defined differently (with display: none). Since the mobile
layout defines it with opacity, we need to recursively check parents.

It's not sufficient to check the opacity value itself, because CSS
transitions may not have finished by the time we check. Instead, we
simply check the CSS class and trust it to hide things properly.

BUG=716542

Review-Url: https://codereview.chromium.org/2845423002
Cr-Commit-Position: refs/heads/master@{#468111}

Now that [1] has been fixed and libgtk-3-0 has been installed in
clusterfuzz's 32-bit configuration, it's safe to enable gtk3 for all
platforms.

[1] https://crbug.com/699669

BUG=79722
TBR=dpranke@chromium.org
CC=erg@chromium.org,inferno@chromium.org

Review-Url: https://codereview.chromium.org/2847863002
Cr-Commit-Position: refs/heads/master@{#468110}

NOPRESUBMIT=true
BUG=713190

Review-Url: https://codereview.chromium.org/2844593002
Cr-Commit-Position: refs/heads/master@{#468109}

This ensures proper capability check.

BUG=none

Review-Url: https://codereview.chromium.org/2845813003
Cr-Commit-Position: refs/heads/master@{#468108}

Specifically, add menu option displays and track site breakdown displays,
sorting, and expansion.

BUG=716111

Review-Url: https://codereview.chromium.org/2846953002
Cr-Commit-Position: refs/heads/master@{#468107}

Using a local proxy instance with the associated bug, the failed
response gave a 404 status. This check differentiates between the bug
and not.

BUG=715644

Review-Url: https://codereview.chromium.org/2844403002
Cr-Commit-Position: refs/heads/master@{#468106}

As suggested in a previous CL, the status for each keyId should have it's own
status value rather than relying on all the KeyIds to have the same status.

No longer passing |unexpected|, as the size check verifies that the correct
number of expected KeyIds matches.

BUG=616166
TEST=modified tests pass

Review-Url: https://codereview.chromium.org/2847803005
Cr-Commit-Position: refs/heads/master@{#468105}

This in preparation for USER_EVENTS, which is a commit only type and
some fields like version and not useful. We want to save as much
bandwidth as possible, and switching to optional saves us ~2 bytes each
before compression.

BUG=714828

Review-Url: https://codereview.chromium.org/2837993002
Cr-Commit-Position: refs/heads/master@{#468104}

BUG=714191

Review-Url: https://codereview.chromium.org/2829293002
Cr-Commit-Position: refs/heads/master@{#468103}

Directory::InsertEntry takes pointer to EntryKernel and inserts owning pointer
into methandles_mapo with WrapUnique. The object is still owned by unique_ptr in
ModelNeutralMutableEntry ctor. If one if the steps inside InsertEntry fails
ModelNeutralMutableEntry will not release unique_ptr which will cause object to
be freed while metahandles map still has entry pointing to it.

I changed InsertEntry to pass ownint pointer to EntryKernel. Caller is free to
stash non-owning pointer, but has to reset it to nullptr if InsertEntry fails.

I refactored couple of functions in Directory to be more strict with pointers to
EntryKernel. Particularly DeleteEntry should use entry found in metahandles_map,
not the entry passed as an argument to remove entry from different indices. It
shouldn't matter in terms of correctness, but makes it easier to reason about
the logic.

BUG=705704
R=skym@chromium.org

Review-Url: https://codereview.chromium.org/2844333003
Cr-Commit-Position: refs/heads/master@{#468102}

WindowManagerApplication's normal destruction order involves tearing down
everything is has created.

However on some fast tests it is possible for WindowManagerApplication to be
destroyed before OnStart is ever called. When this occurs we attempt to destroy
services which we never created, and various DCHECKS are triggered.

PhishingDOMFeatureExtractorTest.SubframeRemoval has a >50% repro rate of this
locally where the crash occurs after the test successfully passes.

TEST=PhishingDOMFeatureExtractorTest.SubframeRemoval
BUG=678687

Review-Url: https://codereview.chromium.org/2851763002
Cr-Commit-Position: refs/heads/master@{#468101}

BUG=None

Review-Url: https://codereview.chromium.org/2849903003
Cr-Commit-Position: refs/heads/master@{#468100}

When in tab fullscreen, replace the ESC button with "Exit Fullscreen"
and display the origin URL of the tab content in the Touch Bar.

A test for this is added in BrowserTouchBarUnitTest

BUG=690611

Review-Url: https://codereview.chromium.org/2816743006
Cr-Commit-Position: refs/heads/master@{#468099}

I think original issue was caused by ChromeApplication.onCreate calling
AccountManagerHelper.initializeAccountManagerHelper and discovering instance of
AccountManagerHelper that was set up by test. This issue is addressed by
http://crrev.com/2836373003.

Another issue was that waiting for syncability propagation to ContentResolver
got broken by refactoring http://crrev.com/2778443002. This issue was addressed
by change http://crrev.com/2847663003.

Seems like after these changes test should be passing. I ran it in a loop for
1000 iterations and it passed so I'm enabling the test.

BUG=605567
R=pnoland@chromium.org

Review-Url: https://codereview.chromium.org/2845173003
Cr-Commit-Position: refs/heads/master@{#468098}

Tests re-enabled are:
UseCounterTest.RecordingFeatures, UseCounterTest.SVGImageContextFeatures,
UseCounterTest.InspectorDisablesMeasurement, UseCounterTest.MutedDocuments

BUG=667913,654502

Review-Url: https://codereview.chromium.org/2847173002
Cr-Commit-Position: refs/heads/master@{#468097}

The security state decoration looks like this:

  Secure |

The divider is included in the bounds, and then the location bar text is placed
just after this decoration; because of that, the focus ring on the security
state decoration (which is exterior to the decoration, like Cocoa focus rings
usually are) draws over the top of the start of the location bar text. This
change:

1) Introduces LocationBarDecoration::GetRealFocusRingBounds() to allow each
   decoration to control its focus ring bounds if it needs to
2) Overrides that method in SecurityStateBubbleDecoration to inset the focus
   ring on the right side

BUG=715909

Review-Url: https://codereview.chromium.org/2847903003
Cr-Commit-Position: refs/heads/master@{#468096}

Webview does not have new tab page.

TBR=nednguyen@google.com,ssid@chromium.org
BUG=716041

Review-Url: https://codereview.chromium.org/2848893002
Cr-Commit-Position: refs/heads/master@{#468095}

With mask tiling, it is possible that a tiled mask gets a filter after
tiles are created. In order to make picture layer tilings throw away
tiles, we need to change the mask type from MULTI_TEXTURE_MASK to
SINGLE_TEXTURE_MASK, but mask type was set to be immutable as we do not
allow NOT_MASK to MASK conversion and vice versa.

This CL attempts to fix the demoting problem by making mask type a non-
const value and prevent NOT_MASK to MASK conversion by DCHECK.

BUG=567293
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2845143002
Cr-Commit-Position: refs/heads/master@{#468094}

BUG=707642
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2845773005
Cr-Commit-Position: refs/heads/master@{#468093}

In the (rare) case of a recording being started and the FilterData
structure being yanked away (and destroyed) from under
SVGFilterPainter's feet, we need to put the PaintController in a
consistent state before destroying it.
Add a new method SVGFilterRecordingContext::Abort() and call that when
SVGFilterPainter::FinishEffect encounters a null FilterData for the
LayoutObject.

BUG=713024
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2847133002
Cr-Commit-Position: refs/heads/master@{#468092}

BUG=none

Review-Url: https://codereview.chromium.org/2840413002
Cr-Commit-Position: refs/heads/master@{#468091}

This applies to Linux and Chrome OS (and Mac Views) until
713359 is fixed.

BUG=602756,713359

Review-Url: https://codereview.chromium.org/2839953005
Cr-Commit-Position: refs/heads/master@{#468090}

BUG=682420

Review-Url: https://codereview.chromium.org/2852543002
Cr-Commit-Position: refs/heads/master@{#468089}

std::less requires #include <functional>,
see e.g. http://en.cppreference.com/w/cpp/utility/functional/less

See the bug for more context.

BUG=716504

Review-Url: https://codereview.chromium.org/2849913002
Cr-Commit-Position: refs/heads/master@{#468088}