GitLab

This reverts commit fd90951e.

Reason for revert: crbug.com/1166280

Original change's description:
> Move subresource_redirect proto to components
>
> Moves the robots_rules.proto from chrome/renderer to components/
>
> Bug: 1160424
> Change-Id: I0b2af266e3a6de40872bf094195b7f0c21c42096
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623647
> Commit-Queue: rajendrant <rajendrant@chromium.org>
> Reviewed-by: Michael Crouse <mcrouse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#842827}

TBR=rajendrant@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I9da5764c078264a93aa1e50118c0296055e4a7c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1160424, 1166280
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627872Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843182}

Roll Chrome Mac PGO profile from chrome-mac-master-1610538373-c4c83fd08459537f19e890c14c2288baf23d3675.profdata to chrome-mac-master-1610560809-c13d1dc2d5ece813e7ca3ddf321bf7cfccbb8ffc.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ie31be2d2aac45ffe7792df6b81f92ba25cdbb954
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627811Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843181}

disabled on desktop platforms

Change-Id: I173ac1025760f908042e64c7c8839fb90e41fc78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626918Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843180}

https://skia.googlesource.com/skia.git/+log/be2a8614c5d6..d8e9436a78bf

2021-01-13 jsimmons@google.com Cache ICU break iterators in SkUnicode_icu
2021-01-13 ethannicholas@google.com Fixed error reporting on invalid SkSL assignments
2021-01-13 johnstiles@google.com Reland "Scrub memory released from a GrMemoryPool in debug mode."
2021-01-13 tdenniston@google.com [svg] Add plumbing for color-interpolation-filters property
2021-01-13 mtklein@google.com support 7 args in skvm::Program::eval()
2021-01-13 fmalita@chromium.org [svg] Initial mask plumbing
2021-01-13 ethannicholas@google.com SkSL DSL operator overloading
2021-01-13 johnstiles@google.com Add guard-rails to Constructor constant-value fetchers.
2021-01-13 johnstiles@google.com Simplify IRGenerator::coerce.
2021-01-13 bsalomon@google.com Revert "Reland "asyncRescaleAndRead supports unpremul results on GPU""
2021-01-13 fmalita@chromium.org [svg] TextPath support
2021-01-13 reed@google.com Allow chrome to be nearest until it can rebaseline
2021-01-13 johnstiles@google.com Split apart SkRuntimeInvalid tests into multiple functions.
2021-01-13 bsalomon@google.com Reland "asyncRescaleAndRead supports unpremul results on GPU"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: ethannicholas@google.com
Change-Id: If6cc2acc8038437a70013a1d70d70bb73a9efeb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628007Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843179}

Change-Id: I89b964d1223683cf42a37eacbd40073e47e54631
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627893
Auto-Submit: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843178}

Bug: 1126640, 333943, 1166283
Change-Id: I48bb8258bebcb35f6ae4cfcb1f644a2b4021e97f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625892
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843177}

And fix init issue on ChromeOS for sign in profiles

Change-Id: I26b87d58f2eae2afecf67685690312a8aed70c60
Bug: 1146151
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625157Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843176}

The study has ended.

Bug: 1126640, 1057072, 1166295
Change-Id: I125f5c2cd569a5c9b685636ce8d476d1871161ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625995
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843175}

Bug: 687225
Change-Id: I4d74f4043d9ab3b2391fff602809b6b30aa0ea3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626921
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843174}

AFDO profile significantly changes the bytes output of the resultant
APK. However, the rolls only contain the file name for gclient to
download thus it is not detected by gn analyze and the bots just short
circuit out early. Add to exclusions to force the bots to run fully.

Change-Id: I1a14628498f9ee7e97b7b2a73626347c5a99e1ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596143Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843173}

This reverts commit a814d87a.

Reason for revert: CLD3LanguageCode enum is still referenced in ukm.xml and this CL breaks the server-side pipelines.

Original change's description:
> Rename LanguageCode and CLD3LanguageCode Enums
>
> This CL renames language code enums to make them more clear.
>
> The current enum |LanguageCode| hashes the first two letters of a local
> code and maps these to language name. This is renamed |LanguageName|.
>
> The current enum |CLD3LanguageCode| hashes the entire ISO639 locale code
> and maps these to the locale code.  This is renamed |LocaleCodeISO639|
>
> Bug: 1155031
> Change-Id: I08fce33d008e26af29607fe35f060c3800318d9a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613285
> Commit-Queue: Trevor  Perrier <perrier@chromium.org>
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Reviewed-by: Megan Jablonski <megjablon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#842708}

TBR=mpearson@chromium.org,tbansal@chromium.org,megjablon@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,perrier@chromium.org

Change-Id: If9165eb4ccde549503012d0b547fab9730ded55b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1155031
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625918Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843172}

Fixes use-after-free issues in URLChecker and
KidsManagementURLCheckerClient.

Asynchronous callbacks passed to unowned objects should be bound with
weak pointers, so if `this` is destroyed, the callback won't fire.

Test:
* As a parent, set a child's Safe Site setting to "Allow all sites"
* Add the child to a Chromebook
This CL fixes DCHECKs and (in prod) potential use-after-free segfaults
that could otherwise occur when running the steps above.

Bug: 1159898
Change-Id: I67ba8f924ded3b6316813529e9b77a3d3735b483
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597547Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Toby Huang <tobyhuang@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843171}

The bubble height is increased in the specific case of kMultiUser
interception, as the text has one additional sentence in this case.

In the future it would be better to dynamically compute the height based
on the length of the text (which would also work in all languages).

Old bubble:
https://drive.google.com/file/d/1ilF544B5X60F5zLgUa4Divy12ht53-4q/view?usp=sharing&resourcekey=0-jQav6k6ls8agZTv-9xbArQ

New bubble:
https://drive.google.com/file/d/1Ky_GEO_XZOsLs1fN1dWBAxM-U6SFnHKC/view?usp=sharing&resourcekey=0-2ZpvsBvEK2GFUKIts-6vpA

New bubble with longer text (might happen in some languages)
https://drive.google.com/file/d/1ssDop-Ympon0SHk_hbKq0rrca1gztyus/view?usp=sharing&resourcekey=0-aZlWPRfaynk9UnP9nTpfpQ

New bubble with shorter title (might happen in some languages/experiments)
https://drive.google.com/file/d/1ThMu_Vs6TOXSm3F1pA6w1TtVhbIACrhm/view?usp=sharing&resourcekey=0-Aosni3qizrPn02mN1Q7fcw

Change-Id: I7f68106a4bf088301601d7a19294eb066125750c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627422Reviewed-by: Monica Basta <msalama@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843170}

Previously the label mask canvas was not flipped for RTL so the wrong
end of the label was being faded out.

Bug: 1166270
Change-Id: Ib3afc1c6dd676788eb58ed16eacb18cb65141fd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627979Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#843169}

This CL adds a profile proto database for chrome cart. Detailed
functions of the database will be added in a later patch.

Bug: 1157892
Change-Id: I30fb26b11463bf66a075f193bf5131baef69a92e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612276
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843168}

After
https://chromium-review.googlesource.com/c/chromium/src/+/2613726
and
https://chromium-review.googlesource.com/c/chromium/src/+/2622754

there appears to be a lack of testing for Select to Speak's options page.

This change adds a basic sanity test and a foundation to write more as
features are added.

R=joelriley@google.com, katie@chromium.org

AX-Relnotes: n/a
Bug: none
Test: this.
Change-Id: Id9fc395b1b95c81fbea4e10bfc5fb86e3f3645fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626914
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843167}

The profile card uses cr-action-menu to display the remove confirmation
dialog. This dialog has an accessibility issue because its content isn't
read automatically when the dialog appears. It also doesn't follow the
common Chrome pattern for webUI dialogs.

This CL switches the remove confirmation dialog over to cr-dialog which
is the standard component for displaying dialogs in webUI.

Bug: 1156068
Change-Id: If865a4b9d9ad4d6e15c3f8980828cee98f0898b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615350
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843166}

This CL hooks the new Disabled Sites code in components into the iOS
Shared Highlighting flow. It also adds a new flag which is used in the
process.

Other platforms can reuse the same flag, but it is not yet exposed via
chrome://flags on those platforms and would need to be added.

Bug: 1157981
Change-Id: I9d84fc4c04fe06fd8e806a98b9ff57bd3f743667
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626207
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Auto-Submit: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843165}

This reverts commit 3b06ccfd.

Reason for revert: Suspect that this caused compile failures
at https://ci.chromium.org/ui/p/chromium/builders/ci/android-archive-dbg/7488/overview

[27214/109670] SOLINK ./libperfetto_android_internal.cr.so
FAILED: libperfetto_android_internal.cr.so libperfetto_android_internal.cr.so.TOC lib.unstripped/libperfetto_android_internal.cr.so
/b/s/w/ir/cipd_bin_packages/cpython/bin/python "../../build/toolchain/gcc_solink_wrapper.py" --reade...(too long)
ld.lld: error: lld uses blx instruction, no object with architecture supporting feature detected
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Original change's description:
> Roll Perfetto from 704a1aa4c802 to 59abfbcd2b03 (7 revisions)
>
> https://android.googlesource.com/platform/external/perfetto.git/+log/704a1aa4c802..59abfbcd2b03
>
> 2021-01-13 lalitm@google.com Merge "tp: don't propogate constraints on tables with left/outer span join"
> 2021-01-13 hjd@google.com Merge "ui: Limit bug filing links to 8kb"
> 2021-01-13 fmayer@google.com Merge "Dynamically decrease sampling rate when buffer fills."
> 2021-01-13 treehugger-gerrit@google.com Merge "tp: strip on all Android targets"
> 2021-01-13 treehugger-gerrit@google.com Merge "tp: remove unnecessary stripping script"
> 2021-01-13 treehugger-gerrit@google.com Merge "traced: add statsd instrumentation"
> 2021-01-13 fmayer@google.com Merge "Make names of malloc hooks / preload more descriptive."
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/perfetto-chromium-autoroll
> Please CC perfetto-bugs@google.com on the revert to ensure that a human
> is aware of the problem.
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
>
> Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
> Bug: None
> Tbr: perfetto-bugs@google.com
> Change-Id: Ie746ac95cc14ba1c1123fac03a40a59dfec3bf86
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627617
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#843108}

TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,perfetto-bugs@google.com

Change-Id: I853cb2d76a33350dcc9802efb23df1b30e83a499
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625893Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843164}

It appears that RegisterMessageCallback is the correct method: https://source.chromium.org/chromium/chromium/src/+/master:content/public/browser/web_ui.h;drc=9d89d198cd0d8ad62d9cc1d6b3c60e29f98a3b0e;l=80
The only instance of RegisterMessageHandler is in that documentation page.

Change-Id: I98dbf30f4a12e25dd768687e396c96e0b16568d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626611
Auto-Submit: Kenton Lam <kentonlam@google.com>
Commit-Queue: dpapad <dpapad@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843163}

This makes it so that TabDragController::UpdateGroupForDraggedTabs does
only what its name suggests (updates the group membership of the dragged
tabs) without doing anything extra (lots of tab movement).

The assumption is that tabs are moved to their destination before
UpdateGroupForDraggedTabs is called. This assumption is commented here:
https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/views/tabs/tab_drag_controller.h;l=527
And it still holds because of this call here:
https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/views/tabs/tab_drag_controller.cc;l=1034

Most of the deleted movements in UpdateGroupForDraggedTabs were added
because functions like RemoveFromGroup() could potentially shift tabs
around. However, by using MoveAndSetGroup instead, the tabs don't
actually move as long as the above assumption holds.

Tested manually and via interactive UI tests:
https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc;l=698

Bug: 1163845
Change-Id: I447c66a10c26a20a10d08979cd47cee4906d9b71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622324Reviewed-by: Charlene Yan <cyan@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843162}

This reverts commit dde5f982.

Reason for revert: Updated not-webview-exposed.txt.

Original change's description:
> Revert "webhid: Mark the API stable"
>
> This reverts commit e05911e4.
>
> Reason for revert: https://crbug.com1164259
WebViewLayoutTest#testWebViewIncludedStableInterfaces is failing because the new API doesn't set up whether it should be exposed in WebView. Interfaces which are intentionally not exposed in WebView need to be added to not-webview-exposed.txt
>
> Original change's description:
> > webhid: Mark the API stable
> >
> > Updates runtime_enabled_features.json5 and the stable webexposed tests
> > to mark the WebHID API stable on desktop platforms.
> >
> > Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/rL1csFYD1Ms
> >
> > Bug: 890096
> > Change-Id: I36a6b62475dd9de01a4dbf013b2be00e8901359e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610995
> > Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
> > Auto-Submit: Matt Reynolds <mattreynolds@chromium.org>
> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#841185}
>
> TBR=chrishtr@chromium.org,mattreynolds@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> Change-Id: I16463f8d4b8e9e4893217f5349d2a8a9f7aa76f7
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 890096
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616200
> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#841413}

Bug: 890096
Bug: 1164259
Change-Id: I501d3679d3103746e116d2dbc3de02cf37900d97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617571Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843161}

Bug: 1121399
Change-Id: Ibaf60f987b9bd308c715d01a8f9ef08aec7a57be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622319Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843160}

Includes one behavioral change, no longer disabling the ability to paste
via keyboard shortcuts when the clipboard is empty. This change
simplifies the code, reducing the number of points of access to the
clipboard and removing the need for an auto-reset bool to control
whether the user is notified of restricted clipboard access. The removal
of the auto-reset bool is especially important as the scope-exiting
reset will always cause a memory access even if the view has been
deleted.

Bug: 1161149
Change-Id: I7a494c534e0efbf5d762a58fe6f7f39591cebb80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619204
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843159}

This CL implementats a new functor API to support SurfaceControl.

Bug: 1157096
Change-Id: I86a9b403b1d4eb160a4a81a5145153b73ee0558b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615318Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843158}

Using wpt-import in Chromium 19571c08.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
igrigorik@chromium.org, yoavweiss@chromium.org:
  external/wpt/preload

NOAUTOREVERT=true
TBR=robertma@google.com

No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel
Change-Id: I6924660ea22ed9580b03a5f0e51dad45c0fabfd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626268Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843157}

Tweens used in bounce animation were not quite to spec.

Bug: 1166014
Change-Id: Iecaadb3ff5e7d00bf911cef0563302e462700dad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625891Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#843156}

https://pdfium.googlesource.com/pdfium.git/+log/a3806cb35923..d3664703dfa9

2021-01-13 tsepez@chromium.org Avoid undefined behavior warning in GetArabicFormTable().

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I2e9828288b836c54d365145a475982936fe2ee2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627887Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843155}

Strings should be updated for the notification messages shown when an operation (screenshot, screen capture, printing, etc) is blocked because of Data Leak Prevention configuration.
The final value are here: https://docs.google.com/document/d/1fqzX-QYidDKijMpPd8kaoFwg1zHAIGB7laD4tIBPzSk/edit
Because different strings should be shown when screenshot/screencapture is blocked because of DLP and DisableScreenshots policy, we need to propagate the reason to the notification.

Bug: 1158743
Change-Id: I99e7ec1e3db19f54fca48ac985349c83051f83a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603309Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Aya Elsayed <ayaelattar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843154}

The sum of the values being compared can be as large as 2.0, so epsilon
should be scaled accordingly.

Bug: internal b/177118785
Change-Id: I6ed39219dddfc5226383e4664937bebc18dcdaed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626925
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Auto-Submit: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843153}

Histograms whose expiration time is moved by 3 milestones, as their use
is current, while the underlying infrastructure is being discussed:

  * GCM.CheckinRequestStatus
  * GCM.CheckinRequestStatusNetError
  * GCM.Crypto.EncryptMessageResult
  * GCM.DeliveredToAppHandler
  * GCM.PendingConnectionEventsAtShutdown
  * GCM.SendWebPushMessagePayloadSize
  * GCM.SendWebPushMessageResult
  * GCM.SendWebPushMessageStatusCode

Histograms whose expiration time is moved by 4 milestones, as their use
is continuous to validate reliability of restoring data from disk at
Chrome start-up:

  * GCM.Crypto.InitKeyStoreSuccessRate
  * GCM.Crypto.LoadKeyStoreSuccessRate
  * GCM.Crypto.RemoveKeySuccessRate
  * GCM.IncomingSendErrors
  * Notifications.Database.DeleteAllForOriginsResult
  * Notifications.Database.ReadResourcesForTriggeredResult
  * Notifications.Database.ReadResourcesResult
  * Notifications.Database.WriteTriggeredResult

Histograms whose expiration is moved by 4 milestones, as they are
reliability indicators used when discussing issue reports regarding
FCM/Notifications:

  * InstanceID.GetToken.NetErrorCode
  * InstanceID.GetToken.RequestStatus
  * PushMessaging.GetRegistrationStatus
  * PushMessaging.PushSubscriptionChangeStatus
  * PushMessaging.UnregistrationGCMResult
  * PushMessaging.UnregistrationIIDResult
  * PushMessaging.UnregistrationReason
  * PushMessaging.UnregistrationStatus

Histograms whose expiration time is moved by 4 milestones, as they
relate to notification behaviour on Windows which is an actively moving
target:

  * Notifications.Windows.ActivationStatus
  * Notifications.Windows.CloseStatus
  * Notifications.Windows.CreateToastManagerErrorCode
  * Notifications.Windows.DisplayFailure
  * Notifications.Windows.DisplayStatus
  * Notifications.Windows.GetDisplayedLaunchIdStatus
  * Notifications.Windows.GetDisplayedStatus
  * Notifications.Windows.GetNotificationLaunchIdStatus
  * Notifications.Windows.GetSettingPolicy
  * Notifications.Windows.GetSettingStatus
  * Notifications.Windows.HandleEventStatus
  * Notifications.Windows.HistoryStatus
  * Notifications.Windows.OnFailedStatus
  * Notifications.Windows.SetReadyCallbackStatus2
  * Notifications.Windows.ShowFailedErrorCode
  * Notifications.Windows.StartMenuShortcutStatus

Histograms whose expiration time is moved by four milestones, as they
relate to delivery of notifications on macOS, which is being worked on:

  * Notifications.XPCConnectionEvent
  * Notifications.Permissions.UNNotification.Banners.Style

Histograms whose expiration time is moved by 6 milestones, as they
relate to performance of functionality exposed to the Web Platform:

  * Android.SelectFileDialogImgCount
  * Android.SelectFileDialogScope
  * Launch.WebAppDisplayMode
  * Notifications.Android.JobStartDelay
  * PushMessaging.DeliveryStatus.FindServiceWorker
  * PushMessaging.DeliveryStatus.ServiceWorkerEvent
  * PushMessaging.UserVisibleStatus
  * ServiceWorker.NotificationCloseEvent.Time
  * ServiceWorker.NotificationClickEvent.Time
  * ServiceWorker.PushEvent.Time

Bug: 1165229, 1165062, 1165061, 1125675, 1125674
Bug: 1165098, 1165181, 1165180, 1165124, 1165011
Bug: 1125741, 1125742, 1125743, 1125744, 1125740
Bug: 1165125, 1125767, 1165071, 1165070, 1125679
Bug: 1165101, 1165100, 1125721, 1125720, 1125718
Bug: 1125717, 1125715, 1125716, 1165096, 1125722
Bug: 1165099
Change-Id: Ie60c561802f5650c100f2466601f98f0564ec2a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623552
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Auto-Submit: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843152}

The general idea is that, if a client tag is provided upon *creation* of
a bookmark, it should be delivered back to clients during later
GetUpdates.

In order to do so, PersistentBookmarkEntity is extended with a new
member field to accommodate the client tag hash, and the corresponding
conversion to/from protos.

Bug: 1032052
Change-Id: Ie5fe597abb6b913da46a293a5f7bdee4446fcf6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624467Reviewed-by: Rushan Suleymanov <rushans@google.com>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843151}

We currently have a maximum session duration hard-coded for Linux
hosts (20 hours) but it isn't configurable and Windows/Mac don't
have a max duration.  This CL adds a policy to allow network admins
to configure the maximum duration of remote access sessions.  The
policy will be applied to hosts running on Windows, Mac, and Linux.

Change-Id: Ia535979155a3f7bfe45c3a2b703e6e84fcae9852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626130
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843150}

Some devices do not have batteries and will have a null BatteryInfoPtr
to represent this. This value needs to be checked before being used when
processing the CrosHealthdProbe.

Bug: chromium:1159440
Change-Id: I427ba3a8fd9d6a3b26ef0e0e2a21b30d3bdd92a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626097
Commit-Queue: Trent Begin <tbegin@chromium.org>
Reviewed-by: Paul Moy <pmoy@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843149}

This reverts commit 3ca3d70c.

Reason for revert: Broke "Share this tab instead" button.

Original change's description:
> Minor UI logic changes to prevent a UAF bug when starting tab capture.
>
> See discussion in crbug 1155426 for details. Changes:
>
> MediaStreamCaptureIndicator::UIDelegate: Ignore multiple calls to
> OnStarted().
>
> TabSharingUIViews: Unconditionally execute clean-up tasks in destructor.
>
> Bug: 1155426
> Change-Id: I392fba38118ce51744ba36b4dec19ebfe39f1fbe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581028
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
> Commit-Queue: Yuri Wiitala <miu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#835736}

TBR=miu@chromium.org,guidou@chromium.org,marinaciocea@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

TBR=marinaciocea@chromium.org

Bug: 1155426, 1165947
Change-Id: I9df25d596cb4df7b5e98db78f019b2665b01e8b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627848
Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843148}

This API seems to trigger a TCC violation on iOS13 but not iOS14.
Simply reverting on iOS13 for now.

Bug: 1159431
Change-Id: I7cf85099536aa9ae44345240bd1d8f1ca67f96a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625912
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843147}

For keyword conflicts, never Remove() prepopulated engines during the
deduplicate step.

This also makes sure that an Add() call using a prepopulated engine
never fails, even if it the prepopulated engine is outranked.
This is needed for proper DSE repair.

These changes are not strictly speaking necessary, since we have made
prepopulated engines outrank autogenerated engines now. However, it's
still possible for an extension or user-added engine to have a keyword
matching the prepopulated engine, so we still want to do this to handle
that unusual case.

We think we eventually will make prepopulated engines marked as
NOT safe_for_autoreplace(). Even if that happens, we should keep this
newly added check in place to handle old database entries.

Bug: 1164024
Change-Id: I362bb44a54b39caa4ad6400a8e478fc5a5941305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621961
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843146}

Bug: 1159562
Change-Id: I0d2bc560e7abe14e4b6ff8be56fb841e9e98ce63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626197
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843145}

This removes the fuchsia sub-namespace from the following classes:
-ScopedServiceBinging
-ScopedServicePublisher
-ServiceDirectoryTestBase

A ::base::fuchsia pseudonym is left in place for these classes for the
duration of the transition.

In addition, this CL removes an unused source file.

Bug: 1073821
Change-Id: I2c0bb6215e9bc073ec03b37834a887457ebcff38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602596
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843144}

This is a reland of 107694e1

The change was reverted due to an uninitialized member on an Impression
object in the test. The reland defaults Impression.impression_data to
0 to avoid these types of errors.

Original change's description:
> [conversions] Use base 10 encoding for impression and conversion data
>
> What:
> No longer parse impressiondata as hex, or use hex when sending
> conversion reports.
>
> Why:
> This causes needless conversions for developers, as raised on
> https://github.com/WICG/conversion-measurement-api/issues/60
>
> Note that the conversions database stores imp and conversion data as
> strings currently because they are represented as hex. These can
> be converted to strings now, but this is left as a followup.
>
> Bug: 1163599
> Change-Id: I5b164c380a97cb272c6a0ee698df8b744feb58ae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611958
> Reviewed-by: Charlie Harrison <csharrison@chromium.org>
> Reviewed-by: Nate Chapin <japhet@chromium.org>
> Commit-Queue: John Delaney <johnidel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#842561}

Bug: 1163599
Change-Id: I192ba4b9452c3ad97f9511ce093f36f9c697ba2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625293Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843143}