GitLab

Instead, make the right decision on the callsite.
This makes the implicit dependency between the request's
cache mode and frame load type a bit smaller.

Bug: 789577
Change-Id: Id82797025c7ff7160ec9cbeb37f681468127a34c
Reviewed-on: https://chromium-review.googlesource.com/1150836
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578696}

This cl adds use counters to find out the ratio of the web pages that
add document level wheel event listeners with passive:false, true, or
unspecified. It also counts the number of document level wheel event
listeners with passive:unspecified that preventDefault wheel events.

This information is useful to investigate the potential performance
benefits and risks of changing the default value of the passive option
to be true for document level wheel/mousewheel event listeners.

Bug: 626196
Change-Id: Ib0ee64b1a5085813d9b70073747ec3f544fbb660
Reviewed-on: https://chromium-review.googlesource.com/1148783
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578695}

This reverts commit 628bdce6.

Reason for revert: virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi.html started failing on WebKit Mac10.13 (retina) and this patch is on the blame list and seems related. Output isn't that useful, other than to say golden images don't match:

9:34:53.543 49202 "/b/s/w/ir/out/Release/image_diff --diff /b/s/w/itqSin9p/tmp_EMj8D/actual.png /b/s/w/itqSin9p/tmp_EMj8D/expected.png /b/s/w/itqSin9p/tmp_EMj8D/diff.png" took 0.20s
09:34:53.546 49154 [1087/5973] virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi.html failed unexpectedly (image diff)
09:34:53.545 49202 worker/6 virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi.html failed:

Original change's description:
> Move some of VisualProperties to RenderWidget::Init().
> 
> VisualProperties are passed to the RenderViewImpl::Create() method via
> the IPC params, then are passed along to the RenderWidget, but in a
> lot of different steps.
> 
> 1st, screen info is passed to the RenderWidget constructor.
> 2nd, the display mode is set directly on the RenderWidget.
> [ a bunch of other initialization here ]
> 3rd, the whole set of properties is passed to
> OnSynchronizeVisualProperties like an IPC was just received.
> 
> The 3rd step sends the screen info and the display mode again, though
> they won't be changed of course.
> 
> This combines step 1 and 2 into one step where they are passed to the
> RenderWidget::Init() method. Then we can look at combining with step 3.
> 
> R=​ajwong@chromium.org, avi@chromium.org
> 
> Bug: 419087
> Change-Id: Ifcb8eaa0915bb235172e8c5b7bee188e863c18c3
> Reviewed-on: https://chromium-review.googlesource.com/1150673
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: Albert J. Wong <ajwong@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578660}

TBR=avi@chromium.org,ajwong@chromium.org,danakj@chromium.org

Change-Id: Ife47ce2124a0a5baffaa2dd08b3dfe7de79cc568
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 419087, 868444
Reviewed-on: https://chromium-review.googlesource.com/1153398Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578694}

Also a typo is fixed.

Bug: 850624
Change-Id: I48e73389406327d373ce3c4e269a141314bf3bc7
Reviewed-on: https://chromium-review.googlesource.com/1152178Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Lu Chen <chelu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578693}

This reverts commit e7b3bd5b.

Reason for revert: Suspected of breaking CFI bots:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2266
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/9276

Example failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8939838131233782656/+/steps/content_browsertests/0/logs/DoNotTrackTest.FetchFromWorker/0

../../third_party/blink/renderer/platform/bindings/wrapper_type_info.h:178:10: runtime error: control flow integrity check for type 'blink::ScriptWrappable' failed during cast to unrelated type (vtable address 0x0000009aab90)
0x0000009aab90: note: vtable is of type 'blink::V8EventListener'
 00 00 00 00  10 96 ab 08 00 00 00 00  90 9c ab 08 00 00 00 00  40 9b ab 08 00 00 00 00  f0 ad ab 08

Original change's description:
> [bindings] Replace JSFunction backlink with GC-aware wrapper link
> 
> Replaces the custom backlink from V8->Blink that was using a v8::External with a
> GC-aware backpointer that is encapsulated in the CustomWrappableAdapter
> interface.
> 
> CustomWrappableAdapter establishes a link from a given JavaScript object to the
> Blink object inheriting from CustomWrappableAdapter. The link is known to
> garbage collectors and thus the Blink object will be kept alive as long as the
> JavaScript object is alive. The adapter can be used to model liveness across V8
> and Blink component boundaries. In contrast to ScriptWrappable, there is no IDL
> definitions required and the JavaScript object must not escape to user-visible
> JavaScript.
> 
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Id9b6a046fd5e3f4c31ddf15894a9968701831e90
> Bug: chromium:843903
> Reviewed-on: https://chromium-review.googlesource.com/1145262
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578621}

TBR=yukishiino@chromium.org,haraken@chromium.org,mlippautz@chromium.org

Change-Id: I2fdc26e9ecffcb2b5d39295650aa061b742985c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:843903
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1153390Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578692}

This is a part of effort to remove /wd4018 warning suppression.

Master CL is
https://chromium-review.googlesource.com/c/chromium/src/+/1152755

This CL was uploaded by git cl split.

R=bajones@chromium.org

Bug: 868248, 588506
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I980cd92d9e69cd3914e2066f159a786959823ba2
Reviewed-on: https://chromium-review.googlesource.com/1152839Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578691}

- Add TestDragDropClient based on ash::DragDropController to map mouse
  events to DragTargetEvents and dispatch them;
- Implement RunDragLoop/CancelDragLoop in test_ws using
  TestDragDropClient;
- Re-enable RunDragLoop/CancelDragLoop;

Bug: 864616
Change-Id: I349e5c80abe8f20e27a5da34992c15cc611a98b3
Reviewed-on: https://chromium-review.googlesource.com/1152461
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578690}

This reverts commit b29fffc2.

Reason for revert: Caused https://crbug.com/861728

Original change's description:
> Avoid unbounded queueing of IPC messages for crashed renderers.
>
> If a renderer process crashes, then we retain the associated
> RenderProcessHostImpl object (to retain the old render_process_host_id
> that may have been stored elsewhere in the system).  Before this CL this
> had an undesired interaction with the ability of RenderProcessHostImpl
> to queue IPCs between the call to Init and the time when a renderer
> process is actually spawned (disclaimer - in practice the queueing has a
> slightly/undesirably longer timeline).
>
> Before this CL, RenderProcessHostImpl::ProcessDied(...) would call
> EnableSendQueue().  This meant that an unbounded number of IPC messages
> may be accumulated in
> ChannelAssociatedGroupController::outgoing_messages_ (until the crashed
> process is restarted).
>
> After this CL, RenderProcessHostImpl::ProcessDied(...) no longer calls
> EnableSendQueue().
> - Short-term: subsystems that require queueing of IPCs should
>   call RPH::EnableSendQueue() themselves (e.g. like RenderViewHostImpl's
>   constructor does).
> - Long-term: we should discard IPCs until RenderProcessHostImpl::Init
>   is called - queueing should only take place in the short time between
>   calling RenderProcessHostImpl::Init and the time the renderer process
>   is actually launched.
>
> There is a small risk that this CL will introduce crashes similar to the
> ones seen in https://crbug.com/658759.
>
> Bug: 813045
> Change-Id: I838bf7ea443633ba0f2314d2de5c83891ec9ac5f
> Reviewed-on: https://chromium-review.googlesource.com/1073621
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#562491}

TBR=nasko@chromium.org,rockot@chromium.org,lukasza@chromium.org


Bug: 813045, 861728
Change-Id: I640ad5080d8b5475d3ab0350c45ff32a6d152667
Reviewed-on: https://chromium-review.googlesource.com/1151912
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578689}

Transition the y position of items in launcher to 0 and change the
opacity of these items while dragging between peeking and closed state.

Demo: https://drive.google.com/open?id=1U64zU-0VctEnjRvW7gFYei5-WqaBN-pg

Bug: 862891
Change-Id: Icad43167661ed31ed9a8514fd39708e3fe4a3689
Reviewed-on: https://chromium-review.googlesource.com/1147329
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578688}

Test ChromeDriverTest.testWindowMaximize started to fail on Waterfall on Mac build bot.
Disabling test execution on Mac build bot.

Bug: chromedriver:2522
Change-Id: I96c0de4cfa1ade871dc4605386968145523917ca
Reviewed-on: https://chromium-review.googlesource.com/1153210Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578687}

This also switches RenderViewTest to LoadHTMLString method,
instead of StartNavigation.

Bug: 789577
Change-Id: Ide2fc31dbf2ce62fd928c30d9170677e4a00e557
Reviewed-on: https://chromium-review.googlesource.com/1147212
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578686}

This reverts commit df6e77ca.

Reason for revert: Reverting as suspect of failing case_media_unittests . https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Audio%20Linux/16824 :

[ RUN      ] CastAudioManagerTest.MakeAudioOutputStreamProxy
../../chromecast/media/audio/cast_audio_manager_unittest.cc:106: Failure
Actual function call count doesn't match EXPECT_CALL(*backend, Initialize())...
         Expected: to be called once
           Actual: never called - unsatisfied and active
Stack trace:
#0 0x00000054cffc testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x00000054c9d9 testing::internal::AssertHelper::operator=()
#2 0x00000053ddd3 testing::internal::GoogleTestFailureReporter::ReportFailure()
#3 0x0000005405b6 testing::internal::UntypedFunctionMockerBase::VerifyAndClearExpectationsLocked()
#4 0x0000003e7142 chromecast::media::MockCmaBackend::~MockCmaBackend()
#5 0x0000003a7340 testing::StrictMock<>::~StrictMock()
#6 0x0000003a44b5 chromecast::media::(anonymous namespace)::CastAudioManagerTest_MakeAudioOutputStreamProxy_Test::TestBody()
../../chromecast/media/audio/cast_audio_manager_unittest.cc:105: Failure
Actual function call count doesn't match EXPECT_CALL(*backend, CreateAudioDecoder())...
         Expected: to be called once
           Actual: never called - unsatisfied and active

Original change's description:
> Fetch and apply Multiroom info in CAOS
> 
> CastAudioOutputStream can now use internal backends with multizone. In
> order for multizone to work, we first need to retrieve the multiroom
> info and pass it to the backend.
> 
> BUG=b:111694183
> TEST=Build, cast_media_unittests
> 
> Change-Id: I128a6b0cc1a389d01102007244fdb5594dd4c637
> Reviewed-on: https://chromium-review.googlesource.com/1145892
> Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
> Reviewed-by: Luke Halliwell <halliwell@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Aidan Wolter <awolter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578670}

TBR=sky@chromium.org,gab@chromium.org,halliwell@chromium.org,jameswest@chromium.org,kmackay@chromium.org,awolter@chromium.org

Change-Id: I519349d1cd87709c2a1bd39299420b5a7df7bcee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:111694183
Reviewed-on: https://chromium-review.googlesource.com/1153309Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578685}

WTF vector and strings cannot be larger than UINT_MAX so change the
indexing, length and find methods to return wtf_size_t.

The desire to change this to the maximum size and not align it with
std::vector which returns size_t is such that callers actually know
the desired maximum size. One example is PaintChunks are currently using
size_t indicies but the size of PaintChunks can be reduced by 8 bytes
(moving two indicies to be 32 bit from 64 bit on 64 bit platforms).

This change is a minimal change. Progressively all the call sites will be
fixed such that they are using wtf_size_t.
https://chromium-review.googlesource.com/c/chromium/src/+/1128178
is a prototype of all the fixes but is to large to commit by itself since
approximately 1100 files need to be fixed.

BUG=652586

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I77db5df1313e6ab92497d4a811204707d5419c53
Reviewed-on: https://chromium-review.googlesource.com/1145045
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578684}

The new name:

* pairs well with the concept of "Observable"
* describes the role rather than the implementation details
* is consistent with other reactive frameworks
* is more concise

Additionally, the Observer's interface method has been renamed
to open(), instead of create(). This intuitively pairs better
with Scope.close(), hopefully reducing the amount of jargon one
needs to learn to use this reactive framework.

Bug: None
Test: cast_base_junit_tests, cast_shell_junit_tests
Change-Id: I20803a484951f886182eb078b07b7c9bfe11acca
Reviewed-on: https://chromium-review.googlesource.com/1152120Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578683}

If the BookmarkModel finishes loading after the
BookmarkHomeViewController is created, but before it is displayed, then
it is possible that a root node is never set on the VC.  This leaves the
VC in an invalid state, causing crashes when its views are eventually
loaded.

This crash can be avoided by always setting the VC's root node when the
bookmark model finishes loading, even if the VC's views have not yet
loaded.

BUG=862592

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3d5fb9519a07f901c0e4dcd7622c9dbac276443a
Reviewed-on: https://chromium-review.googlesource.com/1153136Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578682}

AppendTask schedules this method, and it's possible
that after it's been scheduled, dispose() nulls out
the isolate_task_runner_. TakeNextTask will handle
this situation properly - if the runner is gone,
it returns Task(). So, moving the DCHECK should avoid the
following stack trace which I've seen twice thus far
when running tests with always DCHECK enabled.

Thank you for your suggestion for this fix, Dmitry.

[1:41:0725/182513.246104:FATAL:scoped_refptr.h(219)] Check failed: ptr_.

Change-Id: Ic24aef83876de05159a7cd9805ff8d2015d52629
Reviewed-on: https://chromium-review.googlesource.com/1151950Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578681}

Replaced the current interfaces with mojo interfaces. No functional
change.

Bug: 734672
Change-Id: I0f54fdb63fe6179d1296c1e5132e1f09a4a4b4b2
Reviewed-on: https://chromium-review.googlesource.com/1137103
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578680}

It's flakey, and has been flakey for quite a while.

BUG=868409
TEST=test only change
TBR=riajiang@chromium.org

Change-Id: I4d4a57c9eed04563cdad114075c197244ea7ccdd
Reviewed-on: https://chromium-review.googlesource.com/1153207Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578679}

This CL adds logic to CustomTabActivity's toolbar initialization to
remove the menu button when it is empty. This happens when the UI is a
media viewer (which disables all default menu items) and when the media
is opened via the MediaLauncherActivity (which doesn't add any custom
menu items). In addition to removing the menu button, the margin on the
custom action button bar is removed in order to shift the custom
buttons over to where the menu button was.

Bug: 865103
Change-Id: I19fa270bf30d80d711a0b288b97c9edde79bad2f
Reviewed-on: https://chromium-review.googlesource.com/1149019Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578678}

Key handling for number inputs was accidentally deleted in
https://crrev.com/c/975825. Restore the handling and add a test.

Bug: 868142
Change-Id: I33f24ded29a58154a8987368c2de1001444755c1
Reviewed-on: https://chromium-review.googlesource.com/1150901
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578677}

WeakHandle is a wrapper around WeakPtr, which only cares about
sequence-affinity, not thread-affinity.
Also fixes two unrelated-looking-but-actually-related IWYU violations.

Bug: 846238
Change-Id: Iafffea16a38728f0c3dd6852954da509e0eab633
Reviewed-on: https://chromium-review.googlesource.com/1152821Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578676}

For the following two layout tests:
- fast/events/background-tab-on-submit-ctrl-click.html
- fast/events/background-tab-on-submit-synthesized-ctrl-click.html

Their baselines were updated by crrev.com/c/1119380, which left their
NG-specific baselines stale, and made them fail on layout_ng bot.

This patch updates the baselines to make them pass again.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ia51d79bae429f7d62a4c034f181c02f9c9538e66
Reviewed-on: https://chromium-review.googlesource.com/1152419
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578675}

To streamline the debugging of referrer chain logic, add the ability
to view the referrer chain for any given URL.

Render: https://screenshot.googleplex.com/go6P5jn3LpD

Bug: 864237
Change-Id: Ifc83662fd3e9eed44a6966f951c594857ed79e1e
Reviewed-on: https://chromium-review.googlesource.com/1151539
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578674}

It was added here:
https://chromium-review.googlesource.com/c/chromium/src/+/1108509

Every time I run the tests, it deletes this. I don't know why, but
it's a little annoying having to avoid committing it. So, I figure,
I should just try to commit it once and be done with it. :-)
I've learned that others are having the same issue, but maybe
aren't suffering as much as I am (I have a happy trigger finger
and often do git commit -a -m foo ...).

If this file is needed and you have an idea why, please enlighten
me and apologies for the attempt to remove it.

Thanks much!

Change-Id: I873211c98bc3158638c5abde59bc7acf060be8c7
Reviewed-on: https://chromium-review.googlesource.com/1152540Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578673}

Rename MediaPipelineBackendManager::CreateMediaPipelineBackend()
to MediaPipelineBackendManager::CreateCmaBackend.

Bug: internal b/111850629.
Test: Build cast_shell.
Change-Id: I4134ed18f5dc0972d3e93d07c17a53d1753b8241
Reviewed-on: https://chromium-review.googlesource.com/1152292
Commit-Queue: Guohui Deng <guohuideng@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Bailey Forrest <bcf@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578672}

This will be needed when Print Preview is updated to Material Design,
for the copies and scaling inputs.

Bug: None
Change-Id: I42ed62f5ca323f9ed1c93b89e9588506653469b5
Reviewed-on: https://chromium-review.googlesource.com/1150927Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578671}

CastAudioOutputStream can now use internal backends with multizone. In
order for multizone to work, we first need to retrieve the multiroom
info and pass it to the backend.

BUG=b:111694183
TEST=Build, cast_media_unittests

Change-Id: I128a6b0cc1a389d01102007244fdb5594dd4c637
Reviewed-on: https://chromium-review.googlesource.com/1145892Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Aidan Wolter <awolter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578670}

Add a URLPattern::CreateIntersection() method to return the
intersection of two URLPatterns, if any. This can construct a new
URLPattern in many cases.

For instance, the intersection returned between http://*.google.com/*
and *://google.com/maps is http://google.com/maps.

This CL does not add any (non-test) usages of the new method.

Bug: 867549

Change-Id: I590081fa6d57bcc88c831095b50d21e20e9ec049
Reviewed-on: https://chromium-review.googlesource.com/1150413Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578669}

The system voice is chosen using the Text-to-Speech settings page
and depends on locale.

Bug: 866550
Change-Id: I249a023d9f018ef8ef1f242f82cf3c9d5b6d788b
Reviewed-on: https://chromium-review.googlesource.com/1150773Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578668}

When draw constraints have not changed. Fairly obvious and hopefully
safe change.

Bug: 864436
Change-Id: I6cb4165c34411fa81d1644edb262496e82f8044e
Reviewed-on: https://chromium-review.googlesource.com/1150964Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578667}

This implements the previously-removed textfield jogging behavior
behind a feature flag accessible from chrome://flags.

Followup work: We may implement a special accommodation to the jog flag
to make the keystroke-backspace case less jarring of a transition.

Bug: 868157
Change-Id: I63fbb8f8f171f1d5ccf09f1cd92332963f567ae3
Reviewed-on: https://chromium-review.googlesource.com/1152459
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578666}

Instead of using ATK_ROLE_WINDOW by default for the internal Window
accessibility role, use ATK_ROLE_FRAME. ATK_ROLE_FRAME is used for
windows that have titlebars and buttons, while ATK_ROLE_WINDOW is
reserved for those that don't. Since most windows have buttons and a
titlebar in Chromium, ATK_ROLE_FRAME is probably a better default.

TEST=accessibility_unittests --gtest_filter=AXPlatformNodeAuraLinuxTest.*

Bug: 867006
Change-Id: Ia0366f7088465f123f00e250c4cc6f7393c0c64e
Reviewed-on: https://chromium-review.googlesource.com/1148445
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578665}

On browser startup we attempt to resume all previously active fetches.
The DownloadService might not be ready though, so this change only resumes
the fetches if the DownloadService is ready, and also goes through all the
jobs and resumes the active fetches once the OnServiceInitialized event
is triggered.

Note that ResumeDownload might be called twice on the same guid in some cases,
but that will not cause any problems since the second call will be ignored.

Change-Id: I1d06c944496cd0f1b711ae91d15c003abc70f8c3
Reviewed-on: https://chromium-review.googlesource.com/1152820
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578664}

In event test output, don't use document object's value, which is a URL.
This helps avoid arbitrary differences in tests, as the port numbers
change between runs.

Bug: None
Change-Id: I7c8d5aee6267b8863a5c8712db1287ded551e5c8
Reviewed-on: https://chromium-review.googlesource.com/1150434
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578663}

Bad-cast to base::TestMockTimeTaskRunner from invalid vptr
in base::TestMockTimeTaskRunner::MockClock::NowTicks

test_task_runner_ was getting destructed before the sequence
manager (which calls the test_task_runner_ upon its
destruction).

Bug: 867790
Change-Id: I412b6a720b4607deeaad1ce80d8bd601dfc04814
Reviewed-on: https://chromium-review.googlesource.com/1152979
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578662}

We no longer have mash vs. classic configs in ash, and there's only one
implementation of ShellPort. As a step towards eliminating ShellPort,
remove the cursor handling methods from it.

Also clean up some code that checks to see if we have a cursor
manager -- ash always has one, for the lifetime of Shell.

This manually reverts parts of
https://codereview.chromium.org/2857963003/

Bug: 866523
Test: ash_unittests
Change-Id: Ic905b26587af6c2cebdd4fcbcf07f85d69515d1e
Reviewed-on: https://chromium-review.googlesource.com/1152544Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578661}

VisualProperties are passed to the RenderViewImpl::Create() method via
the IPC params, then are passed along to the RenderWidget, but in a
lot of different steps.

1st, screen info is passed to the RenderWidget constructor.
2nd, the display mode is set directly on the RenderWidget.
[ a bunch of other initialization here ]
3rd, the whole set of properties is passed to
OnSynchronizeVisualProperties like an IPC was just received.

The 3rd step sends the screen info and the display mode again, though
they won't be changed of course.

This combines step 1 and 2 into one step where they are passed to the
RenderWidget::Init() method. Then we can look at combining with step 3.

R=ajwong@chromium.org, avi@chromium.org

Bug: 419087
Change-Id: Ifcb8eaa0915bb235172e8c5b7bee188e863c18c3
Reviewed-on: https://chromium-review.googlesource.com/1150673
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578660}

Tab-switch requests that are made through devtools for telemetry tests
are not treated as user-gesture. So this metric can not reported in
telemetry tests. However, the cost of this function is not directly
related to the user-gesture itself. So always report this metric and
associated trace event. This allows this to be measured and monitored
in telemetry tests.

BUG=858944

Change-Id: Ib7112b4939c44af099ecfb751fe108bbe8ecec86
Reviewed-on: https://chromium-review.googlesource.com/1152888Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578659}

Fix a typo in
https://chromium-review.googlesource.com/c/chromium/src/+/1142449,that
resulted in over-eager execution of ozone/drm/mojo and hence the
firing of DCHECKs on CrOS in certain configurations.

BUG=867077
TEST=Run with DCHECKs always on.

Change-Id: I239f7927894a9d766d9057f3145e458a0fb2aa6b
Reviewed-on: https://chromium-review.googlesource.com/1152900Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578658}

This is a temp fix for a bug on chromecast screen reader whereby
the item that has a focus ring is not invoked after the user
double taps the screen.

When the touch exploration controller sets an anchor point
explicitly, it issues a click gesture rather than a simulated tap
when the user double clicks the screen.  The click never gets
processed properly by the background page because the
ax tree thinks no window has 'keyboard' focus.  This change
defaults the focus_id field of AXTreeData to be 1 (the root node)
since we only ever have one tree and one window to focus on
anyway.

A long term fix involves fixing other focus issues including
(but not limited to) 1) giving the root window focus via Focus()
call, 2) making sure the root window doesn't lose focus and
3) registering a native widget with the aura::Window or
altering the ax_object_cache logic to not require it when
trying to find the ax tree node corresponding to a window.

Bug: b/111911092
Change-Id: Ide68dbae72288f58711d436db99ef495e5ea9eb0
Reviewed-on: https://chromium-review.googlesource.com/1152897Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578657}