- 20 May, 2015 40 commits
-
-
melandory authored
* Removes succesfull runs from debug output. * Use named parameter in call to stopit.ThreadingTimeout, in order to make it clear that it seconds. BUG=369521 R=vabr@chromium.org Review URL: https://codereview.chromium.org/1143223002 Cr-Commit-Position: refs/heads/master@{#330743}
-
mdjones authored
This change is the IOS counterpart to https://codereview.chromium.org/1101993003/ Code that is used for generating HTML and JavaScript have been moved to a superclass; this changes the IOS code to use that. BUG=472797 Review URL: https://codereview.chromium.org/1071413003 Cr-Commit-Position: refs/heads/master@{#330742}
-
mnaganov authored
It turns out that a couple of dirs from the list are actually still being used on the release bot. BUG=350472 TBR=boliu@chromium.org Review URL: https://codereview.chromium.org/1147043002 Cr-Commit-Position: refs/heads/master@{#330741}
-
ashlin.j authored
Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in jingle module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Review URL: https://codereview.chromium.org/1128793002 Cr-Commit-Position: refs/heads/master@{#330740}
-
vollick authored
An orphaned layer has no relation to property trees, so it is an error for it to have property tree indices. BUG=489725 Review URL: https://codereview.chromium.org/1139573004 Cr-Commit-Position: refs/heads/master@{#330739}
-
knn authored
[Android][Cleanup] Remove temporary clobber scripts after r1062213002 removing localized AppRestriction resources. BUG=475515 Review URL: https://codereview.chromium.org/1151523003 Cr-Commit-Position: refs/heads/master@{#330738}
-
jonross authored
Revert "This change is intended to M-43. Currently screen rotation animations expose a bug, causing the login screen to not be useable. Disable rotation animations while a user is not logged in. This will be later reverted on M-44 where a fix to the underlying issue will be landed." This reverts commit 274e83a4. Original review: https://codereview.chromium.org/1139793003/ The underlying bug was fixed via: https://codereview.chromium.org/1125283015/ TBR=oshima@chromium.org BUG=chrome-os-partner:40118 Review URL: https://codereview.chromium.org/1145963003 Cr-Commit-Position: refs/heads/master@{#330737}
-
sdefresne authored
SyncSetupService allows configuring sync. It handles enabling and disabling it, as well as choosing datatypes. Most actions are delayed until a commit is done, to allow the complex sync setup flow on iOS. BUG=429756 Review URL: https://codereview.chromium.org/1148573002 Cr-Commit-Position: refs/heads/master@{#330736}
-
peter authored
Usage of the "gcm_user_visible_only" Manifest key has been deprecated in favor of using PushSubscriptionOptions when subscribing. Show a deprecation warning when only the former is used. BUG=471534 Review URL: https://codereview.chromium.org/1145163002 Cr-Commit-Position: refs/heads/master@{#330735}
-
cwallez authored
BUG= Review URL: https://codereview.chromium.org/1134953003 Cr-Commit-Position: refs/heads/master@{#330734}
-
dongseong.hwang authored
Review URL: https://codereview.chromium.org/1145193002 Cr-Commit-Position: refs/heads/master@{#330733}
-
mlerman authored
This CL implements: - the flow that detects if users are eligible for the promo, up to the point of making the remote call to determine if they sync elsewhere - A rough-out of the code that makes the remote call This previous CL implemented the calls necessary to mint access tokens: https://codereview.chromium.org/973953002 Work to do includes: Wiring up against the new Sync Endpoint, and building out any and all UI. Design Doc for the promo: https://docs.google.com/document/d/1ZmKjU24zAYuo38zFwJxUwJk_0JJ8b0UohkCGI41QnBI/edit Design Doc for the new Sync endpoint: https://docs.google.com/document/d/1pT1lyJLlr9x8kyp1Ns-GlyNySq1Nl0wWRnGX2kQ-pD4/edit BUG=463611 Review URL: https://codereview.chromium.org/1087933002 Cr-Commit-Position: refs/heads/master@{#330732}
-
sdefresne authored
BUG=463851 Review URL: https://codereview.chromium.org/1141423002 Cr-Commit-Position: refs/heads/master@{#330731}
-
groby authored
Views and Cocoa ctors were taking entirely different parameters - parent window vs Browser*. We need those to be consistent, in preparation for work at managed bubbles. BUG = none Review URL: https://codereview.chromium.org/1140223003 Cr-Commit-Position: refs/heads/master@{#330730}
-
spang authored
The name is stale since the class was renamed. It was "NativeDisplayDelegateDri" and is now "DrmGpuDisplayManager". TEST=compile Review URL: https://codereview.chromium.org/1146493004 Cr-Commit-Position: refs/heads/master@{#330729}
-
sullivan authored
Revert of [Telemetry] Disable auto issuing record for thread_times (patchset #3 id:60001 of https://codereview.chromium.org/1140353003/) Reason for revert: Seems to have broken service_worker tests (http://crbug.com/490130) Original issue's description: > [Telemetry] Disable auto issuing record for thread_times > > BUG=444705 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/2905d303db21f120aab1914f98fe0e44284f82ed > Cr-Commit-Position: refs/heads/master@{#330613} TBR=eakuefner@chromium.org,nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=444705 Review URL: https://codereview.chromium.org/1151543002 Cr-Commit-Position: refs/heads/master@{#330728}
-
treib authored
This will allow us (in a follow-up CL) to *not* grant permissions to extensions that come in via Sync disabled due to a permission increase. BUG=484214 Review URL: https://codereview.chromium.org/1136543003 Cr-Commit-Position: refs/heads/master@{#330727}
-
agoode authored
Review URL: https://codereview.chromium.org/1145533004 Cr-Commit-Position: refs/heads/master@{#330726}
-
sdefresne authored
BUG=474249 Review URL: https://codereview.chromium.org/1147843002 Cr-Commit-Position: refs/heads/master@{#330725}
-
edwardjung authored
+ Update chrome://kill and chrome://crash icons. Both now use the same icon. + Make layout consistent with the SSL / Malware / net error set of interstitials. + Switched colours, margin, padding to use native UI constants. BUG=457763 Review URL: https://codereview.chromium.org/1129513002 Cr-Commit-Position: refs/heads/master@{#330724}
-
timvolodine authored
BatteryStatusManagerTest does not compile on M because of the changes to the BatteryManager class. This patch introduces AndroidBatteryManagerWrapper to make the system battery manager testable on M. BUG=488690 Review URL: https://codereview.chromium.org/1130253012 Cr-Commit-Position: refs/heads/master@{#330723}
-
phoglund authored
We removed SDP logging earlier because it was bloating bot logs, but nowadays logs only get printed for failing tests, and SDP information is very useful to debug for instance webrtc:4570. BUG=webrtc:4570,484826,479093 Review URL: https://codereview.chromium.org/1124323005 Cr-Commit-Position: refs/heads/master@{#330722}
-
cschuet authored
This CL adds the possibility to filter by certificate type when issuing a certificate request to chrome.platformKeys API. BUG=488367 TEST=browser_tests:PlatformKeysTest.Basic Review URL: https://codereview.chromium.org/1141253003 Cr-Commit-Position: refs/heads/master@{#330721}
-
pranay.kumar authored
MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). BUG=391045 Review URL: https://codereview.chromium.org/1126963003 Cr-Commit-Position: refs/heads/master@{#330720}
-
aandrey authored
NOTRY=true TBR=yurys Review URL: https://codereview.chromium.org/1143163002 Cr-Commit-Position: refs/heads/master@{#330719}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26d7fad7..d30001ae Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1148773002 Cr-Commit-Position: refs/heads/master@{#330718}
-
tommi authored
WebRTC 9227:9229 Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/6859ada..ead3df8 TBR= BUG= Review URL: https://codereview.chromium.org/1143963003 Cr-Commit-Position: refs/heads/master@{#330717}
-
sdefresne authored
Expose TemplateURLPrepopulateData::GetCurrentCountryID() to detect that the user changed the device region in order to update the list of search engine on iOS. Note that when a region change is detected we remove all default search engines except the one selected by the user and then insert all the new engines. This is possible because user cannot customize search engines, only select one of the default engines. BUG=None Review URL: https://codereview.chromium.org/1130183004 Cr-Commit-Position: refs/heads/master@{#330716}
-
mtomasz authored
TEST=browser_tests: *Providers/FileSystemBrowserTest* BUG=486864 Review URL: https://codereview.chromium.org/1145893002 Cr-Commit-Position: refs/heads/master@{#330715}
-
sdefresne authored
BUG=None Review URL: https://codereview.chromium.org/1123383006 Cr-Commit-Position: refs/heads/master@{#330714}
-
tengs authored
BUG=420315 TEST=unit test Review URL: https://codereview.chromium.org/1147563002 Cr-Commit-Position: refs/heads/master@{#330713}
-
mgiuca authored
Previously, if the user has never used the app launcher, and it loads while in a guest mode browser window, the browser would crash. This was particularly bad because it could happen during startup on Windows, even without explicitly opening the launcher (due to app list warmup). Now if the last used profile is the guest profile, just uses the default. Added DCHECKs on app list profile loads to ensure they are not guest profiles. BUG=468812 Review URL: https://codereview.chromium.org/1106453002 Cr-Commit-Position: refs/heads/master@{#330712}
-
plundblad authored
Before, when entering contracted (gradd 2) braille, backtracking was done using the chrome.input.ime.deleteSurroundingText API. This made text entry visible in the text field immediately. Unfortunately, some contexts don't handle programmatic deletion well (Google Docs' editor is an example). The new approach is to not commit the text ot the edit field until a word has been entered or a non-braille key is entered. To make the user experience better for the braille user, entered braille cells are shown on the display right before the curent selection so that the user gets immediate feedback when typing on the braille dipslay. This approach has drawbacks as well. For example, clicking with a mouse while typing could move focus before the IME has a chance to submit the in-progress word. The assumption is that this would be less of a problem in practice then not being able to use grade 2 at all in some situations. BUG=392854 Review URL: https://codereview.chromium.org/1039703002 Cr-Commit-Position: refs/heads/master@{#330711}
-
sammc authored
Review URL: https://codereview.chromium.org/1134003008 Cr-Commit-Position: refs/heads/master@{#330710}
-
satorux authored
Because I no longer work on code in these directories these days. Add hashimoto@ to chrome/browser/chromeos/dbus/OWNERS. BUG=none Review URL: https://codereview.chromium.org/1144023003 Cr-Commit-Position: refs/heads/master@{#330709}
-
pranay.kumar authored
https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Forward-declare-classes-instead-of-including-headers. Review URL: https://codereview.chromium.org/1135793006 Cr-Commit-Position: refs/heads/master@{#330708}
-
shuchen authored
Currently HWNDMessageHandler::OnSetFocus happens before WM_ACTIVATE is handled in HWNDMessageHandler::OnWndProc(). Root cause: when WM_ACTIVATE comes, in HWNDMessageHandler::OnWndProc(), it will call DefWindowProc() first, which may result in generating WM_SETFOCUS message and call OnWndProc() recursively and therefore OnSetFocus() is called. After the recursive OnWndProc() returns, PostProcessActivateMessage() is called to handle WM_ACTIVATE. So DWTHW::HandleNativeFocus() happens before DNWA::HandleActivationChanged(). Therefore, IMB::OnFocus() will get NULL for host_->GetTextInputClient(), which will result in the IMB instance set to the host InputMethod as the focused TextInputClient (which should be the RWHVA). It would be risky to fix that order in HWNDMessageHandler. Instead, we can remove the IMB::OnFocus call in DWTHW::HandleNativeFocus() which seems to be redundant, because DNWA::OnWindowFocused() can do the thing, which happens after the top window is activated. TBR=ananta@chromium.org,sky@chromium.org BUG=486604 TEST=Verified on local win build. Review URL: https://codereview.chromium.org/1139623003 Cr-Commit-Position: refs/heads/master@{#330707}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#330706}
-
xdai authored
Disable AutoclickTest.DISABLED_SynthesizedMouseMovesIgnored test on official build since it has been failing for several days. BUG=489896 Review URL: https://codereview.chromium.org/1124113006 Cr-Commit-Position: refs/heads/master@{#330705}
-
jackhou authored
They should take up the entire screen, and the fullscreen button must be enabled to allow the user to leave. This also factors out NSWindowFullscreenNotificationWaiter. BUG=459877 Review URL: https://codereview.chromium.org/1109493002 Cr-Commit-Position: refs/heads/master@{#330704}
-