- 14 Aug, 2018 40 commits
-
-
Javier Ernesto Flores Robles authored
FindImageElementAtPointOutsideElement is flaky on devices. Bug: 796418 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I36781de8c1127f74196457c0a0ec7ebf0bd6c5d5 TBR: eugenebut@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1174437Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#582891}
-
Jérôme Lebel authored
Plugging in the non-personalized section: + "Autocomplete searches and URLs" with prefs::kSearchSuggestEnabled + "Make searches and browsing better" with unified_consent::prefs::kUrlKeyedAnonymizedDataCollectionEnabled Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id48c7fbfd9d713a9a2445735797d57d4c7211f05 Reviewed-on: https://chromium-review.googlesource.com/1173236 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#582890}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b5fb1284. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22701 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I69c6827487746ef2f93c3a68901c55f8e046f14f Reviewed-on: https://chromium-review.googlesource.com/1174104 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#582889}
-
Martin Kreichgauer authored
Touch ID previously used a non-zero AAGUID chosen by us. But WebAuthn requires self-attestation to use an all-zero AAGUID value. Also delete the unused |TouchIdAaguid| function. Bug: 678128 Change-Id: I27bc82f7248d2c22ede773c0e6b010f56022d255 Reviewed-on: https://chromium-review.googlesource.com/1172911Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582888}
-
Balazs Engedy authored
Change each sheet show during the WebAuthn UX flow to include a pretty illustration in the top of half of the dialog. Bug: 849323 Change-Id: Ieff9ceea06f63f5b6892e4401b43b922a13d28a8 Reviewed-on: https://chromium-review.googlesource.com/1172323 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582887}
-
Jun Choi authored
Add logic to cancel ongoing WebAuthN request when user clicks "cancel" button from any UI modal or "back" button from the initial welcome screen. Bug: 847985 TBR: jam@chromium.org Change-Id: Ia9a014cf78583c2512ceaebf822758aa0dc65d99 Reviewed-on: https://chromium-review.googlesource.com/1173489 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL rename the openURL: method to indicate that it is loading the URL in a new tab. Bug: 861729 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9bea43c3589070c1b32b8d7bf08330edab9f59e2 Reviewed-on: https://chromium-review.googlesource.com/1174255Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fe19ddfb2910..8f60c708bfd1 git log fe19ddfb2910..8f60c708bfd1 --date=short --no-merges --format='%ad %ae %s' 2018-08-14 raphael.kubo.da.costa@intel.com telemetry: Prefer reading Linux version information from os-release(5) Created with: gclient setdep -r src/third_party/catapult@8f60c708bfd1 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I8c3870f6cbe893b98ac983c3887a0590f621cb0a Reviewed-on: https://chromium-review.googlesource.com/1174212Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582884}
-
Yuta Kitamura authored
This patch adds a new test utility for Blink platform. It's called TestingPlatformSupportWithCustomScheduler, and is a natural extension of TestingPlatformSupport. The new utility removes the need of writing custom Platform and WebThread in tests. Essentially, the objective of this CL is to shift the responsibility of writing custom WebThread from each test to platform/testing. Two affected tests are rewritten to use it. Bug: 826203 Change-Id: I41160fe50286adc3acb09dbd128d654c356d4355 Reviewed-on: https://chromium-review.googlesource.com/1170702 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#582883}
-
Javier Ernesto Flores Robles authored
This reverts commit 5afd5ef8. MDC roll broke feedback for iOS 10. Bug: 873293 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9e181f4bbbec7726d0370b95bd17d4fadca89377 TBR: pkl@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1174256Reviewed-by:
-
Friedrich Horschig authored
Before this CL, the accessory bar wouldn't add impressions to delayed appearing actions. This CL ensures this is done once (per new set of actions) while keeping the constraint that every bar impression happens exactly once. Bug: 873143 Change-Id: I4de6c8f8e95321176d9bca19459d6e9d2cdae746 Reviewed-on: https://chromium-review.googlesource.com/1171227 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#582881}
-
Alex Loiko authored
This CL adds flags and Finch features for a new WebRTC feature. It also applies the flag settings to WebRTC Audio Processing. Bug: chromium:873650 webrtc:7494 Change-Id: If2062aaf4f8bf48e26742b2841187f02221141ff Reviewed-on: https://chromium-review.googlesource.com/1172438 Commit-Queue: Alex Loiko <aleloi@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#582880}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 04226262. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22700 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dtapuska@chromium.org: external/wpt/uievents NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ibc1fdb53ea79ae7f8809f0b21c26ab4e49e97ad6 Reviewed-on: https://chromium-review.googlesource.com/1174099 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Uladzimir Miniailau authored
This CL isolates code for parsing LookupAffiliationResponse into lookup_affiliation_response_parser.*, and adds a fuzzer for it. Bug: 834707 Change-Id: If269a3603a0b84891491955ec0a99ad8506e0fc7 Reviewed-on: https://chromium-review.googlesource.com/1131185 Commit-Queue: Uladzimir Miniailau <miniailau@google.com> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582878}
-
Daniel Cheng authored
- Use the helpers in histogram_functions.h instead of using custom versions. - Use kMaxValue version of UMA_HISTOGRAM_ENUM in one more place - Return const char* for enum stringification helpers to reduce number of temporary strings. - Use StrCat() to build dynamic histogram names to reduce number of temporary strings. Bug: none Change-Id: I720d11ad16c245f3ea59d55c2b75af8914eea7e8 Reviewed-on: https://chromium-review.googlesource.com/1174014 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#582877}
-
Hayato Ito authored
Add links to some useful pictures to understand how DOM works. This CL doesn't add pictures in the repository. At this point, pictures are served from a web site which hayato@chromium.org ownes. TBR=rakina Bug: 742715 Change-Id: Ic48854b4cc37fe4aca55bd2142ff4cbc26af823f Reviewed-on: https://chromium-review.googlesource.com/1174293Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#582876}
-
Maksim Sisov authored
$ git log --oneline 3cb5bbacc5c8a79105c868875222696f6b9d8296...ff1ecaf1014df4cb9ca36c5a270647a9934aaa99 ff1ecaf minigbm: fixup! align minigbm functions names with upstream libgbm 79205a5 minigbm: align minigbm functions names with upstream libgbm faeb009 minigbm: Opening new fd for dri backend a047d41 minigbm: increment ref count in drv_bo_import dc8554f minigbm: amdgpu: align the stride to 256 1805a9b msm: allow allocation of NV12 dumb buffers dea0ccb minigbm: Add BO_USE_HW_VIDEO_DECODER to supported flags a8a3895 minigbm: close bo handle in bo destroy 293d9e3 minigbm: DRM_FORMAT_BGR888 for amdgpu 9924776 minigbm: Build fix for arm64 abe44f6 minigbm: add support for BG24 6bd7885 minigbm: run clang-format Bug: 820047, 869206 Change-Id: I512b35c7821fd3221a97592006de5279b414dd01 Reviewed-on: https://chromium-review.googlesource.com/1169821 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#582875}
-
Marek Haranczyk authored
The change should address random build failures of missing mojo bindings generated headers on targets that cannot depend on bindings code directly but need to use it. Extra: Add missing deps to blink scheduler test_support target. Bug: 852558 Change-Id: Ib0e3be23093dcda6629f6f8d0149d9d5a57bac07 Reviewed-on: https://chromium-review.googlesource.com/1151301Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/501bed82a534..fe19ddfb2910 git log 501bed82a534..fe19ddfb2910 --date=short --no-merges --format='%ad %ae %s' 2018-08-14 achuith@chromium.org _IsCryptohomeMounted requires CrOSInterface. Created with: gclient setdep -r src/third_party/catapult@fe19ddfb2910 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I94c3d863761c3c572a4118415688ecfee30471d9 Reviewed-on: https://chromium-review.googlesource.com/1174211Reviewed-by:
-
Ivan Sandrk authored
New strings are available @ https://docs.google.com/document/d/1cVwZrMVUwOWUCdHFJ2bRe0nVzam4xFNSozmObaKs2Tg Bug: 865947 Change-Id: I163605c3c82230a3a8b0dd9d96fd9eda038fe29b Reviewed-on: https://chromium-review.googlesource.com/1172686Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#582872}
-
Alexandr Ilin authored
This reverts commit bc740b07. Reason for revert: this commit causes compile errors on several internal.client.clank builders, particularly on "monochrome_bundle" target. Failed build: https://ci.chromium.org/buildbot/internal.client.clank/arm-builder-rel/20238 Original change's description: > [build:android] Add a module for AR in Monochrome > > Add an AR Dynamic Feature Module (DFM) and bundle it into the public > Monochrome bundle. > > + Add loadable modules to the build config so that their paths can be > passed to the module create target. > > + Add option to bundle targets to specify the Android SDK target for > synchronized proguarding. This was necessary because the Monochrome > base module uses a different Android SDK than the AR module, which > made proguard sad. Also pass the Android SDK Jar as a dedicated > classpath Jar to proguard and don't mix it with the other classpath > Jars. > > Bug: 863063 > Change-Id: I024d05dd99136c069e510995657ac7236f6b6e5e > Reviewed-on: https://chromium-review.googlesource.com/1165533 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582765} TBR=vollick@chromium.org,yfriedman@chromium.org,tedchoc@chromium.org,agrieve@chromium.org,tiborg@chromium.org Change-Id: I87ab63c3153018390f4018527d760bbd10cdcd16 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 863063 Reviewed-on: https://chromium-review.googlesource.com/1174271Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582871}
-
Hayato Ito authored
Add Event path and Event Retargeting section. TBR=rakina Bug: 742715 Change-Id: I969f020cc0a762a6cc8695c4e5dc7cd03fcb32e0 Reviewed-on: https://chromium-review.googlesource.com/1174196 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
-
Elad Alon authored
When a profile is loaded for the first time, if the policy controlling remote-bound WebRTC event logs is disabled, clear any pending logs from previous times the profile was loaded, when the policy might have been enabled. Bug: 775415 Change-Id: If20928ba660f0be5a73c52a11ae521c5246c174a Reviewed-on: https://chromium-review.googlesource.com/1162322 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
-
Rayan Kanso authored
Bug: 780025 Change-Id: Ia8bb5d2667c4b9132cccbea5cfe5f6ce53e919a2 Reviewed-on: https://chromium-review.googlesource.com/1170829Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#582868}
-
Kent Tamura authored
This simplifies the code slightly. This is a preparation to mojoify FileChooser IPCs [1]. [1] https://chromium-review.googlesource.com/1170454 Change-Id: I52058bedda4508991f88e1c45a09151be02d40e9 Reviewed-on: https://chromium-review.googlesource.com/1174081 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582867}
-
Alexander Alekseev authored
This CL increases OOBE startup sound delay to 4 seconds, and adds UMA metric on it. Bug: 848485 Change-Id: I5401a2625634315760906789fcd69afe04d2972c Reviewed-on: https://chromium-review.googlesource.com/1173014Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#582866}
-
Achuith Bhandarkar authored
Bug=chromium:871600 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I09f909050620f8d2e2e9a1fdedbe2c7091732128 Reviewed-on: https://chromium-review.googlesource.com/1173138Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#582865}
-
Dan Elphick authored
Remove uses of deprecated functions in file_browser_handler_custom_bindings.cc, replacing ToObject() on a known Object with .As<v8::Object>() and use the Context form of ToBoolean along with FromMaybe(false) Bug: v8:7786 Change-Id: Ib4726f5ae77797c736e35d36ae0ca25f50808a0a Reviewed-on: https://chromium-review.googlesource.com/1172436Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#582864}
-
Tetsui Ohkubo authored
OnMessageCenterScrolled should be fired when it's scrolled by fling. Otherwise, stacking notification counter https://crrev.com/c/1168945 and notification corners https://crrev.com/c/1161710 might show invalid state with touch screen. TEST=manual BUG=none Change-Id: I0a647bdd5af979775ef4ef4e8c470a96cbfd299a Reviewed-on: https://chromium-review.googlesource.com/1172233Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#582863}
-
Makoto Shimazu authored
This reverts commit fef811c5. Reason for revert: SaveType/SavePageOriginalVsSavedComparisonTest.Style becomes flaky and findit suggested this is the culprit. Let me revert this speculatively and see if it'll be fixed. Original change's description: > Mojoify FindInPage::Find > > We are mojoifying browser<->renderer communication of Find-in-page. > In this CL, we are converting the Find function to mojo. Find replies > are now separated into two functions, one to update the number of > found matches (SetNumberOfMatches) and the other is to update which > match is active right now (SetActiveMatch). > > This is the final function to be mojoified for FindInPage. > Mojoifying doc: https://goo.gl/JenyGm > > Bug: 819919 > Change-Id: I990160f973b29d7620214d7d58a16ece033adf3f > Reviewed-on: https://chromium-review.googlesource.com/1086950 > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582841} TBR=dcheng@chromium.org,yosin@chromium.org,alexmos@chromium.org,rakina@chromium.org Change-Id: I0c48b0aed588049147f8cc49addaf1686fa67621 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819919, 873965 Reviewed-on: https://chromium-review.googlesource.com/1173892Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582862}
-
Yuki Yamada authored
I am planning to replace V8AbstractEventListener and its subclasses by new classes I will implement for redesigning EventListener/EventHandler in https://crbug.com/872138, so it is better to remove unnecessary dependencies on the classes which inherits blink::EventListener before addressing that. Basically, we should not use blink::V8AbstractEventListener or other classes which inherits EventListener unless we have to use the methods implemented only in child class, but there are some cases that uses child classes without any need. Therefore this CL replaced child classes by blink::EventListener if possible. Bug: 872138 Change-Id: Idc82f93fdc850f532092cc021f6aa458803dcd7b Reviewed-on: https://chromium-review.googlesource.com/1170714 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
According to UX, when the user drags the slider down to 0, it does not become muted. See the bug for the detail of the behavior. TEST=manual BUG=863488 Change-Id: Ie3e65fb3dd80c37773640e677ccf1ec12faabb03 Reviewed-on: https://chromium-review.googlesource.com/1172240Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3f2c0c03. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22699 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ifd879bbc7d3c4057287aa7caec3b3eb72a3d21e7 Reviewed-on: https://chromium-review.googlesource.com/1174091 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
According to UX, background color opacity of UnifiedSystemTray was dropped from 70% to 60%. TEST=manual BUG=863232 Change-Id: Idea912340d91e245cd6ca854b970c4d91e376057 Reviewed-on: https://chromium-review.googlesource.com/1173932Reviewed-by:
-
Adam Rice authored
This reverts commit f3d0a2f2. Reason for revert: The revert was not effective at mitigating https://crbug.com/864351, so reverting the revert as the original CL was effective against https://crbug.com/788890. Original change's description: > Revert "WS: Delete FileReaderLoader in BlobLoader" > > This reverts commit 530f6487. > > Reason for revert: Temporary revert to mitigate https://crbug.com/864351. This CL appears to have fixed https://crbug.com/788890, but that was a render process crash. 864351 is a browser process crash so preventing it is more important. > > Original change's description: > > WS: Delete FileReaderLoader in BlobLoader > > > > Delete the FileReaderLoader member of WebSocketChannelImpl::BlobLoader > > as soon as we are done with it. This moves the lifetime semantics closer > > to what they were before Oilpan, and saves a bit of memory. > > > > Also remove some obsolete pre-Oilpan comments, since > > WebSocketChannelImpl and BlobLoader are garbage collected rather than > > explicitly deleted now. > > > > BUG=788890 > > > > Change-Id: I815e53a3271a91dbeb779b6f386004b454d1db92 > > Reviewed-on: https://chromium-review.googlesource.com/1128837 > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > > Commit-Queue: Adam Rice <ricea@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#573647} > > TBR=ricea@chromium.org,yhirano@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 788890 > Change-Id: I71bdac66189d284637aabcb56998218a925aa01c > Reviewed-on: https://chromium-review.googlesource.com/1166303 > Reviewed-by: Adam Rice <ricea@chromium.org> > Commit-Queue: Adam Rice <ricea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581461} TBR=ricea@chromium.org,yhirano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 788890 Change-Id: If38f2acb5d20293c3dc3a1763464b823576d5767 Reviewed-on: https://chromium-review.googlesource.com/1170522Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#582857}
-
Makoto Shimazu authored
TBR=robertma@chromium.org NOTRY=true Bug: 856601 Change-Id: Iad0f3b236494cc6d1f14af0fc03518ebf3e0671a Reviewed-on: https://chromium-review.googlesource.com/1174144Reviewed-by:
-
tzik authored
NULL blocks scoped_refptr to support nullptr, and eventually blocks the removal of its implicit raw-pointer-to-scoped_refptr conversion. This CL replaces all relevant NULL in //gpu with nullptr. Tbr: bbudge@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6009249763ed14961bd5a725534419d2d0bf71f0 Reviewed-on: https://chromium-review.googlesource.com/1168960 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#582855}
-
Mark Pearson authored
Change-Id: I4535fd202076e24efb6dc9d2e11be88a7fa023db Reviewed-on: https://chromium-review.googlesource.com/1173320Reviewed-by:
-
Jan Wilken Doerrie authored
This change implements BluetoothDevice::IsPaired() by querying the underlying device information. Furthermore, a test is added, which is currently only enabled for Windows. Bug: 821766 Change-Id: Idaed73fe544f115c1a0fc2157f477b009f4c26a6 Reviewed-on: https://chromium-review.googlesource.com/1172971Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#582853}
-
Lei Zhang authored
Change-Id: Ieaabe95f426ef5ebb5846108fde3227efd1c3113 Reviewed-on: https://chromium-review.googlesource.com/1173759Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#582852}
-
