- 25 Feb, 2019 40 commits
-
-
Mike Wittman authored
All implementations of this function are now empty. Bug: 931418 Change-Id: I87d875a5523fa12a9db9b52b1e3baef41118e62b Reviewed-on: https://chromium-review.googlesource.com/c/1478073 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#635198}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/2901ec32a9..93d155bc44 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/2901ec32a9..93d155bc44 Bug: None Change-Id: I0089165c94f2676eb7069fd8c53908fc25ff351f Reviewed-on: https://chromium-review.googlesource.com/c/1485952Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#635197}
-
Marcin Wiącek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing PanelState enum in the form common with other Chrome @IntDef: 1. with @IntDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries 4. with comment about numbering from 0 without gaps 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface There is additionally removed one unnecessary Map. BUG=919666 Change-Id: I8149a0800bd5c0bb205028d230edadc83016ebb9 Reviewed-on: https://chromium-review.googlesource.com/c/1142764Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#635196}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9eb111e85e7e..4a8da2c58a9d Created with: gclient setdep -r src-internal@4a8da2c58a9d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia6d19a65a49a99429f9e1222c9cda370414cfb36 Reviewed-on: https://chromium-review.googlesource.com/c/1487132Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635195}
-
Elly Fong-Jones authored
Bug: None Change-Id: I023840d139f7494636224358c8c0d3519b6179f2 Reviewed-on: https://chromium-review.googlesource.com/c/1486491 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#635194}
-
James Cook authored
Use "Chromebox" vs. "Chromebook" depending on device type. Bug: 872739 Change-Id: I1ef4b6db7b176c8cd27979e39cde5aaf77f76cea Reviewed-on: https://chromium-review.googlesource.com/c/1484507Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#635193}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I7a49ee027d224abc8bb8e5228201bfb69df41c12 Reviewed-on: https://chromium-review.googlesource.com/c/1486836Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635192}
-
Lukasz Anforowicz authored
Before this CL, a comment in //extensions/browser/url_loader_factory_manager.cc used to incorrectly link to an internal doc with a draft of https://www.chromium.org/Home/chromium-security/extension-content-script-fetches (this comment landed back when we were still considering just making the doc public, rather than moving the content under https://www.chromium.org/Home/chromium-security). Bug: 846346 Change-Id: I55a09bc55523bb0f59d21133402da8a53dd94625 Reviewed-on: https://chromium-review.googlesource.com/c/1487351Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#635191}
-
Christian Biesinger authored
{Min,Max}PreferredLogicalWidth only constrains the size by the min/max-width if it is a fixed value. However, ChildIntrinsicLogicalWidth needs to constrain even for percentages and others. R=mstensho@chromium.org Bug: 935022 Change-Id: I3f5eff5e6f8e99484185635e44e3afa426c741fb Reviewed-on: https://chromium-review.googlesource.com/c/1484854 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#635190}
-
Xiaocheng Hu authored
Bug: 935638 Change-Id: I5bd95e9e38a713a42863d2b2607fc1c6bb824bef Tbr: xiaochengh@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/1487195Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635189}
-
Sylvain Defresne authored
Change client code to work as if IdentityManager::GetPrimaryAccount where returning a CoreAccountInfo instead of an AccountInfo. Method will be updated in a followup CL. Bug: 926204 Change-Id: Iae27a30eb1a4bc45987f003fbb9c82142715e9cb Reviewed-on: https://chromium-review.googlesource.com/c/1483019 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#635188}
-
Nektarios Paisios authored
When an object that is aria-owned by another object is re-parented as a layout object we remove any aria-owned children mappings it may have in the AXRelationCache, in addition to the mapping to its aria-owning parent. However, we don't remove any mappings from its parent to the removed object from the AXRelationCache. After the children of its parent will have been marked as requiring an update, the AXRelationCache will try and unmap the parent's existing owned children before adding the new ones. During the unmap process, we check if any of the previous children are already owned by another object, in order to skip removing them from the cache if so. However, we forget to check whether any of the previous children has been removed from the cached because it has been re-parented and its AxID has been re-used because its the same DOM node that has been provided with a layout object. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 934529 Change-Id: I298d396987f444d061a2f2324580726e987a739b Reviewed-on: https://chromium-review.googlesource.com/c/1485064Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#635187}
-
Koji Ishii authored
Following bot results are included. 15512 15515 15525 15533 15546 15561 15579 15582 15590 15597 15603 15609 15618 15628 15641 15648 15650 15651 15652 15668 15670 15674 15679 15684 15691 15698 15701 15703 15715 8 lines were removed and 9 lines were deflaked by consecutive results since 15651. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I8c16a3cb1f4ee33c527192b69f917f96cc03e19a Reviewed-on: https://chromium-review.googlesource.com/c/1481182Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#635186}
-
Elly Fong-Jones authored
This change removes: quick-unlock-pin quick-unlock-pin-signin and removes the old constants for quick-unlock-fingerprint, which is already gone. Bug: 935613 Change-Id: I30338572d5f06737f7f1ab37aafe0616f8386869 Reviewed-on: https://chromium-review.googlesource.com/c/1487251 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#635185}
-
bsheedy authored
Ensures that VrShell.nativeIsDisplayingUrlForTesting() gets called on the UI thread. Not doing so was causing issues for https://chromium-review.googlesource.com/c/chromium/src/+/1478358. Bug: 934351 Change-Id: I42be8a69107758d5fb8b1fa5960a9dbec2dbef89 Reviewed-on: https://chromium-review.googlesource.com/c/1483732 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#635184}
-
Gary Kacmarcik authored
This moves the display scanning code to always be in the DesktopCapturerProxy (DCP). Previously, it was located in the DesktopSessionAgent (DSA) for Windows and in the DCP for Mac. The change to record the display id along with the geometry info broke Windows because that info was calculated in the DSA, but not available in the DCP. By moving all the display scanning into the DCP, this problem is fixed. This also removes the duplicate code and increases the likelihood that it2me will "just work". This works because, on Windows Me2me, the DSA serves as the ClientSessionController, and passes the message across the process boundary to the real ClientSessionController. Bug: 915411 Change-Id: Iecdd827b82c5e75e4a493f31cc31a6555388d4ca Reviewed-on: https://chromium-review.googlesource.com/c/1485016Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#635183}
-
Aditya Keerthi authored
Currently, RenderThreadImpl::RendererIsHidden() is implemented by keeping track of the total number and the number of hidden RenderWidgets in a renderer. If there is a non-zero amount of RenderWidgets and the two numbers are equal, RendererIsHidden() will return true. However, the current implementation is broken, as it does not account for the existence of inactive RenderWidgets. Inactive widgets refer to widgets that are created to support out-of-process iframes, but that do not represent actual widgets. These widgets exist with the sole purpose of maintaining state. Consequently, this widgets are never explicitly marked as hidden or visible, they are simply considered "frozen". This behaviour effects the implementation of RendererIsHidden(), as each time an inactive RenderWidget is created, the total number of RenderWidgets is incremented. However, those widgets will never be marked as hidden, and there will always be a difference between the total number and the number of hidden widgets. As a result, renderers that contain inactive widgets are incorrectly considered visible. Note that RenderProcessHostImpl already has information regarding a renderer's backgrounded and visibility state, using ChildProcessLauncherPriority. Rather than computing this information twice, we can forward the information from the browser process to the renderer process. The existing SetProcessBackgrounded IPC was modified to SetProcessState, now taking a RenderProcessState enum as a parameter. The process can be marked visible, hidden or backgrounded. Depending on the state transition, RenderThreadImpl calls OnRendererHidden, OnRendererVisible, OnRendererBackgrounded and OnRendererForegrounded at the appropriately. The new approach resolves a flaw in the current approach to determine renderer visibility and ensures that we have a single source of truth regarding a renderer's backgrounded and visibility state. Bug: 927440 Change-Id: Ib5aa60cd515443e17a0be691c211721caaf573ac Reviewed-on: https://chromium-review.googlesource.com/c/1448742 Commit-Queue: Aditya Keerthi <adityakeerthi@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#635182}
-
Lukasz Anforowicz authored
This CL fixes a problem where the last committed origin of RenderFrameHost was never set after document.write cancels an initial navigation in a subframe or in a popup. In addition to running the new regression tests, I also manually tested that the repro steps from https://crbug.com/932067 no longer hit the bug - in particular, the console output included both "onupgradeneeded" and "onsuccess". Bug: 932067 Change-Id: If1f031b988005e498a3515abe3137680db35ea0e Reviewed-on: https://chromium-review.googlesource.com/c/1480670Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#635181}
-
Koji Ishii authored
This patch fixes lines to break in the following conditions: 1. When wrappable elements appear inside of nowrap elements. 2. When wrappable spaces after nowrap appear inside of nowrap elements. 3. When non-space break opportunities appear after nowrap. fast/text/whitespace/018.html improves but still doesn't pass. It doesn't pass in Edge/Gecko, and at least some of what it expects look questionable. Further investigation is deferred to future CLs. Bug: 920177 Change-Id: Ieba4d446b818120f423b87a7f4a44b3c63a9d995 Reviewed-on: https://chromium-review.googlesource.com/c/1477629 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#635180}
-
Alan Cutter authored
Bug: 788051 Change-Id: I4f8c1775eecec9fccd13e6e1ca495dba2d30f823 Reviewed-on: https://chromium-review.googlesource.com/c/1485614 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#635179}
-
Elly Fong-Jones authored
This change assigns: enable-explicit-dma-fences overlay-strategies tint-gl-composited-content to chromeos-gfx@google.com and marks them all as non-expiring. These flags are used for graphics debugging in ChromeOS production builds. Bug: None Change-Id: I062dd408c8b2a2bd814798227e1ad41a1e2c7692 Reviewed-on: https://chromium-review.googlesource.com/c/1486872 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#635178}
-
Michael Lippautz authored
Previous graph: * MediaElementAudioSourceNode -> Handler -root-> HTMLMediaElement New graph: * MediaElementAudioSourceNode -> HTMLMediaElement -> MediaElementAudioSourceNode * Handler -weak-> HTMLMediaElement The previous layout would yield in a cycle when HTMLMediaElement could reach (through JS) the MediaElementAudioSourceNode. The new layout computes liveness on the main thread and make the handler on the audio thread dependent on this liveness. This works as the AudioNode are eagerly disposed and the weak reference in handler thus has the same liveness as HTMLMediaElement. In both approaches objects are collected as soon as MediaElementAudioSourceNode is unreachable. Bug: 928781, 843903, 404577 Change-Id: I968f76b78efdeb6e0fd0ee42fd8baecd403e3e4f Reviewed-on: https://chromium-review.googlesource.com/c/1482453Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#635177}
-
Christian Biesinger authored
Originally added in https://crrev.com/c/1327746 Also fixes a typo in one of the tests from that patch. R=mstensho@chromium.org Bug: 934936 Change-Id: Ib079171549853a21d5bcdd05dabb461c4a1e492c Reviewed-on: https://chromium-review.googlesource.com/c/1483946 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#635176}
-
Xiaocheng Hu authored
Bug: 935629 Change-Id: I8a3c83a027dff593756897b0332dd047da0c6e2d Tbr: xiaochengh@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/1487173Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635175}
-
Mike Reed authored
Bug: skia:8773 Change-Id: Icb42a9604f44c342eb18a974068ba0584dc3a740 Reviewed-on: https://chromium-review.googlesource.com/c/1476972Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#635174}
-
Steven Bingler authored
Change-Id: I2bb4ee0d3676dc29dda4de7424ab418637f59803 Reviewed-on: https://chromium-review.googlesource.com/c/1483450Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#635173}
-
Min Chen authored
Bug: 934953 Change-Id: I031a8aa7fd12057515c92d966d4255fd0e7c0a8f Reviewed-on: https://chromium-review.googlesource.com/c/1483815 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#635172}
-
Katie D authored
Missed changing function name in one place, in https://chromium-review.googlesource.com/c/1480542. Bug: 905419 Change-Id: I38c174a4899b163c58ebc99ff0fd995fb7c6c9b5 Reviewed-on: https://chromium-review.googlesource.com/c/1484580Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#635171}
-
Richard Townsend authored
A future CL will introduce a HTML parser which doesn't use the HTMLParserScheduler. This CL moves PumpScheduler outside so it can be re-used by this new parser. No behaviour changes are expected. Bug: 901056 Change-Id: I096e379f1c4adcd9ce221c241c322415995298a0 Reviewed-on: https://chromium-review.googlesource.com/c/1456013Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#635170}
-
John Delaney authored
This is a reland of 4eb465c4 Original change's description: > Measure main frame bytes and main frame ad bytes per-page > > Measure the amount of bytes directly loaded in the main frame by the > page. Record separately the total number of ad bytes loaded in the main > frame. Main frame ad bytes per page are currently recorded in > PageLoad.Clients.Ads.Resource.Bytes.TopLevelAds, but this only accounts > for network bytes. > > Rather than adding more counters to AdsPLMO, main frame data will > be stored in a separate FrameData object to reduce repetition. It > makes sense at this point to also refactor all page bytes counts to > a frame data object. This will help compartmentalize the two classes. > This change should be a no-op to existing metrics. > > Bug: 919122 > Change-Id: I83839cea1d01e375bb8d2a088be69d0911119966 > Reviewed-on: https://chromium-review.googlesource.com/c/1478091 > Commit-Queue: John Delaney <johnidel@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634320} Bug: 919122 Change-Id: I10bc30f171e4afcb7c5ed146a336848a0c5ec338 Reviewed-on: https://chromium-review.googlesource.com/c/1486372 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#635169}
-
Raymond Toy authored
When a source node has been scheduled to stop but is subsequently disconnected so that it's not reachable from the destination, final processing of the node wasn't getting done, so that we think the node is still active. Implement HandleStoppableSourceNode which checks for active nodes to see if the current time is past the stop time. If so, cleanup of the node is scheduled, freeing this finished node and allowing it to be collected. Two tests added (one for OscillatorNode and one for ConstantSourceNode). Also verified the repro case from the bug shows that the nodes are collected. Bug: 717528 Test: internals/constant-source-stopped-gc.html, internals/oscillator-stopped-gc.html Change-Id: I7e8797abc9ba553b4f459db95f6ad6c8939dabf3 Reviewed-on: https://chromium-review.googlesource.com/c/1474989Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#635168}
-
Reid Kleckner authored
crrev.com/631831 removed remote_application_details.h and now check_gn_headers.py is complaining. TBR=joedow@chromium.org Change-Id: Id752208b1a524a98cd0947743ebbffccabe03563 Reviewed-on: https://chromium-review.googlesource.com/c/1487231Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#635167}
-
Guido Urdaneta authored
LocalVideoCapturerSource is complex and independent enough that it should have its own file. Moreover, MediaStreamVideoCapturerSource is generic and works with other types of capturer sources. This change will facilitate maintenance of LocalVideoCapturerSource and will simplify Onion Soup since it makes MediaStreamVideoCapturerSource have fewer dependencies on content. Bug: 921006 Change-Id: Ib4afeb776fc13f41fe44240e921ff429ab7084fb Reviewed-on: https://chromium-review.googlesource.com/c/1483082Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#635166}
-
Robert Ma authored
Bug: 935208 Change-Id: Ie5e73c7fd01c46d7f033c9f2ed5522c35926bd3f Reviewed-on: https://chromium-review.googlesource.com/c/1485492 Auto-Submit: Robert Ma <robertma@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#635165}
-
Lukasz Anforowicz authored
All renderer-initiated navigations should specify an |initiator_origin| (CommonNavigationParams::initiator_origin is a base::Optional to accomodate browser-initiated navigations and some extension APIs which need to distinguish between no origin VS a unique origin). Bug: 919144 Change-Id: I91ad5a2ecc1ac81c7f13f16f6eb281f814866411 Reviewed-on: https://chromium-review.googlesource.com/c/1474091 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#635164}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2cba890d. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 359fd7da "[PE] Fix rendering issue with effect escaping in pre-CompositeAfterPaint" 3685447d "[WPT] Move subresource_path from generator to referrer-policy-test-case.js" 4ea68472 "Creates an ICE transport object at DTLS transport initialization." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ic6ad6e1bbb8387c4fabffe7908395702b906b63b Reviewed-on: https://chromium-review.googlesource.com/c/1486673Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635163}
-
Alex Clarke authored
Instead of a linked list of EmptyQueuesToReload we use a single atomic bit per TaskQueueImpl. Sampling the atomic flag is inherently racy wrt SequenceManagerImpl::ReloadEmptyWorkQueues. This is OK however thanks to the WorkDeduplicator which spots if a PostTask (and possibly a SetReloadFlag) occurred while DelayTillNextTask was running. Improves SequenceManagerPerfTest.PostImmediateTasks_OneQueue/3 by about 6% on Linux. Change-Id: I61943c6a3bd4fc96f063b94217767fc899962c4e BUG: 901345, 897751 Reviewed-on: https://chromium-review.googlesource.com/c/1474656 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#635162}
-
Xiaocheng Hu authored
Bug: 935607 Change-Id: Idca5f854c7cc85741d4fcbe2db5e9c12bcab08dd NoTry: True Tbr: xiaochengh@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1486719Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635161}
-
liberato@chromium.org authored
VideoResourceUpdater can't currently convert hw VideoFrame resources into sw planes in sw comspositing mode, since it isn't given a context provider to use for the conversion. This CL causes it to fall back to software video decoding in that case. Note that adding support to VideoResourceUpdater isn't terribly difficult, but might be crashy. The rough sketch is here: https://chromium-review.googlesource.com/c/chromium/src/+/1483680 Bug: 932879 Change-Id: I3b05e17fce40b9095de7eb6bc5ef64645a69a11b Reviewed-on: https://chromium-review.googlesource.com/c/1484073Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#635160}
-
Chris Hall authored
Comment had a 'not' which was likely a mistake, the Add*Attribute methods all remove the attribute if it already exists before adding. R=aboxhall,dmazzoni Change-Id: Iaf0bc259ba8c6e9f64f4b443935ff01979ca893d Reviewed-on: https://chromium-review.googlesource.com/c/1485613 Auto-Submit: Chris Hall <chrishall@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#635159}
-