GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150843 0039d316-1c4b-4281-b951-d872f2087c98

Removes support for v8Locale. ChromeOS has already moved to new v8Intl.

BUG=28604
TEST=v8Locale should not exist. ChromeOS should build properly.


Review URL: https://chromiumcodereview.appspot.com/10837152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150842 0039d316-1c4b-4281-b951-d872f2087c98

CrOS Aura: Fix pinning Chrome Web Store to Launcher

When requesting to load the extension icon, we now check whether the ext. resource is empty. If so, we request DONT_CACHE (instead of CACHE). Caching fails two DCHECKS when the ext. resource is empty. Also the key involved in caching would be an empty string when the ext. resource is empty.

Earlier solution, later abandoned (reverted):
Icons are not required in extension or app manifests. Modified
Extension::HasCachedImage and Extension::SetCachedImage to not fail
a DCHECK nor to cache an image, if the ExtensionResource is empty.

See also the now obsolete: http://codereview.chromium.org/10823115/

BUG=124865
TEST=Click on Apps icon in the Launcher;
     Right click on Chrome Web Store;
     Select Pin to Launcher;
     Observe no DCHECK on Debug build on linux desktop

Review URL: https://chromiumcodereview.appspot.com/10830123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150841 0039d316-1c4b-4281-b951-d872f2087c98

We are missing some debugging flags in the make which prevents us from getting
debugging info in the SDK.

This CL only affects the SDK (specifically SDK examples and user libs) and not Chrome.

BUG=141227
R=binji@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10832208

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150840 0039d316-1c4b-4281-b951-d872f2087c98

The script currently does not run tries, since the try mechanism rejects
the entire request if any requrest bot is bogus.
Review URL: https://chromiumcodereview.appspot.com/10854028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150839 0039d316-1c4b-4281-b951-d872f2087c98

Import pyauto_errors.JavascriptRuntimeError so that
AddDomMutationObserver can raise it correctly.

BUG=None
TEST=
NOTRY=True


Review URL: https://chromiumcodereview.appspot.com/10824237

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150837 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10830236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150836 0039d316-1c4b-4281-b951-d872f2087c98

The implementation of this method is basically noop in platforms other than ios and it is put in the header file; this change adds inline annotation to avoid duplicate symbol link error on other platforms.

BUG=NONE


Review URL: https://chromiumcodereview.appspot.com/10837182

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150831 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150829 0039d316-1c4b-4281-b951-d872f2087c98

used.

TBR=jamescook@chromium.org
BUG=chromium-os:33223,chromium:129052
TEST=built

Review URL: https://chromiumcodereview.appspot.com/10831236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150828 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10834193

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150827 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141639
TEST=Visual, if you look carefully.


Review URL: https://chromiumcodereview.appspot.com/10855078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150826 0039d316-1c4b-4281-b951-d872f2087c98

Properly notify the handle verifier when a handle is passed around. This CL fixes issues introduced by r150508.

BUG=134694


Review URL: https://chromiumcodereview.appspot.com/10855061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150825 0039d316-1c4b-4281-b951-d872f2087c98

The number of calles of FindEntryByPathSync() is reduced from 17 to 15.

BUG=10831212,126634
TEST=Copying a file (and a hosted document) on Drive works before from file manager

Review URL: https://chromiumcodereview.appspot.com/10828219

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150824 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150823 0039d316-1c4b-4281-b951-d872f2087c98

control: http://codereview.chromium.org/10836175/
Review URL: https://chromiumcodereview.appspot.com/10832223

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150822 0039d316-1c4b-4281-b951-d872f2087c98

Sync the client (Chrome) version of the SafeBrowsing csd protocol buffer definition with the version we have on the server.

This change adds a couple of fields which will be used by Chrome on
Android to display custom SafeBrowsing warnings.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/10827231

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150821 0039d316-1c4b-4281-b951-d872f2087c98

I added another histogram into the DuplicateContentResourceHandler. The histogram is meant to keep track of all the ResourceTypes of resources coming through the handler to see the distribution of ResourceTypes.
R=gavinp@chromium.org,darin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10831201

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150820 0039d316-1c4b-4281-b951-d872f2087c98

R=robertshield
BUG=None
TEST=None
NOTRY=TRUE

Review URL: https://chromiumcodereview.appspot.com/10854042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150819 0039d316-1c4b-4281-b951-d872f2087c98

The README has been updated with info about preview.py.

BUG=141034

Review URL: https://chromiumcodereview.appspot.com/10831225

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150818 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141497
TEST=test works again


Review URL: https://chromiumcodereview.appspot.com/10855074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150817 0039d316-1c4b-4281-b951-d872f2087c98

While the use of gmock's InSequence is unfortunate (read: brittle tests), it does help capture the call sequences for various pipeline operations. You may notice in the original incarnation of these tests in http://codereview.chromium.org/10828045/ didn't need InSequence. I'm aiming to remove InSequence after I'm done rewriting the guts of Pipeline.

BUG=110228

Review URL: https://chromiumcodereview.appspot.com/10832197

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150816 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Compiles

Review URL: https://chromiumcodereview.appspot.com/10828052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150814 0039d316-1c4b-4281-b951-d872f2087c98

Failing on the ChromiumOS Dbg Bots.

BUG=141497,139117
TEST=none
TBR=jochen

Review URL: https://chromiumcodereview.appspot.com/10837188

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150813 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 77592af8b97f753a7b2540e613166759c6fc314c.

TBR=yoz@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10828221

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150810 0039d316-1c4b-4281-b951-d872f2087c98

BUG=130377
TEST=chrome/ppapi/tests/test_image_data.cc
Review URL: https://chromiumcodereview.appspot.com/10823211

----
Failing on mac 10.6 bots:
http://build.chromium.org/p/chromium/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/25635


TBR=nfullagar@google.com
Review URL: https://chromiumcodereview.appspot.com/10832218

TBR=dalecurtis@google.com
Review URL: https://chromiumcodereview.appspot.com/10826226

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150809 0039d316-1c4b-4281-b951-d872f2087c98

Since the devtools server is running for each content shell browser process, the user doesn't specify a server port anymore. Instead I let the system pick. This made it necessary to plumb the data back from net::HttpServer.

For now I only added Windows and Linux UI. Mac UI will be done later.

BUG=90445
Review URL: https://chromiumcodereview.appspot.com/10837177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150808 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10837185

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150807 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139699

Review URL: https://chromiumcodereview.appspot.com/10832185

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150806 0039d316-1c4b-4281-b951-d872f2087c98

Revert 150799 - sync skia's gyp file directory, in preparation for sharing .gypi files between skia and chrome
Review URL: https://chromiumcodereview.appspot.com/10823256

TBR=reed@google.com
Review URL: https://chromiumcodereview.appspot.com/10837187

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150805 0039d316-1c4b-4281-b951-d872f2087c98

Support navigation with keyboard shortcuts as other platform(GTK).

BUG=90445
TEST=


Review URL: https://chromiumcodereview.appspot.com/10832221

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150804 0039d316-1c4b-4281-b951-d872f2087c98

refactor EnumerateDevices to make it a persistent request.
After the requester calls EnumerateDevices, it should expect new device list as initial response and whenever devices are changed.
A new method StopEnumerateDevices is also added to allow the request to stop device enumeration.

It also includes corresponding change in Pepper since EnumerateDevices contract is changed (http://codereview.chromium.org/10837064/).
This patch keeps current Pepper API, while using the new API of EnumerateDevices from MediaStreamDispatcher. 
Pepper calls StopEnumerateDevices when it receives the first enumerated result. 

A new Pepper API will be created in a separate patch to make EnumerateDevices persistent. 

BUG=137799
Review URL: https://chromiumcodereview.appspot.com/10828230

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150803 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140306

Review URL: https://chromiumcodereview.appspot.com/10826189

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150802 0039d316-1c4b-4281-b951-d872f2087c98

Deselect should maintain previously selected wallpaper and select guest user should use default guest wallpaper


Deselect user from user pod should not set the wallpaper to a white background. It should use whatever wallpaper is showing.

It also fix the problem when selecting guest user pod, the wallpaper didn't set to default guest user wallpaper.


BUG=141259, 141226

Review URL: https://chromiumcodereview.appspot.com/10827203

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150801 0039d316-1c4b-4281-b951-d872f2087c98

Some of these directories are currently excluded from the license check. This change fixes the metadata where required and removes them from PRUNE_PATHS.

Other directories contain third-party code, but aren't in directories named 'third-party', so aren't checked by the license tool by default. This change fixes the metadata where required and adds them to ADDITIONAL_PATHS.

To avoid adding to about:credits licenses for modules that don't ship as part of the product, this change also introduces a special 'NOT_SHIPPED' value for the 'License File' field.

This will simplify the process of adding a tool to check license compatibility for the Android WebView build.

BUG=138921

Review URL: https://chromiumcodereview.appspot.com/10830201

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150800 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10823256

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150799 0039d316-1c4b-4281-b951-d872f2087c98

TBR=brettw@chromium.org
TEST=fixes checkperms on Linux builder.

Review URL: https://chromiumcodereview.appspot.com/10855077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150798 0039d316-1c4b-4281-b951-d872f2087c98

I am not simply reverting 147297 because that CL included some js code for correctly handling errors in the ASP case, and that is still useful should the user decide to go back to ASPs.

Change that disabled OTP on trunk:
https://chromiumcodereview.appspot.com/10800010
http:crrev.com/147297

BUG=137772,141636
TEST=Signing in should ask for OTP instead of ASP.

Review URL: https://chromiumcodereview.appspot.com/10800010

Review URL: https://chromiumcodereview.appspot.com/10818006

TBR=rogerta@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10834251

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150797 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139117,141497
TEST=WebNavigationApiTest.*


Review URL: https://chromiumcodereview.appspot.com/10826224

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150796 0039d316-1c4b-4281-b951-d872f2087c98

In the process, refactors the Instant code so that all logic is
centralized in the InstantController. InstantLoader now merely
forwards messages between InstantController and the renderer.

BUG=none
R=sky@chromium.org
TEST=Instant works as before when enabled from chrome://settings/.

Review URL: https://chromiumcodereview.appspot.com/10836031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150795 0039d316-1c4b-4281-b951-d872f2087c98