GitLab

Makes the "IsSystemThemeDistinctFromDefaultTheme()" detection logic
compatible with non-GTK (ie. Aura) Linux.  It moves the check out of
sync code and into the ThemeService so this kind of bug will be less
likely to recur if the themes logic changes again.

Re-enables an integration test that was disabled during the transition
to Aura.

BUG=304554,392934

Review URL: https://codereview.chromium.org/388563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282491 0039d316-1c4b-4281-b951-d872f2087c98

Pending libvpx updates
BUG=392309

R=scherkus@chromium.org

Review URL: https://codereview.chromium.org/376283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282490 0039d316-1c4b-4281-b951-d872f2087c98

There is a typo in the output element of the "Build Remoting Webapp unittest.html" action.  The current output element refers to a non-existent location.  As a result, ninja invoke the action on every build run.

I also removes exclude-js from the input element, as there is no need to re-invoke the action if the content of an excluded script is modified.

BUG=392834

Review URL: https://codereview.chromium.org/385713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282486 0039d316-1c4b-4281-b951-d872f2087c98

This builds on https://codereview.chromium.org/385653002/ .

Many functions in Python's logging module grab a lock internally. Some
appear to do so before converting the provided message to a string via
its __str__ method.

Calling an object's __str__ method before calling a logging funciton
allows anything called by the __str__ method to log without the risk of
hitting a deadlock.

BUG=392869

Review URL: https://codereview.chromium.org/383793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282485 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that enrollment recovery really only is triggered when the
machine id can be accessed.

BUG=389481

Review URL: https://codereview.chromium.org/386643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282484 0039d316-1c4b-4281-b951-d872f2087c98

We probably shouldn't allow this, but it's currently relied upon by the
WebAudio code and cleaning it up is a big deal: http://crbug.com/151051.

The AudioRendererSink interface does not specify that after Stop() the
sink can no longer be used.  All other sinks allow restart, so this is
just keeping with the pace.

In http://crrev.com/280502 I conflated the one-stop-only mechanics of
AudioRenderer:Stop() with those of AudioRendererSink::Stop().  This
patch reverts that mistake while keeping the fixes for the original
issue.

BUG=389204,390977
TEST=new unittest.

Review URL: https://codereview.chromium.org/381823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282481 0039d316-1c4b-4281-b951-d872f2087c98

As requested by frankf:
  https://codereview.chromium.org/351603002/#msg2
  https://codereview.chromium.org/358993003/#msg9
  https://codereview.chromium.org/371813005/#msg8

BUG=267773

Review URL: https://codereview.chromium.org/377373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282480 0039d316-1c4b-4281-b951-d872f2087c98

ChromeRenderViewObserver::CapturePageInfo is a relic. It hasn't captured page content for indexing for about a year now (r212459), and the fancy footwork to avoid re-indexing isn't needed any more.

BUG=371151
TEST=everything still works

Review URL: https://codereview.chromium.org/363293005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282479 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromedriver:843
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/385753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282477 0039d316-1c4b-4281-b951-d872f2087c98

We recently moved to new directory structure, and while refactoring
we missed to specify localname for the module. crreve.com/282209

NOTRY=true
BUG=393057

Review URL: https://codereview.chromium.org/389453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282476 0039d316-1c4b-4281-b951-d872f2087c98

Pre-CL for https://codereview.chromium.org/379943003/:

We need to delay load "setupapi.dll" as device/bluetooth now uses "SetupDiGetDevicePropery" which is available on Vista+ only.

BUG=388016
TBR=keybuk@chromium.org, armansito@chromium.org

Review URL: https://codereview.chromium.org/387673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282472 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Observe an onvoiceschanged event handler gets called when...
- built-in extension tts engine loads.
- webstore-based extension engine is enabled/disabled.

Review URL: https://codereview.chromium.org/361363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282471 0039d316-1c4b-4281-b951-d872f2087c98

Previously, errors in the user-defined callback function could break the
internal state of the pageCapture API. This is now mitigated by reading
and nulling the callback before using it, and only access the properties
of the response object after verifying that it is not void.

Also fixed a typo in an error message.

BUG=392800
TEST=Manually the tests from the bug report (or read the source code and
infer from the changes that the reported bugs have been fixed.)

Review URL: https://codereview.chromium.org/384653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282470 0039d316-1c4b-4281-b951-d872f2087c98

Fixes an issue when using managed_install=1 with Android L.

BUG=None
NOTRY=true
TBR=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/380343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282469 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282468 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/996861db81bec78480b83e7a77f18fd5a786320e..fd429991e99d18cbb956f91b7c347440b39684c1

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=jcgregorio@google.com
BUG=

Review URL: https://codereview.chromium.org/388493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282467 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282464 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391927
TESTED=manual testing libyuv compiles with clang-cl
R=rnk@chromium.org

Review URL: https://codereview.chromium.org/380813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282463 0039d316-1c4b-4281-b951-d872f2087c98

All existing actions can now be accessed from ActionRunner
directly, so this file has outlived its usefulness.

BUG=361809

Review URL: https://codereview.chromium.org/356833010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282462 0039d316-1c4b-4281-b951-d872f2087c98

Both internals pages were displaying the partition path, which is bogus
when in Incognito mode - both just store everything in memory. Track
and pass the state along from context -> internals helper -> JS -> HTML
and show a label instead. (Screenshots in the bug.)

BUG=388168
R=michaeln@chromium.org

Review URL: https://codereview.chromium.org/388583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282460 0039d316-1c4b-4281-b951-d872f2087c98

Removes most remaining dependencies from core sync/ files on
sync/notifier/.

There are some internal_api/public files that still reference
sync/notifier.  These will be dealt with after sync/notifer/ has been
moved to components/invalidation/.

BUG=259559

Review URL: https://codereview.chromium.org/377413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282458 0039d316-1c4b-4281-b951-d872f2087c98

It was removed from the gyp build a while back.

BUG=353602
TEST=none
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/384833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282457 0039d316-1c4b-4281-b951-d872f2087c98

R=skyostil,brianderson
BUG=346230

Review URL: https://codereview.chromium.org/340743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282456 0039d316-1c4b-4281-b951-d872f2087c98

when we hadn't. To avoid errors like this I'm splitting tab_animation_
into two distinct fields. Less possibility of error this way.

BUG=387371
TEST=none

Review URL: https://codereview.chromium.org/382693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282455 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/387723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282454 0039d316-1c4b-4281-b951-d872f2087c98

In r273854 we may have removed an indirect pathway used to close open
autofill popups when the associated web_contents undergoes a zoom
change. This CL replaces that by directly registering the
ChromeAutofillClient as a ZoomObserver, allowing it to directly
react to zoom events.

BUG=392412

Review URL: https://codereview.chromium.org/377423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282453 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Assignment inside conditional
* Possibly-uninitialized local variable
* Signedness mismatch

This also contains a small number of other cleanups/simplifications to
nearby code.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/382613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282451 0039d316-1c4b-4281-b951-d872f2087c98

R=enne

Review URL: https://codereview.chromium.org/387613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282449 0039d316-1c4b-4281-b951-d872f2087c98

Most everything but android and cdm code has been converted. Next step is to break these up into smaller BUILD.gn files per subdirectory.

All hail GN. orz

BUG=none
R=brettw@chromium.org, dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/268713006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chrome-os-partner:29764
R=jennyz@chromium.org
TBR=jennyz@chromium.org

Review URL: https://codereview.chromium.org/382923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282447 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the bug that resourceless software mode not
dirtying the draw properties.

This allows OutputSurface::ForcedDrawToSoftwareDevice to be
removed. And merged the valid_for_tile_management parameter
into resourceless_software_draw. This effectively reverses
the last bool parameter on SetExternalDrawConstraints.

BUG=391829

Review URL: https://codereview.chromium.org/376683004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282445 0039d316-1c4b-4281-b951-d872f2087c98

This also breaks a few more misc. bonds between chrome/common and component_updater.

BUG=371463

Review URL: https://codereview.chromium.org/375973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282444 0039d316-1c4b-4281-b951-d872f2087c98

All hail GN. oRZ

BUG=none
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/380483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282443 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391203

Review URL: https://codereview.chromium.org/387543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282442 0039d316-1c4b-4281-b951-d872f2087c98

BUG=389016

Review URL: https://codereview.chromium.org/369893008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282441 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375379
NOTRY=true
R=aurimas@chromium.org

Review URL: https://codereview.chromium.org/379963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282440 0039d316-1c4b-4281-b951-d872f2087c98

Implements support for receiving nudges from the non-blocking sync
engine.  When a non-blocking sync type requests a commit, it will also
send a request to the sync scheduler asking it to schedule
a sync cycle for some time in the future.

Adds some of the code required to support refresh requests, but does not
include an interface to allow clients of the non-blocking sync API to
access it.

Adds basic support for the initial download nudge.  When a non-blocking
type starts syncing for the first time, it sends a request to the
scheduler asking it to download any data available on the server.  This
allows it to complete initial sync quickly and without putting the
scheduler into configure mode.  For now, this looks like
a refresh request in the sync protocol.  This will be changed in
a future CL.

BUG=351005

Review URL: https://codereview.chromium.org/375023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282439 0039d316-1c4b-4281-b951-d872f2087c98

New components:
- rappor
- data_reduction_proxy
- captive_portal
- translate
- usb_service
- web_modal

Removes the _IMPLEMENTATION define for web_modal. It is unused (it is a static library, not a component).

Adds third_party/cld and third_party/cld_2 BUILD files.

Separates out the include dir setting of "//" and the root gen directory so. cld_2 needed to not have this due to base file name conflicts.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/382663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282438 0039d316-1c4b-4281-b951-d872f2087c98

being misused in such a way that makes it impossible to add other trusted
extension context types. It's also a nice cleanup, though requires rewriting
the ExtensionAPI::IsPrivileged function with sightly different semantics.

BUG=391944
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/377753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282437 0039d316-1c4b-4281-b951-d872f2087c98

MSVC evaluates functions in a different order, causing test failures.

> Remove media::AudioRendererImpl::now_cb_ and clean up tests.
> 
> It's no longer needed as of r282376.
> 
> BUG=370634
> R=rileya@chromium.org
> 
> Review URL: https://codereview.chromium.org/380893002

TBR=scherkus@chromium.org

Review URL: https://codereview.chromium.org/380303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282436 0039d316-1c4b-4281-b951-d872f2087c98