GitLab

Takes a snapshot of the visible tab when the tab grid
is shown. This CL does not retrieve the corresponding
images in the tab grid.

BUG=686770

Review-Url: https://codereview.chromium.org/2971093002
Cr-Commit-Position: refs/heads/master@{#486021}

Bug: 730031
Change-Id: I488847d6df8a6da9d3f78676d062e1f5117e4a67
Reviewed-on: https://chromium-review.googlesource.com/566953
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486020}

This CL adds Zucchini utilities related to parsing and printing, along
with tests. Details:
- LimitedOutputStream: Used for printing error messages without
  flooding console with output.
- AsHex: Syntactical sugar for iostream-printing of hex values.
- PrefixSep: Syntactical sugar for iostream-printing of list of values.
- EatChar and StrictUInt: Parse command line parameters. Will be used to
  parse imposed matches.

Bug: 729154
Change-Id: I232295419172a5b52cbb39cea89009a2e03fb684
Reviewed-on: https://chromium-review.googlesource.com/567265
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486019}

Bug: 738510
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I0095d6f8d4959d1fa797f64ff45885348780bed8
Reviewed-on: https://chromium-review.googlesource.com/552763Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486018}

Fix a crash in renderer activity logging introduced by revision
7ab1596c. Specifically,
ListValue::Set() accepts null values, but ListValue::Append does not.
Substitute Append(nullptr) with Append(base::MakeUnique<base::Value>()).
Add a regression unittest.

Bug: 740866
Change-Id: Icf72435960e7ad8f3544f8e74d44977db2f9fe4f
Reviewed-on: https://chromium-review.googlesource.com/567243Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486017}

We now have a shiny new toy, which simplifies the code a bit.

BUG=None

Change-Id: I1ffc10027238762364eae99f743a194159a99d8d
Reviewed-on: https://chromium-review.googlesource.com/568027
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486016}

This reverts commit 50a17030.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=741761

Original change's description:
> VR: Cancel stay_hidden animation when VR UI is ready to be shown.
> 
> This replaces hugely hacky behaviour where we assumed Chrome would start
> up within 500ms because we couldn't figure out how to cancel the
> activity animation, with only moderately hacky behaviour where we start
> a noDisplay activity in order to cancel the animation.
> 
> The duration of the stay_hidden animation has been increased to the max
> duration of 10s, giving chrome ample time to start up while hidden and
> then cancel the animation.
> 
> Bug: 740004
> Change-Id: I0f2c8daac7b0f692f0ed5a9bbfefe29a925811e6
> Reviewed-on: https://chromium-review.googlesource.com/567336
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: Yash Malik <ymalik@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485980}

TBR=mthiesse@chromium.org,dtrainor@chromium.org,ymalik@chromium.org

Change-Id: Iee18c28ac9a047e0e281ed6fe5defd0cde1eec9a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 740004
Reviewed-on: https://chromium-review.googlesource.com/568638Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486015}

This reverts commit 15617f0b.

Reason for revert:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/8765

base_unittest MemoryDumpManagerTest.PostTaskForSequencedTaskRunner is crashing due to the data race.

Original change's description:
> memory-infra: Move TracingObserver to service/
> 
> The memory tracing observer along with peak detector and periodic
> scheduler should live in service/resource_coordinator since the peak
> detector needs to know about the OS dump providers.
> The tests were moved in previous CL.
> 
> BUG=728199
> 
> Change-Id: Ib4934421d1d057fd7d062258179f17d3ca8209f7
> Reviewed-on: https://chromium-review.googlesource.com/554280
> Commit-Queue: Primiano Tucci <primiano@chromium.org>
> Reviewed-by: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485968}

TBR=dcheng@chromium.org,primiano@chromium.org,dpranke@chromium.org,hjd@chromium.org,xunjieli@chromium.org,ssid@chromium.org

Change-Id: Iea202e6099216cb8ccad38d6f0d5354ea82643fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 728199
Reviewed-on: https://chromium-review.googlesource.com/568401Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486014}

1) Fix the typo of referencing a benchmark
2) Create a dummy option object for benchmark 
to instantiate story_set (multitab benchmark CreateStorySet(..) need the option)

TBR=eyaich@chromium.org

Change-Id: I5dce266b64a274d48862e1bcd8305b4a078ce6d8
Reviewed-on: https://chromium-review.googlesource.com/568283
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#486013}

metadata includes a signature for the disk image itself, in addition to code
signatures on individual executables within the archive. This change records
the DMG signature for uploading via SafeBrowsing pings.

BUG=627605

Review-Url: https://codereview.chromium.org/2934373002
Cr-Commit-Position: refs/heads/master@{#486012}

Power Level Monitoring is disabled on Android so WasRecentlyAudible
will always return false. Therefore we should not perform this
check on Android.

BUG=740105

Change-Id: I7a4fb85e95472d95b0efc9336a46e49ea00f36f8
Reviewed-on: https://chromium-review.googlesource.com/567935
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486011}

Bug: 693772
Change-Id: Ib49f0324ae91ca4c2f44554fb3316d3c43c57417
Reviewed-on: https://chromium-review.googlesource.com/566896Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486010}

This reverts commit 428a5f83.

Reason for revert:
Has build 61.0.3155.0 which contains this CL.

Original change's description:
> aw: Remove emulator gpu blacklist
> 
> Prefer to use dynamic look up required EGL extensions instead.
> This is only temporary, to get an official build to allow for manual
> testing. Will revert after.
> 
> Bug: 738109
> Change-Id: Iaea11e2b6118fa46d1d5ff2d205b1df65e482fd6
> Reviewed-on: https://chromium-review.googlesource.com/567422
> Reviewed-by: Selim Gurun <sgurun@chromium.org>
> Commit-Queue: Bo Liu <boliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485737}

TBR=boliu@chromium.org,sgurun@chromium.org

Change-Id: I87fc12af9fc2fda4dcc917f4d56a93746ee4aa67
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 738109
Reviewed-on: https://chromium-review.googlesource.com/568159Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Commit-Queue: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486009}

If the token service has already a refresh token for the authenticated
account before this account is signed in to Chrome, then |OnRefreshToken|
notification will not be called after |GoogleSigninSucceeded|.

This CL changes the UserPolicySigninService to handle the case when the
refresh token is already present when |GoogleSigninSucceeded| is fired.

See bug for the link to the design document.

Bug: 733226
Change-Id: I17e3ef8285b4012e125951c5a38e1851a09c9c9a
Reviewed-on: https://chromium-review.googlesource.com/559538
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486008}

AudioParamMap is a map-like container owned by AudioWorkletNode object.
It associates the name of a parameter to the actual AudioParam object.

Spec: https://webaudio.github.io/web-audio-api/#idl-def-AudioParamMap

Bug: 736781
Change-Id: I063add4281954036b90442dc5c4a6e9c50145e41
Reviewed-on: https://chromium-review.googlesource.com/548239
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486007}

Previously segments were always pulled from the back of the vector
and only the last value was checked before deciding to create a
new segment.  This allows small buffers on the end to repeatedly
result in shmem creation. 

Instead switch to a first fit algorithm where segments are kept in
sorted order by size. Also switch to choosing the minimum segment
size based on the resolution and clear between flushes.

Since we may be allocating a few more buffers now, the code will
expire unused ones if they haven't been used after 1024 frames.

tl;dr: reductions in memory of ~42% at 360p or below, ~8% at 480p,
~10% at 720p, equivalent at 1080p, ~38% at 2160p. So this should
save us 10s to 100s of KBs on the most common media.

Old results:
360p, dec: 1228217, alloc: 409600 (4), d/a: 2.99858, size: 102400
480p, dec: 3170779, alloc: 536946 (5), d/a: 5.90521, size: 102400
720p, dec: 9402525, alloc: 1191936 (8), d/a: 7.88845, size: 102400
1080p, dec: 16676052, alloc: 2052082 (9), d/a: 8.12641, size: 102400
2160p, dec: 63319373, alloc: 3051283 (18), d/a: 20.7517, size: 102400

New results:
360p, dec: 1228217, alloc: 237568 (6), d/a: 5.16996, size: 32768
480p, dec: 3170779, alloc: 495616 (7), d/a: 6.39765, size: 49152
720p, dec: 9402525, alloc: 1077248 (8), d/a: 8.72828, size: 73728
1080p, dec: 16676052, alloc: 2043904 (9), d/a: 8.15892, size: 98304
2160p, dec: 63319373, alloc: 1888256 (7), d/a: 33.5333, size: 196608

BUG=none
TEST=manual playback of clips with varying resolutions.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Change-Id: I6df3dd41320dcc70dfd23224767b107806b0942e
Reviewed-on: https://chromium-review.googlesource.com/565007
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486006}

The client side of the command buffer handles emulation of the
GL_PACK_ROW_LENGTH parameter.

TEST=conformance2/reading/read-pixels-pack-parameters.html

BUG=602688

Change-Id: Id3415d56c565504b423f2a32d91d865274667037
Reviewed-on: https://chromium-review.googlesource.com/567430
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486005}

This includes a change to the compiler that removes the ability to
suppress availability warnings by redeclaring functions. The new way
to suppress warnings is to enclose the function reference in an
"if (@available)" block.

Previous CLs have cleaned up the code base to use the new way of
suppressing warnings (see bug).

Bug: 735328
Change-Id: I340ac5c16df837d13fa5b8885e9f5a8e7bcf8e0c
Reviewed-on: https://chromium-review.googlesource.com/566280
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486004}

Adds horizontal scrolling to the VR browser scrolling test, so now both
vertical and horizontal scrolling using the Daydream controller are
tested.

This should hopefully be good enough to remove the need to manually test
basic scroll functionality.

Bug: 728779
Change-Id: I882755999485b6610fcd865953cb1b06ca47edd5
Reviewed-on: https://chromium-review.googlesource.com/567033Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486003}

There are two reasons for this CL:
1. This layout test times out on virtual/gpu/ test suite.
2. The layout test is uses testharness, but it has an expected file.

The reason for #1 is that when the test creates a canvas, it uses the
canvas's default width and height which is 300*150, and call getImageData
and putImageData on the entire canvas with the same color. We really don't
need that, this CL sets the width and height to be 5 and should test the
same thing.

The reason for #2 is that this layout test has several small tests, the
name for each small tests are the same, and testharness apparently
doesn't like that.

This CL removes a line in the expectation file, and some -expected.txt

Bug: 709009
Change-Id: I14935f4bf84a8cabb5a9aa56dc502b5d02768b77
Reviewed-on: https://chromium-review.googlesource.com/568079Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486002}

This CL removes the DB thread reference from IOSChromePasswordStoreFactory and
replaces it with an appropriate CreateSequencedTaskRunnerWithTraits call.

Bug: 689520
Change-Id: I19c7a6473f7d26ce192005e25b297c878716bee5
Reviewed-on: https://chromium-review.googlesource.com/567984Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486001}

Some files excluded from jumbo compilation seems to compile just
fine in jumbo so this patch removes their special treatment.

Review-Url: https://codereview.chromium.org/2971153002
Cr-Commit-Position: refs/heads/master@{#486000}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2964383002
Cr-Commit-Position: refs/heads/master@{#485999}

Store all client hints as enum values. This makes client hints
more structured. As a bonus, it reduces the chances of bugs by
adding compile-time checks, and makes it easier to introduce
new client hint values.

In forthcoming CLs, this structured list of client hints would be
persisted on the disk on the browser side.

Bug: 735518
Change-Id: I5e743398ed1c3484def527543fabcfad99a0f14a
Reviewed-on: https://chromium-review.googlesource.com/563555
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485998}

This reverts commit fd8b83c8.

Reason for revert: This CL breaks password_settings_eg_test, we might need to update the tests so they use the new A11y labels. Though I'm not sure if there's more than that. 

Original change's description:
> Password settings on iOS: use Title Case
> 
> Most of setting headers in the passwords seciton on iOS already use Title Case,
> except for the headers of the saved and blacklisted lists of passwords.
> 
> This CL fixes that by creating new strings for iOS settings inside
> ios/chrome/app/strings/ios_strings.grd. Previously the code used shared strings
> from the password_manager component (components/password_manager_strings.grdp).
> That string was also used by the old (non-MD) desktop settings, which have
> already been deprecated. The MD settings on desktop use the Title Case as iOS
> should as well, but the MD settings strings are consistently saved in
> chrome/app/settings_strings.grdp, where they cannot be shared with iOS.
> 
> The CL creates the new string instead of sharing the one from MD settings,
> because sharing has no benefit (on no build both strings are included, so no
> storage spared) and has the drawback of binding the style of both strings
> forever together.
> 
> The CL does not remove the component string yet. The old desktop settings code
> is still in the codebase, and the shared string (used only by the old settings)
> should be deleted once those old settings are deleted.
> 
> The CL was approved in https://chromium-review.googlesource.com/c/567181. This
> is a verbatim copy of that CL, but re-uploaded after Gerrit issues prevented me
> to actually land the original one. Hence I'm TBR-in lpromero@ who approved the
> original.
> TBR=lpromero@chromium.org
> 
> Bug: 740952
> Change-Id: I455b8f2a5edd1089916a7b87f20eddc3b274a2b7
> Reviewed-on: https://chromium-review.googlesource.com/567930
> Reviewed-by: Vaclav Brozek <vabr@chromium.org>
> Commit-Queue: Vaclav Brozek <vabr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485912}

TBR=vabr@chromium.org,lpromero@chromium.org

Change-Id: I41a5e01b086a1643a6f72f3934d5cfea6ceb57b6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 740952
Reviewed-on: https://chromium-review.googlesource.com/568387Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485997}

This CL implements IAccessibleTable, IAccessibleTable2 and
IAccessibleTableCell on AXPlatformNodeWin. It forwards calls on
BrowserAccessibilityWin to this implementation.

BUG=703369

Review-Url: https://codereview.chromium.org/2969113002
Cr-Commit-Position: refs/heads/master@{#485996}

TBR=yzshen@chromium.org

Bug: 
Change-Id: I3bb44ece86db7599af6d92ef2ec89012dd4846dc
Reviewed-on: https://chromium-review.googlesource.com/568535Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485995}

These were found as part of the effort to re-enable android unused
resources lint checks. The actual lint checks will be re-enabled once
platform-tools is rolled to version 26+.

Bug: 731159
Change-Id: I6c977371acac62b4301fe71def8e0f0313238a73
Reviewed-on: https://chromium-review.googlesource.com/566893Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485994}

This reverts commit 05d4aefd.

Reason for revert: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/89457

Original change's description:
> Roll src/third_party/skia/ c4176a2fa..46b654df9 (6 commits)
> 
> https://skia.googlesource.com/skia.git/+log/c4176a2fa5aa..46b654df9e70
> 
> $ git log c4176a2fa..46b654df9 --date=short --no-merges --format='%ad %ae %s'
> 2017-07-11 ethannicholas converted GrSimpleTextureEffect to sksl
> 2017-07-12 reed remove unreachable perspective code for imageshader
> 2017-07-11 liyuqian Always enable Analytic AA for rects
> 2017-07-11 bsalomon Make SmallPathOp a non-legacy GrMeshDrawOp
> 2017-07-12 robertphillips Address ASAN complaint
> 2017-07-11 robertphillips Plumb raw GrMipLevel* down instead of SkTArray<GrMipLevel> in GrGpu
> 
> Created with:
>   roll-dep src/third_party/skia
> 
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, see:
> http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
> 
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> TBR=ethannicholas@chromium.org
> 
> Change-Id: Iaa9f8d51a32084c0449c65b80ca70b9c7e9635f5
> Reviewed-on: https://chromium-review.googlesource.com/568220
> Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485962}

TBR=skia-deps-roller@chromium.org,ethannicholas@chromium.org

Change-Id: I5f8e6f95396c3e8f5258c23deb3edf076ae4e352
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/568439Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485993}

There are two implementation of AddStringToDigestor. Beyond being
one more than needed, they also conflict in jumbo builds.

This patch merges the two AddStringToDigestor and removes the
conflicting files from the jumbo exclusion list.

Review-Url: https://codereview.chromium.org/2800133003
Cr-Commit-Position: refs/heads/master@{#485992}

Server previews recently stopped working with introduction of
CL 544586 when previews_to_allow is 0 or UNSPECIFIED. This CL
adds a check to guards its use if UNSPECIFIED.

The chromedriver lite.py integration tests failed prior to these fix
but succeed with it patched in.

Bug: 741067
Change-Id: If206200688fac4fabca6df7186f4981623276487
Reviewed-on: https://chromium-review.googlesource.com/567559Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485991}

Add a browsertest for the navigation handle getting lost when doing rapid navigations after a session restore.

BUG=738177

Review-Url: https://codereview.chromium.org/2976643002
Cr-Commit-Position: refs/heads/master@{#485990}

This CL cleans the Keyboard Accessory View (KAV) situation for the
web toolbar to support InputAssistantItems on iPad (1).
In particular, this CL:
- Removes keyboard_accessory_view.*.
  Now only new_keyboard_accessory_view.* is used.
- Removes HardwareKeyboardWatcher because it only works when there is
  a KAV (crbug.com/740898).
- Removes |-locationBarChanged| because it would only be used to
  record MobileFirstTextInOmnibox (crbug.com/740611).
- Removes the |_keyboardAccessoryView| ivar. It was used when the KAV
  was not laid out with auto layout and had multiple modes.

(1) https://docs.google.com/document/d/1pWfwHEeCNeWgkDjawJiDoEf93gkDV9usINcYDyXvwcY/edit#heading=h.sku52p315l4d

Bug: 738106, 708341, 740611
Change-Id: If6e509de3e6d57f0347b3e355b91af16bd055adb
Reviewed-on: https://chromium-review.googlesource.com/567087Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485989}

Bug: 738593
Change-Id: Iafbe191294f825b9d1446c3a51c3f7ce527b9831
Reviewed-on: https://chromium-review.googlesource.com/564279Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485988}

Change-Id: If4e7534748cd2149916dad57b21d875666aa5b71
Reviewed-on: https://chromium-review.googlesource.com/567026Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Scott Nichols <nicholss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485987}

When a refresh token was replaced by a new one, it was not revoked, and
essentially leaking.

OnRefreshTokenRevoked() is not called because it is used to signal that
the associated account no longer has a valid token. This is not the case
here, since the token is immediately replaced by a new one.

Bug: 735898
Change-Id: If0f9777543d574a00084d7dd6b67209aeacf150c
Reviewed-on: https://chromium-review.googlesource.com/568303Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485986}

post initial load."

This time, land behind a command line flag (the same one that controls
the stop/reload icon toggles). Also, it was noted that this change could
make certain actions feel sluggish, such as pressing "Save Changes" in
monorail, because the throbber feedback was no longer immediate. To
address this, only suppress switches to the throbber that occur right
after the throbber has stopped showing. That way, as long as you press
"Save Changes" a few seconds after the page has finished loading, the
throbber feedback will be immediate, but we'll still get the suppression
of flicker at the end of a page load (visible, for example, on yahoo.com,
cyclingnews.com, or when navigating to an extension/app/etc. in the
Chrome Web Store).

Bug: 734104
Change-Id: I5a59fc16785e3a5f30b40a72f03c5c6a67e66337
Reviewed-on: https://chromium-review.googlesource.com/567800Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485985}

BUG=chromium:717394

Review-Url: https://codereview.chromium.org/2979703002
Cr-Commit-Position: refs/heads/master@{#485984}

The |cursor_view| in Textfield uses the default construction of view, 
where the cursor is always initialized as visible. It was showing in some 
default location before landing fix of bug crbug.com/734988. It now shows 
in the beginning of the Textfield instead. As a result, an unwanted text 
cursor is displayed to users. In this change, after calling  
UpdateCursorViewLocation, UpdateCursorVisibility is added to adjust the 
visibility.  

Bug: 739607
Change-Id: I3243857173c9c30cb0da11eae31f030e26771bd7
Reviewed-on: https://chromium-review.googlesource.com/564019Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485983}

"cancelPendingPrintRequest" does not actually exist. Remove the call to
this function from the PrintPreviewUI.

BUG=740264

Review-Url: https://codereview.chromium.org/2974183002
Cr-Commit-Position: refs/heads/master@{#485982}