GitLab

The test result looks worse than it used to, but not bad
enough to fix. It's a super marginally situation, so not
too important.

There may still be failures on Mac Debug after this. The
test previously showed Release/Debug differences. The
expectation may need to be re-added with narrowed conditions.

R=fmalita@chromium.org
BUG=390488,636475

Review-Url: https://codereview.chromium.org/2254833002
Cr-Commit-Position: refs/heads/master@{#412583}

This wrapping was added in r355704 because at the time mojo::Callbacks
did not like being freed on arbitrary threads, which would happen if
they were passed to //device/usb APIs. This is no longer an issue so the
wrapping can be removed.

BUG=None

Review-Url: https://codereview.chromium.org/2236683002
Cr-Commit-Position: refs/heads/master@{#412582}

BUG=637923
TBR=sky@ for trivial services/ui/gpu update.

Review-Url: https://codereview.chromium.org/2248973005
Cr-Commit-Position: refs/heads/master@{#412581}

Revert of Enable promotion of RenderPassDrawQuads to CALayers. (patchset #1 id:1 of https://codereview.chromium.org/2249923003/ )

Reason for revert:
Has correctness issues on 10.10:

https://bugs.chromium.org/p/chromium/issues/detail?id=638526

Original issue's description:
> Reland of Enable promotion of RenderPassDrawQuads to CALayers. (patchset #1 id:1 of https://codereview.chromium.org/2238113002/ )
>
> Reason for revert:
> Landing again, since main performance regressions have been dealt with.
>
> https://bugs.chromium.org/p/chromium/issues/detail?id=636884
>
> Original issue's description:
> > Revert of Enable promotion of RenderPassDrawQuads to CALayers. (patchset #1 id:1 of https://codereview.chromium.org/2234513002/ )
> >
> > Reason for revert:
> > Causes performance regressions when there are a lot of filters. Probably needs better IOSurface caching.
> >
> > https://bugs.chromium.org/p/chromium/issues/detail?id=636884
> >
> > Original issue's description:
> > > Enable promotion of RenderPassDrawQuads to CALayers.
> > >
> > > BUG=581526
> > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
> > >
> > > Committed: https://crrev.com/c48bb2ddd6f847130de7956e9bf7e350d875b10c
> > > Cr-Commit-Position: refs/heads/master@{#411055}
> >
> > TBR=ccameron@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=581526
> >
> > Committed: https://crrev.com/314269eae868551bb560428fce916863e4d60cb4
> > Cr-Commit-Position: refs/heads/master@{#411505}
>
> TBR=ccameron@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=581526
>
> Committed: https://crrev.com/777aa9fb4a33a0ae71ed5363225d52ed807a5ff0
> Cr-Commit-Position: refs/heads/master@{#412144}

TBR=ccameron@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=581526

Review-Url: https://codereview.chromium.org/2255833002
Cr-Commit-Position: refs/heads/master@{#412580}

|content::| to "ui/events/blink"

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits|
from |content::| to "ui/events/blink", so they can be accessed by
|InputHandlerProxy|.

Adds dependency:
  1. content/common : ui/events/blink
  2. content/renderer/mus : ui/events/blink

Concerns:
  1. Moving |WebInputEventTraits| seems redundant since we only
need |WebInputEventTraits::Delete/Clone|.
  2. "ui/events/blink" seems to be static linked, so it will cause each
file to grow.

After discussion with dtapuska@ and tdresser@ it doesn't really
matter whether we move it entirely or only part of it.
So the easier solution is to move it entirely for now, and handle it
later if it's actually causing problems.

BUG=637393

Review-Url: https://codereview.chromium.org/2240983003
Cr-Commit-Position: refs/heads/master@{#412579}

Hides ToS when Arc is managed, disable checkbox for Location Service
and B&R in case they are managed. Apply managed settings on each Arc
start.

TEST=Manually on device.
BUG=b/30469058
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2235293002
Cr-Commit-Position: refs/heads/master@{#412578}

Background tracing: Add config option to control whether or not to stop reactive tracing when a repeated trigger occurs

R=simonhatch@chromium.org
BUG=637129

Review-Url: https://codereview.chromium.org/2247033005
Cr-Commit-Position: refs/heads/master@{#412577}

https://boringssl.googlesource.com/boringssl/+log/96e1a25943ba98e644d71d23dd30815704da77a7..405da489002ca1fe5ee3f1c390b207d468f4a8e7

BUG=none

Review-Url: https://codereview.chromium.org/2253103002
Cr-Commit-Position: refs/heads/master@{#412576}

https://chromium.googlesource.com/skia.git/+log/d24ee1419f17..8d3f92a92be7

$ git log d24ee1419..8d3f92a92 --date=short --no-merges --format='%ad %ae %s'
2016-08-17 csmartdalton Make GrReducedClip's gen ID only apply to the element list
2016-08-17 robertphillips Kick the can down the road a bit w.r.t. fuzzer complaint
2016-08-17 bsalomon Fix tile bitmap code in SkGpuDevice to compute correct local coords.
2016-08-17 bsalomon Minor cleanup of GP classes in GrOvalRenderer
2016-08-17 msarett Modify SkPngCodec to recognize 565 images from the sBIT chunk

BUG=635787

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=robertphillips@google.com

Review-Url: https://codereview.chromium.org/2251113002
Cr-Commit-Position: refs/heads/master@{#412575}

There's a crash in
AutoplayUmaHelper::onVisibilityChangedForVideoMutedPlayMethod().
It might be possible that the callback is called after the observer
is released. This CL adds additional nullcheck to avoid the crash.

This CL also fixes a possible memory leak by changing
wrapPersistent to wrapWeakPersistent.

BUG=638595

Review-Url: https://codereview.chromium.org/2249223003
Cr-Commit-Position: refs/heads/master@{#412574}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6c31b348..a33f1674

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2255803002
Cr-Commit-Position: refs/heads/master@{#412573}

//components/test_runner signals that a test is finished if it receives a
notificationDone signal from Javascript at a time when (a) it is waiting for
such a signal, (b) it does not think it is in the midst of a load, and (c) it
has no work in its queue. However, the definition of (b) is flawed for
browser-side navigation. The current definition for being in the midst of a
load is the time between WebFrameClient::didStartProvisionalLoad() being called
and WebFrameClient::didStopLoading() being called. However, for browser-side
navigations there is a period of time when navigation is ongoing but the
renderer has not yet received the didStartProvisionalLoad() callback. If
//components/test_runner gets a notificationDone signal during this period, it
can erroneously think that the test is finished.

This CL fixes the problem by having WebFrameTestProxy implement
WebFrameClient::didStartLoading(), teaching //components/test_runner to be
aware of the time period where a navigation is occurring, and using that as
input to decide whether a test is finished when it receives a notificationDone
signal.

Review-Url: https://codereview.chromium.org/2147633003
Cr-Commit-Position: refs/heads/master@{#412572}

Currently this layout test canvas/philip/tests/2d.text.draw.text.metrics.html
gets different results on linux platform comparing to all the other
platforms. But when I open the test file directly on chrome, the result
is exactly the same as the results on the other platform. The reason is
that the content shell test runner has some flags enabled.

This CL rewrite the test in a more reasonable way.

BUG=277215

Review-Url: https://codereview.chromium.org/2232243002
Cr-Commit-Position: refs/heads/master@{#412571}

An ANGLE revert requires this test to be expected to fail.

BUG=638313
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2249823004
Cr-Commit-Position: refs/heads/master@{#412570}

Revert of cc: Move data to LayerTree from LayerTreeHost. (patchset #9 id:160001 of https://codereview.chromium.org/2183403002/ )

Reason for revert:
Invalid cast breaks CFI build, which is shipping on Linux soon

Original issue's description:
> cc: Move data to LayerTree from LayerTreeHost.
>
> Move bulk of the tree state from LayerTreeHost to LayerTree. The
> LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
> to push the corresponding properties to LayerTreeImpl during commit.
>
> BUG=628683
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
>
> Committed: https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b
> Cr-Commit-Position: refs/heads/master@{#412413}

TBR=enne@chromium.org,loyso@chromium.org,vollick@chromium.org,piman@chromium.org,khushalsagar@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=628683

Review-Url: https://codereview.chromium.org/2253143002
Cr-Commit-Position: refs/heads/master@{#412569}

This was there so that crash client id could be cleared.
However, this was being called out of MetricsService::Stop(),
so it needed a special provision to not clear it when shutting
down, for example.

This change instead removes all of that plumbing and makes the
id clearing happen in the same place we clear the UMA client id,
when the user actually opts-out (as opposed to just metrics service
stopping). Unifies the prefs manipulation that happens when the
user changes the setting into a helper function.

As a follow up change after this lands, we should also make that
function be called on iOS.

BUG=635669
TBR=sgurun@chromium.org,nyquist@chromium.org,noyau@chromium.org

Review-Url: https://codereview.chromium.org/2248793002
Cr-Commit-Position: refs/heads/master@{#412568}

TBR=lushnikov@chromium.org
BUG=638618

Review URL: https://codereview.chromium.org/2253133002 .

Cr-Commit-Position: refs/heads/master@{#412567}

Do not automatically maximize the window if the maximized bounds can be controlled by the client in Tablet mode (aka Maximized mode), which all arc windows are.

The maximizing in tablet mode will be handled on arndroid side.

BUG=635899
TEST=MaximizeModeWindowManagerTest.DontMaximizeClientManagedWindows

Review-Url: https://codereview.chromium.org/2249953002
Cr-Commit-Position: refs/heads/master@{#412566}

Revert of Android: Make the spare renderer accessible to all Chrome tabs. (patchset #7 id:120001 of https://codereview.chromium.org/2199393002/ )

Reason for revert:
New test WarmupManagerTest#testCreateAndTakeSpareRenderer failing on 3 different bots:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35784
https://build.chromium.org/p/chromium.android/builders/KitKat%20Tablet%20Tester/builds/5165
https://build.chromium.org/p/chromium.android/builders/Jelly%20Bean%20Tester/builds/5527

Original issue's description:
> Android: Make the spare renderer accessible to all Chrome tabs.
>
> In Custom Tabs, an external application can "warm up" Chrome. This
> creates and initializes a spare renderer, and has been found to be a
> significant optimization for loading performance.
>
> This patch moves the spare renderer logic out of Custom Tabs, and makes
> it accessible and useful for regular navigations in Chrome. Note that
> this patch doesn't add new call sites for the spare renderer creation.
>
> BUG=633964
>
> Committed: https://crrev.com/f7ce563033df1df90b314e4f727596c93c2b3d6d
> Cr-Commit-Position: refs/heads/master@{#412510}

TBR=yusufo@chromium.org,mariakhomenko@chromium.org,lizeb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633964

Review-Url: https://codereview.chromium.org/2254863002
Cr-Commit-Position: refs/heads/master@{#412565}

BUG=522043

Review-Url: https://codereview.chromium.org/2243353002
Cr-Commit-Position: refs/heads/master@{#412564}

BUG=249976

Review-Url: https://codereview.chromium.org/1920433003
Cr-Commit-Position: refs/heads/master@{#412563}

Currencies such as JPY do not have fractions by default. If the
website is using web payments with an amount like "500", then
UI should show only "500", without any decimals.

BUG=638480

Review-Url: https://codereview.chromium.org/2246923006
Cr-Commit-Position: refs/heads/master@{#412562}

Remove expectations for compositing/overflow/reflected-overlay-scrollbars-should-appear-without-compositing.html

The test seems to be passing consistently.

TBR=vollick@chromium.org
BUG=396775,636475

Review-Url: https://codereview.chromium.org/2253893002
Cr-Commit-Position: refs/heads/master@{#412561}

This reverts commit 7ce3db95 and relands
22f8a43c without changes. I believe the
failure would be fixed after the bots are clobbered.

Original Description:

This class handles output protection query and request in the browser
process on all platforms. On ChromeOS, it delegates the operations on
the hardware displays to OutputProtectionDelegate. On other platforms,
it does not check hardware displays. On all platforms, it checks
whether there is any network link and adds it to the existing link mask.

This class will also be used to implement mojo OutputProtection service
on all platforms.

This CL also updated PPAPI cdm adapter and PPAPI code to enable output
protection calls on all platforms. A unit test is added via external
clear key tests.

TBR=ddorwin@chromium.org, jrummell@chromium.org, oshima@chromium.org, bbudge@chromium.org
BUG=592122, 589618, 623214
TEST=Added new tests.

Review-Url: https://codereview.chromium.org/2094903005
Cr-Commit-Position: refs/heads/master@{#412560}

Add policy declaration for using of Location Service

BUG= b/30469058
TEST=policy and browser tests extended.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

patch from issue 2225933002 at patchset 20001 (http://crrev.com/2225933002#ps20001)

Review-Url: https://codereview.chromium.org/2243513002
Cr-Commit-Position: refs/heads/master@{#412559}

https://chromium.googlesource.com/skia.git/+log/ff863bc550a8..d24ee1419f17

$ git log ff863bc55..d24ee1419 --date=short --no-merges --format='%ad %ae %s'
2016-08-17 fmalita [SVGDom] Add <line> support
2016-08-17 robertphillips Cast for fuzzer complaint
2016-08-17 jvanverth Add alternative ambient shadow method to Android shadow sample
2016-08-17 halcanary SkPDF: pull out SkPDFMakeCIDGlyphWidthsArray.cpp
2016-08-17 rmistry Add gerrit config lines to cq.cfg

BUG=637187

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=robertphillips@google.com

Review-Url: https://codereview.chromium.org/2253933002
Cr-Commit-Position: refs/heads/master@{#412558}

Revert of Implement BluetoothGattNotifySession::Stop on Android (patchset #33 id:640001 of https://codereview.chromium.org/2051333004/ )

Reason for revert:
Suspect of breaking https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/2450

[345/345] BluetoothRemoteGattCharacteristicTest.GattCharacteristicValueChanged (TIMED OUT)
6 tests timed out:
    BluetoothRemoteGattCharacteristicTest.GattCharacteristicValueChanged (../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1931)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession (../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1026)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_Multiple (../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1067)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_OnIndicate (../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1039)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_OnNotifyAndIndicate (../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1054)
    BluetoothRemoteGattCharacteristicTest.StartNotifySession_Reentrant_Success_Success (../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1217)

Original issue's description:
> Implement BluetoothGattNotifySession::Stop on Android
>
> This change enables the stopNotifications function for remote GATT
> characteristics on Android. In order to do so, two distinct refactorings have been done;
>
> 1) The session classes have been simplified so that platform specific versions are no longer required. All code that previously used BluetoothGattNotifySession[Mac|Win|BlueZ] now simply use the base BluetoothGattNotifySession class.
>
> 2) BluetoothRemoteGattCharacteristic::StartNotifySession and StopNotifySession have been rewritten so that all the code for keeping track of the different session objects and the notification state sits in the base class. Inheriting classes should no longer override these two functions, but instead override the much simpler SubscribeToNotifications and UnsubscribeFromNotifications.
>
> BUG=584370
>
> Committed: https://crrev.com/d41af3adfd8500c81c827ab03ed2736909cf1ee8
> Cr-Commit-Position: refs/heads/master@{#412498}

TBR=ortuno@chromium.org,rkc@chromium.org,msarda@chromium.org,sacomoto@chromium.org,tommyt@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584370

Review-Url: https://codereview.chromium.org/2241263005
Cr-Commit-Position: refs/heads/master@{#412557}

Changes match the logic in SourceHighlighter in the same file and will
result in UI showing message akin to 'No source file available'. This is fine
as already the same happens for other source files in bundled extensions.

BUG=627896

Review-Url: https://codereview.chromium.org/2245143004
Cr-Commit-Position: refs/heads/master@{#412556}

As a safety mechanism, this CL introduces throttling mechanism for
thumbnail fetching for articles for you on mobile NTP. Per default, the
quota is unlimited but can be easily decreased by finch.

Since all thumbnail requests are user initiated (by scrolling below
the fold), the CL also extends the throttler to support separate quota
for interactive requests (previously called "forced").

Lastly, it fixes a bug that the callback passed in in FetchSuggestionImage() got called with a wrong id (with the ID of the snippet "[url]" and not with the ID of the suggestion "[category_id]|[url]").

BUG=627073

Review-Url: https://codereview.chromium.org/2227973002
Cr-Commit-Position: refs/heads/master@{#412555}

BUG=636523

Review-Url: https://codereview.chromium.org/2230183005
Cr-Commit-Position: refs/heads/master@{#412554}

Apply the same resizing method to the reference result as is used on the test.

R=ajuma@chromium.org
BUG=245556,636475

Review-Url: https://codereview.chromium.org/2232373003
Cr-Commit-Position: refs/heads/master@{#412553}

- Remove m_button field from PlatformMouseEvent as
    there was one in WebPointerProperties.
- Remove duplicate PlatformMouseEvent::MouseButton
    and WebScrollbarBehavior::Button enums and use
    WebPointerProperties::Button enum instead.
- Making WebPointerProperties::Button an enum class.

- Also cleanup related target for pointerevents. The related target for all pointerevents (similar to mouseevent) should be null except for boundary events. So relatedTarget can be removed from some of the functions as they don't send boundary events.

BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

TBR=pfeldman@chromium.org

Review-Url: https://codereview.chromium.org/2227563003
Cr-Commit-Position: refs/heads/master@{#412552}

Clang warns about this.

BUG=82385
R=rnk@chromium.org
TBR=primiano

Review URL: https://codereview.chromium.org/2258503002 .

Cr-Commit-Position: refs/heads/master@{#412551}

WKWebView returns NSError if script evaluation result type is not
supported. Since all scripts are wrapped into anonymous function,
autofill should be wrapped too.

BUG=None

Review-Url: https://codereview.chromium.org/2242353002
Cr-Commit-Position: refs/heads/master@{#412550}

Move some files and unit tests from chrome/browser/spellchecker/ and
android-specific java code to the spellcheck component. This move
generally includes the android slice of spellchecker.

In particular in this patch:
 - move the relevant chrome/browser/spellchecker files and unit tests
 - move the android java files and create proper jni registrar
 - isolate spellcheck preference constants into separate files
 - properly initialize "java_object_initialization_failed_" in
   spellchecker_session_bridge_android.cc
 - update references in the code base
 - update and create build files

The main motivation behind the componentization of the spellcheck
feature is that we want to make it available in Android WebView.

Preceding spellcheck componentization patches:
[1] https://codereview.chromium.org/2166683003/
[2] https://codereview.chromium.org/2177343002/
[3] https://codereview.chromium.org/2198143002/

BUG=583616, 629609
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2244083002
Cr-Commit-Position: refs/heads/master@{#412549}

Use methods which returns id instead of deprecated methods which return
NSString. JS execution API returned NSString because that was the only
supported option from UIWebView. Now WKWebView returns id which should
be used everywhere.

BUG=595761

Review-Url: https://codereview.chromium.org/2247973002
Cr-Commit-Position: refs/heads/master@{#412548}

Cleaning fast/events media tests to use
testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Review-Url: https://codereview.chromium.org/2246223004
Cr-Commit-Position: refs/heads/master@{#412547}

An out-of-flow positioned object that "belongs" to a line may need to adjust
its block position after the line has been laid out, since the line may have
been pushed to the next fragmentainer by a pagination strut.

BUG=291616

Review-Url: https://codereview.chromium.org/2249853007
Cr-Commit-Position: refs/heads/master@{#412546}

This tool is meant for testing of NetworkChangeNotifier and ProxyConfigService.

R=mmenke

Review-Url: https://codereview.chromium.org/2253023002
Cr-Commit-Position: refs/heads/master@{#412545}

These were using an incorrect path to the shadow tests.

BUG=638323
TBR=kbr@chromium.org,zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2252083002
Cr-Commit-Position: refs/heads/master@{#412544}