- 19 Apr, 2017 40 commits
-
-
thakis authored
Now that blink lives in the src repo, there's no need to generate a separate LASTCHANGE file for it. The LASTCHANGE line makes it into the user agent. LASTCHANGE.blink used --git-hash-only to only have the git hash in there. Remove that now-unused flag and use version.py's -e flag to get the same effect for webkit_version.h Reverts parts of https://chromiumcodereview.appspot.com/14973005/ No intended behavior change. BUG=none Review-Url: https://codereview.chromium.org/1982423002 Cr-Commit-Position: refs/heads/master@{#465739}
-
mef authored
This reduces number of reads and reallocations if UrlRequest::Read has more data available. Change QuicTestServer to return simple response without HTTP/2 trailers, so it doesn't break the QuicHttpStream. BUG=706515 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:ios-simulator-cronet Review-Url: https://codereview.chromium.org/2776583004 Cr-Commit-Position: refs/heads/master@{#465738}
-
kkhorimoto authored
This CL disables EG synchronization when dealing with the onload JS dialog. BUG=711291 Review-Url: https://codereview.chromium.org/2825673003 Cr-Commit-Position: refs/heads/master@{#465737}
-
rdevlin.cronin authored
Similar to functions, API events can be restricted on a per-context basis. Apply the same deletion logic to them if they are unavailable in the given context. Modify APIBinding unittests to reflect this, and add more comprehensive tests in NativeExtensionBindingsSystem to test APIs that can be partially-available to websites. BUG=653596 Review-Url: https://codereview.chromium.org/2821793003 Cr-Commit-Position: refs/heads/master@{#465736}
-
rdevlin.cronin authored
Move custom request handling from registering a method in the APIBindingHooks to a delegate call to match CreateCustomEvent. Add a APIBindingHooksTestDelegate for use in unittests to avoid having a bunch of one-off subclasses. BUG=653596 Review-Url: https://codereview.chromium.org/2831453002 Cr-Commit-Position: refs/heads/master@{#465735}
-
takumif authored
We have a file in extensions/ [1] that depends on Media Router mojo definitions from chrome/browser/. To remove this dependency from extensions/ to chrome/browser/, this CL moves that file to chrome/renderer/, and Media Router mojo interfaces to chrome/common/media_router/mojo/. Media Router typemaps and related C++ structs are also moved to chrome/common/media_router/. [1] extensions/renderer/resources/media_router_bindings.js BUG=704958 Review-Url: https://codereview.chromium.org/2771413003 Cr-Commit-Position: refs/heads/master@{#465734}
-
michaelpg authored
and correct the component. BUG=none Review-Url: https://codereview.chromium.org/2821623002 Cr-Commit-Position: refs/heads/master@{#465733}
-
weidongg authored
Delay 100 ms before closing the window to give some time for rendering jobs to be done. BUG=649218 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2826753002 Cr-Commit-Position: refs/heads/master@{#465732}
-
lazyboy authored
The consumer ContentVerifyJob, calls this only once and ContentVerifier is ref counted, so this is a good thing to do. BUG=712945 Test=No visible changes expected. Review-Url: https://codereview.chromium.org/2824333003 Cr-Commit-Position: refs/heads/master@{#465731}
-
tedchoc authored
This removes the duplicate functionality in DeviceClassManager. BUG= Review-Url: https://codereview.chromium.org/2826203003 Cr-Commit-Position: refs/heads/master@{#465730}
-
robhogan authored
BUG=706324 Review-Url: https://codereview.chromium.org/2806123002 Cr-Commit-Position: refs/heads/master@{#465729}
-
krasin authored
In particular, it's a follow up to https://chromium-review.googlesource.com/472192. This CL is just to fix the bots. I will follow up with proper changes to the allocator which will eliminate the need for the blacklist entry. BUG=713293 Review-Url: https://codereview.chromium.org/2834513002 Cr-Commit-Position: refs/heads/master@{#465728}
-
bnc authored
This CL lands part of server change 153489255. BUG=488484 Review-Url: https://codereview.chromium.org/2829463002 Cr-Commit-Position: refs/heads/master@{#465727}
-
twellington authored
Revert of [Home] Close the BottomSheet when a URL is loaded on the NTP (patchset #1 id:1 of https://codereview.chromium.org/2829523002/ ) Reason for revert: Broke Lollipop Tester junit.framework.AssertionFailedError: Sheet should be at half height expected:<1> but was:<3> at org.chromium.chrome.browser.ntp.ChromeHomeNewTabPageTest.validateState(ChromeHomeNewTabPageTest.java:197) at org.chromium.chrome.browser.ntp.ChromeHomeNewTabPageTest.createNewTab(ChromeHomeNewTabPageTest.java:168) at org.chromium.chrome.browser.ntp.ChromeHomeNewTabPageTest.testCloseNTP_TwoTabs(ChromeHomeNewTabPageTest.java:92) at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:758) at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853) Original issue's description: > [Home] Close the BottomSheet when a URL is loaded on the NTP > > This ensures that a click on the doodle will close the BottomSheet. > > BUG=712607 > > Review-Url: https://codereview.chromium.org/2829523002 > Cr-Commit-Position: refs/heads/master@{#465604} > Committed: https://chromium.googlesource.com/chromium/src/+/2a80017ed38340c00d1d214a3a2445acf5a9ed05 TBR=mvanouwerkerk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=712607 Review-Url: https://codereview.chromium.org/2830743003 Cr-Commit-Position: refs/heads/master@{#465726}
-
xunjieli authored
File writes happen on a file thread. This CL waits for the file thread to flush writes to disk. BUG=712307 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2827673002 Cr-Commit-Position: refs/heads/master@{#465725}
-
proberge authored
BUG=500085 Review-Url: https://codereview.chromium.org/2824033003 Cr-Commit-Position: refs/heads/master@{#465724}
-
mark authored
ffe4c1018c1b net: Update Blink source code references e04194afd91d win: Wrap TerminateProcess() to accept cdecl patches on x86 74fddc3fed2a win: Wrap test::ChildLauncher::Start() in ASSERT_NO_FATAL_FAILURE() f487da4ff2c4 win handler: Move test targets to handler_test.gyp BUG=crashpad:179 Review-Url: https://codereview.chromium.org/2833533003 Cr-Commit-Position: refs/heads/master@{#465723}
-
ojan authored
BUG=713260 TBR=sullivan@chromium.org Review-Url: https://codereview.chromium.org/2834503002 Cr-Commit-Position: refs/heads/master@{#465722}
-
rogerm authored
Flakiness has expanded from just Windows and memory bots to Mac and Linux as well. Broadly disabling the test. BUG=641400 TBR=michaelpg@chromium.org Review-Url: https://codereview.chromium.org/2828063002 Cr-Commit-Position: refs/heads/master@{#465721}
-
ananta authored
The proposed fix is to notify the parent views when a child enables layering. The parent in this case the ScrollView overrides the newly added notification OnChildLayerChanged() and enables viewport layering. This ensures that the ring gets clipped. Longer term it seems like the focus ring should really be a property of the view and should not be instantiated by different controls all over the place. That for a later patchset. BUG=665412, 656198 TEST=Covered by test ViewObserverTest.ScrollViewChildAddLayerTest and ViewObserverTest.ChildViewLayerNotificationTest Review-Url: https://codereview.chromium.org/2813353002 Cr-Commit-Position: refs/heads/master@{#465720}
-
rogerm authored
BUG=713201 TBR=mkolom@yandex-team.ru, creis@chromium.org, sky@chromium.org, dgozman@chromium.org Review-Url: https://codereview.chromium.org/2829773002 Cr-Commit-Position: refs/heads/master@{#465719}
-
cwallez authored
https://chromium.googlesource.com/angle/angle.git/+log/b36e539..b812669 BUG= TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2832583002 Cr-Commit-Position: refs/heads/master@{#465718}
-
bnc authored
Retry request upon receiving a GOAWAY frame with error code NO_ERROR and with Last-Stream-ID lower than stream id corresponding to request. BUG=681477 Review-Url: https://codereview.chromium.org/2820163004 Cr-Commit-Position: refs/heads/master@{#465717}
-
dmazzoni authored
This change finishes support for AX_ACTION_HIT_TEST in AXHostDelegate so that you can send a hit test request on the root of the whole automation tree and get a hit test on either views or web content. Switches Select-to-speak to use this new API. A follow-up change will change the way select-to-speak works so that it sends the mouse event to the extension and the hit test comes from there, but this is a self-contained change that can land first. BUG=699617 Review-Url: https://codereview.chromium.org/2813083003 Cr-Commit-Position: refs/heads/master@{#465716}
-
nbishop authored
The three chrome help URL constants incorrectly used OFFICIAL_BUILD for a feature that should only be in Google-branded builds. BUG=none TEST=Build browser with is_official_build=true and target_os=chromeos. Click the help button in the system menu, verify it shows a support.google.com URL instead of the genius app. Review-Url: https://codereview.chromium.org/2825513002 Cr-Commit-Position: refs/heads/master@{#465715}
-
avayvod authored
BUG=678663,703441 Review-Url: https://codereview.chromium.org/2819273005 Cr-Commit-Position: refs/heads/master@{#465714}
-
martiniss authored
This reverts commit 1e2d5ea4. BUG=705135 Reason: Bot came back online Review-Url: https://codereview.chromium.org/2831693002 Cr-Commit-Position: refs/heads/master@{#465713}
-
xjz authored
BUG=712479 Review-Url: https://codereview.chromium.org/2825493005 Cr-Commit-Position: refs/heads/master@{#465712}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/121ef2b4a8c6..6939b1db033b $ git log 121ef2b4a..6939b1db0 --date=short --no-merges --format='%ad %ae %s' 2017-04-19 simonhatch Dashboard - Filter NaN values in /graph_json and /graph_revisions. 2017-04-19 kainino Mac: download numpy and cv2 from Cloud Storage Created with: roll-dep src/third_party/catapult BUG=711307 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Id2d7bc9cf780f8e0f6d9a78e5118fd5aff8ea955 Reviewed-on: https://chromium-review.googlesource.com/482179 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#465711}
-
ojan authored
virtual/sharedarraybuffer/fast/css/fontfaceset-check-platform-fonts.html is flaky on Windows. BUG=713094 TBR=ksakamoto Review-Url: https://codereview.chromium.org/2832593002 Cr-Commit-Position: refs/heads/master@{#465710}
-
nasko authored
Revert of Disable flaky WebNavigationApiTest.CrossProcessHistory. (patchset #1 id:1 of https://codereview.chromium.org/2790383002/ ) Reason for revert: What I believe was the underlying issue has been reverted, so it should be safe to reenable this test back. Original issue's description: > Disable flaky WebNavigationApiTest.CrossProcessHistory. > > TBR=nasko@chromium.org > BUG=708139 > > Review-Url: https://codereview.chromium.org/2790383002 > Cr-Commit-Position: refs/heads/master@{#461690} > Committed: https://chromium.googlesource.com/chromium/src/+/656fccff69eae8da012f0f83bcd3fc89214c5258 TBR=maxmorin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=708139 Review-Url: https://codereview.chromium.org/2830813002 Cr-Commit-Position: refs/heads/master@{#465709}
-
afakhry authored
If item get removed from the content pane, the buttons should always remain at the bottom. BUG=712539 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2833533002 Cr-Commit-Position: refs/heads/master@{#465708}
-
jdufault authored
This also renames the JS<->C++ API; C++ does not need to know about pin. BUG=623344 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2814863002 Cr-Commit-Position: refs/heads/master@{#465707}
-
mahmadi authored
Displays a PaymentMethodItem in the credit card form in order to identify the server card being edited. http://imgur.com/a/CM38f BUG=602666 Review-Url: https://codereview.chromium.org/2826593005 Cr-Commit-Position: refs/heads/master@{#465706}
-
spqchan authored
Revert of [Mac] Support for Touch Bar Customization (patchset #8 id:180001 of https://codereview.chromium.org/2814683005/ ) Reason for revert: Broke the 10.12 build Original issue's description: > [Mac] Support for Touch Bar Customization > > Implement customization support for the default touch > bar. Changed the item identifiers to reverse-DNS style format. > > BUG=710100 > > Review-Url: https://codereview.chromium.org/2814683005 > Cr-Commit-Position: refs/heads/master@{#464967} > Committed: https://chromium.googlesource.com/chromium/src/+/1ad3c00f56fbf19ecba52bdf0591ca7ad1098d3a TBR=rsesek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=710100 Review-Url: https://codereview.chromium.org/2831713002 Cr-Commit-Position: refs/heads/master@{#465705}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e6777487..bde4f053 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2830753002 Cr-Commit-Position: refs/heads/master@{#465704}
-
egdaniel authored
BUG= Review-Url: https://codereview.chromium.org/2825333003 Cr-Commit-Position: refs/heads/master@{#465703}
-
mthiesse authored
I only saw this crash once, and can't reproduce, but better safe than sorry. BUG=712823 Review-Url: https://codereview.chromium.org/2830463002 Cr-Commit-Position: refs/heads/master@{#465702}
-
panicker authored
BUG=657826,657825 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2778223005 Cr-Commit-Position: refs/heads/master@{#465701}
-
wnwen authored
Adding all sources to a "_all" pseudo module fixes Studio's code analysis functions (imports, refactoring). In order to have things build properly in gradle, the "_all" module has all sources excluded (gradle applies the filters, studio does not). Also fix "--all" targets to include tests. Make it easier to make sweeping java refactors in Android Studio. BUG=620034 Review-Url: https://codereview.chromium.org/2812133003 Cr-Commit-Position: refs/heads/master@{#465700}
-