- 22 May, 2019 40 commits
-
-
Dale Curtis authored
Even though we'd like to stop earlier if an element isn't playing, we can't know if the page is waiting for canplaythrough, so we must buffer until that point so the event fires. This is a partial revert of d71061f0's behavior. We still handle play/pause at kReadyStateHaveMetaData, but unfortunately the preroll attempt is still needed. TODO: Instead of prerolling non-playing tags past metadata, we might instead signal kReadyStateHaveFutureData upon suspend to avoid wasting resources. TODO: Clearly this behavior is missing a test. :| BUG=879406 TBR=sandersd Change-Id: I967ab2c4f8297f8f2e7f9ea91dab7e04f9b88880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623668Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#662084}
-
Jan Wilken Dörrie authored
This change adds support for mutable lambdas to base::BindLambdaForTesting. Since a mutable lambda might invalidate its state after being run once, the returned Callback is a base::OnceCallback instead of a base::RepeatingCallback. Bug: 789805 Change-Id: Ie8a1ffe2f8001ca7f75a9e3626638feb11c5c9d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617452 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#662083}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ieebe05ed1d54aee0df8f2ab2ea1cda617e0b2ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622461Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662082}
-
Timothy Loh authored
app_list.mojom is gone, so app_list_metrics_unittest.cc shouldn't try to include this. TBR=xiyuan Bug: 958134 Change-Id: Iea03664ef6e46914f7561d26f99fdc9f6a50c3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624009 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#662081}
-
Lutz Justen authored
Error codes were hard coded to English so far. This CL uses i18n translated strings. BUG=chromium:952238 TEST=Tested by manually changing error codes in Javascript. Change-Id: I74c81293aafd51bd46c0e5e960ed6b0483808cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608706Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#662080}
-
Thanh Nguyen authored
This CL add hour bin predictor to Dolphin. The logic in this CL is similar to the logic of hour bin predictor in Roselle. Bug: 921444 Change-Id: Idb4c3f1f4905c9cdfa91d5b810149c36c0675418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594381 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#662079}
-
Hirokazu Honda authored
Bug: None Test: Build chrome Change-Id: I5c1598e3bb5d38274ca4bd98ca90305fa78a13c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623661 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#662078}
-
Christopher Cameron authored
TBR=ellyjones Bug: 958255 Change-Id: I50dcef8589e7f11473f359f8a61181206f3567a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623573Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#662077}
-
Timothy Loh authored
The removal of app_list.mojom and new_window.mojom is causing some compile failures as they were left included in a couple of places. TBR=mukai,xiyuan NOTRY=TRUE Bug: 958209, 958134, 965743 Change-Id: I7eb8c010258230cc423bf40ae14e42543852a7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623662Reviewed-by:
-
Daniel Libby authored
Given that there were a couple regressions the first time I changed this behavior for scrollbar presses (see crrev.com/1580588 and the revert, crrev.com/1616341), I'm introducing a feature flag so that we can have a kill switch. R=bokan@chromium.org, dcheng@chromium.org, dtapuska@chromium.org Bug: 954007 Change-Id: I635c5f39a798986c820287c47474f8b80a473307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617140 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#662075}
-
Vlad Tsyrklevich authored
This reverts commit 3c600ba3. Reason for revert: This change is causing test failures on the Windows/ macOS ASan bots. Original change's description: > GWP-ASan: Teach allocator about PartitionAlloc > > A core security guarantee of PartitionAlloc is that allocations of > different types are never given overlapping allocations. In order to > maintain this security guarantee, the GuardedPageAllocator needs to > taught to know when it is used to back PartitionAlloc, and passed in the > types on Allocate(). In those cases it maintains a PartitionAlloc > specific free list that is aware of what types have been previously used > for particular slots. > > Bug: 956824 > Change-Id: I77e596f29d29cc7f88b9e838b8bae891037bafcb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622477 > Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> > Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> > Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#661994} TBR=vtsyrklevich@chromium.org,vitalybuka@chromium.org Change-Id: I0e72a0e081899ccd2705418e068360051f3dfb92 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 956824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623669 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#662074}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ef7c2db2184..b8ab2a78853c git log 4ef7c2db2184..b8ab2a78853c --date=short --no-merges --format='%ad %ae %s' 2019-05-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@b8ab2a78853c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: I27bae88760b4ea6a131ef515026048c05ebbbc75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622642Reviewed-by:
-
Bill Orr authored
eye-level -> local floor-level -> local-floor bounded -> bounded-floor identity -> viewer XRSession.viewerSpace is removed. Bug: 963155, 961906, 953488 Change-Id: I5ab8b23ec14ffd5e2b272238b7fa11a29b11f09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616525Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#662072}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f4d2a446cc12..e79721932344 git log f4d2a446cc12..e79721932344 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 capn@google.com Fix typo in Vector lerp() Created with: gclient setdep -r src/third_party/swiftshader@e79721932344 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I23d5068a0a37ba914ad02e8700c5fe4d41e86968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622643Reviewed-by:
-
Henrique Ferreiro authored
As advised in [1], this CL ports calls to Foo::Create() factory functions to use MakeGarbageCollected<Foo> from //third_party/blink/renderer/core/dom/dom_exception.h. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBg> Bug: 939691 Change-Id: Iea8b8b2546c58984d4532623d8e3a32c7b555df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621126Reviewed-by:
-
Julien Isorce authored
In DesktopCaptureDevice, get the ICC profile of the webrtc frame to generate a gfx::ColorSpace. Then in VideoCaptureDeviceClient, merge the primaries and transfer function into the yuv colorspace thanks to gfx::ColorSpace::GetWithMatrixAndRange. Otherwise the gamma color correction is lost and rendering has wrong colors when attaching the captured stream of the desktop to a <video> tag. Bug: 945468 Test: content_unittests --gtest_filter=*VideoCaptureControllerTest.*ColorSpace* Change-Id: I67c5bb01d1addc2f0282ad67a86be859ce74d592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542175 Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
-
Eric Aleshire authored
Bug: 922813 Change-Id: Ib684a14d5af69a47b5a76205d6e0dc4329259887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623270Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#662068}
-
Wei-Yin Chen (陳威尹) authored
Settings.Global.ANIMATOR_DURATION_SCALE is a system-wide setting on Android. It can be used to slow down all animations to help debugging. Before this CL, all animations except CompositorAnimator can be slowed down, leading to a weird combination and mismatched animation speed. Bug: None Change-Id: Idfc0cdc7cd8884bdd0f7caa6f15bdf711585feed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617915 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#662067}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c9e2283502a7..7a6143385da4 git log c9e2283502a7..7a6143385da4 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 sangwoo.ko@navercorp.com Decode datetime string when it's not utf-8 Created with: gclient setdep -r src/third_party/depot_tools@7a6143385da4 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:955206 TBR=agable@chromium.org Change-Id: I07e2fd4705d6f7d5122e506ba323d1c2567e675d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622796Reviewed-by:
-
Torne (Richard Coles) authored
Use the new JavaRef<jobjectArray>::ReadElements helper to iterate through array elements in VrShell::OnTabListCreated. Change-Id: Ib1857000231e896428bc126bbbf08580e7644d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623458 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#662065}
-
Alexey Baskakov authored
Plumb WebApp.Icon.HttpStatusCodeClassOnSync histogram name to WebAppDataRetriever. We have deprecated Extensions.BookmarkApp.Icon.HttpStatusCodeClassOnCreate Extensions.BookmarkApp.Icon.HttpStatusCodeClassOnSync histograms in favor of WebApp.Icon.HttpStatusCodeClassOnCreate WebApp.Icon.HttpStatusCodeClassOnSync histograms. Bug: 901226 Change-Id: Ib1b6ced375efdf66f2b64e0803e4e82ad6df4a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621423 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#662064}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4f08faae82cc..bb90cccb7dd1 git log 4f08faae82cc..bb90cccb7dd1 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1216f271..15b783dc (661928:662034) 2019-05-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0c18b1a2..1216f271 (661811:661928) Created with: gclient setdep -r src/third_party/webrtc@bb90cccb7dd1 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia22be9d2279c9adc3d29aca8e31a1799eac7e4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622795Reviewed-by:
-
Eugene But authored
loadURL: from other test helpers wait until load is finished. startLoadingURL: name emphasizes that method returns without waiting. Bug: 960407 Change-Id: I50a9f38cb30bece839279a9e46089fca6220af2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623626 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#662062}
-
Jeevan Shikaram authored
ExtensionResource::GetFilePath will DCHECK if it's not called on a background thread. Currently, the App Service calls this method on the UI thread, which causes App Management to crash when DCHECKs are enabled. This CL refactors apps::LoadIconFromExtension to ensure that this method is only called on a background thread. Bug: 916380 Change-Id: I3ba8757e884c6336b4b7b61fc46363c8273fcc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619586Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#662061}
-
Alan Cutter authored
This CL removes two flags: - enable-desktop-pwas: This is on by default for desktop. - enable-experimental-app-banners: This is on by default for Android These flags are being removed together because AppBannerManager::IsExperimentalAppBannersEnabled() was true if either one was true. This was in effect true for all platforms by default. TBR: vakh@chromium.org Bug: 959086 Change-Id: I0c9f170f3be7ba1cacc7750c9268316912c98ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609744 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
We need to destroy WebContents early on WebAppProvider::ProfileDestroyed() (as in PendingBookmarkAppManager()) Bug: 901226 Change-Id: I055e04678b5f0eb4c07f0f5d33e0208904033f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621986Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#662059}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/38211554aed6..4b4149fa7025 git log 38211554aed6..4b4149fa7025 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 manojgupta@chromium.org Revert "simple_builders: Disable kernel afdo update." Created with: gclient setdep -r src/third_party/chromite@4b4149fa7025 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I7a5085b78607128b813166195f300da102bae9a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622901Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e63b01b364a0..4ef7c2db2184 git log e63b01b364a0..4ef7c2db2184 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@4ef7c2db2184 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: I7e10db40f154f8f1e2e8d081c5e740db04e0490b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622900Reviewed-by:
-
Takuto Ikuta authored
This is step 2 written in https://chrome-internal-review.googlesource.com/c/infradata/config/+/1324360 I updated suppression list for data race happened in libgobject.so. e.g. https://ci.chromium.org/p/chromium/builders/try/linux_chromium_tsan_rel_ng/282235 Bug: 954450 Change-Id: I08c167b1b4f9077c1f74985b13e89c46f6ca203d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621768Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#662056}
-
Hiroki Nakagawa authored
According to the issue, each browser-initiated request should have a unique request id. Bug: 937174 Change-Id: I49f27ef4a65aa98697156a5eb03f20f3f14e867d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623650Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#662055}
-
Asanka Herath authored
The NetLogEventType::AUTH_CONTROLLER BEGIN event is logged the first time an entry point method is invoked on the controller. The END event is logged upon the destruction of the controller if a BEGIN event was logged. R: mmenke@chromium.org Bug: 884313 Change-Id: I884fc21f8208e60d5306bb9ea412b982aa90d2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619828 Commit-Queue: Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Asanka Herath <asanka@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#662054}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I4a1cc39088ff261134392959ec93d03c9a61916e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623826Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#662053}
-
Peter Kotwicz authored
This CL re-enables WebApkUpdateManagerTest.testFileDeletedIfStoreWebApkUpdateRequestToFileFails WebApkUpdateManagerTest.testPendingUpdateFileDeletedAfterUpdateCompletion The tests started failing as a result of https://chromium-review.googlesource.com/c/chromium/src/+/1494657 BUG=937109 Change-Id: I7c129cde5d3e57b59be34fc750e5ec45e339c325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520208Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c7e440c0091d..c9e2283502a7 git log c7e440c0091d..c9e2283502a7 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-22 ehmaldonado@chromium.org Revert "gclient: Require a target ref when applying patches." 2019-05-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-21 ehmaldonado@chromium.org gclient: Require a target ref when applying patches. 2019-05-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@c9e2283502a7 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:956807,chromium:956807 TBR=agable@chromium.org Change-Id: Ibcd1faf80a62a75aa53d2dc388d274fa8dacc9eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622896Reviewed-by:
-
John Lee authored
The feature that the histograms measure metrics for will continue to run past M76, and we want to continue logging metrics for it. Bug: 960027 Change-Id: Id61be13841aac9bc43366c91f9e633cdf14345b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620771Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 19864 19871 19875 19882 19902 19918 19936 19941 19942 19944 19945 19962 19968 19973 19974 19978 19985 19996 20007 20011 20020 20039 20052 20063 20078 20085 20089 20100 20117 20126 9 lines were removed and 2 lines were deflaked by consecutive results since 20007. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I46312353405378c7624ea0b6c713977ea77c43b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617046Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#662049}
-
Yoshifumi Inoue authored
This patch introduces |SECURITY_DCHECK()| in |NGOffsetMapping| constructor and |NGOffsetMappingUnit| constructor to detect wrong behavior of |NGOffsetMappingBuider| for ease of debugging. This patch also remove |CHECK| for offsets in |NGOffsetMapping|[1] in |Element#innerText| because of we check them at construction time. [1] http://crrev.com/c/1619510 Make Element#innerText to use CHECK at StringView construction Bug: 964871, 965702 Change-Id: Ie03709d4eaddea6696f3d1bc009fd5184675ce8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621803 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#662048}
-
Michael Giuffrida authored
Bug: 957772 Change-Id: I134c1ff6c1f3431ef7f0debc1ae346dd2dd689f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620766 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#662047}
-
Gary Kacmarcik authored
Change-Id: I278f34f5cc2d4ce7dc7f01e39ea9cd0e52be0c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623266Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#662046}
-
Ian Vollick authored
Since the existing machinery is tied to the notion of focus, we need to move focus even when performing "focusless" spatial navigation. The rest of the "focusless" idioms apply, however. Layout tests are by default in accessibility mode, so I've had to provide a means to disable this for my tests and add extra tests to ensure that snav behavior is what we expect both in and out of accessibility mode. Bug: 941572 Change-Id: I82890eb27e35c902c27632badf65c1a09ca0667d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620345Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
-
