- 14 Jun, 2019 16 commits
-
-
James Cook authored
The original CL caused a null pointer dereference on |prefs_util_| in extensions::SettingsPrivateEventRouter when StartOrStopListeningForPrefsChanges() is called from the constructor. This doesn't happen in dev builds, so I suspect it requires some extension to be installed. Fix by ensuring |prefs_util_| is initialized. Add DCHECK so existing settingsPrivate api tests will cover this case. Original CL description ----------------------- This fixes a longstanding issue where guest mode users cannot change the browser's preferred language list. The main profile in guest mode is an off-the-record/incognito profile. This CL from 2.5 years ago https://codereview.chromium.org/2499093002 changed the settingsPrivate API in guest mode to use the backing ("recording") profile instead of the main incognito profile for pref writes. The languages UI continued to function because the incognito profile's preferences were "overlaid" onto the recording profile prefs. By default, all prefs were overlaid, except for a block-list. That block-list was changed to a whitelist, and the whitelisted prefs were gradually removed. This CL removed the language prefs from the list: https://chromium-review.googlesource.com/c/chromium/src/+/1174118/ which made the guest mode language section stop working. For guest mode we want to use the incognito pref store where possible. The incognito pref store is in-memory. The backing user profile is deleted after logout (it is on a tmpfs) but it's better to just avoid writing the prefs. Change the BCKSFactories to prefer the incognito profile. Return null services in tests because unit tests with TestingProfile generally don't need these services. Bug: 887383 Test: added to browser_tests, manual test in guest mode on eve Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653748 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#668434} Change-Id: Id7ddf10ed15ca3ccb5c41abecbafbf66adddc3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659024 Cr-Commit-Position: refs/heads/master@{#669063}
-
Chris Harrelson authored
Also fixed one typo I noticed along the way. Change-Id: Ifd64bf3d8388dcfc2d42ba606d5ecfa786ffa5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653651Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#669062}
-
Ben Kelly authored
Bug: 960012 Change-Id: I4276b1bd22d418281d21b2034166cb094040dc14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653248Reviewed-by:
Staphany Park <staphany@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#669061}
-
Maggie Chen authored
Introduced a new finch flag kGpuWatchdogV2 disabled by default. All V2 functions added in this CL are the same as V1 for now. The purpose of GPU watchdog Version 2 is to simplify the logic and reduce the number of GPU crash reports if possible Bug:949839 Change-Id: I7b6cd58425a91d379b7abc5c5452c974def905a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652561 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#669060}
-
Tina Wang authored
Previously an empty device list would be shown when there is no valid remote device but multiple devices are synced. i.e. All remote synced devices are using Chrome with version earlier than M-75. Now we will hide the entry points when there is no valid device. Bug: 970896 Change-Id: I64c1d58210c7ac30d1b455ea77d8aaccf6fecb27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652372Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#669059}
-
David Bertoni authored
This file should have been removed in 1645984. Bug: 961836 Change-Id: I94f51d5b8eb2b001db54944de547a8af4e0caa73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658935Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#669058}
-
Kristi Park authored
Depending on window size, the number of text lines might be different. Explicitly set the number of text lines. Bug: 960622 Change-Id: Iaf54a8ab7688f0454bfb34e7dd6aa61392214bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658440 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#669057}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/727d7ca2730f..e502dbcca014 git log 727d7ca2730f..e502dbcca014 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 perezju@chromium.org [Telemetry] Add download path for android_n_arm64-v8a Created with: gclient setdep -r src/third_party/catapult@e502dbcca014 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:867592 TBR=crouleau@google.com Change-Id: Icddd87e04d8cc3e693ef1ad72f73960db3d8f12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659671Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669056}
-
Yuly Novikov authored
Bug: 973992 Change-Id: I3f6988acd705f15ade7c6a85a66095ff87515647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659616Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#669055}
-
Aaron Gable authored
I look forward to the day that this is no longer necessary, but for now masternames are still keys into the chromium_tests bot_config dictionary. TBR: jbudorick Bug: 971387 Change-Id: I2d79fb35260c615900b8ae0cd7d4b7a9cacc9711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658632Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#669054}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0e08b37624f8..c8c1ab9dcdb1 Created with: gclient setdep -r src-internal@c8c1ab9dcdb1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:b/133794084 TBR=mmentovai@google.com,aboxhall@google.com,mstensho@google.com,oksamyt@google.com Change-Id: I3ea0f99ef93229c20392f31601f15abbaa16dbd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659670Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669053}
-
Will Harris authored
This is required for intercepts to work very early during the initialization of the target process. BUG=750886 Change-Id: I81a4bc43fc6652d473b557ade7f55d54cdb2a6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658591 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#669052}
-
Kyle Milka authored
There's only a single source of custom background images so the logic for handling multiple sources is no longer needed. Bug: None Change-Id: I0503c36ba06c258e7e5ea7e898ab1b32639037c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658931Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#669051}
-
Aleks Totic authored
A followup to cbiesinger's https://chromium-review.googlesource.com/c/chromium/src/+/1653864 Fixes more cases. Bug: 968019 Change-Id: Ie379fa5e2672c0c2ed0302eb7d40c4460262c00b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658657 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#669050}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5894b6aad4b1..9e25f74faab6 git log 5894b6aad4b1..9e25f74faab6 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 sakal@webrtc.org Update visibility for JNI targets in sdk/android. Created with: gclient setdep -r src/third_party/webrtc@9e25f74faab6 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia5473642a6a321dd7117523e672765c98d732be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658775Reviewed-by:
-
Antonio Gomes authored
... except media_stream_constraints_util_video_content_unittest.cc, which will be removed on a follow up step (it has linking problems on win dbg bots that need fixing). Namely, the following files are Onion souped, from content/renderer/media/stream to renderer/modules/mediastream. - media_stream_constraints_util_sets_unittest.cc - media_stream_constraints_util_unittest.cc - media_stream_constraints_util_video_device_unittest.cc Note that all them now leave along side with their respective implentation files in Blink. Last, the only dependency in content that these tests still had were the inclusion of content/renderer/media/stream/mock_constraint_factory.h. Following the same logic used in [1], these helper mock files were moved to Blink too as part of this CL. BUG=704136 Change-Id: I29f1cb65b80844655271979019e53afee84c9879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654128 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#669048}
-
- 13 Jun, 2019 24 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/b988e6b45063..c21dd10cf196 git log b988e6b45063..c21dd10cf196 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 dneto@google.com Update glslc tests for -finvert-y option (#704) 2019-06-13 andrejnau@gmail.com Pass InvertY to glslang (#695) Created with: gclient setdep -r src/third_party/shaderc/src@c21dd10cf196 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: Ib551e4c6dce630ac4711a91e6f01a63367938862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659628Reviewed-by:
-
Natalie Chouinard authored
Migrate Tracing Category settings page from the deprecated framework preferences to the Preference Support Library. Bug: 968592 Change-Id: Ib3420889fac2827517812cc6536f011922bbeccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647146 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#669046}
-
Sky Malice authored
Bug: 966272 Change-Id: I1bafc8f8aaea54e157a4ffa66a3c314ae99f1696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659688 Auto-Submit: Sky Malice <skym@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#669045}
-
Regan Hsu authored
Change-Id: Ia62c2e093937e4aafd7cdd1ae48981809f6a66f1 Bug: 936390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657349 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#669044}
-
Matt Wolenetz authored
This test normally takes only 1-2 seconds to execute on Chromium Mac release builders, but can timeout at low frequency (3 times in > 100 builds). Per WPT documentation [1], this change marks the test timeout as "long". In Blink, this change also removes the flaky timeout test expectation for this test. [1] https://web-platform-tests.org/writing-tests/testharness-api.html#harness-timeout BUG=971252 TEST=confirmed locally with Blink's web test runner and injected test delays that this change allows the test to run over 6 seconds without failing with timeout. Change-Id: Icf60260640f201f3fc3c072c6bef9097bff928df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659132Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#669043}
-
Alberto Herrera authored
Also plumb the battery value so that it will be available to Ash Tray and the Settings UI. Bug: 785758 Change-Id: I93698c967d92066c388c64a50ad80b81f2aff93f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642135 Commit-Queue: Alberto Herrera <ahrfgb@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Dale Curtis authored
There seem to be multiple issues with VP9.2 decoding on RS3. NVIDIA has disabled support in RS3 for some Windows issue in such a way that the MFT falls back to software decoding without notifying us. I was unable to find a way to generate the GUID list of supported DXVA modes like "dxdiag" does (which somehow doesn't include the VP9.2 GUID: DXVA2_ModeVP9_VLD_10bit_Profile2). Since we can't test for it, just disable it since it's usage is rare. BUG=937108 TEST=tmathmeyer on 1709 w/ patch. R=sunnyps Change-Id: Id97475b22e322c6fbe347be1ab995d3865418914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642034Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#669041}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/710e17039085..765b75c294d2 git log 710e17039085..765b75c294d2 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 sidaths@google.com Merge "Update UI to show GPU frequency tracks" Created with: gclient setdep -r src/third_party/perfetto@765b75c294d2 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I3c6234dbb8601294806a70832b515a62d8b3d79e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659192Reviewed-by:
-
Sam McNally authored
Bug: 928157 Change-Id: I4de4dcbea0a5fee509fb2c4511a2b2cd6ea932bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657376Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#669039}
-
Clark DuVall authored
Now that network service is launched, this is no longer needed. Modified a few of the unittests to work with the other WebRequestInfo constructor. Bug: 934009 Change-Id: Ie291f23de31b0059902c541c4d2b97475403ee90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658655Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#669038}
-
Yue Li authored
This reverts commit e5bfed5b. Reason for revert: provider.VERIFY is still required to select the right provider for play media queries. See more details in b/133794084 The original bug b/130370217 will be resolved by bumping up media.PLAY_MEDIA version to 2. Bug: b/133794084 Original change's description: > Remove VerifyProvider clientOp support > > Since we are sending app capabilities to the server, the VerifyProvider > clientOp is no longer needed. This is the second step of removing the > logic: > > 1. Remove VerifyProvider in the list of supported actions (internal) > 2. Remove Handling of the VerifyProvider action (external) > 3. Remove the logic of notifying the VerifyProvider action (internal) > > Bug: b/134085742 > Change-Id: I5c6eab87d24655198696a1b711efeb4ecf15a9dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637650 > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Yue Li <updowndota@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665237} TBR=sammc@chromium.org,xiaohuic@chromium.org,updowndota@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/134085742 Change-Id: Ic14cd90816094836b1cb822755b654a7284d7ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659529Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#669037}
-
Robert Kroeger authored
Strides and offsets in a NativePixmapHandle should always be >= 0 so get the compiler to enforce that with unsigned types. Bug: 960137 Change-Id: Ic754fc61dc4f5ee28e2b164ddcc502c6aafa753f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651614 Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#669036}
-
Sean Harrison authored
Bug: 960513 Change-Id: I31cc20f1986e767605961b7657e7a40af4227a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657391Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#669035}
-
Oksana Zhuravlova authored
TBR=kschmi@microsoft.com Bug: 973946 Change-Id: I69b54fdfe9421acacaf98c2bcf684680e7cb66fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659029 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#669034}
-
Steven Bennetts authored
This is an initial CL that enables mojo for Settings ands includes a small isolated useage. The network_config mojo API will be used in parallel with the networkingPrivate extension API while the code is transitioned. Forthcoming CLs will transition the rest of Internet Settings to use the mojo API, eventually fully replacing the extension API. Adding mojo bindings to the Settings page resulted in no measurable load time regressions. See issue for details. This CL: * Modifies SettingsUI to derive from MojoWebUIContriller * Binds network_config mojo service to SettingsUI and OSSettingsUI * Implements device enable API call in internet_page using Mojo Bug: 853953 Change-Id: I99c3d2064361abb51368acc3811c45341f2db56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652802 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#669033}
-
Mohamed Mansour authored
aura::WindowTreeHost::OnHostResizedInPixels is trying to use a null compositor. This only happens when the browser is being destroyed while resizing is happening. Adding a null check for compositor_ would stop this crash. Similar null check is happening in aura::WindowTreeHost::OnHostDisplayChanged Bug: 920682 Change-Id: I9807db420cca686f5143fb62a93469eef2f1d556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658773 Commit-Queue: Mohamed Mansour <mmansour@microsoft.com> Reviewed-by:
-
John Williams authored
- Fixed a bug in CastMessageHandler::DoEnsureConnection() causing it to use the wrong VirtualConnectionType, and fixed similar broken DCHECK in CreateVirtualConnectionRequest(). - Added OnSessionSet() method to ActivityRecord, which is called once the the activity's session ID becomes available. MirroringActivityRecord uses this method to start the mirroring service. - Added OnInternalMessage() method to ActivityRecord analogous to OnAppMessage(). This is needed by MirroringActivityRecord to forward messages to the mirroring service. - InternalMessage now has a namespace field which is used to record the namespace of the CastMessage from which it was created. - Renamed CastMessageHandler::SendCastMessage() to SendCastMessageToSocket(); the name SendCastMessage is used for a new method. - Added OFFER and ANSWER values to CastMessageType enum. - Added DVLOG calls in CastTransportImpl to show all messages sent and received via cast channels. - Moved operator<< for CastMessage into cast_message_util.cc, and eliminated CastMessageToString(). - Added lots of TODOs pointing out design issues and potential improvements. Bug: 965229 Change-Id: I423b70572fe1f51d738badc50fbfc820f0ac4b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643415 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#669031}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a74bd78e9ccd..d05ca1537ccd git log a74bd78e9ccd..d05ca1537ccd --date=short --no-merges --format='%ad %ae %s' 2019-06-13 jbudorick@chromium.org Invert ios_internal fetch spec. Created with: gclient setdep -r src/third_party/depot_tools@d05ca1537ccd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:803846 TBR=agable@chromium.org Change-Id: I09f3fbf2897c48ade74ace937749c52dcb52929f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659204Reviewed-by:
-
Sujie Zhu authored
Server side config: https://critique.corp.google.com/#review/252708499 Bug: 954367 Change-Id: I68f8dbe9c3d97139f82e66a09f64d80ec860cf09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656051Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sujie Zhu <sujiezhu@google.com> Cr-Commit-Position: refs/heads/master@{#669029}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b08d53d3c1c6..88596beab317 git log b08d53d3c1c6..88596beab317 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 jmadill@chromium.org Vulkan: Implement a texture descriptor cache. 2019-06-13 shrekshao@google.com Enable floatBlend for D3D9 2019-06-13 dongja@google.com Vulkan: fix array size for internal shaders 2019-06-13 jmadill@chromium.org Refactor DrawCallPerfParams. Created with: gclient setdep -r src/third_party/angle@88596beab317 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:970532 TBR=jmadill@google.com Change-Id: Idfc3de99e8fc6db5f183b840bbaac248f50c1185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659142Reviewed-by:
-
Jacob DeWitt authored
magic-window.html now supports using click-and-drag to adjust viewer pose orientation in an inline session. input-selection.html is split into two samples since it has evolved to demonstrate too many things at once: - teleportation.html demonstrates just the teleporting + adjusting rotation functionality - gamepad.html does the same thing with gamepad input, with the improvement of having boxes that corespond to joysticks/touchpads for an xr-standard gamepad moving in response to the associated input axes instead of having additional boxes that move but don't respond to button presses. It also displays data tables if an optional URL parameter is set. Bug: 966565, 974037 Change-Id: Icf286e7303c64b94ed3c9d4031bfd88a71c3d9e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656437 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#669027}
-
Sergey Ulanov authored
Now Vulkan and out-of-process rasterization is supported in WebEngine. It's enabled only when it detects that the Vulkan loader service is present in the service directory passed during Context creation. Also removed Vulkan loader service from the CastRunner manifest, so for now WebRunner is the only client that will have Vulkan enabled. Bug: 962617 Change-Id: I5994b825057aebfc10ff5a828c7ace947aec3816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618242 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#669026}
-
Ken Rockot authored
This is no longer necessary since the Service Manager is initialized before browser threads are even created. None of the implementations of this override needed the ServiceManagerConnection specifically, but only its Connector. Additionally, with recent changes to Service Manager initialization the PostCreateThreads() method is effectively equivalent in timing to what ServiceManagerConnectionStarted was. As such all prior implementations of ServiceManagerConnectionStarted have been moved into a PostCreateThreads override, and references to the connection argument have been replaced with GetSystemConnector(). Bug: 904240 Change-Id: I70a445f5dcf9d16df654b95d971672f8c611e108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652798 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#669025}
-
John Rummell authored
Instead of returning a base::File object and letting the utility process do the read/write operations, change the mojo interface so that the operations are instead done inside the browser process, and pass the contents to/from the utility process. This is done to simplify the code and is the first part of a change to make CdmFile operations use streams instead of base::File. Bug: 958204 Test: Modified tests pass Change-Id: I3d01c4a848889ad0f5f3780305a00481b1ae0074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636438 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#669024}
-
