- 25 Feb, 2019 40 commits
-
-
Yuly Novikov authored
This reverts commit 5e12be67. Reason for revert: Breaks compile on GPU FYI Mac Builder. Original change's description: > Enable -Wextra-semi in mac release builds that have dcheck_always_on set. > > Bug: 926235 > Change-Id: I32c7a9f15f1f544caaceef28b0d34ebd643aa35d > Reviewed-on: https://chromium-review.googlesource.com/c/1486880 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Mark Mentovai <mark@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635214} TBR=thakis@chromium.org,mark@chromium.org Change-Id: I611e0ac85226e48f312b1a9bfca6aaadc23a8ead No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 926235, 935704 Reviewed-on: https://chromium-review.googlesource.com/c/1487806Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#635273}
-
Justin Cohen authored
Referencing this on Xcode 10 and 10.1 was a no-op, but on 10.2/10.14 it causes a failure. TBR: sergeyberezin@ Change-Id: Ic3630fa53278d96a77d215a35eeae9b9b3615756 Reviewed-on: https://chromium-review.googlesource.com/c/1487355 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635272}
-
Joshua Peraza authored
Change-Id: I91d3e0493290f7fbbef384e9d84c6f9713a7ecd9 Reviewed-on: https://chromium-review.googlesource.com/c/1486685 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#635271}
-
Lily Chen authored
This reverts commit 24ab3332. Reason for revert: Causes cronet test crashes, and makes hitting a use-after-free problem much more likely Original change's description: > Network Error Logging: Generate error reports on cancellation > > A network error should be reported if the resource fetch is aborted > before it is complete: > https://w3c.github.io/network-error-logging/#transmission-of-request-and-response-errors > > This CL adds NEL error generation (with report type ERR_ABORTED) for > any HttpNetworkTransactions destructed without previously generating a > success or error report. This guarantees that every > HttpNetworkTransaction results in a NEL report. Successes are reported > after receiving valid headers (if the response code is 4xx or 5xx, or > if the body will not be read, or on a redirect), or after completely > reading the body. Any other outcome is reported as an error. > > Bug: 934000 > Change-Id: I8f71309c9cea0295546b23861fba6b131f72a3d7 > Reviewed-on: https://chromium-review.googlesource.com/c/1480195 > Commit-Queue: Lily Chen <chlily@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634834} TBR=mmenke@chromium.org,chlily@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 934000, 935034, 935209 Change-Id: I1bfe60632094f541acec8d8ba815d2cfaead9e82 Reviewed-on: https://chromium-review.googlesource.com/c/1487356Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#635270}
-
Joshua Peraza authored
This adds a small executable, libcrashpad_handler_trampoline.so, to Monochrome, Trichrome, and SystemWebView. The trampoline loads the remaining Crashpad handler code from the main native library, which must export `CrashpadHandlerMain()`. All three packages will continue to use /system/bin/app_process to launch Crashpad on P-. Note on static_initializers.gni: There aren't any real, new static initializers. The increased count is due to the addition of the new object. Static initializers are counted by measuring the size of each object's .init_array and dividing by the object's pointer size. libcrashpad_handler_trampoline.so has two invalid slots which are ignored by the loader: readelf -x .init_array libcrashpad_handler_trampoline.so Hex dump of section '.init_array': 0x00001008 ffffffff 00000000 Bug: 928422 Change-Id: Iba56cd6feda73ebc91f6758724d823e48b5c6e8f Reviewed-on: https://chromium-review.googlesource.com/c/1454078Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#635269}
-
Yann Dago authored
Bug: 933811 Change-Id: I0b8fc2409051e5b8c18b6a91cf5821b0b84b3862 Reviewed-on: https://chromium-review.googlesource.com/c/1486712Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#635268}
-
Harley Li authored
In Application>Service Worker's list of service workers on current domain are originally not sorted. This patch sorts them according to their timestamps. The test: the service worker registration for scope2 comes first because it is newer (i.e. registered later) than the one for scope1. Bug: 894783 Change-Id: I01d1b97fb8f51cb4ea67d614c284ed78ca7136e9 Reviewed-on: https://chromium-review.googlesource.com/c/1482030 Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#635267}
-
Nico Weber authored
https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/4f32cbf268a8..9bf9b18f0a70 $ git log 4f32cbf26..9bf9b18f0 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 aardappel Added -Wc++98-compat-extra-semi 2019-02-25 aardappel Added -Wextra-semi to Clang build. 2019-02-21 bwelling Fix big-endian build. (#5205) 2019-02-21 eric.erhardt Remove byte* property in ByteBufferAllocator (#5191) 2019-02-21 bwelling Improve endian detection. (#5204) 2019-02-22 mockbutler Add RPM packaging support (#5177) 2019-02-21 krojew Fixed vector of unions crash in java (#5190) 2019-02-21 efe Added .net core project (#5187) Created with: roll-dep src/third_party/flatbuffers/src And re-enable chromium_code warning level for flatbuffers. Bug: 934834 Change-Id: I4a2bb19d58f3a7f78fd57936d7586c6acb8fa502 Reviewed-on: https://chromium-review.googlesource.com/c/1487520Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#635266}
-
Sven Sauleau authored
Switching from USVString to DOMString will allow the string to contain non normalized surrogates, thus the two strings in the test case won't match anymore. Note that v8 already uses a DOMString as argument and that test failed. Bug: v8:8319 Change-Id: I34dec61768f6791404ef49a77e21570a2634ebfe Reviewed-on: https://chromium-review.googlesource.com/c/1477227 Commit-Queue: Sven Sauleau <ssauleau@igalia.com> Auto-Submit: Sven Sauleau <ssauleau@igalia.com> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#635265}
-
Qingsi Wang authored
Bug: 925876 Change-Id: I059de09a878a9c953bc7716b3ee327dac14e4c44 Reviewed-on: https://chromium-review.googlesource.com/c/1455685Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Qingsi Wang <qingsi@google.com> Cr-Commit-Position: refs/heads/master@{#635264}
-
Harley Li authored
We should stop the service worker before unregistering it. Originally, clicking "Clear site data" will unregister the service worker. In Application>Service Workers, the service worker's tab title is marked as "deleted", but its "status" says it's still running. Bug: 894783 Change-Id: Ib1550cfab8274a27495bb795501f54e9a19f6a36 Reviewed-on: https://chromium-review.googlesource.com/c/1480725Reviewed-by:
-
Philip Rogers authored
When BlinkGenPropertyTrees was moved from status=experimental to status=stable in https://crrev.com/633410, there became no way to disable the feature with chrome's feature setting. This is because runtime_features.cc had this bad logic: if (base::FeatureList::IsEnabled(blink::features::kBlinkGenPropertyTrees)) WebRuntimeFeatures::EnableFeatureFromString("BlinkGenPropertyTrees", true); Because finch uses feature settings, this affects the control group of the BlinkGenPropertyTrees finch trial. This patch updates the runtime enabled feature to be fully controlled by the chrome feature setting. Tested the following scenarios: +------------------------------------------------+-----------+------------+ | flag | pre-patch | post-patch | +------------------------------------------------+-----------+------------+ | no flag | BGPT on | BGPT on | | --enable-features=BlinkGenPropertyTrees | BGPT on | BGPT on | | --disable-features=BlinkGenPropertyTrees | BGPT on | BGPT off | | --enable-blink-features=BlinkGenPropertyTrees | BGPT on | BPGT on | | --disable-blink-features=BlinkGenPropertyTrees | BGPT off | BGPT off | +------------------------------------------------+-----------+------------+ Bug: 935195 Change-Id: Iba560582e3b2b2377f6b4af31a4c6263215467fa Reviewed-on: https://chromium-review.googlesource.com/c/1485491Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5efe61188243..8c1e8f1fb771 git log 5efe61188243..8c1e8f1fb771 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 sugoi@google.com PipelineLayout implementation 2019-02-25 chrisforbes@google.com Suppress warnings for more instructions that require no work Created with: gclient setdep -r src/third_party/swiftshader@8c1e8f1fb771 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I2aace45c7afaad4c34f4e010eafc69f81fc14c82 Reviewed-on: https://chromium-review.googlesource.com/c/1487135Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635261}
-
Leonard Grey authored
Bug: 924505 Change-Id: I03acc4583256ca154b6186e65a551aa610e5f44b Reviewed-on: https://chromium-review.googlesource.com/c/1487354Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#635260}
-
Brandon Wylie authored
Change-Id: I977e636cea32df167a44ef4ee5ce67981e3e4864 Reviewed-on: https://chromium-review.googlesource.com/c/1487073Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#635259}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/01e1527e35e2..a7e0cc8291d3 git log 01e1527e35e2..a7e0cc8291d3 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 thestig@chromium.org Stop using fcvt() in AFPercent_Format(). 2019-02-25 thestig@chromium.org Add more AFPercent_Format() tests. 2019-02-25 thestig@chromium.org Support AFPercent_Format()'s 3rd parameter. Created with: gclient setdep -r src/third_party/pdfium@a7e0cc8291d3 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I40a4d4f303b7d883a80cd77898e9959c814140a9 Reviewed-on: https://chromium-review.googlesource.com/c/1487208Reviewed-by:
-
Vladislav Kaznacheev authored
Override insets in BubbleBorder with a value specific for system tray. Previous implementation relied on adjusting insets computed in BubbleBorder which was fragile and not quite correct. TBR=stevenjb@chromium.org Bug: 932159 Test: manual Change-Id: I363607f0580190c7777d446cb2167d7fa956a309 Reviewed-on: https://chromium-review.googlesource.com/c/1474278 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#635257}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/18f119bb3a03..d13a3a7aff05 git log 18f119bb3a03..d13a3a7aff05 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@d13a3a7aff05 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Idd777cae7b666216ed2770d346d3fba1951d9302 Reviewed-on: https://chromium-review.googlesource.com/c/1487207Reviewed-by:
-
Dan Harrington authored
I ran the test 40 times on my local device, and it passed each one. Hopefully the previous changes to this test file have fixed the flake. Bug: 923212 Change-Id: Ic8b3e6e6b82b60d14bdef9975d5d70e256dcf1b7 Reviewed-on: https://chromium-review.googlesource.com/c/1470634Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#635255}
-
Darren Shen authored
We would like to test the accessibility keyboard in Tast, but it's activated based on a pref. We'll whitelist this pref so that Tast can set it to true to bring up the accessibility keyboard. Note: this introduces another ash dependency from chromeos. Bug: 879073 Change-Id: I593e4d544ea4f0e1717c4a683d0fe65d2a7a7a38 Reviewed-on: https://chromium-review.googlesource.com/c/1485691Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#635254}
-
Xiaocheng Hu authored
Bug: 935688 Tbr: mek@chromium.org NoTry: True Change-Id: Ic7add940d264e1fc4b3e77cbaf7e49e2c3f6fd2f Reviewed-on: https://chromium-review.googlesource.com/c/1487370Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635253}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d7d9726d..9e322313 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie4d815edd2d1a055297e2c17b54bf5496afd3902 Reviewed-on: https://chromium-review.googlesource.com/c/1487071Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635252}
-
Xianzhu Wang authored
Add the following UMA metrics: - Blink.Paint.CachedItemPercentage: percentage of cached display items among all display items. Higher number means higher performance because of less invalidated display items. - Blink.Paint.IndexedItemPercentage: percentage of indexed display items during out-of-order matching of display items. Lower number means higher performance because of less cost of out-of-order matching and indexing. - Blink.Paint.CachedSubsequencePercentage: percentage of cached subsequences. Higher number means higher performance because of less invalidated subsequences. The numbers are accumulated for multiple PaintController paint sessions. We report the percentages after updating paint in a document lifecycle when we have enough data to report. They will help analyze progression/regressions of Blink.PrePaint.UpdateTime and Blink.Paint.UpdateTime. Change-Id: I000cff61165673c7e9a3c132e0007d85a7d96fc1 Reviewed-on: https://chromium-review.googlesource.com/c/1485234Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#635251}
-
Toni Barzic authored
Removes update screen related exit codes from ScreenExitCode enum, and adds a separate enum to UpdateScreen class. Error exit codes are condensed into a single UPDATE_ERROR code (as the action taken by wizard controller is pretty much the same for all), and the decidion whether non-critical updates should be ignored is moved from WizardController to UpdateScreen - i.e. for non critical updates, UpdateScreen will return UPDATE_NOT_REQUIRED result instead of an error. Changes how UpdateScreen reports exit - instead of calling the BaseScreenDelegate::OnExit, it runs a callback that is provided in its constructor. BUG=930267 Change-Id: I74b9c4c87f213eafbe6adb98f8942d4d8450dc09 Reviewed-on: https://chromium-review.googlesource.com/c/1481852Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#635250}
-
Nate Fischer authored
This implements WebView's SetCheckClearTextPermitted functionality for the NetworkService code path, fixing the related test. This mostly copies the legacy code path implementation (which uses a static method on AwURLRequestContextGetter). To implement this, we must extend the NetworkContext mojo interface. Since this functionality is entirely Android specific (no other OS enforces cleartext at the moment), this exposes this as an Android-only method on the interface. As a special note: we must set the cleartext setting for both code paths, for every run. This is because we configure this setting before the FeatureList itself is initialized, so we can't reliably know which code path we will use. Therefore, we plumb the setting to both code paths, so it's always available for the code path we need. Bug: 899012 Test: run_webview_instrumentation_test_apk \ Test: --enable-features=NetworkService,NetworkServiceInProcess \ Test: --gtest_filter=AwContentsStaticsTest.testSetCheckClearTextPermittedTrue Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Ic4b93fb65e79676cef8eda268ac70725ebdc2517 Reviewed-on: https://chromium-review.googlesource.com/c/1484585Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#635249}
-
Nico Weber authored
Bug: 926235 Change-Id: Idbe191988ab7b912c9b9af2e5c9f266fa633b274 Reviewed-on: https://chromium-review.googlesource.com/c/1486874 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635248}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f6b0439fb639..9dc060116dbd git log f6b0439fb639..9dc060116dbd --date=short --no-merges --format='%ad %ae %s' 2019-02-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1776af77065f..8c1e8f1fb771 (1 commits) 2019-02-25 scroggo@google.com Reland "Treat kWEBP encode with quality=100 as lossless" 2019-02-25 scroggo@google.com Add a wuffs Release bot 2019-02-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 5efe61188243..1776af77065f (1 commits) Created with: gclient setdep -r src/third_party/skia@9dc060116dbd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I4d277300acb50e5923e9fc0ec68fe2f75c5bcdbe Reviewed-on: https://chromium-review.googlesource.com/c/1487134Reviewed-by:
-
vitaliii authored
Enable scrypt key derivation when setting sync custom passphrase in testing/variations/fieldtrial_testing_config.json. Bug: 875901 Change-Id: Idcfb76d8e1c1977875bd401520e665ffb0010399 Reviewed-on: https://chromium-review.googlesource.com/c/1483077 Auto-Submit: vitaliii <vitaliii@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#635246}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/986b2bef7f47..2d403737b88f $ git log 986b2bef7..2d403737b --date=short --no-merges --format='%ad %ae %s' 2019-02-24 marpan vp9-rtc: Fix to Q clamp in adjust_q_cbr 2019-02-22 marpan vp9-rtc: Decrease noise estimation thresh for kLow 2019-02-22 kyslov Fix 32-bit unsigned integer overflow in block_variance 2019-02-21 marpan vp9-rtc: Adjust thresholds for noise estimation. Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I822c29345662f2a24976af4e56af25a1f606c8cf Reviewed-on: https://chromium-review.googlesource.com/c/1487171Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#635245}
-
Robert Ogden authored
Change-Id: Ie6a5dbe84f22c21a296cd7c40a74b6ebb895fbb7 Reviewed-on: https://chromium-review.googlesource.com/c/1484414 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#635244}
-
John Abd-El-Malek authored
Stop running network_service_headless_browsertests on linux bots as network service is now enabled there. Bug: 933880 Change-Id: I9c8122968c0d6f6132a84481cb6e4afe63be2eaa Reviewed-on: https://chromium-review.googlesource.com/c/1487703 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#635243}
-
Mike Wittman authored
Eliminates the internal null Module state in favor of nullptr. Bug: 931418 Change-Id: I8d7f6f00f5433d189542bceb790ca23c5b97fb4d Reviewed-on: https://chromium-review.googlesource.com/c/1478095 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#635242}
-
Etienne Bergeron authored
The trace event is setting an args on a SkString which may no longer exists when the trace event id dumped. This trace event needs to duplicate the string. As this is a SkString, we can't use the default tracing macro that detect a str::string argument. R=oysteine@chromium.org TBR=drott@chromium.org Change-Id: I2935bb8162c79edc2f3dc213eb1600fa7f2183e5 Reviewed-on: https://chromium-review.googlesource.com/c/1486873 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
-
Koji Ishii authored
This was added in r564717 (CL:1084314), but more recent changes that makes NG selection more similar to legacy makes this no longer necessary. Bug: 636993 Change-Id: I181bff37b32f142c2dd1e2897a519f2191a7b607 Reviewed-on: https://chromium-review.googlesource.com/c/1482352 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#635240}
-
Xiaocheng Hu authored
Bug: 935688, 935689, 935690 Tbr: xiaochengh@chromium.org NoTry: True Change-Id: I5c4cab2bb7ebf6cb66dc60a13ac47bf39becd4a3 Reviewed-on: https://chromium-review.googlesource.com/c/1487707Reviewed-by:
-
David Jacobo authored
After intent picker taking a more generic role (not used for ARC apps only), AppsNavigationThrottle was introduced, which implements the throttle logic ArcNavigationThrottle was responsible for before. This CL proposes renaming ArcNavigationThrottle to ArcIntentPickerAppFetcher so it reflects more accurately its usage. Bug: 915852 Test: Previous unit/browser tests passing. Change-Id: I5fceb11524ddac2b74345ce4924aaf3ebfba3b12 Reviewed-on: https://chromium-review.googlesource.com/c/1483704Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635238}
-
Eugene But authored
Bug: 934379 Change-Id: Idaaffef3e449f3ea7250028f6507c5ebb63d1d12 Reviewed-on: https://chromium-review.googlesource.com/c/1483736Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#635237}
-
Jacob Dufault authored
We may want to just use FakeGaia directly instead of introducing a mixin, but that can be decided later. For now let's focus on simplifying all of the test bases. Bug: 912704 Change-Id: Id4a7ab8e0c23343b7e6e59c7b7d2aefc16891515 Reviewed-on: https://chromium-review.googlesource.com/c/1366895 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4a8da2c58a9d..62f4f3343374 Created with: gclient setdep -r src-internal@62f4f3343374 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:916361,chromium:790424,chromium:790423,chromium:790405 TBR=mmoss@chromium.org Change-Id: I4f1e49cb37fb2ed240bc6ca6f8a001890bc0ca3a Reviewed-on: https://chromium-review.googlesource.com/c/1487591Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635235}
-
Joshua Peraza authored
b1739cc67f57 crashpad: Remove semicolons, Windows edition 9d26012e9c73 POSIX: don’t be overly restrictive about mmap() region length dc17650336ad fuchsia: Update MultiprocessExec.BuiltinTrapTermination for task kill revamp 99bf283e54d0 android: Add methods to start handler with /system/bin/linker Change-Id: Ia525db34270c866d1f28fbdf71c9487720a2b110 Reviewed-on: https://chromium-review.googlesource.com/c/1487177 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
-
