- 24 Sep, 2019 40 commits
-
-
Mustapha Jaber authored
This change adds support for navigation-controls media feature, which will initially be used to detect if the user agent supplies a back button present in its UI. This media feature will allow apps to avoid the "double back button" problem by letting them conditionally display a back button depending on whether the user agent is already displaying one. The logic for updating navigation-controls from its default state has not yet been implemented. Spec: https://github.com/fallaciousreasoning/backbutton-mediaquery Bug: 822944 Change-Id: If8bc5054c0591f7e822277a83119273b69aef0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802195 Commit-Queue: Mustapha Jaber <mustjab@microsoft.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#699459}
-
Aaron Leventhal authored
See intent to implement and ship on feature dashboard: https://www.chromestatus.com/feature/4666935918723072 TBR=kinuko@chromium.org Bug: 1006767 Change-Id: I1b5eb7d2f324c4008578e7f7e1cb08a9288520f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816803 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#699458}
-
Gavin Williams authored
Bug: 1001056 Change-Id: I326b21b3e25e472fa15dc9bd9d9c97feb688ad4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815542Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#699457}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e3a5983705da..645a8dea641a git log e3a5983705da..645a8dea641a --date=short --no-merges --format='%ad %ae %s' 2019-09-24 capn@google.com Claim Vulkan 1.1 conformance 2019-09-24 capn@google.com Implement VK_KHR_driver_properties 2019-09-24 sugoi@google.com Revert "Do not call Scheduler destructor in libVulkan." Created with: gclient setdep -r src/third_party/swiftshader@645a8dea641a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/129792032,chromium:b/129792032,chromium:b/141380274 Change-Id: I7cb72632e505463bfabaf31870a124d6500c7c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821966Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699456}
-
Boris Sazonov authored
Removes the sign-out dialog implementation from ConfirmManagedSyncDataDialog and calls to it from AccountManagementFragment, as the correct sign-out dialog for managed accounts is implemented by SignOutDialogFragment. Bug: 1007250 Change-Id: I73fad2459efac5b0a2f27575a2e63adcf8cdf3d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738698 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#699455}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0accebb4. With Chromium commits locally applied on WPT: d4ca0e6e "Add missing worklet referrer tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jrummell@chromium.org: external/wpt/encrypted-media jsbell@chromium.org: external/wpt/storage NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I9aff044501f4fa5d78c3a04b7d9323a4a34b64da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822102Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699454}
-
David Bienvenu authored
This disables the background Native Window Occlusion calculation for WindowOcclusionTrackerTest tests, because it can interfere with the expectations of the tests. Bug: 1007338 Change-Id: Ia4e91a9b5ea748f5ed7e243175a020f69d4d59a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822897Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699453}
-
Renjie Tang authored
A sample netlog that I captured inter-opting with quic.rocks:4433 https://drive.google.com/file/d/1kad8a5-7Rxow-o1eEwckKWLipeLR0as9/view?usp=sharing Search HTTP3 for entries. Change-Id: I3ab02c9b49ebc82ee8ceb040beaacac1a4dea32c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816823 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#699452}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/696ceeee0ff2..61918356b65e git log 696ceeee0ff2..61918356b65e --date=short --no-merges --format='%ad %ae %s' 2019-09-24 treehugger-gerrit@google.com Merge changes Ie37dbea4,Id0cd4617 2019-09-24 nicomazz@google.com Merge "Enable traces download and opening in catapult" 2019-09-24 nicomazz@google.com Merge "Improve adb socket detection logic" 2019-09-24 taylori@google.com Merge "perfetto-ui: Persist timespan highlight" 2019-09-24 lalitm@google.com perfetto: remove license comment 2019-09-24 treehugger-gerrit@google.com Merge "args_tracker: use stable_sort when ordering by row id" Created with: gclient setdep -r src/third_party/perfetto@61918356b65e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I30bcf2652a242e67603eb52bffac46f968fbf3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822279Reviewed-by:
-
Tao Bai authored
PageLoadMetricsEmbedderBase registers common observers for the embedders, the embedders shall derive the implementation from PageLoadMetricsEmbedderBase and initialize its specific observers. Bug: 995880 Change-Id: Ie60163f3191394a63fd144d52f3433a9ec513e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816801 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#699450}
-
Kurt Horimoto authored
This eliminates the boilerplate code of UIViewController setup in the coordinator, as well as the delegate and datasource capabilities provided to the mediator. Bug: 990070 Change-Id: Id0a385a7ebc171f7ff103b9bda1928d1a813eac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809515 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#699449}
-
Mason Freed authored
Prior to this CL, an invalid color filter would cause a renderer crash in software_renderer. This is now fixed. Bug: 1004054 Change-Id: I0182b1dd475d2aab909611aa9a01351863e0632d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819960 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#699448}
-
Yu Han authored
Added NOTREACHED so that in debug build, we'll get the error thrown if this case is encountered. Bug: 625676 Change-Id: If4802d387eba4b4c66488620dd61520ad7a5d78f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822326Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@google.com> Cr-Commit-Position: refs/heads/master@{#699447}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a4f7741ee65c..eb4818bc4652 Created with: gclient setdep -r src-internal@eb4818bc4652 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ibc38b5c11eff9fbf7f19918143acd2380cab12ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822024Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699446}
-
Kurt Horimoto authored
This eliminates the boilerplate code of UIViewController setup in the coordinator, as well as the delegate and datasource capabilities provided to the mediator. Bug: 990070 Change-Id: Ia0c4514476dd7f34770a649816e049c32d26c34a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809898 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Akihiro Ota authored
Change-Id: I2181ab6f31d0f2a36cf46df6c0439e77d526a8fc Bug: 1007368 Change-Id: I2181ab6f31d0f2a36cf46df6c0439e77d526a8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815158 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Switches use of PrintResult in net_perftests to PerfResultReporter and whitelists net_perftests for conversion to histograms before uploading to the perf dashboard. The majority of tests in net_perftests didn't actually use PrintResult, instead just logging to stdout in a format not usable by the parsing script. These have all been changed to use PerfResultReporter as well so that results from these tests actually show up on the perf dashboard. Bug: 923564 Change-Id: I172cd364bdc00a8f59666d8c822c0a3c6482fb8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809116Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Adam Ettenberger authored
This change is an optimization for AXPosition<>::CompareTo. 1. AXPosition<>::CreateParentPosition There was 1 low-hanging optimization here to reduce the number of times |MaxTextOffset| is called. Storing the results of |MaxTextOffset| in a local variable and adding a new virtual method |IsEmbeddedObjectInParent| which can replace the call of |MaxTextOffsetInParent| for this method. So |MaxTextOffset| doesn't need to be computed 3-4x, now only 1x. 2. AXPosition<>::CompareTo Simplifying logic using the recently added |LowestCommonAnchor|. Instead of always computing the TREE position |LowestCommonAncestor| will only do so if one or both positions are tree positions. This reduces the cost for comparing 2 TEXT positions slightly. --- For AXPosition<>::CompareTo, I measured the perf difference with std::chrono::high_resolution_clock on an unoptimized debug build. The document had 2 columns of 100 divs each, each div had a single kStaticText child, and each column had an additional leaf kStaticText. I measured about a 30% perf improvement for comparing text positions. Both when comparing the leaf text positions in each column, and when comparing a leaf text position to a root anchored text position. Comparing tree positions was negligible compared to text positions. Before : a. LHS Branch (this->GetAnchor() == common_anchor) 169.102ms b. RHS Branch (this->GetAnchor() == common_anchor) 164.94ms c. Fallthrough) 313.984ms After : a. LHS Branch (this->GetAnchor() == common_anchor) 111.249ms b. RHS Branch (this->GetAnchor() == common_anchor) 114.441ms c. Fallthrough) 218.247ms --- Bug: 928948 Change-Id: I610f4b5157e85f2a523edf6efa793bbc306b372d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814628 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699442}
-
Ben Kelly authored
Bug: 1006546,1005983,1004041 Change-Id: Ic50205176c645a4ea77948a30b7535908cb41286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819804 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#699441}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 211 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-03-22. Change-Id: Ie04b919e56dfb2877234ccadbe46567f8e743985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822237 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#699440}
-
Ankit Kumar 🌪️ authored
Document links or bookmarks may have horizontal scroll offsets defined in the PDF. Currently the horizontal scroll offsets are not taken into account during navigation of document links or bookmarks. This CL adds the horizontal scroll offset for document links and bookmarks. Tests have been modified to validate the scroll value. Bug: 982176 Change-Id: I80d227b1455db49d35294835dd6ed07f6154ca9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803941Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699439} -
Adrienne Walker authored
Change-Id: I71684e81c6cca77bcf7a84fbb5a65db33497cbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822417 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#699438}
-
Khushal authored
R=ericrk@chromium.org Bug: 992626 Change-Id: I6d106e24e3ee5a328449d59e9c20979bb4d64efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817326Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#699437}
-
Lukasz Anforowicz authored
This CL disallows an unlocked renderer process from accessing origins/urls that require isolation (i.e. require a process lock). The new enforcement works only on the UI thread - calls to CanAccessDataForOrigin on the IO thread will unfortunately continue to allow access for all unlocked renderer processes. See also https://docs.google.com/document/d/17t85azUYz-Wzo9vPrrghd47ilxjqCryDNJPGROKc8Es The new enforcement is enabled only on Android. On desktop, the citadel-style enforcement is blocked by NTP support for OOPIFs - see https://crbug.com/566091 and also https://docs.google.com/document/d/1jtanAByotYMaJzdxd2aIknwoVz1kjxL_HAR_mKBsJls Bug: 764958 Change-Id: I7864ca737c14c26c3c8cefe3cc2887028f891679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545157Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#699436}
-
Carlos Caballero authored
MessageLoopFor is going away soon. Bug: 891670 Change-Id: I9e2521c6f3479ffb2dc7f9806620bd185320577a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821921Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#699435}
-
Christy Chen authored
In the Network condition tools, user facing strings in the dropdown menu of user agent options are not localized. https://imgur.com/ZDp4j8D In this change: - adds ls() calls to those strings in NetworkConfigView.js. - GRDP changes are generated automatically, with manually written descriptions - Placeholders (<ph name="LOCKED_1">) are added in the grdp to prevent translations of the branding related strings. Bug: 941561 Change-Id: Ib274dd425733d0ef4f4199ff6334810f113ade27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816184Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Mandy Chen <mandy.chen@microsoft.com> Commit-Queue: Christy Chen <chrche@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699434}
-
Raul Tambre authored
Conversion performed automatically using '2to3 -w -f has_key .'. This is backwards compatible with Python 2. Bug: 941669 Change-Id: Ia884751c572c6bbe94cea10831f010e85f9e59fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817600Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#699433}
-
Tommy Li authored
Adds a metric to track how unstable our matches are due to asynchronous updates. Whenever a dropdown position gets asynchronously set to a new match that's different from the old match, this histogram logs the index. Bug: 398135 Change-Id: I9e7ba88c2ad8be616d933649805697aeb23cd938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803830 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#699432}
-
Abigail Klein authored
Bug: 949340, 785493 Change-Id: I2c467420ae4a250253071f9ce7d1c77a4b42aa32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817107 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
-
Fredrik Söderquist authored
Since we (now) know which instance times originated as offset-values in the attribute, we can clear those out before (re)parsing the attribute, rather than keeping a set of existing times and filter against those. The only potential downside is that this filtering step is O(n^2). When doing this we can also remove the HashTraits and associated bits for hashing SMILTimes. Also start exposing the origin from SMILTimeWithOrigin directly and change the (few) users. Adding of the implicit '0s' begin-time is now also done in ParseBeginOrEnd if needed since it is also treated as having 'attribute' origin. Bug: 1005185 Change-Id: I3bdf6a099d5853683cbbb516d8778e587353c3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818481 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#699430}
-
Tim van der Lippe authored
This includes the update to escodegen to 1.12.0 Change-Id: Ib186ca573c9435caaba9556fc6e85b122af219c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821609Reviewed-by:
-
Bin Du authored
Bug: internal bug id b/130928904 Change-Id: I051aa85d6e43e92b66b37ec420fbcc70060ac79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814674 Commit-Queue: Bin Du <dubin@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#699428}
-
Robert Ogden authored
Also bumps the expirations. Change-Id: I4f88f6e2dfef4a605f1bb2b9c4b68b87f2df385a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822325 Commit-Queue: Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#699427}
-
Nathan Zabriskie authored
https://chromium-review.googlesource.com/c/chromium/src/+/1764515 introduced a DCHECK that was being hit in views_examples_exe. Adding values to the SwapTimings submitted by DirectOutputSurface fixes the problem. Change-Id: Ic82b6dc8570811576c6f4b48f1fcbac1cd9c9e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820046 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#699426}
-
Mandy Chen authored
ServiceWorkerVersionRunningStatus is sent through CDP and displayed directly to the user in DT. This CL localizes the running status strings in the frontend. Location of the running status strings: https://imgur.com/pIZZCqo ServiceWorkerVersionRunningStatus: https://chromedevtools.github.io/devtools-protocol/tot/ServiceWorker#type-ServiceWorkerVersionStatus Bug: 941561 Change-Id: I14142f6fa0e95d6392e26676e450041b8207929c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814501Reviewed-by:
-
danakj authored
We have the min/max page zoom factors limits and methods to convert between "page zoom factor" and "page zoom level" in - content/common/page_zoom.h - blink/renderer/core/exported/web_view_impl.cc - blink/public/web/web_view.h Instead of duplicating the limits and the logic, consolidate it all into a single blink public header. content/browser/ and components are able to include blink public headers, they just can't link against blink. The new site is in blink/public/common/page/page_zoom.h This updates all callers to point to this common site, and removes the redundant ones in content/common/ and WebView{Impl}. R=dcheng@chromium.org TBR=darin Bug: 419087 Change-Id: Ib89f022d96c9ac7ebfd4b84c08f666a25458725a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814857 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:Darin Fisher <darin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Chris Davis authored
This change fixes an issue with the delayloads_unittest.cc not respecting the is_multi_dll_chrome set to false. This is needed in anticipation of the change to merge chrome.dll and chrome_child.dll. Bug: http://crbug.com/726150 Change-Id: Iccc35c2bcb2b952c871da2fa43eff211fb1df3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809671 Commit-Queue: Chris Davis <chrdavis@microsoft.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699423}
-
Matt Simmons authored
* If in incognito, hide the MV tile layout. * Start MVC'ing the MV tile list component. * Add tests for MVC'ed bits. Bug: 985386 Change-Id: I479756d2c28bb1dd743821e84803f6b53b68c669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814575Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#699422}
-
Marc Treib authored
Bug: none Change-Id: I77ac2637794507da16e2d172600c4839f2aa2dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821603 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#699421}
-
K Moon authored
This change adds a mutable PDFEngine* field to TestClient. This can be useful whenever the TestClient needs to call back into the PDFEngine. Note that creating an engine requires a PDFEngine::Client, so the reference from the client to the engine must be set after construction. For PDFiumEngine specifically, PDFiumTestBase::InitializeEngine() provides a convenient way to create an engine and initialize it from a PDF file. The TestClient may need to call into the PDFEngine before the PDF is fully loaded, however, so InitializeEngine() now takes care of setting the backreference on the client. Bug: 885110 Change-Id: I4f1cea5b40c995f91fcac32ff49d7de931505c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812134 Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by:
-
