GitLab

This patch includes the correct GN changes.

This CL does the following:
* Fixes the component build
* Limits the length of LogEntry strings
* Cleans up the code a little to help with crash debugging

BUG=479095
For device_event_log gypi:
TBR=reillyg@chromium.org

Review URL: https://codereview.chromium.org/1140643002

Cr-Commit-Position: refs/heads/master@{#329320}

Add NetworkChangeNotifierFactoryCast to create instance of
NetworkChangeNotifierLinux that ignores interfaces that will not be
used to connect to internet.

BUG=469863
R=gunsch@chromium.org,byungchul@chromium.org,wzhong@chromium.org

Review URL: https://codereview.chromium.org/1137483004

Cr-Commit-Position: refs/heads/master@{#329319}

Move priority and is_occluded from Tile to new PrioritizedTile class.

Logged https://code.google.com/p/chromium/issues/detail?id=485705 for the traceviewer change

BUG=483293

Review URL: https://codereview.chromium.org/1130123003

Cr-Commit-Position: refs/heads/master@{#329318}

The following TODO existed in mime_sniffer.cc since 2008:

// TODO(abarth): we don't handle partial byte matches yet
// MAGIC_NUMBER("video/mpeg", "\x00\x00\x01\xB")
// MAGIC_NUMBER("audio/mpeg", "\xFF\xE")
// MAGIC_NUMBER("audio/mpeg", "\xFF\xF")

video/mpeg is not sniffed by Firefox or IE, and is not required to be sniffed by the spec at https://mimesniff.spec.whatwg.org/.

audio/mpeg is already sniffed for the common case where the file starts with an ID3 tag. The uncommon case where it starts with "\xFF\xF." is too broad (it matches the little-endian UTF-16 byte-order-mark), and is not required by the spec.

Remove the TODO.

TEST=net_unittests
BUG=

Review URL: https://codereview.chromium.org/1138483004

Cr-Commit-Position: refs/heads/master@{#329317}

This CL renames the section in the manifest, so it's more meaningful.

TEST=Refactoring only.
BUG=474146

Review URL: https://codereview.chromium.org/1137813003

Cr-Commit-Position: refs/heads/master@{#329316}

PaintRecorder needs to present a gfx::Canvas instead of an SkCanvas.
Currently it does so via CreateCanvasWithoutScaling which returns
a new Canvas allocated on the heap. But mallocs are terrible, so
instead make it a constructor and have the canvas allocated as part
of ui::PaintRecorder on the stack.

This changes the time to record a single tab loading spinner from
0.138818 ms to 0.124487 ms per frame for a 10% reduction in time.

R=sky
BUG=466426

Review URL: https://codereview.chromium.org/1124223010

Cr-Commit-Position: refs/heads/master@{#329315}

Also add a version that runs plugin power saver.

We'd like to compare a set of flash-heavy pages with or without
plugin power saver.

R=sullivan@chromium.org
BUG=478918

Review URL: https://codereview.chromium.org/1137613002

Cr-Commit-Position: refs/heads/master@{#329314}

palmer@ recently introduced SchemeIsCryptographic() and
IsOriginSecure(), which are meant to replace SchemeIsSecure().

IsOriginSecure() roughly means "do we trust this content not to be
tampered with before it reaches the user?" [1] This is a higher-level
definition that corresponds to the new "privileged contexts" spec. [2]

SchemeIsCryptographic() [3] is close to the old definition of
SchemeIsSecure(), and literally just checks if the scheme is a
cryptographic scheme (HTTPS or WSS as of right now). The difference is
that SchemeIsCryptographic() will not consider filesystem URLs secure.

[1] https://code.google.com/p/chromium/codesearch#chromium/src/content/public/common/origin_util.h&sq=package:chromium&type=cs&l=19&rcl=143099866
[2] https://www.chromium.org/Home/chromium-security/prefer-secure-origins-for-powerful-new-features and https://w3c.github.io/webappsec/specs/powerfulfeatures/
[3]  https://code.google.com/p/chromium/codesearch#chromium/src/url/gurl.h&sq=package:chromium&type=cs&l=250&rcl=1430998666

BUG=362214

Review URL: https://codereview.chromium.org/1131493004

Cr-Commit-Position: refs/heads/master@{#329313}

- Removes media-router-sink custom element.
- Removes media-router-sink-picker custom element.
- Replaces media-router-sink with paper-item (material).
- Replaces media-router-sink-picker with core-menu.
- Removes sink type icons.

Review URL: https://codereview.chromium.org/1133853003

Cr-Commit-Position: refs/heads/master@{#329312}

The test is timing out there.

TBR=miu@chromium.org
BUG=487033

Review URL: https://codereview.chromium.org/1130293004

Cr-Commit-Position: refs/heads/master@{#329311}

SchemeIsCryptographic().

We recently introduced SchemeIsCryptographic() and IsOriginSecure(),
which are meant to replace SchemeIsSecure().

IsOriginSecure() roughly means "do we trust this content not to be
tampered with before it reaches the user?" [1] This is a higher-level
definition that corresponds to the new "privileged contexts" spec. [2]

SchemeIsCryptographic() [3] is close to the old definition of
SchemeIsSecure(), and literally just checks if the scheme is a
cryptographic scheme (HTTPS or WSS as of right now). The difference is
that SchemeIsCryptographic() will not consider filesystem URLs secure.

IsOriginSecure() should be correct for most Fizz code.

[1] https://code.google.com/p/chromium/codesearch#chromium/src/content/public/common/origin_util.h&sq=package:chromium&type=cs&l=19&rcl=143099866
[2] https://www.chromium.org/Home/chromium-security/prefer-secure-origins-for-powerful-new-features and https://w3c.github.io/webappsec/specs/powerfulfeatures/
[3] https://code.google.com/p/chromium/codesearch#chromium/src/url/gurl.h&sq=package:chromium&type=cs&l=250&rcl=1430998666

BUG=362214

Review URL: https://codereview.chromium.org/1136643004

Cr-Commit-Position: refs/heads/master@{#329310}

The crash was probably due to accessing a dangling pointer to the plugin
container during a small time frame between PepperWebPluginImpl::destroy()
and the destructor being called. (Speculated from source since no reliable
repro is found.)

This CL clears eveything in the destroy() function as if the destructor has
been called, only delaying memory release.

R=tommycli
BUG=483068

Review URL: https://codereview.chromium.org/1137663006

Cr-Commit-Position: refs/heads/master@{#329309}

The C++ define OFFICIAL_BUILD wasn't getting set, and the widevine version .rc files was getting linked twice.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

R=dpranke
TBR=ddorwin@chromium.org

Review URL: https://codereview.chromium.org/1134623003

Cr-Commit-Position: refs/heads/master@{#329308}

Revert of Restrict use of hardware-secure codecs based on the RendererPreference. (patchset #11 id:210001 of https://codereview.chromium.org/1124863005/)

Reason for revert:
Compile failure in KeySystemConfigSelectorTest::SelectConfig().

../../media/blink/key_system_config_selector_unittest.cc:177:57: error: too few arguments to function call, expected 6, have 5

http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/113

Original issue's description:
> Restrict use of hardware-secure codecs based on the RendererPreference.
>
> This passes the value of |use_video_overlay_for_embedded_encrypted_video| from RendererPreferences to requestMediaKeySystemAccess() so that it can correctly block either non-hardware-secure codecs or hardware-secure codecs.
>
> BUG=467779
>
> Committed: https://crrev.com/491fea8c41977b1557a79cf2f53d4b60ecd159d9
> Cr-Commit-Position: refs/heads/master@{#329296}

TBR=xhwang@chromium.org,ddorwin@chromium.org,nasko@chromium.org,sky@chromium.org,sandersd@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=467779

Review URL: https://codereview.chromium.org/1137993004

Cr-Commit-Position: refs/heads/master@{#329307}

Review URL: https://codereview.chromium.org/1137073003

Cr-Commit-Position: refs/heads/master@{#329306}

There's two possible stable values for |titleY_|,
kPrimaryTextPosTop - when status message is visible,
kPrimaryTextOnlyPosTop - when status message is not visible.

There was an inconistency how this was being initialized -
as isStatusTextVisible_ was being set to NO but the value
was set to kPrimaryTextPosTop.

The text would then be misaligned if the code would take
the -hideSecondaryTitle in -setStateFromDownload:.

This CL fixes the issue and updates the test to check this.

BUG=484848

Review URL: https://codereview.chromium.org/1130903004

Cr-Commit-Position: refs/heads/master@{#329305}

The most significant change is to expose its public/ directory.
This requires simultaneous path changes in src/pdf.

This pulls in:
2daf76f Add owners file for PDFium
ac19d2d Create top-level public/ header directory.
0627231 Move function prototypes to new doc_utils.h file
6661fd4 Fix compilation under chromium checkouts.
17ea732 Better error from pdfium_test when page too big to render.
470408c Fix errors from commit f0a169e.
f0a169e Fix a bunch of -Wunused-but-set-variable warnings.
21031ad Support arrays in nonstd::unique_ptr<>.
1fd0b10 Manual revert of ad2a822ce5c3
9ea57a4 Remove FX_STRSIZE casts, use safe conversions

BUG=pdfium:154

Review URL: https://codereview.chromium.org/1140603002

Cr-Commit-Position: refs/heads/master@{#329304}

The total available size is now returned by GetHeapStatistics api.
This CL uses the value in the dump provider to show the value in
other_spaces segment of the memory dump.

BUG=481504

Review URL: https://codereview.chromium.org/1129403003

Cr-Commit-Position: refs/heads/master@{#329303}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/38a0fb8..60d9c66

TBR=yosin@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1132533005

Cr-Commit-Position: refs/heads/master@{#329302}

Revert of Adjusts dragging logic to be less likely to trigger false positive switch from snapping to docking (patchset #5 id:90001 of https://codereview.chromium.org/1127133003/)

Reason for revert:
I suspect this is causing a browser_tests failure on the bots:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/2069
https://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/1913

Sorry!

Original issue's description:
> Adjusts dragging logic to be less likely to trigger false positive switch from
> snapping to docking.
>
> This CL adjusts the logic which selects whether a window will be snapped to
> half of the workspace width or will be docked at the end of the drag when the
> window is dragged to the edge of the workspace in the special case of the dock
> being visible. The CL makes it easier to snap a window to half the workspace
> width in this special case (and harder to inadvertently dock the window)
>
> BUG=484877
> TEST=None
>
> Committed: https://crrev.com/988c697aff35b3fd347dec35f2f2ac159c8328a9
> Cr-Commit-Position: refs/heads/master@{#329268}

TBR=pkotwicz@chromium.org,varkha@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=484877

Review URL: https://codereview.chromium.org/1128933005

Cr-Commit-Position: refs/heads/master@{#329301}

BUG=472700
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/1129033008

Cr-Commit-Position: refs/heads/master@{#329300}

This CL adds a histogram to track the length of the app list search query
at the time a result is opened. This will provide information about the
efficiency of users of the app list search.

BUG=485449

Review URL: https://codereview.chromium.org/1128413002

Cr-Commit-Position: refs/heads/master@{#329299}

BUG=228694

Review URL: https://codereview.chromium.org/1134123004

Cr-Commit-Position: refs/heads/master@{#329298}

Update to newer version (closure dependencies have been removed).

BUG=485567

Review URL: https://codereview.chromium.org/1138123002

Cr-Commit-Position: refs/heads/master@{#329297}

This passes the value of |use_video_overlay_for_embedded_encrypted_video| from RendererPreferences to requestMediaKeySystemAccess() so that it can correctly block either non-hardware-secure codecs or hardware-secure codecs.

BUG=467779

Review URL: https://codereview.chromium.org/1124863005

Cr-Commit-Position: refs/heads/master@{#329296}

This way it won't leak if destroyed. Also cleaned up html_viewer's use
of ResourceLoader.

R=ben@chromium.org
TBR=ben@chromium.org
BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1132083003

Cr-Commit-Position: refs/heads/master@{#329295}

Clang has an apparent bug on arm64 which causes it to replace elements of the
|cases| array with garbage.  Removing \0 from the end of the string constant
works around this bug.  Tracked in https://llvm.org/bugs/show_bug.cgi?id=23437.

BUG=477682
TEST=Arm64 iOS bots go green.

Review URL: https://codereview.chromium.org/1132063004

Cr-Commit-Position: refs/heads/master@{#329294}

BUG=481687

Review URL: https://codereview.chromium.org/1132873002

Cr-Commit-Position: refs/heads/master@{#329293}

Merge this with DidNavigateToPage since they are called and essentially called
in the same time (after page.Navigate & before page.RunPageInteractions)

BUG=455391, 470147

Review URL: https://codereview.chromium.org/1139823002

Cr-Commit-Position: refs/heads/master@{#329292}

BUG=486738
R=stevenjb@chromium.org, pneubeck@chromium.org

Review URL: https://codereview.chromium.org/1137633003

Cr-Commit-Position: refs/heads/master@{#329291}

After crrev.com/1117423002 VideoFrames can carry three textures, each
one representing a different YUV plane.
VideResourceUpdater needs to create a YUV external resource in case the
VideoFrame contains three native texture representing a frame in YUV420.

BUG=485859

Review URL: https://codereview.chromium.org/1127423006

Cr-Commit-Position: refs/heads/master@{#329290}

Without this on android we don't open the browser to fill the screen,
nor resize when the rotation changes.

R=ben@chromium.org
BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1141453002

Cr-Commit-Position: refs/heads/master@{#329289}

This is to understand why Issue 476559 is happening.

BUG=476559

Review URL: https://codereview.chromium.org/1136053003

Cr-Commit-Position: refs/heads/master@{#329288}

Writes to lossy prefs should not trigger writes to disk to be scheduled.
This behavior is implemented for JsonPrefStore. CommitPendingWrites will
ensure that all outstanding lossy writes are also written to disk.

BUG=476800

Committed: https://crrev.com/e9d8c9882ca272c803711e26ded4dd7d5203a59e
Cr-Commit-Position: refs/heads/master@{#329122}

Review URL: https://codereview.chromium.org/1127963002

Cr-Commit-Position: refs/heads/master@{#329287}

This enables unit tests to run with Bluetooth permission,
by adding the Bluetooth permission to native_test.

Non-test applications will not have the Bluetooth permission,
and unit tests should also verify behavior
when the permission is not given. To enable this
createWithoutPermissionForTesting is added and
results in a state equivalent to when the permission
is not available.

Unit tests will be built in parallel for both when Bluetooth
permission exists and doesn't.

BUG=471536

Committed: https://crrev.com/30e81472dc168ea1c331a8779b3f6a14f684c54b
Cr-Commit-Position: refs/heads/master@{#329212}

Review URL: https://codereview.chromium.org/1129683002

Cr-Commit-Position: refs/heads/master@{#329286}

BUG=464922

Review URL: https://codereview.chromium.org/1129123004

Cr-Commit-Position: refs/heads/master@{#329285}

This CL introduces the 'gaia-icon-button' decorator, which can be applied to any
<button>.
All icon buttons introduced recently are <button is="gaia-icon-button">s now.

BUG=478545,472671
TEST=manual

Review URL: https://codereview.chromium.org/1133733003

Cr-Commit-Position: refs/heads/master@{#329284}

This change was reverted in r322170 due to WebView breakage. The
ApplicationStatus dependency has been made optional, allowing
WebView to opt-out of its use. It was speculatively reverted
again in r327092, but that turned out to be a false alarm.

Original description: ----------------------------

Currently, when an activity is stopped, we explicitly hide the
foreground Tab. This is problematic, as current hiding semantics
might clear the visual front buffer before the window is hidden.
This in turn causes an unpleasant flickering during activity
transitions, e.g., when backgrounding Chrome or locking the screen.

Wire Activity onPause/onResume notifications to WindowAndroidObservers,
allowing the foreground tab to preserve its front buffer while hiding
its web content. If the tab is explicitly hidden, or the root window
is lost, the front buffer will be cleared as usual.

BUG=481450,434401

Review URL: https://codereview.chromium.org/1001573003

Cr-Commit-Position: refs/heads/master@{#329283}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ff93a86..38a0fb8

TBR=yosin@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1128003004

Cr-Commit-Position: refs/heads/master@{#329282}

http://crrev.com/328649 changed VideoRendererImpl so that it only
posted AttemptRead() when there was space in the queue.  Unfortunately
this causes more dropped frames for demanding content (H.264 4K in
particular) than always posting since the AttemptRead() call may be
delayed for some time:

AttemptRead() TimeFromPostUntilExecuted: 0.076 ms
AttemptRead() TimeFromPostUntilExecuted: 4.613 ms
AttemptRead() TimeFromPostUntilExecuted: 56.158 ms
AttemptRead() TimeFromPostUntilExecuted: 56.197 ms
AttemptRead() TimeFromPostUntilExecuted: 52.214 ms
AttemptRead() TimeFromPostUntilExecuted: 35.555 ms
AttemptRead() TimeFromPostUntilExecuted: 18.917 ms

At the same time, the performance improvements I saw locally on my
MacBook are not reflected by the performance bots.  I further see the
dropped frame regression locally on Windows, so let's revert.

I considered a couple other solutions to avoid always posting, but
none were very glamorous:
- Release lock before calling AttemptRead(), fixes cases where Render()
was blocked on the lock in FrameReady().
- Checking the end time / ideal render count for the current frame and
posting on when we're almost expired...

In both cases, neither resolved all problem cases and both add more
complexity than just posting.  The task will abort trivially if there
is no work to do, so just revert.

BUG=439548
TEST=telemetry dropped frame count is lower.

Review URL: https://codereview.chromium.org/1135143002

Cr-Commit-Position: refs/heads/master@{#329281}