- 11 Oct, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0912f5e649f3..d6527adcbefb Created with: gclient setdep -r src-internal@d6527adcbefb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iee3b8db7235fe2b826e28eacca96d38163d60f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857162Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705287}
-
Andrew Xu authored
This CL adds the rounded corners for |shelf_container_view_|. It helps to cut off the child view outside of scrollable shelf's bounds. Bug: 1009368 Change-Id: I47119b7126100753f9c7ded2d9a6cde67fc44e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848345 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#705286}
-
Elly Fong-Jones authored
This change adds two new global key bindings: Command-Option-UpArrow traverses to the next accessible pane Command-Option-Shift-UpArrow traverses to the previous accessible pane This allows keyboard access to: * The downloads bar * Bubbles that don't grab focus when they appear * The toolbar etc etc. This is the approach proposed by UX in https://bugs.chromium.org/p/chromium/issues/detail?id=919260#c20, but I decided to use the (imo more Mac-like) "shift means backward" convention rather than using DownArrow for forward and UpArrow for backward. Bug: 919260,956432,945923 Change-Id: I4d15d706b903d1be9d1894725f96107a4b6b1373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856888 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#705285}
-
Kevin DiClemente authored
Initialize allow_default_credentials before being used in HttpNetworkSession::QuicInfoToValue(), as this can cause a use-of-uninitialized-value in net::FileNetLogObserver::FileWriter::WritePolledDataToFile, where in JSONWriter::BuildJSONString, for Value::Type::BOOLEAN, node.GetBool() contains an uninitialized value. Change-Id: Ia3c1f530046c246255cde9394b04773eb5d9ccac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853991 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#705284}
-
Xianzhu Wang authored
These tests failed on the try bot linux_layout_tests_layout_ng_disabled with and without patch. Blindly rebaseline them to save CPU of the bot by avoiding additional steps. Also remove outdated disable-blink-features=LayoutNG/virtual/disable-blink-gen-property-trees TBR=kojii@chromium.org Change-Id: Iba3bee92f93283759414940a222d66a54708b5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856881Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705283}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/80f53b785b37..6787f232aedd git log 80f53b785b37..6787f232aedd --date=short --no-merges --format='%ad %ae %s' 2019-10-11 saza@webrtc.org Remove AudioProcessing::level_estimator() getter 2019-10-11 eladalon@webrtc.org Fix WebRTC-Video-MinVideoBitrate for VP9 2019-10-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3d7980bd..da0e48ef (705004:705127) 2019-10-11 srte@webrtc.org Adds support for stopping fake TCP cross traffic. Created with: gclient setdep -r src/third_party/webrtc@6787f232aedd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I7f64a1a1c5e6f553481b123b1ca4ba8b63a6c3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857160Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705282}
-
Fabrice de Gans-Riberi authored
The "hub" feature is the permanent replacement for the "deprecated-shell" feature. Bug: 977730 Change-Id: I3212a39f8d8acce39a33470d63a5dc1d8aa4d965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848651 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#705281}
-
Oystein Eftevaag authored
R=ssid@chromium.org Change-Id: Ifacbffb22fdbc7aeb6abf96fe3dd85edbc075c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850772Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#705280}
-
Ahmed Fakhry authored
This CL implements the following: - Launching Chrome either from the Shelf, or from the Launcher, the current active desk is favored to find a tabbed browser. This means if active desk doesn't have a browser window, a new one will be created to host the new tab, even if there exists another browser windows on other desks. - Launching an app that opens in a tab will behave the same way as above if it is being launched from the Launcher. However, clicking on its icon in the shelf will switch to the desk that contains its tab (if any), otherwise it will launch a new instance. BUG=1009505 TEST=Manually, Added tests. Change-Id: I139af619aaf4337de6c944b7018eaef6ee454148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842624Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#705279}
-
Josh Nohle authored
EasyUnlockServiceRegular::RefreshCryptohomeKeysIfPossible() now just calls CheckCryptohomeKeysAndMaybeHardlock(). The method's refresh functionality was removed in http://crrev/c/1306348. Bug: 1013682 Change-Id: Id7789c7cde15303251470afb97eda5f49c6896fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856880 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#705278}
-
Toni Barzic authored
Same as for shared app list configs, if vertical space available to app list grid is extremely limited, non-shared configs should be scaled down to save as much space as possible. Change-Id: I5347b39723cc556eeda88061b8e9f5a181b6c803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854636 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Henrique Nakashima authored
All usages should be from FeatureUtilities. Change the usages from other classes to go through FeatureUtilities. This is a step to avoid collateral effects from refactoring FeatureUtilities. Bug: 1012975 Change-Id: I2efc779784bafc56cd2ae32392a6e2ab1377fbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854858 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#705276}
-
Sidney San Martín authored
It's been said before and will be said again: keyboard event handling in Chrome is a monster. Several things came together to make this happen: First, in most Mac apps, cmd+w closes the dictionary popover if it's visible. This specifically happens through the `performClose:` action sent by the main menu. But, in Chrome, cmd+w closes the tab and not the window, so cmd+w sends a different action. This meant that cmd+w originally closed the tab and left the dictionary popover floating. This was fixed many years ago (see r118131 and r322075) by making `-[AppController menuNeedsUpdate:]` check the current target of `performClose:` and only map cmd+w to "close tab" when the target is a browser window. This would work but for another layer of keyboard shortcut handling trickery. For a number of reasons (see comment beginning "If this keyEquivalent" added in r565490), Chrome doesn't actually let `NSMenuItem`s send their own actions. Instead, ChromeCommandDispatcherDelegate determines which menu item *would* have been targeted by a given event, then handles the event itself. The end result is that, when the dictionary popover is visible, the menu items are successfully remapped so that cmd+w means "Close Window". But, any actual cmd+w event is grabbed by ChromeCommandDispatcherDelegate and sent directly to Chrome's own keyboard shortcut handling… so the browser window closes. This change adds a check that was proposed back in r322075, and makes ChromeCommandDispatcherDelegate only grab the event when the found menu item's action would be sent to its own window. Bug: 947752 Change-Id: Ib32988d5fb69c79f899069feb02f7529ea05225f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849431 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#705275}
-
Clark DuVall authored
This makes it so various inputs (e.g. file input, submit button) have the correct labels. Change-Id: I5d49dc5d2d71a92fedfd0a6748ad142454e0e55a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856845Reviewed-by:
-
Anastasia Helfinstein authored
After feedback from leberly@ that the significance of the dashed focus rings used by Switch Access is unclear, we are changing that behavior. Per a discussion with lpalmaro@ and jasonwan@, the new behavior is to show a dashed focus ring around the "next" focus when selecting the element has a primary effect of changing the focus (i.e. selecting the back button or entering a group), and no dashed ring otherwise. The previous behavior was to always show the dashed ring as the current group's location. Bug: 996392 Change-Id: I5f13df27f7a57818cd0cca9f118fe46581009071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848352 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#705273}
-
Adam Langley authored
If FidoCableDiscovery was only provided with v2 pairing information then it wouldn't send any advertisements, but also wouldn't signal that it was ready. BUG=1002262 Change-Id: I0e15d0017ec97891316c0fe1ea83761384676e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857298Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#705272}
-
Manu Cornet authored
Bug: None Change-Id: I6110495e02aca81c2f9fead9037fcc1be0352255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855219Reviewed-by:
-
Ian Kilpatrick authored
Realized it was easier to read this in reverse that what was happening previously. Probably just as a result of it being moved away from NGPaintFragment at some point. Change-Id: I0bc29a0b6868c8c47a69bfdc82cbc8a8c9017eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856723 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#705270}
-
Lei Zhang authored
Replace the std::unique_ptr<base::Value> parameter to base::Value. Bug: 1012811 Change-Id: Id63d78a0ce54a381822b911ce67caf5afe38b3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848857Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705269}
-
Sahel Sharify authored
This cl reads supported delegations of an installable payment app from its web app manifest for just in time installation. With this change an installable payment app can specify whether or not they will provide shipping address and/or payer's contact information in their app manifest. Change-Id: I278bf5484bb52f5f02e3d66193e6f705b5313ab3 Bug: 984694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834421Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#705268}
-
John Budorick authored
One of the shards times out when running w/ just 2 shards. Bug: 1011494 Change-Id: Ie1764870e928373e0fee97db957ebc60cc501019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856844 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705267}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c3fdfcff. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" 1644eff7 "Update scroll to text feature detectability API" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mlamouri@chromium.org: external/wpt/mediasession NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I36aa5e20ad2e4f6e9d89043096273da706ccf2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855381Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705266}
-
Roman Sorokin authored
Also removed ShellObserver from LockLayoutManager Bug: 833348 Change-Id: Ic4e899145eb7751ff5c089193e7733017383ff03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855939Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705265}
-
gogerald authored
This CL is based on https://chromium-review.googlesource.com/c/chromium/src/+/1824554/3 It is the fourth patch of splitting the bigger one https://chromium-review.googlesource.com/c/chromium/src/+/1797069 It also unifies the record of the 'Android.OmniboxFocusReason' metrics. Screenshot: https://drive.google.com/file/d/1YlxcF40SYtGVj9K0YgviQtnt5tdGFm-m/view?usp=sharing Bug: 982018, 1012275 Change-Id: I16d045777164d49d72356af474e5c186c8318370 Binary-Size: crbug.com/998206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824126 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#705264}
-
Justin Gallagher authored
Chrome's translation system only supports translating no (Norwegian), not nb (Norwegian Bokmal). To alias the language codes, there's a map in language_util.cc that converts between the UI language and the translation language. This works fine for Filipino, where there is a 1-to-1 mapping between UI language code to translate code. However, Chrome technically supports both variations of Norwegian as UI languages. When trying to add no, the mapping kicks in and instead adds nb to the language list. Rather than mapping both ways, we should map nb to no for translate, but retain no for the UI language. Test: Open chrome://settings/languages, and attempt to add Norwegian to the languages list. You should see Norwegian listed - without this fix, Norwegian Bokmal is added instead. Bug: 842126 Change-Id: Ib564602e52a70589a5e0fa6a7a4aac813f9207e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834577Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Justin Gallagher <jugallag@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705263}
-
Francois Doray authored
::GetThreadPriority() sometimes returns -3 or -6 on bots. -3 https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8900924268806719008/+/steps/base_unittests/0/logs/PlatformThreadWinTest.SetBackgroundThreadModeFailsInIdlePriorityProcess/0 -6 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8900658140238913376/+/steps/browser_tests__with_patch__on_Windows-10-15063/0/logs/Flaky_failure:_BackgroundFetchBrowserTest.OfflineItemCollection_VerifyResourceDownloadedWhenDownloadTotalSmallerThanActualSize__status_FAILURE_SUCCESS_/0 Handling these values is a prerequisite to enable THREAD_MODE_BACKGROUND_* by default. Bug: 931720, 919466 Change-Id: Ib109a06bf95907a2988427158ea233b8395bf1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829570 Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
-
Adam Langley authored
QR codes for caBLE v2 pairing are only valid for a limited time period. Some devices cannot scan and advertise within a two-second window thus this change increases the window to four seconds. It also includes extra debugging to help identify if this increase is insufficient. BUG=1002262 Change-Id: I0f201a08fd6ac5003411472a51831c9b90beb0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856683 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
-
Ken Rockot authored
This switches Network Service to a simpler service model which does not involve the Service Manager. Instead, the browser directly controls a singleton Network Service process or in-process instance. This should not change existing Network Service lifetime or behavior; it only gives the browser direct control of process lifetime instead of relying on the Service Manager to do that work. Bug: 977637 Change-Id: I626ec8bec935e02f7c0d66a3c379a5fc0c547a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673442 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#705260}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/741c0aa6f5a1..bbf0ce28f06a git log 741c0aa6f5a1..bbf0ce28f06a --date=short --no-merges --format='%ad %ae %s' 2019-10-11 tobine@google.com Vulkan:Add support to stage D or S textures Created with: gclient setdep -r src/third_party/angle@bbf0ce28f06a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: If3d70582f2101a4b2c94cf5676e1f1f5460050b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856838Reviewed-by:
-
Patrick Monette authored
This feature has already been removed from the code base. Bug: 73098 Change-Id: Ic6b5fc5660000f75a5f8bb474af1e5ba760bc6fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853948Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#705258}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4d4275fc6a5d..ec08b81b4fde git log 4d4275fc6a5d..ec08b81b4fde --date=short --no-merges --format='%ad %ae %s' 2019-10-11 manojgupta@google.com cros_fuzz: Install 'virtual/implicit-system' Created with: gclient setdep -r src/third_party/chromite@ec08b81b4fde If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Idbfce4859639091fd955d9521325810c5f270c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857198Reviewed-by:
-
dalyk authored
Bug: 985589 Change-Id: Iab4c0a05ddaac3f26f4fa39b88efca55072bd5f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846321Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#705256}
-
Adam Langley authored
The code tries to avoid logging caBLE devices multiple times by recording already-logged information. This works when the device advertises a constant set of UUIDs but |emplace| doesn't overwrite existing elements in a map so fails when the device changes its configuration. This change fixes that. Change-Id: I15788f54c62d4ae5e0d0cd98563c41cc66be7077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856682 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
-
Maksym Onufriienko authored
Per Xcode release notes, setting FramebufferServerRendererPolicy to 'none' will allow CoreSimulator to skip compositing operations in the virtual frame buffer. This may improve test performance. To avoid any unexpected complications, first delete this value before and after each test run. In a followup CL, this value can be set to 'none' without potentially breaking other bots. Bug: 989674 Change-Id: I90319a86364ee727bc751cb27ac9404f989deb69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854266Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#705254}
-
Xianzhu Wang authored
Overlay resizer can be displayed when there are no scrollbars or the existing scrollbars are an overlay. We can't paint it in background phase because it can be obscured by the content of the resizable container or a positive child paint layer. With this change, overlay resizer will be painted(like overlay scrollbars) in kOverlayOverflowControls(renamed from kOverlayScrollbars) phase. In the follow up CLs, some clean up will be made to: 1. The logic that can use the new added function: HasNonOverlayOverflowControls. 2. Namings of the variable or method related to the original kOverlayScrollbars paint phase. This is 1/3 of a series of patches: 1. This patch. 2. https://crrev.com/c/1817874 3. https://crrev.com/c/1831917 Bug: 1006173 Change-Id: I5cb295d539b925ac1a6d7299798ccfcf4a59abf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816486 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Lei Zhang authored
The test sporadically fails on the bot. Also rename the test name from "All" to "Drawer" to avoid potential confusion with other tests. Bug: 1013656 Change-Id: Ie6314b8c039f7e58796ad36a7f930729ffdb31f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856721 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#705252}
-
Andrew Grieve authored
This was broken by recent refactor: e7e326d5 Change-Id: I4603d1163acad3b7a4340a0330a79fcc71f1a31e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856842 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#705251}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9fa72471b87d..1f088ab877cb git log 9fa72471b87d..1f088ab877cb --date=short --no-merges --format='%ad %ae %s' 2019-10-11 thestig@chromium.org Avoid an assertion failure in CPDF_DIBBase::StartLoadMask(). 2019-10-10 thestig@chromium.org Simplify MonthFromTime(). Created with: gclient setdep -r src/third_party/pdfium@1f088ab877cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:1013066 Change-Id: I7a10f6292c4bd378f59bdd190fd82593c4dfcd5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856631Reviewed-by:
-
Jared Saul authored
Change-Id: Ie245e371cabeaba50213e92b9d4d54c65c072412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856361Reviewed-by:
Siyu An <siyua@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#705249}
-
Toni Barzic authored
I'm the only person in the list, and given that I'm not actively working on apps APIs, it's probably not worth having me as an owner for all api implementations any longer. (Lately, I've been just redirecting all review requests). Change-Id: Ib3f09a12ae2cfde6004e657368229fb2be662165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856840 Auto-Submit: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705248}
-
