- 30 Oct, 2020 40 commits
-
-
Morten Stenshorne authored
We still use the legacy layout engine APIs when calculating offsets relative to some ancestor (needed by DOM APIs such as offsetLeft, offsetTop and getClientRects()). This means that we cannot use offsets relative to the containing box fragment. We need to make them relative to the containing LayoutBlockFlow instead, or machineries such as LayoutObject::MapLocalToAncestor() will fail when in block fragmentation. Also fixed an issue in the NG-to-legacy-writeback code. It was wrong for RTL, since we used the inline-size of the column (rather than that oof the column set) when converting between logical and physical offsets. This alone doesn't fix any existing tests, but it is needed by the new tests added in this CL, and also helps fix a couple of the existing tests that now pass. Also move one ContainingBlockFlowFragmentOf() call out of the way (we get nullptr when block-fragmented). Moved it into paint fragment-specific code, which was the only code that needed it. Bug: 829028 Change-Id: Ib19b11ecfdd47cdd77aed41c6935be86004fe166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508590Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#822860}
-
yilkal authored
This cl provides the appropriate scope for consent logging. Bug: 1131174 Change-Id: I5f6c617cffbb007c588ac816fee208d5557a1c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510743Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#822859}
-
Peter Boström authored
Bug: None Change-Id: I9ab1b3baed360696fd9633f74d0f92309b9d9b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511075 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#822858}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/17e0deaebaa6..5bee67fced90 2020-10-30 bclayton@google.com Add File & Range information to tint::Source If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: rharrison@google.com Change-Id: Id9f6c10c458d037e0b753b69da90ba37487815dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510667Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822857}
-
Thomas Lukaszewicz authored
Bug: None Change-Id: Ie704de6fb88fd7f91b1bfd5b0fd0eec92ab3a0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511669Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#822856}
-
Junbo Ke authored
Bug: b/172062828 Test: Build Change-Id: Ia17478fd5d2db2d7d4e0d55d70a465d5c1dc07a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510879Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#822855}
-
Charlene Yan authored
Boiler plate setup to enable tests for TabStripRegionView with and without scrolling. Added one test for scrolling to ensure the TabStrip can grow larger than its parent. Bug: 1141674 Change-Id: I7ae9ba8a1f6b8f2f8f899002dcea51cc1c64edd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493483 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#822854}
-
Matthias Körber authored
Change-Id: Ie48947eb4686c46f110f0f033f16390c5cbcfd75 Bug: 1101280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506575 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#822853}
-
Dave Tapuska authored
This method is easy to move since there already exists a callback on the WebViewClient to control the history offset and length. Move the method to be implemented on WebViewImpl and call that callback. Remove plumbing for PageMsg in the various classes. BUG=993189 Change-Id: Iec57c5b797f3d7dba21a386e1a664c28425f3c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503168 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#822852}
-
Jesse Schettler authored
The page number reported by lorgnette changed from being 0-indexed to 1-indexed. Use the page number as is instead of adding 1 to it. Bug: 1059779 Change-Id: Ieb52cef8edc25db90e1e13a839f4c2bbf657d471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511469Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#822851}
-
danakj authored
Because the input type to OnceCallback::Then() is a templated type as OnceCallback<U>, a RepeatingCallback does not bind and implicitly convert to a OnceCallback. This is because templated pattern matching does not try conversions, so it must match exactly. Add an overload of OnceCallback::Then() to receive a RepeatingCallback and cast it explicitly to a OnceCallback, forwarding it on to the original Then() method. R=dcheng@chromium.org Bug: 1140582 Change-Id: Ib571eb361922588a3f200e6aea5c045aad0f72d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510411 Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/4d14555787ce..cb2f21d0af42 2020-10-30 alexleung@google.com Import updated Cast Media Runtime Proto Definitions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I8536a82b8d98892be25ba1c7b8fa4b4a77a3dbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510783Reviewed-by:
-
Demetrios Papadopoulos authored
Specifically when navigating the UI with VoiceOver using Ctrl+Alt+RightArrow, the label should be skipped, and the focus should go straight to the expand icon button, which already correctly points to the label with |aria-labeledby|. Bug: 1055829 Change-Id: I13f2bce30b6aaa11f518e68f779296c294dd30ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510131 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#822848}
-
Andrew Grieve authored
This reverts commit c2bb3798. Reason for revert: Reverting to see what perf alerts fire. Original change's description: > Android: Remove -fprofile-sample-accurate from blink core > > This trades off some size for performance. > > Binary-Size: Trading size for speed > Bug: 1125115 > Change-Id: If18e8ef4449dec6aab4494fa7d04063d8d94b845 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491540 > Reviewed-by: George Burgess <gbiv@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819964} Bug: 1125115 Change-Id: Iebce1fffa79b590fd015d0054f9fe2da9e3bb3a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498088Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#822847}
-
Wenbin Zhang authored
This reverts commit ecd51275. Reason for revert: Android builds started failing after this commit. CalledProcessError message is related gyp: FAILED: obj/clank/java/clank_java.turbine.jar gen/clank/java/clank_java.generated.srcjar /b/s/w/ir/cipd_bin_packages/cpython/bin/python ../../build/android/gyp/turbine.py --depfile=gen/clank/java/clank_java__header.d --generated-dir=gen/clank/java/clank_java/generated_java --jar-path=obj/clank/java/clank_java.turbine.jar --java-srcjars=\[\"gen/clank/java/clank_java__rjava_resources.srcjar\"\] --classpath=@FileArg\(gen/clank/java/clank_java.build_config:javac:interface_classpath\) --processorpath=@FileArg\(gen/clank/java/clank_java.build_config:javac:processor_classpath\) --processors=@FileArg\(gen/clank/java/clank_java.build_config:javac:processor_classes\) --turbine-jar-path ../../third_party/turbine/turbine.jar --generated-jar-path gen/clank/java/clank_java.generated.srcjar --java-version=1.8 --bootclasspath=@FileArg\(gen/clank/java/clank_java.build_config:android:sdk_interface_jars\) --chromium-code=1 --warnings-as-errors --jar-info-exclude-globs=\[\"\*/R.class\",\ \"\*/R\\\$\*.class\",\ \"\*/Manifest.class\",\ \"\*/Manifest\\\$\*.class\",\ \"\*/GEN_JNI.class\"\] @gen/clank/java/clank_java.sources Traceback (most recent call last): File "../../build/android/gyp/turbine.py", line 176, in <module> sys.exit(main(sys.argv)) File "../../build/android/gyp/turbine.py", line 172, in main output_paths=output_paths) File "/b/s/w/ir/cache/builder/src/build/android/gyp/util/md5_check.py", line 64, in CallAndWriteDepfileIfStale track_subpaths_allowlist=track_subpaths_allowlist) File "/b/s/w/ir/cache/builder/src/build/android/gyp/util/md5_check.py", line 155, in CallAndRecordIfStale function(*args) File "../../build/android/gyp/turbine.py", line 167, in <lambda> lambda: _OnStaleMd5(options, cmd, javac_cmd, files, options.classpath), File "../../build/android/gyp/turbine.py", line 51, in _OnStaleMd5 fail_on_output=options.warnings_as_errors) File "/b/s/w/ir/cache/builder/src/build/android/gyp/util/build_utils.py", line 272, in CheckOutput raise CalledProcessError(cwd, args, stdout + stderr) Original change's description: > Re-enabling aar .info file checker > > Bug: 1143257 > Change-Id: I88d02690152aa3dabeece3d6cd937d1e3f61a1a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508329 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Sam Maier <smaier@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822760} TBR=agrieve@chromium.org,smaier@chromium.org Change-Id: I6b1265138408f289daa72ef13c48db6669e40c74 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1143257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511730Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#822846}
-
dpapad authored
Previously scrollbars always appeared light, even if a WebUI page was otherwise respecting dark mode. The upcoming FormControlsDarkMode feature allows webpages to specify whether scrollbras should follow the system's theme, by specifying a new <meta name="color-scheme"> tag. In this CL updating WebUIs that do support dark mode, except for chrome://new-tab-page which needs to be investigated separately (styling breaks when the meta tag is added). Launch Chrome with the following flags to experience dark scrollbars. --enable-features=WebUIDarkMode,CSSColorSchemeUARendering \ --force-dark-mode Bug: 1142291 Change-Id: Ia2cece4b18c4f1c1453ce5dad7815881104fa1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509690 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9d02bd39..96789f0a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7d637b5dd6bc5aa728087cc635426bc758d2a390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511069Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822844}
-
Liquan (Max) Gu authored
This reverts commit ece73b5c. Reason for revert: the test is still flaky. Original change's description: > Tentatively re-land flaky test: #WindowClientReady > > Context: > PaymentRequestEvent.openWindow() fails with a cross-origin error > caused by some unknown factors. > > Change: > * Reverted the reverting CL: crrev.com/c/2220705 > > Bug: 1075481 > > Change-Id: I2a3452f58d5686e0dcfcd1ba0e30229e69bfe280 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459389 > Reviewed-by: Sahel Sharify <sahel@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818151} TBR=yfriedman@chromium.org,sahel@chromium.org,maxlg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1075481 Change-Id: I423ff1c7cffe050e8b15267ee7e7e522cb138fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511330Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#822843}
-
Patrick Noland authored
This CL adds an observer interface to LocationBarDataProvider, allowing consumers to listen for changes. It also implements observer registration and notification in LocationBarModel. Initially, only title change notifications are supported, with the intention to add more fields, e.g. url, in future changes. The corresponding LocationBar "poke" method, setTitleToPageTitle, is removed. Bug: 1139481 Change-Id: I1240c8152c818a32761a18c846e6d11cf6efa4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505800 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#822842}
-
Nico Weber authored
...even in Chrome OS builds that set `arm_float_abi = "hard"` for the outer Chrome OS builds -- the inner android build (for arc) should still use the regular Android softfloat abi. Bug: 1144188 Change-Id: I3cf726ce4134ad4d8cce8def8647d5851c081a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510772 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#822841}
-
Jesse Doherty authored
The NewTabPage.MostVisited histogram is used as part of a high level guiding metric. We're trying to consolidate these metrics as user actions to improve query speeds and enable new analysis. BUG=b/161525144 Change-Id: I25a0f4f90a8f11c14ae5dab22ad199917440d719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508133Reviewed-by:
-
Matt Menke authored
It's one of only two remaining consumers of the SpawnedTestServer in HTTP mode. While the still need the SpawnedTestServer for some special cases (e.g., client certs), it's no longer needed in any simple HTTP case, and it's been an unending source of test flake. Finally being able to remove HTTP support from it is a big step towards deprecating it. Bug: 492672 Change-Id: If8fb9994d675950b0bbd718d4933da4925f0f64d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510372Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#822839}
-
Bettina Dea authored
Preparing for full launch. Bug: 1038797, 1068310 Change-Id: I76d4f4ce83decfa3322e313bf2102f01716a538b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508316 Commit-Queue: Bettina Dea <bdea@chromium.org> Auto-Submit: Bettina Dea <bdea@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#822838}
-
Jeffrey Kardatzke authored
BUG=chromium:1141237,b:153111783 TEST=media_unittests, media_h265_parser_fuzzer Change-Id: I71ff94421a5dea803b7cd26bb4da36c47ccb7f8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510136Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#822837}
-
minch authored
StatusAreaWidget::UpdateAfterColorModeChange looks not color mode related, but session state related. Make it call UpdateBackground() directly. Bug: 1131543 Change-Id: I858e5a3bd64cc735d547dc7fec1554f011885916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508169Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#822836}
-
Evan Stade authored
The cancel button is a workaround for <L behavior and is a no-op in L+, see docs for androidx.media.app.NotificationCompat.MediaStyle#setShowCancelButton() Bug: none Change-Id: I7474644bcfdbf7bb4a24f6838b393756f174d1ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493482Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#822835}
-
Adrienne Walker authored
This DCHECK happens if the data pipe that the appcache url loader is writing the response body into for the renderer to read is closed. This case is already handled (throwing a mojo error that the renderer side can handle), and so don't DCHECK(false). Bug: 1063255 Change-Id: Ic0d0af3e576d831251d878fb38db6438713bc652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510875 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#822834}
-
autofill-always-return-cloud-tokenized-card is required for testing Cloud tokens. autofill-enable-virtual-card is required to launch Issued cards. Change-Id: I6fb3580812ab0b4c6b8ed40a2e9962868f097855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510779Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#822833}
-
Mei Liang authored
This CL migrates the following package to use LayoutStateObserver: * org.chromium.chrome.browser.omnibox.* * org.chromium.chrome.browser.toolbar.* Change-Id: Ica63de41ae8cae0b402da2e0d94d3c52a728f034 Bug: 1108496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501070 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#822832}
-
Rakib M. Hasan authored
TBR=robertma@chromium.org Bug: None Change-Id: Iad2eaba7a95e26857b145114342a66f7a42efc77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508314 Commit-Queue: Rakib Hasan <rmhasan@google.com> Auto-Submit: Rakib Hasan <rmhasan@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#822831}
-
Evan Stade authored
Make navigateToStream block until the first contentful paint is complete. Otherwise, the FCP from that navigation can interfere with later code that waits for FCP. Bug: 1144246 Change-Id: Idc16b2ae7c0c9b11fc21e349992b44b671b566d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511043Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#822830}
-
Daniel Cheng authored
Change-Id: If44f3d970b3de9aa2d8bc9d237665cbac9bf5e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490842 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#822829}
-
Andrew Xu authored
This CL implements a new feature of the multipaste menu: (1) If the image to show is a bitmap image, scale the image up to fill the contents area. For example, the size of the contents area is 128x66 while the image's size is 64x22. After scaling up, the image's size becomes 192x66. (2) If the image to show is rendered from HTML, scale the image up until its size matches one edge of the contents area. Use the same example. After scaling up, the image's size becomes 128x44. Bug: 1139498 Change-Id: I982a17125a1b67669e7d528403010605f4a34d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506669Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822828}
-
David Black authored
Holding space drag images currently have a light background until full theming support is implemented. In the short term, use scoped light mode as default. Bug: 1131543 Change-Id: Ifcabe502bd600896201f86c4662e3b446dced17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510737 Auto-Submit: David Black <dmblack@google.com> Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#822827}
-
Theresa Wellington authored
Add strings for upcoming add to home screen in-product help. Bug: 1144250 Change-Id: I938886c6953ae707de4d76bc036e1b30041fe47c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510714 Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#822826}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6903f467cb0a..deea5b13b56d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC thomasanderson@google.com,pmonette@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1120889,chromium:1142775,chromium:1143257,chromium:1143787 Tbr: thomasanderson@google.com,pmonette@google.com Change-Id: Icaf87f3e83f162d16ddcad1b57c0f08b97f45b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510659Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822825}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ce4726c3a32b..6bc1c128830e 2020-10-30 cpinnamaneni@microsoft.com Service worker button to show network panel in drawer. 2020-10-30 jalyn@microsoft.com Settings: Add e2e tests for shortcuts tab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1137050,chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I34fd238f4230fe92a58600ab684f39e7c0a1b1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511011Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c7be37e12173..9396c2b0646a 2020-10-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I6fb0fa2937f28d18207d8e6c24eb62a9c97b47a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510656Reviewed-by:
-
Sorin Jianu authored
This is done as part of splitting IDL and renaming ControlService to UpdateServiceInternal. This change: * removes a sequence checker on the object destructor * replaces a thread checker with a sequence checker * replaces a couple of posted callbacks with direct Run(). * renames com_task_runner to STA_task_runner to make it clear it is the task runner running the COM code in the COM apartment and not some other task runner, and for acronym capitalization * uses a SingleThreadTaskRunner instead of a SequencedTaskRunner. The intention is to declutter the code a little and possibly simplify the sequence checker management on destruction. Bug: 1140562, 1143011 Change-Id: I6db022483c72d340da3cd053e6a900db4c5702ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510912Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#822822}
-
Wenbin Zhang authored
Add log to make execution time of gtest visible from task page. Bug: chromium:1138988 Change-Id: I12072412628e612c38c3bc172b2bb94bd115b5ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511029 Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
-
