- 19 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/95adedb9c23f..72bba625d5f7 git log 95adedb9c23f..72bba625d5f7 --date=short --no-merges --format='%ad %ae %s' 2018-11-19 srte@webrtc.org Adds shared base class for data units. 2018-11-19 mbonadei@webrtc.org Make rtc_event_log protos publicly visible. 2018-11-19 solenberg@webrtc.org Move NetworkStatistics and AudioDecodingCallStats from common_types.h 2018-11-19 mbonadei@webrtc.org Adding empty api:create_peerconnection_factory. 2018-11-19 aleloi@webrtc.org Disabling test StunPortTest.TestPrepareAddressHostname on WIN. Created with: gclient setdep -r src/third_party/webrtc@72bba625d5f7 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idf01c13de74b34cecd8a7cfb2072d066f5d800cf Reviewed-on: https://chromium-review.googlesource.com/c/1341857Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609298}
-
Lutz Justen authored
Just use 'extension' instead of 'extension_<32-byte-hash>' as root category name for brevity. The hash blew up the ADMX files quite a bit since the root category is prepended to pretty much every ID. Note that the categories are already namespaced by the hash, so the hash is not necessary. Bug: 900517 Test: manual Change-Id: I74ec7d3463486525139bf895edbea84bef0afe12 Reviewed-on: https://chromium-review.googlesource.com/c/1338081 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#609297}
-
Leszek Swirski authored
ChromeActivityTestRule.loadUrl waits for the page to be loaded before returning. However, a new renderer will first start loading the blank page, and if loadUrl is called before the blank page completes loading, it will pick up the blank page load as the url load, and will return early. To fix this, we have to check if the page url matches the expected url. We were doing this by checking the tab url (Tab.getUrl()), however this only returns the url in the address bar, not the current navigation url. Instead, we have to pass through the currently loaded url into the page loaded callback, and read that. Bug: 894796 Change-Id: Ifc2afa1ca5da258990a6fe5fffd48656d2f2c1ee Reviewed-on: https://chromium-review.googlesource.com/c/1318893 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#609296}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe04679d4048..e86231b9da1a Created with: gclient setdep -r src-internal@e86231b9da1a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I29fcda5c686b7d8da9afa165b5f72d465285d24b Reviewed-on: https://chromium-review.googlesource.com/c/1341858Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609295}
-
Elly Fong-Jones authored
This reverts commit b3bf64e2. Reason for revert: Introduces https://crbug.com/906075 - bare command press closes menus Original change's description: > views: close menus when accelerators are pressed on Mac > > This change: > > 1) Has MenuController consider command to be an accelerator key, along with > control and alt, for the purpose of not searching for mnemonics; > 2) Adds a Mac override of ViewsDelegate::ProcessAcceleratorWhileMenuShowing > which tells the menu to close for an accelerator > > Bug: 885138 > Change-Id: Iee9d9abb3b1bb3c2d346d7aaf7e532866b4ad26a > Reviewed-on: https://chromium-review.googlesource.com/c/1334147 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607699} TBR=ellyjones@chromium.org,sky@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 885138 Change-Id: If98c70bcab18df7bd4895cbbc603c1878ba9ef91 Reviewed-on: https://chromium-review.googlesource.com/c/1341218Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#609294}
-
Kevin Ellis authored
The patch makes it possible to sanity check the interpolation paths for 2-D matrix transformations. The decomposition of a 2-D or a 3-D matrix is not unique, and can therefore affect the interpolation path. For example, negative scaling and rotation can be interchanged in some combinations. By restricting the tests to transforms produced by a restricted set of 2-D geometric operations, we can highlight cases where there is a preferred decomposition, and more easily flag regressions. Bug: 797472 Change-Id: Ic7d240ae6978e25aded183ea811c76a179f1e16a Reviewed-on: https://chromium-review.googlesource.com/c/1340941Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#609293}
-
Marc Treib authored
SyncUserSettings is a new class that encapsulates all the user-configurable knobs for Sync. It replaces a bunch of setters and getters directly on the SyncService. Bug: 884159 Change-Id: Ifead457dd109d648285b97217274370d1f25ef36 Reviewed-on: https://chromium-review.googlesource.com/c/1339873Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#609292}
-
Marc Treib authored
Some of the settings have surprising default values. As a first step, let's at least document those. Bug: 884159, 906034 Change-Id: I8ee8ba2d6ffc2886f8bc623062787d6ec8d332ed Reviewed-on: https://chromium-review.googlesource.com/c/1340301Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#609291}
-
Gauthier Ambard authored
This CL adds a top constraints to the FindBar to avoid having it overlapping the status bar when entering fullscreen. Bug: 903802 Change-Id: I885c6eb8ca39a1810c1ce5c068d87ab01d68e22e Reviewed-on: https://chromium-review.googlesource.com/c/1341912Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#609290}
-
Peter Boström authored
Decoupling the two helps when displaying a blue favicon (such as Facebook) under the loading-progress indicator. Similar concerns apply in incognito over grey favicons. There are possibly similar concerns when using themes. This change also decouples favicon placeholder roundrect radius from throbber since they are no longer overlapping eachother. Bug: chromium:906605 Change-Id: Ie1959d0d447851f3cac3430e3d31b3b989bed263 Reviewed-on: https://chromium-review.googlesource.com/c/1341527Reviewed-by:
Edward Jung <edwardjung@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#609289}
-
Javier Ernesto Flores Robles authored
Bug: 845472 Change-Id: I47898430b16721084ec836c2d4627ccf1db7c0c3 Reviewed-on: https://chromium-review.googlesource.com/c/1338181Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#609288}
-
Friedrich Horschig authored
Adding an owner for password search and password accessory flags. Change-Id: I07b80dbd7180a40741f330ad22c24657d84450d0 Reviewed-on: https://chromium-review.googlesource.com/c/1341534 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Christian Dullweber authored
Set owner for rewrite-leveldb-on-deletion and clear-old-browsing-data. Remove remove-navigation-history flag. Bug: 906585 Change-Id: I36f931902d48eff7fd8ec3008970246d6318d3bd Reviewed-on: https://chromium-review.googlesource.com/c/1341518 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/abd53ec26b11..e867072a2353 git log abd53ec26b11..e867072a2353 --date=short --no-merges --format='%ad %ae %s' 2018-11-19 fmayer@google.com profiling: Use binfs directory in README. Created with: gclient setdep -r src/third_party/perfetto@e867072a2353 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If3a203f60e9bd1417a4d87cb100b2e16157ddd4f Reviewed-on: https://chromium-review.googlesource.com/c/1341855Reviewed-by:
-
Makoto Shimazu authored
This CL updates two entries: - enable-service-worker-imported-script-update-check - enable-service-worker-servicification Bug: 897809 Change-Id: I08103d8e247b8251a7aa62e5e7a30bab04c0cc94 Reviewed-on: https://chromium-review.googlesource.com/c/1341284 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 84b396de. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I77e41607d705d65e52171fb4581611fdfe361aea Reviewed-on: https://chromium-review.googlesource.com/c/1340510 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609283}
-
Elly Fong-Jones authored
TBR=avi@chromium.org Bug: 906602 Change-Id: Ifb1da0eb3b5ce013a3e64f8ab53e91c0708da6ea Reviewed-on: https://chromium-review.googlesource.com/c/1341969Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 01a53aa6. Reason for revert: the test still fails https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/36437 Original change's description: > [LayoutTest] Rebaseline live-edit-no-reveal.js after V8 roll > > Bug: V8:8405 > Change-Id: Ia53c8d5d8842143f4e41b6b82149e58c70664062 > Reviewed-on: https://chromium-review.googlesource.com/c/1341512 > Reviewed-by: Dan Elphick <delphick@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609237} TBR=rmcilroy@chromium.org,delphick@chromium.org Change-Id: I525c9fe9c6041658b1c4aa67350bbf1f10c024c0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: V8:8405 Reviewed-on: https://chromium-review.googlesource.com/c/1341840Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#609281}
-
Jeremy Roman authored
It's a common and difficult to debug pitfall when you derive a GC mixin but fail to use this macro. It leads to confusing crashes during tracing. With this CL, the compiler will emit a warning like this: In file included from ../../third_party/blink/renderer/core/html/portal/document_portals.cc:5: ../../third_party/blink/renderer/core/html/portal/document_portals.h:17:25: error: [blink-gc] Garbage-collected class 'DocumentPortals' derives mixin class 'Supplement<blink::Document>'. You must add USING_GARBAGE_COLLECTED_MIXIN(DocumentPortals). public Supplement<Document> { ~~~~~~~^~~~~~~~~~~~~~~~~~~~ ../../third_party/blink/renderer/platform/supplementable.h:119:27: note: [blink-gc] Mixin base class derived here: class Supplement : public GarbageCollectedMixin { ~~~~~~~^~~~~~~~~~~~~~~~~~~~~ 1 error generated. Bug: 869498 Change-Id: I93454c418d53ebe0fcd411e0a829597dd9aaf925 Reviewed-on: https://chromium-review.googlesource.com/c/1340784 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#609280}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7aa42b4c..558ce607 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5acf9ecc5b1f604fd6507af189d629ff99c6b7e0 Reviewed-on: https://chromium-review.googlesource.com/c/1340511Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609279}
-
Stepan Khapugin authored
Makes the shortcuts cell shorter for better presentation on iPads. Bug: none Change-Id: Ia126279d680760cbb79b6fb07bf51aa6aeac67c6 Reviewed-on: https://chromium-review.googlesource.com/c/1337335 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#609278}
-
Marc Treib authored
These tests are based on SharedPreferences, which previously weren't reset between tests, causing the tests to start with incorrect assumptions. This CL adds a setUp() that clears the preferences, and removes the FlakyTest annotations. Bug: 905233 Change-Id: Ib66b506811ae38335605498d9eeef9be89d9ef08 Reviewed-on: https://chromium-review.googlesource.com/c/1340817Reviewed-by:
-
Francois Doray authored
Tests involving TaskScheduler accessed the members of SameThreadTaskSource from different threads without synchronization. This CL fixes the issue by making sure that the initial invocation of TestTask() happens on the same thread as other invocations. TSAN report before this CL: WARNING: ThreadSanitizer: data race (pid=126426) Write of size 4 at 0x7b1400001c0c by thread T4: #0 base::sequence_manager::SameThreadTaskSource::TestTask() base/task/sequence_manager/sequence_manager_perftest.cc:311:25 #1 Invoke<void (base::sequence_manager::SameThreadTaskSource::*)(), base::sequence_manager::SameThreadTaskSource *> base/bind_internal.h:516:12 #2 MakeItSo<void (base::sequence_manager::SameThreadTaskSource::*const &)(), base::sequence_manager::SameThreadTaskSource *> base/bind_internal.h:616 #3 RunImpl<void (base::sequence_manager::SameThreadTaskSource::*const &)(), const std::__1::tuple<base::internal::UnretainedWrapper<base::sequence_manager::SameThreadTaskSource> > &, 0> base/bind_internal.h:689 #4 base::internal::Invoker<base::internal::BindState<void (base::sequence_manager::SameThreadTaskSource::*)(), base::internal::UnretainedWrapper<base::sequence_manager::SameThreadTaskSource> >, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:671 #5 Run base/callback.h:99:12 #6 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:99 #7 base::internal::TaskTracker::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) base/task/task_scheduler/task_tracker.cc:641:23 #8 base::internal::TaskTrackerPosix::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) base/task/task_scheduler/task_tracker_posix.cc:23:16 #9 base::internal::TaskTracker::RunAndPopNextTask(scoped_refptr<base::internal::Sequence>, base::internal::CanScheduleSequenceObserver*) base/task/task_scheduler/task_tracker.cc:496:3 #10 base::internal::SchedulerWorker::RunWorker() base/task/task_scheduler/scheduler_worker.cc:333:24 #11 base::internal::SchedulerWorker::RunSharedWorker() base/task/task_scheduler/scheduler_worker.cc:237:3 #12 base::internal::SchedulerWorker::ThreadMain() base/task/task_scheduler/scheduler_worker.cc:207:7 #13 base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:81:13 Previous write of size 4 at 0x7b1400001c0c by main thread: #0 TestTask base/task/sequence_manager/sequence_manager_perftest.cc:330:27 #1 base::sequence_manager::SameThreadTaskSource::Start() base/task/sequence_manager/sequence_manager_perftest.cc:297 #2 base::sequence_manager::SingleThreadImmediateTestCase::Start() base/task/sequence_manager/sequence_manager_perftest.cc:408:41 #3 base::sequence_manager::SequenceManagerPerfTest::Benchmark(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, base::sequence_manager::TestCase*) base/task/sequence_manager/sequence_manager_perftest.cc:636:15 #4 base::sequence_manager::SequenceManagerPerfTest_PostImmediateTasks_OneQueue_Test::TestBody() base/task/sequence_manager/sequence_manager_perftest.cc:714:3 #5 HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc #6 testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2522 #7 testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2703:11 #8 testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2825:28 #9 testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5227:43 #10 HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc #11 testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4835 #12 RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2369:46 #13 base::TestSuite::Run() base/test/test_suite.cc:294 #14 main base/test/run_all_perftests.cc:8:42 TSAN report after this CL: No races found. Change-Id: I03b816a01fe33eed86966f89cb1ad1b9ab34c2e3 Reviewed-on: https://chromium-review.googlesource.com/c/1340534Reviewed-by:Alex Clarke <alexclarke@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#609276}
-
Javier Ernesto Flores Robles authored
Adds descriptions to the new actions opening settings in Manual Fallback. Bug: 845472 Change-Id: If6ff348f3e8277ada4756001cfa4b98d3cc520e5 Reviewed-on: https://chromium-review.googlesource.com/c/1341535Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#609275}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0c1a474a0142..fe04679d4048 Created with: gclient setdep -r src-internal@fe04679d4048 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8882ace693db99257f920ef80e5e8f2d00f09e58 Reviewed-on: https://chromium-review.googlesource.com/c/1341854Reviewed-by:
-
Yi Su authored
The parameter |opt_split| in __gCrWeb.findInPage.highlightWord is always false. Since we don't support AND search in FindInPage, this parameter should be removed. This is a preparation work for fixing the bug. Bug: 228585 Change-Id: I4c0bd3381c7dc0f5012fa4c161814e52a5a1ec97 Reviewed-on: https://chromium-review.googlesource.com/c/1341834Reviewed-by:
-
Yi Su authored
Clean up the find_in_page.js by removing unused function. This is a preparation work for bug fixing. Bug: 228585 Change-Id: Id20053f8623b8a25dba69c2779623854c2b4d666 Reviewed-on: https://chromium-review.googlesource.com/c/1341536Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/179a3923b9e4..95adedb9c23f git log 179a3923b9e4..95adedb9c23f --date=short --no-merges --format='%ad %ae %s' 2018-11-19 mbonadei@webrtc.org Always compile VP9 source files. 2018-11-19 nisse@webrtc.org Delete class ChannelSendProxy 2018-11-19 danilchap@webrtc.org in RtcpTransceiver remove workaround for old bug in RtcpReceiver 2018-11-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 92e84c81..3efc758c (608282:609210) 2018-11-19 srte@webrtc.org Adds clamping to TimeDelta. 2018-11-19 srte@webrtc.org Adds scalar division to DataRate. 2018-11-19 mbonadei@webrtc.org Switch from RTC_DISABLE_VP9 to RTC_ENABLE_VP9. 2018-11-19 phoglund@webrtc.org Fix small issues that stops the Chromium DEPS roll. Created with: gclient setdep -r src/third_party/webrtc@95adedb9c23f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I770253a65f1315505eec116172139566298f2c45 Reviewed-on: https://chromium-review.googlesource.com/c/1341853Reviewed-by:
-
A Olsen authored
There is no circumstance in which in an infinite loop actually ever happens - especially not in production which doesn't use StubCrosSettingsProvider - but in tests there is a bigger risk, and it is currently only narrowly avoided. This CL no longer notifies listeners when the value does not actually change, which should prevent infinite loops of the form where a listener tries to immediately write the same value after it is notified of a change to that value. See go/onsystemprefchanged for a longer explanation. (In a different CL I want to make a change that exposes this infinite loop problem, so I am fixing it first in this CL.) Change-Id: Ie47ac2db905a54c4d6244e06b54471c36454583d Reviewed-on: https://chromium-review.googlesource.com/c/1340305 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#609270}
-
Thomas Tangl authored
The sync data type USER_EVENTS is tied back to TYPED_URLS when UnifiedConsent is enabled. Code related to USER_EVENTS in the UnifiedConsentService is removed. This is includes migration, rollback and metrics. Bug: 905342 Change-Id: I0361d79c0df269410955ba46a13aaf62affac275 Reviewed-on: https://chromium-review.googlesource.com/c/1339867 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609269}
-
Vadym Doroshenko authored
This function is not needed with a new UI where the user can manually change username/password in a prompt. So it's not used on Desktop anymore. But it's still used on Android and iOS. This CL implements the same logic as in PasswordFormManager::Update. Bug: 831123 Change-Id: I19edc5a6eddb9afb1d34d9d48bd0935fb551c184 Reviewed-on: https://chromium-review.googlesource.com/c/1340266Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#609268}
-
Mikel Astiz authored
If decrypting an update fails despite CanDecrypt() returning true, it's safe to assume the data is corrupted. Hence, let's drop such update and prevent the worker's update queue from being blocked indefinitely. Bug: 873902 Change-Id: I01bc8271d2e1daa961f3136d8b5a21d4ecde1ced Reviewed-on: https://chromium-review.googlesource.com/c/1341531Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609267}
-
Maxim Kolosovskiy authored
This reverts commit 05672d8d. Reason for revert: Test failures https://bugs.chromium.org/p/chromium/issues/detail?id=906587 Original change's description: > Normalize Katakana to Hiragana in ScriptRunIterator > > This patch normalizes Katakana to Hiragana in ScriptData, and > thus in ScriptRunIterator. > > There are 3 ICU script code for kana; USCRIPT_HIRAGANA, > USCRIPT_KATAKANA, and USCRIPT_KATAKANA_OR_HIRAGANA. However, > OpenType has only one 'kana' for all these 3 script codes. > > When shaping, HarfBuzz handles the normalization. However, > Blink splits the incoming string by the ICU scripts. > Splitting these 3 scripts is not useful but consumes CPU > and memory. > > By normalizing in ScriptRunIterator, all types of Kana are > in single run. > > timeToFirstContentfulPaint:layout shows ~3% improvements > https://pinpoint-dot-chromeperf.appspot.com/job/10d9760fe40000 > > though bink_perf.layout does not show much differences > https://pinpoint-dot-chromeperf.appspot.com/job/14f19c00140000 > > This is probably because Katakana characters are not used > much in `japanese-kokoro-insert` (written in ~100 years ago,) > while they are more used in modern pages. > > Bug: 636993 > Change-Id: If692bb575f2232b8fca10cd2ea87e3022debdf05 > Reviewed-on: https://chromium-review.googlesource.com/c/1337650 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609119} TBR=eae@chromium.org,kojii@chromium.org,drott@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 636993 Change-Id: Icb14d6ad2a3453c9bfab9287e5c0a4995ac1c97f Reviewed-on: https://chromium-review.googlesource.com/c/1341519Reviewed-by:
-
Hayato Ito authored
A follow-up CL of https://crrev.com/c/1325271. BUG=902661,903666 Change-Id: I877f4239ffb8ab92225086968dca5dbb729678cf Reviewed-on: https://chromium-review.googlesource.com/c/1328541Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#609265}
-
Takashi Toyoshima authored
Bug: 905971 Change-Id: I305358199844ecb0858bbd74e6fd4b888bf63966 Reviewed-on: https://chromium-review.googlesource.com/c/1341782Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#609264}
-
Yoshifumi Inoue authored
This function makes |NGInlineNode::GetOffsetMapping()| to work with legacy layout tree by changing |CollectInlinesInnternal()| not to call |LayoutInline:: UpdateShouldCreateBoxFragment()| when it is called for offset mapping since we don't need to call |UpdateShouldCreateBoxFragment()| for offset mapping and it set |IsInInlineFormattingContext()| bit flag in |LayoutObject| then causing DCHECK(). This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1337224 Utilize NGInlineNode::GetOffsetMapping() in Element#innerText Change-Id: I0d7d844faa2581c24cd786f15ec066141c445e1b Reviewed-on: https://chromium-review.googlesource.com/c/1341780Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#609263}
-
Eric Willigers authored
https://drafts.csswg.org/css-values/#math-function-serialize-a-summation Percentage should be serialized before dimensions with units Also fix typo in WPTs svg/geometry/parsing/*-computed.svg calc(50% + 60x) becomes calc(50% + 60px) BUG=904805 Change-Id: I2ecb732564c405f9315a1ef06e5bd0777c407f19 Reviewed-on: https://chromium-review.googlesource.com/c/1341289Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#609262}
-
Yoshifumi Inoue authored
This patch introduces const version of |NGPaintFragment:: LastForSameLayoutObject()| to avoid callers to use |const_cast| for improving code health. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1341776 [LayoutNG] Implement LayoutNG version of {First,Last}CharacterAfterWhitespaceCollapsing() Change-Id: I2dfad3861db1e93b89f5ca2441c2e222bee0181d Reviewed-on: https://chromium-review.googlesource.com/c/1341775 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Hans Wennborg authored
Bug: none Change-Id: Ic8355b94db77c728535a68fd00947d44422b4604 Reviewed-on: https://chromium-review.googlesource.com/c/1341908Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#609260}
-
Shu Chen authored
Bug: 878949 Change-Id: Ic6197ff02354d53da9fec1193cd67e073b663d61 Reviewed-on: https://chromium-review.googlesource.com/c/1341436Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#609259}
-
